223447 2021-03-18 09:38:15 -0700 [iOS] editing/selection/character-granularity-rect.html fails on certain internal configurations after r274610 2021-03-18 11:18:18 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin hi megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1741224 0 wenson_hsieh 2021-03-18 09:38:15 -0700 (More precisely, it fails when the image extraction feature is disabled) 1741245 1 423614 wenson_hsieh 2021-03-18 10:26:36 -0700 Created attachment 423614 Patch 1741250 2 423614 hi 2021-03-18 10:36:51 -0700 Comment on attachment 423614 Patch rs=me 1741254 3 423614 wenson_hsieh 2021-03-18 10:50:58 -0700 Comment on attachment 423614 Patch Thanks for the review! 1741276 4 ews-feeder 2021-03-18 11:17:05 -0700 Committed r274653: <https://commits.webkit.org/r274653> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423614. 1741277 5 webkit-bug-importer 2021-03-18 11:18:18 -0700 <rdar://problem/75581661> 423614 2021-03-18 10:26:36 -0700 2021-03-18 11:17:05 -0700 Patch bug-223447-20210318102636.patch text/plain 3644 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiMDAyYzI5OWI3MGMxMzBi MmI5YzgzZGM1MmI0ZDRiYTkyZjY2ZTAuLjc2YmRmMGFkY2NiZTUzZjE1ZmMwNDQ1NjIwMWM3MDUz NDA0ZWU0ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjEtMDMtMTggIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gZWRpdGluZy9z ZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXJlY3QuaHRtbCBmYWlscyBvbiBjZXJ0YWlu IGludGVybmFsIGNvbmZpZ3VyYXRpb25zIGFmdGVyIHIyNzQ2MTAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzQ0NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIHZlcnNpb25zIG9mIGlPUyB3aGVyZSBg RU5BQkxFKElNQUdFX0VYVFJBQ1RJT04pYCBpcyBkZWZpbmVkIGJ1dCB0aGUgc3lzdGVtIGZlYXR1 cmUgaXMgZGlzYWJsZWQsIHRoaXMgdGVzdAorICAgICAgICBiZWdhbiBmYWlsaW5nIGFmdGVyIHIy NzQ2MTAuIFRoaXMgaXMgYmVjYXVzZSB0aGUgbmV3IGltYWdlIGV4dHJhY3Rpb24gZGVmZXJyYWwg Z2VzdHVyZSBub3cgYmxvY2tzIHRleHQKKyAgICAgICAgaW50ZXJhY3Rpb24gZ2VzdHVyZXMsIGJ1 dCB0aGUgY29kZSB0byBhY3R1YWxseSBmYWlsIHRoaXMgZGVmZXJyaW5nIGdlc3R1cmUgKGFuZCB0 aHVzLCAibGlmdCIgdGhlIGRlZmVycmluZworICAgICAgICBnZXN0dXJlIGdhdGUpIGlzIHN0aWxs IGJlaGluZCB0aGUgc3lzdGVtIGZsYWcuIEFzIGEgcmVzdWx0LCB0ZXh0IGludGVyYWN0aW9ucyB3 aGVuIHRoZSBpbWFnZSBleHRyYWN0aW9uIGZsYWcgaXMKKyAgICAgICAgZGlzYWJsZWQgd2lsbCBv bmx5IGJlZ2luIGFmdGVyIHRoZSB0b3VjaCBlbmRzLgorCisgICAgICAgIFRoaXMgbWVhbnMgdGhh dCB3aGVuIHNlbGVjdGluZyB0ZXh0IHZpYSBhIGxvbmcgcHJlc3MsIHRoZSB0ZXh0IHNlbGVjdGlv biBkb2Vzbid0IGFwcGVhciB1bnRpbCBsaWZ0aW5nIHRoZSB0b3VjaAorICAgICAgICBpZiBpbWFn ZSBleHRyYWN0aW9uIGlzIGRpc2FibGVkLiBUbyBmaXggdGhpcywgd2Ugb25seSBlbmFibGUgdGhp cyBkZWZlcnJpbmcgZ2VzdHVyZSBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgc3lzdGVtCisgICAgICAg IGZlYXR1cmUgaXMgZW5hYmxlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvR2VzdHVyZVJl Y29nbml6ZXJDb25zaXN0ZW5jeUVuZm9yY2VyLm1tOgorICAgICAgICAoV2ViS2l0OjpHZXN0dXJl UmVjb2duaXplckNvbnNpc3RlbmN5RW5mb3JjZXI6OnRpbWVyRmlyZWQpOgorCisgICAgICAgIEFk ZGl0aW9uYWxseSB0d2VhayB0aGUgYEdlc3R1cmVSZWNvZ25pemVyQ29uc2lzdGVuY3lFbmZvcmNl cmAgdG8gb25seSBmb3JjaWJseSByZXNldCBsaW5nZXJpbmcgdW5saWZ0ZWQgZ2VzdHVyZQorICAg ICAgICByZWNvZ25pemVycyBpZiB0aGV5IGFyZSBlbmFibGVkLgorCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgc2V0VXBJbnRlcmFjdGlvbl0pOgorCiAyMDIxLTAzLTE4ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBCdW1wIEFQSSB2ZXJz aW9uIHdoZW4gYnVpbGRpbmcgd2l0aCBsaWJzb3VwMwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL0dlc3R1cmVSZWNvZ25pemVyQ29uc2lzdGVuY3lFbmZvcmNlci5tbSBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9HZXN0dXJlUmVjb2duaXplckNvbnNpc3RlbmN5 RW5mb3JjZXIubW0KaW5kZXggNTgwNTUwNDY1MzI0ZjFlZmVjNzEyZGIxMWU4MGQyMzQ5ZTc5Y2Vl OC4uNDJiZDA1ODAyNmU4YjFhYjc3NmY2ZWE3MjVkNTZjMDc0MmVlYWI3ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL0dlc3R1cmVSZWNvZ25pemVyQ29uc2lzdGVuY3lF bmZvcmNlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvR2VzdHVyZVJlY29n bml6ZXJDb25zaXN0ZW5jeUVuZm9yY2VyLm1tCkBAIC03MSw3ICs3MSw3IEBAIHZvaWQgR2VzdHVy ZVJlY29nbml6ZXJDb25zaXN0ZW5jeUVuZm9yY2VyOjp0aW1lckZpcmVkKCkKICAgICBhdXRvIHN0 cm9uZ1ZpZXcgPSBtX3ZpZXcuZ2V0KCk7CiAgICAgYXV0byBwb3NzaWJsZURlZmVycmluZ0dlc3R1 cmVzID0gW05TTXV0YWJsZUFycmF5PFdLRGVmZXJyaW5nR2VzdHVyZVJlY29nbml6ZXIgKj4gYXJy YXldOwogICAgIGZvciAoV0tEZWZlcnJpbmdHZXN0dXJlUmVjb2duaXplciAqZ2VzdHVyZSBpbiBb c3Ryb25nVmlldyBkZWZlcnJpbmdHZXN0dXJlc10pIHsKLSAgICAgICAgaWYgKGdlc3R1cmUuc3Rh dGUgPT0gVUlHZXN0dXJlUmVjb2duaXplclN0YXRlUG9zc2libGUpCisgICAgICAgIGlmIChnZXN0 dXJlLnN0YXRlID09IFVJR2VzdHVyZVJlY29nbml6ZXJTdGF0ZVBvc3NpYmxlICYmIGdlc3R1cmUu ZW5hYmxlZCkKICAgICAgICAgICAgIFtwb3NzaWJsZURlZmVycmluZ0dlc3R1cmVzIGFkZE9iamVj dDpnZXN0dXJlXTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDgwNjQwMzYyNzZlY2JjNmZk ZTMwMjc1ZjIzNDA0NGE1MWJiYTUwNTQuLjA1YTJlOTE1NGI3NzlkNmY1MWZiZmIwMzQ5MWUxZjk3 MWRjMmE4MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNzk1LDYgKzc5NSw3IEBAIC0gKHZvaWQpc2V0 VXBJbnRlcmFjdGlvbgogICAgIF9pbWFnZUV4dHJhY3Rpb25EZWZlcnJpbmdHZXN0dXJlUmVjb2du aXplciA9IGFkb3B0TlMoW1tXS0RlZmVycmluZ0dlc3R1cmVSZWNvZ25pemVyIGFsbG9jXSBpbml0 V2l0aERlZmVycmluZ0dlc3R1cmVEZWxlZ2F0ZTpzZWxmXSk7CiAgICAgW19pbWFnZUV4dHJhY3Rp b25EZWZlcnJpbmdHZXN0dXJlUmVjb2duaXplciBzZXROYW1lOkAiRGVmZXJyZXIgZm9yIGltYWdl IGV4dHJhY3Rpb24iXTsKICAgICBbX2ltYWdlRXh0cmFjdGlvbkRlZmVycmluZ0dlc3R1cmVSZWNv Z25pemVyIHNldEltbWVkaWF0ZWx5RmFpbHNBZnRlclRvdWNoRW5kOllFU107CisgICAgW19pbWFn ZUV4dHJhY3Rpb25EZWZlcnJpbmdHZXN0dXJlUmVjb2duaXplciBzZXRFbmFibGVkOnNlbGYuX2lt YWdlRXh0cmFjdGlvbkVuYWJsZWRdOwogI2VuZGlmCiAKICAgICBmb3IgKFdLRGVmZXJyaW5nR2Vz dHVyZVJlY29nbml6ZXIgKmdlc3R1cmUgaW4gc2VsZi5kZWZlcnJpbmdHZXN0dXJlcykgewo=