223440 2021-03-18 05:05:23 -0700 [ews] Add unit-test to ensure that config.json doesn't have tab characters 2021-03-25 06:44:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1741169 0 aakash_jain 2021-03-18 05:05:23 -0700 Add unit-test to ensure that config.json doesn't have tab characters. We use PEP8 style guidelines, which says "Spaces are the preferred indentation method." https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces 1741171 1 423588 aakash_jain 2021-03-18 05:13:46 -0700 Created attachment 423588 Patch 1743736 2 webkit-bug-importer 2021-03-25 05:06:14 -0700 <rdar://problem/75832376> 1743755 3 ews-feeder 2021-03-25 06:44:44 -0700 Committed r275018: <https://commits.webkit.org/r275018> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423588. 423588 2021-03-18 05:13:46 -0700 2021-03-25 06:44:45 -0700 Patch bug-223440-20210318081345.patch text/plain 3813 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDY0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAzLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgdW5pdC10ZXN0IHRvIGVuc3VyZSB0aGF0IGNvbmZpZy5q c29uIGRvZXNuJ3QgaGF2ZSB0YWIgY2hhcmFjdGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzNDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9sb2Fk Q29uZmlnX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ29uZmlnRG90SlNPTlRlc3QudGVzdF90YWJf Y2hhcmFjdGVyKTogVW5pdC10ZXN0IHRvIGVuc3VyZSB0aGF0IHRoZXJlIGFyZSBubyB0YWIgY2hh cmFjdGVycy4KKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uOgorICAg ICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weToKKyAgICAg ICAgKENvbmZpZ0RvdEpTT05UZXN0LnRlc3RfdGFiX2NoYXJhY3Rlcik6CisKIDIwMjEtMDMtMTgg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtX UEVdIEJ1bXAgQVBJIHZlcnNpb24gd2hlbiBidWlsZGluZyB3aXRoIGxpYnNvdXAzCkluZGV4OiBU b29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2xvYWRDb25maWdf dW5pdHRlc3QucHkJKHJldmlzaW9uIDI3NDY0MSkKKysrIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13 ZWJraXQtb3JnL2xvYWRDb25maWdfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYg KzM5LDExIEBAIGNsYXNzIENvbmZpZ0RvdEpTT05UZXN0KHVuaXR0ZXN0LlRlc3RDYXMKICAgICAg ICAgY3dkID0gb3MucGF0aC5kaXJuYW1lKG9zLnBhdGguYWJzcGF0aChfX2ZpbGVfXykpCiAgICAg ICAgIGxvYWRDb25maWcubG9hZEJ1aWxkZXJDb25maWcoe30sIGlzX3Rlc3RfbW9kZV9lbmFibGVk PVRydWUsIG1hc3Rlcl9wcmVmaXhfcGF0aD1jd2QpCiAKKyAgICBkZWYgdGVzdF90YWJfY2hhcmFj dGVyKHNlbGYpOgorICAgICAgICBjd2QgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5hYnNwYXRo KF9fZmlsZV9fKSkKKyAgICAgICAgd2l0aCBvcGVuKG9zLnBhdGguam9pbihjd2QsICdjb25maWcu anNvbicpLCAncicpIGFzIGNvbmZpZzoKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZSgnXHQn IG5vdCBpbiBjb25maWcucmVhZCgpLCAnVGFiIGNoYXJhY3RlciBmb3VuZCBpbiBjb25maWcuanNv biwgcGxlYXNlIHVzZSBzcGFjZXMgaW5zdGVhZCBvZiB0YWJzLicpCisKICAgICBkZWYgdGVzdF9i dWlsZGVyX2tleXMoc2VsZik6CiAgICAgICAgIGNvbmZpZyA9IHNlbGYuZ2V0X2NvbmZpZygpCiAg ICAgICAgIHZhbGlkX2J1aWxkZXJfa2V5cyA9IFsnYWRkaXRpb25hbEFyZ3VtZW50cycsICdhcmNo aXRlY3R1cmVzJywgJ2J1aWxkZGlyJywgJ2NvbmZpZ3VyYXRpb24nLCAnZGVzY3JpcHRpb24nLApJ bmRleDogVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNvbgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uCShyZXZpc2lvbiAyNzQ2NDEp CisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2NvbmZpZy5qc29uCSh3b3JraW5nIGNvcHkp CkBAIC01MzMsNyArNTMzLDcgQEAKICAgICAgICJhcmNoaXRlY3R1cmVzIjogWyJpMzg2Il0sCiAg ICAgICAid29ya2VybmFtZXMiOiBbImV3czE2NCIsICJld3MxNjUiLCAiZXdzMTY2Il0KICAgICB9 LAotICAgICB7CisgICAgewogICAgICAgIm5hbWUiOiAidHZPUy0xNC1CdWlsZC1FV1MiLAogICAg ICAgInNob3J0bmFtZSI6ICJ0diIsCiAgICAgICAiaWNvbiI6ICJidWlsZE9ubHkiLApAQCAtNjA0 LDcgKzYwNCw3IEBACiAgICAgICAidHJpZ2dlcnMiOiBbImpzYy10ZXN0cy1taXBzZWwtdGVzdHMt ZXdzIl0sCiAgICAgICAid29ya2VybmFtZXMiOiBbImlnYWxpYS1qc2MzMi1taXBzZWwtZXdzIiwg ImlnYWxpYS1qc2MzMi1taXBzZWwtZXdzLTAzIl0KICAgICB9LAotICB7CisgICAgewogICAgICAg Im5hbWUiOiAiSlNDLU1JUFNFTC0zMmJpdHMtVGVzdHMtRVdTIiwKICAgICAgICJzaG9ydG5hbWUi OiAianNjLW1pcHMtdGVzdHMiLAogICAgICAgImljb24iOiAidGVzdE9ubHkiLApJbmRleDogVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weQkocmV2 aXNpb24gMjc0NjQxKQorKysgVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnX3Vu aXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNiBAQAogIyEvdXNyL2Jpbi9lbnYg cHl0aG9uCiAjCi0jIENvcHlyaWdodCAoQykgMjAxOC0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDE4LTIwMjEgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQg YmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC00NCw2ICs0NCwx MSBAQCBjbGFzcyBDb25maWdEb3RKU09OVGVzdCh1bml0dGVzdC5UZXN0Q2FzCiAgICAgICAgIGN3 ZCA9IG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmFic3BhdGgoX19maWxlX18pKQogICAgICAgICBs b2FkQ29uZmlnLmxvYWRCdWlsZGVyQ29uZmlnKHt9LCBpc190ZXN0X21vZGVfZW5hYmxlZD1UcnVl LCBtYXN0ZXJfcHJlZml4X3BhdGg9Y3dkKQogCisgICAgZGVmIHRlc3RfdGFiX2NoYXJhY3Rlcihz ZWxmKToKKyAgICAgICAgY3dkID0gb3MucGF0aC5kaXJuYW1lKG9zLnBhdGguYWJzcGF0aChfX2Zp bGVfXykpCisgICAgICAgIHdpdGggb3Blbihvcy5wYXRoLmpvaW4oY3dkLCAnY29uZmlnLmpzb24n KSwgJ3InKSBhcyBjb25maWc6CisgICAgICAgICAgICBzZWxmLmFzc2VydFRydWUoJ1x0JyBub3Qg aW4gY29uZmlnLnJlYWQoKSwgJ1RhYiBjaGFyYWN0ZXIgZm91bmQgaW4gY29uZmlnLmpzb24sIHBs ZWFzZSB1c2Ugc3BhY2VzIGluc3RlYWQgb2YgdGFicy4nKQorCiAgICAgZGVmIHRlc3RfYnVpbGRl cl9rZXlzKHNlbGYpOgogICAgICAgICBjb25maWcgPSBzZWxmLmdldF9jb25maWcoKQogICAgICAg ICB2YWxpZF9idWlsZGVyX2tleXMgPSBbJ2FkZGl0aW9uYWxBcmd1bWVudHMnLCAnYXJjaGl0ZWN0 dXJlcycsICdidWlsZGRpcicsICdjb25maWd1cmF0aW9uJywgJ2Rlc2NyaXB0aW9uJywK