223421 2021-03-18 00:51:05 -0700 should always use all prerequisites for the `ModernMediaControls.{js,css}` rules in DerivedSources.make 2021-03-18 02:12:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223309 223410 1 hi hi hi webkit-bug-importer ysuzuki oldest_to_newest 1741066 0 hi 2021-03-18 00:51:05 -0700 `$?` is a uniqued space-separated list of all prerequisites modified after the target was modified `$^` is a uniqued space-separated list of all prerequisites regardless of when the target/prerequisite was modified We want to use the latter since we always want to `cat` all the JS/CSS files, not just the recently edited ones. 1741067 1 423566 hi 2021-03-18 00:51:34 -0700 Created attachment 423566 Patch 1741070 2 423567 hi 2021-03-18 00:53:28 -0700 Created attachment 423567 Patch 1741074 3 423567 ysuzuki 2021-03-18 00:57:42 -0700 Comment on attachment 423567 Patch Nice, r=me 1741101 4 ews-feeder 2021-03-18 02:11:17 -0700 Committed r274625: <https://commits.webkit.org/r274625> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423567. 1741102 5 webkit-bug-importer 2021-03-18 02:12:15 -0700 <rdar://problem/75565469> 423566 2021-03-18 00:51:34 -0700 2021-03-18 00:53:28 -0700 Patch 223421.diff text/plain 1658 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NWIwMmEzYjBlMDkuLjc0NDA0NDVmYzk1ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDIxLTAzLTE4ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KKworICAgICAgICBzaG91bGQgYWx3YXlzIHVzZSBhbGwgcHJlcmVxdWlzaXRlcyBmb3IgdGhl IGBNb2Rlcm5NZWRpYUNvbnRyb2xzLntqcyxjc3N9YCBydWxlcyBpbiBEZXJpdmVkU291cmNlcy5t YWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM0 MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIERl cml2ZWRTb3VyY2VzLm1ha2U6CisgICAgICAgIGAkP2AgaXMgYSB1bmlxdWVkIHNwYWNlLXNlcGFy YXRlZCBsaXN0IG9mIGFsbCBwcmVyZXF1aXNpdGVzIG1vZGlmaWVkIGFmdGVyIHRoZSB0YXJnZXQg d2FzIG1vZGlmaWVkLgorICAgICAgICBgJF5gIGlzIGEgdW5pcXVlZCBzcGFjZS1zZXBhcmF0ZWQg bGlzdCBvZiBhbGwgcHJlcmVxdWlzaXRlcyByZWdhcmRsZXNzIG9mIHdoZW4gdGhlIHRhcmdldC9w cmVyZXF1aXNpdGUgd2FzIG1vZGlmaWVkLgorICAgICAgICBXZSB3YW50IHRvIHVzZSB0aGUgbGF0 dGVyIHNpbmNlIHdlIGFsd2F5cyB3YW50IHRvIGBjYXRgIGFsbCB0aGUgSlMvQ1NTIGZpbGVzLCBu b3QganVzdCB0aGUgcmVjZW50bHkgZWRpdGVkIG9uZXMuCisKIDIwMjEtMDMtMTcgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIGRvbid0IGNvcHkgYGltYWdlT3Zl cmxheS5jc3NgIG9yIGBtZXRlckVsZW1lbnRTaGFkb3cuY3NzYApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZSBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3Vy Y2VzLm1ha2UKaW5kZXggZmEzNmI5NTA2NTc3Li5jYmEwZjM1OWNjNGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvRGVy aXZlZFNvdXJjZXMubWFrZQpAQCAtMTU0Nyw3ICsxNTQ3LDcgQEAgTU9ERVJOX01FRElBX0NPTlRS T0xTX1NUWUxFX1NIRUVUUyA9IFwKIGFsbCA6IE1vZGVybk1lZGlhQ29udHJvbHMuY3NzCiAKIE1v ZGVybk1lZGlhQ29udHJvbHMuY3NzIDogJChNT0RFUk5fTUVESUFfQ09OVFJPTFNfU1RZTEVfU0hF RVRTKQotCWNhdCAkPyA+IE1vZGVybk1lZGlhQ29udHJvbHMuY3NzCisJY2F0ICReID4gTW9kZXJu TWVkaWFDb250cm9scy5jc3MKIAogIyB1c2VyIGFnZW50IHN0eWxlIHNoZWV0cwogCkBAIC0xNjQ1 LDcgKzE2NDUsNyBAQCBNT0RFUk5fTUVESUFfQ09OVFJPTFNfU0NSSVBUUyA9IFwKIGFsbCA6IE1v ZGVybk1lZGlhQ29udHJvbHMuanMKIAogTW9kZXJuTWVkaWFDb250cm9scy5qcyA6ICQoTU9ERVJO X01FRElBX0NPTlRST0xTX1NDUklQVFMpCi0JY2F0ICQ/ID4gTW9kZXJuTWVkaWFDb250cm9scy5q cworCWNhdCAkXiA+IE1vZGVybk1lZGlhQ29udHJvbHMuanMKIAogIyB1c2VyIGFnZW50IHNjcmlw dHMKIAo= 423567 2021-03-18 00:53:28 -0700 2021-03-18 02:11:18 -0700 Patch 223421.diff text/plain 1658 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NWIwMmEzYjBlMDkuLjc0NDA0NDVmYzk1ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIxLTAzLTE4ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KKworICAgICAgICBzaG91bGQgYWx3YXlzIHVzZSBhbGwgcHJlcmVxdWlzaXRlcyBmb3IgdGhl IGBNb2Rlcm5NZWRpYUNvbnRyb2xzLntqcyxjc3N9YCBydWxlcyBpbiBEZXJpdmVkU291cmNlcy5t YWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjM0 MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIERl cml2ZWRTb3VyY2VzLm1ha2U6CisgICAgICAgIGAkP2AgaXMgYSB1bmlxdWVkIHNwYWNlLXNlcGFy YXRlZCBsaXN0IG9mIGFsbCBwcmVyZXF1aXNpdGVzIG1vZGlmaWVkIGFmdGVyIHRoZSB0YXJnZXQg d2FzIG1vZGlmaWVkLgorICAgICAgICBgJF5gIGlzIGEgdW5pcXVlZCBzcGFjZS1zZXBhcmF0ZWQg bGlzdCBvZiBhbGwgcHJlcmVxdWlzaXRlcyByZWdhcmRsZXNzIG9mIHdoZW4gdGhlIHRhcmdldC9w cmVyZXF1aXNpdGUgd2FzIG1vZGlmaWVkLgorICAgICAgICBXZSB3YW50IHRvIHVzZSB0aGUgbGF0 dGVyIHNpbmNlIHdlIGFsd2F5cyB3YW50IHRvIGBjYXRgIGFsbCB0aGUgSlMvQ1NTIGZpbGVzLCBu b3QganVzdCB0aGUgcmVjZW50bHkgZWRpdGVkIG9uZXMuCisKIDIwMjEtMDMtMTcgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIGRvbid0IGNvcHkgYGltYWdlT3Zl cmxheS5jc3NgIG9yIGBtZXRlckVsZW1lbnRTaGFkb3cuY3NzYApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZSBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3Vy Y2VzLm1ha2UKaW5kZXggZmEzNmI5NTA2NTc3Li5jYmEwZjM1OWNjNGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvRGVy aXZlZFNvdXJjZXMubWFrZQpAQCAtMTU0Nyw3ICsxNTQ3LDcgQEAgTU9ERVJOX01FRElBX0NPTlRS T0xTX1NUWUxFX1NIRUVUUyA9IFwKIGFsbCA6IE1vZGVybk1lZGlhQ29udHJvbHMuY3NzCiAKIE1v ZGVybk1lZGlhQ29udHJvbHMuY3NzIDogJChNT0RFUk5fTUVESUFfQ09OVFJPTFNfU1RZTEVfU0hF RVRTKQotCWNhdCAkPyA+IE1vZGVybk1lZGlhQ29udHJvbHMuY3NzCisJY2F0ICReID4gTW9kZXJu TWVkaWFDb250cm9scy5jc3MKIAogIyB1c2VyIGFnZW50IHN0eWxlIHNoZWV0cwogCkBAIC0xNjQ1 LDcgKzE2NDUsNyBAQCBNT0RFUk5fTUVESUFfQ09OVFJPTFNfU0NSSVBUUyA9IFwKIGFsbCA6IE1v ZGVybk1lZGlhQ29udHJvbHMuanMKIAogTW9kZXJuTWVkaWFDb250cm9scy5qcyA6ICQoTU9ERVJO X01FRElBX0NPTlRST0xTX1NDUklQVFMpCi0JY2F0ICQ/ID4gTW9kZXJuTWVkaWFDb250cm9scy5q cworCWNhdCAkXiA+IE1vZGVybk1lZGlhQ29udHJvbHMuanMKIAogIyB1c2VyIGFnZW50IHNjcmlw dHMKIAo=