223405 2021-03-17 17:33:33 -0700 [ITP] User initiated cross-domain link navigations getting counted as Top Frame Redirects 2023-01-02 11:33:48 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mathieu.perreault charliew drexler.robin jon.burns mathieu.perreault webkit-bug-importer wilander oldest_to_newest 1740968 0 mathieu.perreault 2021-03-17 17:33:33 -0700 The report is about user-initiated cross-domain link navigations that are sometimes counted as top frame redirects in the eyes of ITP. Details ======= The demo is two domains A and B linking to each other through <a> tags. The interaction is starting at A, clicking on a link to navigate to B, waiting X seconds and clicking to go back to A. - If the operation is done fast (X < 5 seconds), one can see that TopFrameUniqueRedirectsTo table being updated for the navigation from B -> A. - If X > 5s before clicking to navigate back to A, there is no TopFrameUniqueRedirectsTo table entry. The `ITPDebug` log doesn’t show this interaction, so that’s why we need to look in the sqlite database. As far as one can tell, [this](https://github.com/WebKit/WebKit/blob/main/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp#L1567) is the logic in the WebKit code. Given that there are no `ITPDebug` statement, one can infer that `wasNavigatedAfterShortDelayWithoutUserInteraction` is probably `true`, but in this case there _was_ a user interaction so that seems incorrect. Since it’s derived from a value passed from the UI Process, it’s impossible to confirm that by code inspection though. Videos ====== https://screenshot.click/github_and_back_fast.mov https://screenshot.click/github_and_back_slow.mov 1740969 1 mathieu.perreault 2021-03-17 17:34:57 -0700 Forgot to mention that the very simple demo that this is based on is at https://app.tornadored.com/oauth. Thank you! 1740975 2 webkit-bug-importer 2021-03-17 17:41:39 -0700 <rdar://problem/75552559> 1740976 3 wilander 2021-03-17 17:42:01 -0700 Thanks for filing, Mathieu! 1911263 4 drexler.robin 2022-11-09 08:28:04 -0800 The initial bug report description makes it seem like user initiated navigations are only counted as redirects if a user navigates back and forth between two domains. > The interaction is starting at A, clicking on a link to navigate to B, waiting X seconds and clicking to go back to A. However, this behavior also occurs if you click on any outgoing cross-domain link too quickly. Which likely flags a lot of pages unnecessarily as prevalent. E.g. if you go to https://robin-test-1.account.myshopify.com/login?return_to=%2F and click on the `Continue` button in under 5 seconds, an entry to the `TopFrameUniqueRedirectsTo` table will be added for `account.myshopify.com`. 1922292 5 charliew 2022-12-30 12:46:36 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8108 1922549 6 ews-feeder 2023-01-02 11:33:46 -0800 Committed 258382@main (aee01bb955fb): <https://commits.webkit.org/258382@main> Reviewed commits have been landed. Closing PR #8108 and removing active labels.