223390 2021-03-17 11:40:26 -0700 don't use raw unicode characters in modern media controls JS 2021-03-17 12:26:37 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi eric.carlson ews-watchlist glenn hi jer.noble joepeck philipj sergio simon.fraser webkit-bug-importer ysuzuki oldest_to_newest 1740820 0 hi 2021-03-17 11:40:26 -0700 this causes JSC to evaluate the script as UTF-16 1740821 1 423511 hi 2021-03-17 11:41:31 -0700 Created attachment 423511 Patch 1740838 2 ews-feeder 2021-03-17 12:22:26 -0700 Committed r274578: <https://commits.webkit.org/r274578> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423511. 1740839 3 webkit-bug-importer 2021-03-17 12:23:13 -0700 <rdar://problem/75538232> 1740840 4 423511 simon.fraser 2021-03-17 12:26:37 -0700 Comment on attachment 423511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423511&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + * Modules/modern-media-controls/controls/icon-service.js: Missing the "why". 423511 2021-03-17 11:41:31 -0700 2021-03-17 12:22:27 -0700 Patch bug-223390-20210317124130.patch text/plain 7323 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZTZjYWE1NzIyMmQxYjM5MTY5Y2ZhNzE4YTNhNjRjNTg2YTI5ODI3Li4x N2E1ZmE2ODgyOTM5MTg5ZjBiN2Q2NzA4OTRlNTMzYjk2ZWUxMGNhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMjEtMDMtMTcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIGRvbid0IHVzZSByYXcgdW5pY29kZSBjaGFyYWN0ZXJzIGluIG1vZGVybiBt ZWRpYSBjb250cm9scyBKUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjIzMzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBNb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pY29uLXNl cnZpY2UuanM6CisgICAgICAgICogTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJv bHMvdGltZS1sYWJlbC5qczoKKyAgICAgICAgKFRpbWVMYWJlbC5wcm90b3R5cGUuY29tbWl0UHJv cGVydHkpOgorICAgICAgICAqIE1vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhL3Bs YWNhcmQtc3VwcG9ydC5qczoKKyAgICAgICAgKFBsYWNhcmRTdXBwb3J0LnByb3RvdHlwZS5fdXBk YXRlQWlyUGxheVBsYWNhcmQpOgorICAgICAgICAqIGVuLmxwcm9qL21vZGVybi1tZWRpYS1jb250 cm9scy1sb2NhbGl6ZWQtc3RyaW5ncy5qczoKKyAgICAgICAgRHJpdmUtYnk6IEFkZCBtaXNzaW5n IHN0cmluZ3MgYW5kIHJlbW92ZSB1bnVzZWQgb25lcy4KKwogMjAyMS0wMy0xNiAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIGhlYXAgYWxsb2NhdGlvbiB1 bmRlciBBdWRpb1N1bW1pbmdKdW5jdGlvbjo6dXBkYXRlUmVuZGVyaW5nU3RhdGUoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJv bHMvaWNvbi1zZXJ2aWNlLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEt Y29udHJvbHMvY29udHJvbHMvaWNvbi1zZXJ2aWNlLmpzCmluZGV4IGNkNTA3ZDFkMjgwYzgzMDZk MjY5ZThlZTAxNzgxNTkyNmQ5NGE2ZWYuLjdmYTZmN2NlYWM3MTYyMmM0YjcwYjllOWNhYTk2ZGE2 MjI2ZmRiMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlh LWNvbnRyb2xzL2NvbnRyb2xzL2ljb24tc2VydmljZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pY29uLXNlcnZpY2UuanMKQEAg LTMyLDcgKzMyLDcgQEAgY29uc3QgSWNvbnMgPSB7CiAgICAgRm9yd2FyZCAgICAgICAgIDogeyBu YW1lOiAiRm9yd2FyZCIsIHR5cGU6ICJzdmciLCBsYWJlbDogVUlTdHJpbmcoIkZvcndhcmQiKSB9 LAogICAgIEludmFsaWRDaXJjbGUgICA6IHsgbmFtZTogIkludmFsaWRDaXJjbGUiLCB0eXBlOiAi cGRmIiwgbGFiZWw6IFVJU3RyaW5nKCJJbnZhbGlkIikgfSwKICAgICBJbnZhbGlkUGxhY2FyZCAg OiB7IG5hbWU6ICJpbnZhbGlkLXBsYWNhcmQiLCB0eXBlOiAicG5nIiwgbGFiZWw6IFVJU3RyaW5n KCJJbnZhbGlkIikgfSwKLSAgICBPdmVyZmxvdyAgICAgICAgOiB7IG5hbWU6ICJPdmVyZmxvdyIs IHR5cGU6ICJzdmciLCBsYWJlbDogVUlTdHJpbmcoIk1vcmUuLi4iKSB9LAorICAgIE92ZXJmbG93 ICAgICAgICA6IHsgbmFtZTogIk92ZXJmbG93IiwgdHlwZTogInN2ZyIsIGxhYmVsOiBVSVN0cmlu ZygiTW9yZVx1MjAyNiIpIH0sCiAgICAgUGF1c2UgICAgICAgICAgIDogeyBuYW1lOiAiUGF1c2Ui LCB0eXBlOiAic3ZnIiwgbGFiZWw6IFVJU3RyaW5nKCJQYXVzZSIpIH0sCiAgICAgUGlQUGxhY2Fy ZCAgICAgIDogeyBuYW1lOiAicGlwLXBsYWNhcmQiLCB0eXBlOiAicG5nIiwgbGFiZWw6IFVJU3Ry aW5nKCJQaWN0dXJlIGluIFBpY3R1cmUiKSB9LAogICAgIFBsYXkgICAgICAgICAgICA6IHsgbmFt ZTogIlBsYXkiLCB0eXBlOiAic3ZnIiwgbGFiZWw6IFVJU3RyaW5nKCJQbGF5IikgfSwKQEAgLTQw LDcgKzQwLDcgQEAgY29uc3QgSWNvbnMgPSB7CiAgICAgUmV3aW5kICAgICAgICAgIDogeyBuYW1l OiAiUmV3aW5kIiwgdHlwZTogInN2ZyIsIGxhYmVsOiBVSVN0cmluZygiUmV3aW5kIikgfSwKICAg ICBTa2lwQmFjayAgICAgICAgOiB7IG5hbWU6ICJTa2lwQmFjazE1IiwgdHlwZTogInN2ZyIsIGxh YmVsOiBVSVN0cmluZygiU2tpcCBCYWNrICVzIFNlY29uZHMiLCBTa2lwU2Vjb25kcykgfSwKICAg ICBTa2lwRm9yd2FyZCAgICAgOiB7IG5hbWU6ICJTa2lwRm9yd2FyZDE1IiwgdHlwZTogInN2ZyIs IGxhYmVsOiBVSVN0cmluZygiU2tpcCBGb3J3YXJkICVzIFNlY29uZHMiLCBTa2lwU2Vjb25kcykg fSwKLSAgICBTcGlubmVyU3ByaXRlICAgOiB7IG5hbWU6ICJTcGlubmVyU3ByaXRlIiwgdHlwZTog InBuZyIsIGxhYmVsOiBVSVN0cmluZygiTG9hZGluZ+KApiIpIH0sCisgICAgU3Bpbm5lclNwcml0 ZSAgIDogeyBuYW1lOiAiU3Bpbm5lclNwcml0ZSIsIHR5cGU6ICJwbmciLCBsYWJlbDogVUlTdHJp bmcoIkxvYWRpbmdcdTIwMjYiKSB9LAogICAgIFRyYWNrcyAgICAgICAgICA6IHsgbmFtZTogIk1l ZGlhU2VsZWN0b3IiLCB0eXBlOiAic3ZnIiwgbGFiZWw6IFVJU3RyaW5nKCJNZWRpYSBTZWxlY3Rp b24iKSB9LAogICAgIFZvbHVtZTAgICAgICAgICA6IHsgbmFtZTogIlZvbHVtZTAiLCB0eXBlOiAi c3ZnIiwgbGFiZWw6IFVJU3RyaW5nKCJNdXRlIikgfSwKICAgICBWb2x1bWUwUlRMICAgICAgOiB7 IG5hbWU6ICJWb2x1bWUwLVJUTCIsIHR5cGU6ICJzdmciLCBsYWJlbDogVUlTdHJpbmcoIk11dGUi KSB9LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29u dHJvbHMvY29udHJvbHMvdGltZS1sYWJlbC5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL3RpbWUtbGFiZWwuanMKaW5kZXggMTYwYTIwOTdl Y2I2ZDA5MWE5Yjc4MzQ2MTQ4N2U5OWJkNWNkMDQxZS4uYzQzNTg1ZDA4ZTU2NTlkNTdhNGRjZjRj NTVjZGNhZjZmODgyNDU3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rl cm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvdGltZS1sYWJlbC5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy90aW1lLWxhYmVsLmpz CkBAIC03MywxNSArNzMsMTUgQEAgY2xhc3MgVGltZUxhYmVsIGV4dGVuZHMgTGF5b3V0Tm9kZQog ICAgICAgICAgICAgY29uc3QgdGltZUFzU3RyaW5nID0gZm9ybWF0dGVkU3RyaW5nRm9yRHVyYXRp b24odGhpcy52YWx1ZSk7CiAgICAgICAgICAgICBzd2l0Y2ggKHRoaXMuX3R5cGUpIHsKICAgICAg ICAgICAgIGNhc2UgVGltZUxhYmVsLlR5cGUuRWxhcHNlZDoKLSAgICAgICAgICAgICAgICB0aGlz LmVsZW1lbnQuc2V0QXR0cmlidXRlKCJhcmlhLWxhYmVsIiwgYCR7VUlTdHJpbmcoIkVsYXBzZWQi KX06ICR7dGltZUFzU3RyaW5nfWApOworICAgICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5zZXRB dHRyaWJ1dGUoImFyaWEtbGFiZWwiLCBVSVN0cmluZygiRWxhcHNlZDogJXMiLCB0aW1lQXNTdHJp bmcpKTsKICAgICAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICAgICAgY2FzZSBUaW1lTGFi ZWwuVHlwZS5SZW1haW5pbmc6Ci0gICAgICAgICAgICAgICAgdGhpcy5lbGVtZW50LnNldEF0dHJp YnV0ZSgiYXJpYS1sYWJlbCIsIGAke1VJU3RyaW5nKCJSZW1haW5pbmciKX06ICR7dGltZUFzU3Ry aW5nfWApOworICAgICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5zZXRBdHRyaWJ1dGUoImFyaWEt bGFiZWwiLCBVSVN0cmluZygiUmVtYWluaW5nOiAlcyIsIHRpbWVBc1N0cmluZykpOwogICAgICAg ICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgICAgICBjYXNlIFRpbWVMYWJlbC5UeXBlLkR1cmF0 aW9uOgotICAgICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5zZXRBdHRyaWJ1dGUoImFyaWEtbGFi ZWwiLCBgJHtVSVN0cmluZygiRHVyYXRpb24iKX06ICR7dGltZUFzU3RyaW5nfWApOworICAgICAg ICAgICAgICAgIHRoaXMuZWxlbWVudC5zZXRBdHRyaWJ1dGUoImFyaWEtbGFiZWwiLCBVSVN0cmlu ZygiRHVyYXRpb246ICVzIiwgdGltZUFzU3RyaW5nKSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhL3BsYWNhcmQtc3VwcG9ydC5qcyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhL3BsYWNhcmQtc3VwcG9ydC5q cwppbmRleCA5YjA0N2YzMjY2NGY4YmQwY2JiNTI5MDk2MGFmYjRiMzg1ODQ0MmUyLi5jZWQzMGUw YzEyOGY1YTllZTc0ZmY2ODhhOTAzNzY5MGQ1MzMwYjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS9wbGFjYXJkLXN1cHBvcnQu anMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVk aWEvcGxhY2FyZC1zdXBwb3J0LmpzCkBAIC04Niw3ICs4Niw3IEBAIGNsYXNzIFBsYWNhcmRTdXBw b3J0IGV4dGVuZHMgTWVkaWFDb250cm9sbGVyU3VwcG9ydAogICAgICAgICAKICAgICAgICAgc3dp dGNoKHRoaXMubWVkaWFDb250cm9sbGVyLmhvc3QuZXh0ZXJuYWxEZXZpY2VUeXBlKSB7CiAgICAg ICAgICAgICBjYXNlICdhaXJwbGF5JzoKLSAgICAgICAgICAgICAgICBkZXZpY2VOYW1lID0gVUlT dHJpbmcoIlRoaXMgdmlkZW8gaXMgcGxheWluZyBvbiDigJwlc+KAnS4iLCBlc2NhcGVIVE1MKHRo aXMubWVkaWFDb250cm9sbGVyLmhvc3QuZXh0ZXJuYWxEZXZpY2VEaXNwbGF5TmFtZSkgfHwgVUlT dHJpbmcoIkFwcGxlIFRWIikpOworICAgICAgICAgICAgICAgIGRldmljZU5hbWUgPSBVSVN0cmlu ZygiVGhpcyB2aWRlbyBpcyBwbGF5aW5nIG9uIFx1MjAxQyVzXHUyMDFELiIsIGVzY2FwZUhUTUwo dGhpcy5tZWRpYUNvbnRyb2xsZXIuaG9zdC5leHRlcm5hbERldmljZURpc3BsYXlOYW1lKSB8fCBV SVN0cmluZygiQXBwbGUgVFYiKSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg ICBjYXNlICd0dm91dCc6CiAgICAgICAgICAgICAgICAgZGV2aWNlTmFtZSA9IFVJU3RyaW5nKCJU aGlzIHZpZGVvIGlzIHBsYXlpbmcgb24gdGhlIFRWLiIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZW4ubHByb2ovbW9kZXJuLW1lZGlhLWNvbnRyb2xzLWxvY2FsaXplZC1zdHJpbmdzLmpz IGIvU291cmNlL1dlYkNvcmUvZW4ubHByb2ovbW9kZXJuLW1lZGlhLWNvbnRyb2xzLWxvY2FsaXpl ZC1zdHJpbmdzLmpzCmluZGV4IDI4OTBjZTQwYjUzN2UzZjY1YjFkN2U4ZWI3YzUyZDQ0Nzk0NWM2 M2EuLjk0NTg0NjkzNWRiOWNkZTBkZDk4NTY2MDJjODE3ZWJlNzZjNmU3NjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2VuLmxwcm9qL21vZGVybi1tZWRpYS1jb250cm9scy1sb2NhbGl6ZWQt c3RyaW5ncy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9lbi5scHJvai9tb2Rlcm4tbWVkaWEtY29u dHJvbHMtbG9jYWxpemVkLXN0cmluZ3MuanMKQEAgLTEsMzMgKzEsMzAgQEAKIGNvbnN0IFVJU3Ry aW5ncyA9IHsKICAgICAiQWlyUGxheSI6ICJBaXJQbGF5IiwKICAgICAiQXBwbGUgVFYiOiAiQXBw bGUgVFYiLAotICAgICJBdWRpbyI6ICJBdWRpbyIsCiAgICAgIkF1ZGlvIENvbnRyb2xzIjogIkF1 ZGlvIENvbnRyb2xzIiwKLSAgICAiRHVyYXRpb24iOiAiRHVyYXRpb24iLAorICAgICJEdXJhdGlv bjogJXMiOiAiRHVyYXRpb246ICVzIiwKICAgICAiRW50ZXIgRnVsbCBTY3JlZW4iOiAiRW50ZXIg RnVsbCBTY3JlZW4iLAogICAgICJFbnRlciBQaWN0dXJlIGluIFBpY3R1cmUiOiAiRW50ZXIgUGlj dHVyZSBpbiBQaWN0dXJlIiwKLSAgICAiRWxhcHNlZCI6ICJFbGFwc2VkIiwKKyAgICAiRWxhcHNl ZDogJXMiOiAiRWxhcHNlZDogJXMiLAogICAgICJFeGl0IEZ1bGwgU2NyZWVuIjogIkV4aXQgRnVs bCBTY3JlZW4iLAogICAgICJFcnJvciI6ICJFcnJvciIsCiAgICAgIkZvcndhcmQiOiAiRm9yd2Fy ZCIsCiAgICAgIkludmFsaWQiOiAiSW52YWxpZCIsCiAgICAgIkxpdmUgQnJvYWRjYXN0IjogIkxp dmUgQnJvYWRjYXN0IiwKKyAgICAiTG9hZGluZ1x1MjAyNiI6ICJMb2FkaW5nXHUyMDI2IiwKICAg ICAiTWVkaWEgU2VsZWN0aW9uIjogIk1lZGlhIFNlbGVjdGlvbiIsCi0gICAgIk1vcmUuLi4iOiAi TW9yZS4uLiIsCisgICAgIk1vcmVcdTIwMjYiOiAiTW9yZVx1MjAyNiIsCiAgICAgIk11dGUiOiAi TXV0ZSIsCiAgICAgIlBhdXNlIjogIlBhdXNlIiwKICAgICAiUGljdHVyZSBpbiBQaWN0dXJlIjog IlBpY3R1cmUgaW4gUGljdHVyZSIsCiAgICAgIlBsYXkiOiAiUGxheSIsCi0gICAgIlJlbWFpbmlu ZyI6ICJSZW1haW5pbmciLAorICAgICJSZW1haW5pbmc6ICVzIjogIlJlbWFpbmluZzogJXMiLAog ICAgICJSZXdpbmQiOiAiUmV3aW5kIiwKICAgICAiU2tpcCBCYWNrICVzIFNlY29uZHMiOiAiU2tp cCBCYWNrICVzIFNlY29uZHMiLAogICAgICJTa2lwIEZvcndhcmQgJXMgU2Vjb25kcyI6ICJTa2lw IEZvcndhcmQgJXMgU2Vjb25kcyIsCi0gICAgIlN1YnRpdGxlcyI6ICJTdWJ0aXRsZXMiLAogICAg ICJUaGlzIHZpZGVvIGlzIHBsYXlpbmcgaW4gcGljdHVyZSBpbiBwaWN0dXJlLiI6ICJUaGlzIHZp ZGVvIGlzIHBsYXlpbmcgaW4gcGljdHVyZSBpbiBwaWN0dXJlLiIsCiAgICAgIlRoaXMgdmlkZW8g aXMgcGxheWluZyBvbiB0aGUgVFYuIjogIlRoaXMgdmlkZW8gaXMgcGxheWluZyBvbiB0aGUgVFYu IiwKLSAgICAiVGhpcyB2aWRlbyBpcyBwbGF5aW5nIG9uIOKAnCVz4oCdLiI6ICJUaGlzIHZpZGVv IGlzIHBsYXlpbmcgb24g4oCcJXPigJ0uIiwKKyAgICAiVGhpcyB2aWRlbyBpcyBwbGF5aW5nIG9u IFx1MjAxQyVzXHUyMDFELiI6ICJUaGlzIHZpZGVvIGlzIHBsYXlpbmcgb24gXHUyMDFDJXNcdTIw MUQuIiwKICAgICAiVW5tdXRlIjogIlVubXV0ZSIsCiAgICAgIlZpZGVvIENvbnRyb2xzIjogIlZp ZGVvIENvbnRyb2xzIiwKLSAgICAiVm9sdW1lIERvd24iOiAiVm9sdW1lIERvd24iLAotICAgICJW b2x1bWUgVXAiOiAiVm9sdW1lIFVwIgogfTsK