223340 2021-03-17 00:28:29 -0700 [GTK][WPE][CMake] libCMS2 should be included only if guard USE_LCMS is defined 2021-03-18 16:39:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223442 InRadar P2 Normal --- 1 dpino dpino annulen bugs-noreply cgarcia ews-watchlist gyuyoung.kim ryuan.choi sergio webkit-bug-importer oldest_to_newest 1740444 0 dpino 2021-03-17 00:28:29 -0700 [GTK][WPE][CMake] libCMS2 should be included only if guard USE_LCMS is defined 1740446 1 423443 dpino 2021-03-17 00:29:11 -0700 Created attachment 423443 Patch 1740615 2 cgarcia 2021-03-17 02:18:34 -0700 Why? aren't those just empty? 1740977 3 dpino 2021-03-17 17:49:04 -0700 (In reply to Carlos Garcia Campos from comment #2) > Why? aren't those just empty? In the webkitsearch instance I build WebKit directly using cmake, with a command like this: cmake /home/buildbot/webkit-index/webkit/WebKit -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ '-DCMAKE_C_FLAGS=-Xclang -load -Xclang /home/buildbot/mozsearch/clang-plugin/libclang-index-plugin.so -Xclang -add-plugin -Xclang mozsearch-index -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/analysis -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit/target -Xclang -fparse-all-comments' '-DCMAKE_CXX_FLAGS=-Xclang -load -Xclang /home/buildbot/mozsearch/clang-plugin/libclang-index-plugin.so -Xclang -add-plugin -Xclang mozsearch-index -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/analysis -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit/target -Xclang -fparse-all-comments' -DUSE_WPE_RENDERER=OFF -DUSE_LCMS=OFF -DENABLE_BUBBLEWRAP_SANDBOX=OFF -DENABLE_GAMEPAD=OFF -DCMAKE_BUILD_TYPE=Debug -DPORT=GTK I got the following error when passing -DUSE_LCMS=OFF: CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: LCMS2_INCLUDE_DIR (ADVANCED) used as include directory in directory /home/buildbot/webkit-index/webkit/WebKit/Source/WebCore ... LCMS2_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/buildbot/webkit-index/webkit/WebKit/Source/WebCore ... 1741500 4 ews-feeder 2021-03-18 16:38:20 -0700 Committed r274685: <https://commits.webkit.org/r274685> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423443. 1741502 5 webkit-bug-importer 2021-03-18 16:39:18 -0700 <rdar://problem/75596979> 423443 2021-03-17 00:29:11 -0700 2021-03-18 16:38:22 -0700 Patch bug-223340-20210317152909.patch text/plain 3069 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZmYzQ0OGEyNTMwM2I3 NGRmMzlkMTA2YWJkNDFhYzBlNjE3MTI2YS4uYjFlOGY4ZWU4MjgyYWVmZmVmYWUxNjA5M2JlYzE0 ZjY5ODk1ZGU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTAzLTE3ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXVtD TWFrZV0gbGliQ01TMiBzaG91bGQgYmUgaW5jbHVkZWQgb25seSBpZiBndWFyZCBVU0VfTENNUyBp cyBkZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjMzNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorICAgICAgICAqIFBsYXRmb3JtV1BFLmNtYWtlOgorCiAy MDIxLTAzLTE2ICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgZG9j dW1lbnQgcGljdHVyZUluUGljdHVyZUVsZW1lbnQgaXMgbnVsbCBpZiB5b3UgRW50ZXIgUGljdHVy ZSBpbiBQaWN0dXJlIGZyb20gY29udGV4dHVhbCBtZW51CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9QbGF0Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtl CmluZGV4IGM0NmMwYmFkZDNiNTE1ZTc4NWI3NGQ2NmU3OGI0Mjk4Yjk5MTc2MTYuLjNjMDE0NmY2 OTgyYjExNzliY2NjNDg0YWM2M2VhOWE3NTQ3ZGI4OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt YWtlCkBAIC05Myw3ICs5Myw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAg JHtHTElCX0dNT0RVTEVfTElCUkFSSUVTfQogICAgICR7R0xJQl9HT0JKRUNUX0xJQlJBUklFU30K ICAgICAke0dMSUJfTElCUkFSSUVTfQotICAgICR7TENNUzJfTElCUkFSSUVTfQogICAgICR7TElC U0VDUkVUX0xJQlJBUklFU30KICAgICAke0xJQlRBU04xX0xJQlJBUklFU30KICAgICAke0hZUEhF Tl9MSUJSQVJJRVN9CkBAIC0xMDYsNiArMTA1LDEyIEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElC UkFSSUVTCiAgICAgR1RLOjpHVEsKICkKIAoraWYgKFVTRV9MQ01TKQorICAgIGxpc3QoQVBQRU5E IFdlYkNvcmVfTElCUkFSSUVTCisgICAgICAgICR7TENNUzJfTElCUkFSSUVTfQorICAgICkKK2Vu ZGlmICgpCisKIGlmIChVU0VfV1BFX1JFTkRFUkVSKQogICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVf TElCUkFSSUVTCiAgICAgICAgIFdQRTo6bGlid3BlCkBAIC0xMTcsMTIgKzEyMiwxNyBAQCBsaXN0 KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtFTkNIQU5U X0lOQ0xVREVfRElSU30KICAgICAke0dJT19VTklYX0lOQ0xVREVfRElSU30KICAgICAke0dMSUJf SU5DTFVERV9ESVJTfQotICAgICR7TENNUzJfSU5DTFVERV9ESVJ9CiAgICAgJHtMSUJTRUNSRVRf SU5DTFVERV9ESVJTfQogICAgICR7TElCVEFTTjFfSU5DTFVERV9ESVJTfQogICAgICR7VVBPV0VS R0xJQl9JTkNMVURFX0RJUlN9CiApCiAKK2lmIChVU0VfTENNUykKKyAgICBsaXN0KEFQUEVORCBX ZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAgICAgICR7TENNUzJfSU5DTFVE RV9ESVJ9CisgICAgKQorZW5kaWYgKCkKKwogaWYgKFVTRV9PUEVOR0wpCiAgICAgbGlzdChBUFBF TkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL09wZW5HTFNoaW1z LmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UgYi9Tb3Vy Y2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCA1ZTdiNmFhN2Y4MDhmZWUwNTdkYjUx MWZkMjFkOThhMzM1YzZjMzAwLi44ODQ5MTBjZmUwYmIzMTk5YmI2YjcwMmQwYWIxMTlhYWJiNGQ2 N2VjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQorKysgYi9T b3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtNTgsMjAgKzU4LDMwIEBAIGxpc3Qo QVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAgJHtHTElCX0dNT0RVTEVfTElCUkFSSUVTfQog ICAgICR7R0xJQl9HT0JKRUNUX0xJQlJBUklFU30KICAgICAke0dMSUJfTElCUkFSSUVTfQotICAg ICR7TENNUzJfTElCUkFSSUVTfQogICAgICR7TElCVEFTTjFfTElCUkFSSUVTfQogICAgICR7VVBP V0VSR0xJQl9MSUJSQVJJRVN9CiApCiAKK2lmIChVU0VfTENNUykKKyAgICBsaXN0KEFQUEVORCBX ZWJDb3JlX0xJQlJBUklFUworICAgICAgICAke0xDTVMyX0xJQlJBUklFU30KKyAgICApCitlbmRp ZiAoKQorCiBsaXN0KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAg ICAgJHtBVEtfSU5DTFVERV9ESVJTfQogICAgICR7R0lPX1VOSVhfSU5DTFVERV9ESVJTfQogICAg ICR7R0xJQl9JTkNMVURFX0RJUlN9Ci0gICAgJHtMQ01TMl9JTkNMVURFX0RJUn0KICAgICAke0xJ QlRBU04xX0lOQ0xVREVfRElSU30KICAgICAke1VQT1dFUkdMSUJfSU5DTFVERV9ESVJTfQogKQog CitpZiAoVVNFX0xDTVMpCisgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TWVNURU1fSU5DTFVERV9E SVJFQ1RPUklFUworICAgICAgICAke0xDTVMyX0lOQ0xVREVfRElSfQorICAgICkKK2VuZGlmICgp CisKIGlmIChVU0VfV1BFX1ZJREVPX1BMQU5FX0RJU1BMQVlfRE1BQlVGIE9SIFVTRV9XUEVCQUNL RU5EX0ZET19BVURJT19FWFRFTlNJT04pCiAgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJ RVMgJHtXUEVCQUNLRU5EX0ZET19MSUJSQVJJRVN9KQogICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVf U1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMgJHtXUEVfSU5DTFVERV9ESVJTfSkK