223307 2021-03-16 22:29:02 -0700 Avoid unnecessary repaints when transforms change 2021-03-17 16:13:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham changseok esprehn+autocc ews-watchlist glenn jonlee kondapallykalyan pdr sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1740385 0 simon.fraser 2021-03-16 22:29:02 -0700 Avoid unnecessary repaints when transforms change 1740386 1 423436 simon.fraser 2021-03-16 22:32:19 -0700 Created attachment 423436 Patch 1740700 2 423436 sam 2021-03-17 07:39:07 -0700 Comment on attachment 423436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423436&action=review > Source/WebCore/ChangeLog:17 > + This reduces some repaint calls in the MotionMark leaves test. This seems like something that would be great to be able to write tests for. Any ideas on how we could make this testable? 1740891 3 webkit-bug-importer 2021-03-17 13:53:00 -0700 <rdar://problem/75542232> 1740944 4 simon.fraser 2021-03-17 16:13:17 -0700 Landed with a test: https://trac.webkit.org/changeset/274597/webkit 423436 2021-03-16 22:32:19 -0700 2021-03-17 12:24:22 -0700 Patch bug-223307-20210316223218.patch text/plain 4248 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZiYThlNTU2OTlmYTQ4 ZmI5NTI3MmI1N2VhZDYxYjRlNjYxYzlmYi4uYTcxZmI1YjRmZDdlYjI2ZDcxNDdlOTZjOTNmODc1 YmUzOGY0MTczNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIxLTAzLTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIHVubmVj ZXNzYXJ5IHJlcGFpbnRzIHdoZW4gdHJhbnNmb3JtcyBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzMwNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlckVsZW1lbnQ6OnJlcGFpbnRCZWZv cmVTdHlsZUNoYW5nZSgpIGlzc3VlcyByZXBhaW50cyB3aGVuIHRyYW5zZm9ybXMsIG9wYWNpdHkK KyAgICAgICAgb3IgZmlsdGVycyBjaGFuZ2UgYmVjYXVzZSB0aGUgbGF5ZXIgbWlnaHQgZGlzYXBw ZWFyLCBidXQgd2Uga25vdyB0aGF0IHRoaXMgb25seSBoYXBwZW5zCisgICAgICAgIGlmIHRoZSBz dHlsZSBjaGFuZ2VzIGJldHdlZW4gaGF2aW5nIGEgdHJhbnNmb3JtL2ZpbHRlci9ub24tMSBvcGFj aXR5IGFuZCBub3QuCisKKyAgICAgICAgVHJhbnNmb3JtIGNoYW5nZXMgaW4gZ2VuZXJhbCByZXBh aW50IHZpYSBsYXlvdXQgKHRoZSBSZW5kZXJMYXllciBnZXRzIHNldExheWVyTmVlZHNGdWxsUmVw YWludCgpCisgICAgICAgIGNhbGxlZCBvbiBpdCkuCisKKyAgICAgICAgT3BhY2l0eSBhbmQgZmls dGVyIGNoYW5nZXMgcmVwYWludCBieSB2aXJ0dWUgb2YgYSBSZXBhaW50TGF5ZXIgc3R5bGUgZGlm Zi4KKworICAgICAgICBUaGlzIHJlZHVjZXMgc29tZSByZXBhaW50IGNhbGxzIGluIHRoZSBNb3Rp b25NYXJrIGxlYXZlcyB0ZXN0LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRWxlbWVudDo6cmVwYWludEJlZm9yZVN0eWxl Q2hhbmdlKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclN0eWxlOjpoYXNPcGFjaXR5IGNvbnN0KToKKwogMjAyMS0wMy0x NSAgRWJyYWhpbSBCeWFnb3dpIDxlYnJhaGltQGdudS5vcmc+IGFuZCBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgPGltZz4gaXNuJ3QgYWJsZSB0byBy ZW5kZXIgUlRMIHRleHQgY29ycmVjdGx5IGluIEFMVCB0ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKaW5kZXggODA3OGJmNzkxMTFjODgwMzk5ZmU0OTEzODY5 OGI3Y2VhYmI3NzQ4Yi4uOGI2YzYwYmI0MDRmNmU3N2QzYmQ2NzRjZWFkZjI5MTEwZDI5M2RiMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcApAQCAtNDA2LDkg KzQwNiw5IEBAIGJvb2wgUmVuZGVyRWxlbWVudDo6cmVwYWludEJlZm9yZVN0eWxlQ2hhbmdlKFN0 eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTCiAgICAgICAgICAgICAgICAgICAgIHx8 IG9sZFN0eWxlLmhhc0F1dG9Vc2VkWkluZGV4KCkgIT0gbmV3U3R5bGUuaGFzQXV0b1VzZWRaSW5k ZXgoKQogICAgICAgICAgICAgICAgICAgICB8fCBvbGRTdHlsZS5jbGlwKCkgIT0gbmV3U3R5bGUu Y2xpcCgpCiAgICAgICAgICAgICAgICAgICAgIHx8IG9sZFN0eWxlLmhhc0NsaXAoKSAhPSBuZXdT dHlsZS5oYXNDbGlwKCkKLSAgICAgICAgICAgICAgICAgICAgfHwgb2xkU3R5bGUub3BhY2l0eSgp ICE9IG5ld1N0eWxlLm9wYWNpdHkoKQotICAgICAgICAgICAgICAgICAgICB8fCBvbGRTdHlsZS50 cmFuc2Zvcm0oKSAhPSBuZXdTdHlsZS50cmFuc2Zvcm0oKQotICAgICAgICAgICAgICAgICAgICB8 fCBvbGRTdHlsZS5maWx0ZXIoKSAhPSBuZXdTdHlsZS5maWx0ZXIoKTsKKyAgICAgICAgICAgICAg ICAgICAgfHwgb2xkU3R5bGUuaGFzT3BhY2l0eSgpICE9IG5ld1N0eWxlLmhhc09wYWNpdHkoKQor ICAgICAgICAgICAgICAgICAgICB8fCBvbGRTdHlsZS5oYXNUcmFuc2Zvcm0oKSAhPSBuZXdTdHls ZS5oYXNUcmFuc2Zvcm0oKQorICAgICAgICAgICAgICAgICAgICB8fCBvbGRTdHlsZS5oYXNGaWx0 ZXIoKSAhPSBuZXdTdHlsZS5oYXNGaWx0ZXIoKTsKICAgICAgICAgICAgICAgICBpZiAobGF5ZXJN YXlHZXREZXN0cm95ZWQpCiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBSZXF1aXJlZFJlcGFp bnQ6OlJlbmRlcmVyQW5kRGVzY2VuZGFudHNSZW5kZXJlcnNXaXRoTGF5ZXJzOwogICAgICAgICAg ICAgfQpAQCAtNDIwLDcgKzQyMCw3IEBAIGJvb2wgUmVuZGVyRWxlbWVudDo6cmVwYWludEJlZm9y ZVN0eWxlQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTCiAgICAgICAg IGlmIChpczxSZW5kZXJMYXllck1vZGVsT2JqZWN0PigqdGhpcykpIHsKICAgICAgICAgICAgIC8v IElmIHdlIGRvbid0IGhhdmUgYSBsYXllciB5ZXQsIGJ1dCB3ZSBhcmUgZ29pbmcgdG8gZ2V0IG9u ZSBiZWNhdXNlIG9mIHRyYW5zZm9ybSBvciBvcGFjaXR5LCB0aGVuIHdlIG5lZWQgdG8gcmVwYWlu dCB0aGUgb2xkIHBvc2l0aW9uIG9mIHRoZSBvYmplY3QuCiAgICAgICAgICAgICBib29sIGhhc0xh eWVyID0gZG93bmNhc3Q8UmVuZGVyTGF5ZXJNb2RlbE9iamVjdD4oKnRoaXMpLmhhc0xheWVyKCk7 Ci0gICAgICAgICAgICBib29sIHdpbGxIYXZlTGF5ZXIgPSBuZXdTdHlsZS5oYXNUcmFuc2Zvcm0o KSB8fCBuZXdTdHlsZS5vcGFjaXR5KCkgPCAxIHx8IG5ld1N0eWxlLmhhc0ZpbHRlcigpIHx8IG5l d1N0eWxlLmhhc0JhY2tkcm9wRmlsdGVyKCk7CisgICAgICAgICAgICBib29sIHdpbGxIYXZlTGF5 ZXIgPSBuZXdTdHlsZS5oYXNUcmFuc2Zvcm0oKSB8fCBuZXdTdHlsZS5oYXNPcGFjaXR5KCkgfHwg bmV3U3R5bGUuaGFzRmlsdGVyKCkgfHwgbmV3U3R5bGUuaGFzQmFja2Ryb3BGaWx0ZXIoKTsKICAg ICAgICAgICAgIGlmICghaGFzTGF5ZXIgJiYgd2lsbEhhdmVMYXllcikKICAgICAgICAgICAgICAg ICByZXR1cm4gUmVxdWlyZWRSZXBhaW50OjpSZW5kZXJlck9ubHk7CiAgICAgICAgIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKaW5kZXggNThhMmIyYzRh MzBjMTA1YTkxMzFlMGNiMTMzMzhiYjlkNWY2OTIyOC4uMmNjMjcxOWJlODI3NDQzNzVlOGY4ZWVm N2E1YmU4NjNjZTMyNmZhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0 eWxlL1JlbmRlclN0eWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1Jl bmRlclN0eWxlLmgKQEAgLTUwMiw2ICs1MDIsNyBAQCBwdWJsaWM6CiAKICAgICBmbG9hdCB0ZXh0 U3Ryb2tlV2lkdGgoKSBjb25zdCB7IHJldHVybiBtX3JhcmVJbmhlcml0ZWREYXRhLT50ZXh0U3Ry b2tlV2lkdGg7IH0KICAgICBmbG9hdCBvcGFjaXR5KCkgY29uc3QgeyByZXR1cm4gbV9yYXJlTm9u SW5oZXJpdGVkRGF0YS0+b3BhY2l0eTsgfQorICAgIGJvb2wgaGFzT3BhY2l0eSgpIGNvbnN0IHsg cmV0dXJuIG1fcmFyZU5vbkluaGVyaXRlZERhdGEtPm9wYWNpdHkgPCAxOyB9CiAgICAgQ29udHJv bFBhcnQgYXBwZWFyYW5jZSgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PENvbnRyb2xQYXJ0 PihtX3JhcmVOb25Jbmhlcml0ZWREYXRhLT5hcHBlYXJhbmNlKTsgfQogICAgIEFzcGVjdFJhdGlv VHlwZSBhc3BlY3RSYXRpb1R5cGUoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxBc3BlY3RS YXRpb1R5cGU+KG1fcmFyZU5vbkluaGVyaXRlZERhdGEtPmFzcGVjdFJhdGlvVHlwZSk7IH0KICAg ICBkb3VibGUgYXNwZWN0UmF0aW9XaWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fcmFyZU5vbkluaGVy aXRlZERhdGEtPmFzcGVjdFJhdGlvV2lkdGg7IH0K