223297 2021-03-16 19:05:59 -0700 [GLIB] REGRESSION(r274273): fast/canvas/webgl/gl-teximage-imagebitmap.html is failing 2021-03-18 18:16:16 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino bugs-noreply cgarcia jdarpinian kbr kkinnunen Ms2ger webkit-bug-importer zdobersek oldest_to_newest 1740346 0 dpino 2021-03-16 19:05:59 -0700 The test is failing since r274273: https://results.webkit.org/?platform=GTK&platform=ios&platform=mac&platform=WPE&suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2Fgl-teximage-imagebitmap.html --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/gl-teximage-imagebitmap-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/gl-teximage-imagebitmap-actual.txt @@ -5,11 +5,12 @@ PASS pixel 299, 149 should be 255, 0, 0, 255 was 255, 0, 0, 255 PASS pixel 0, 75 should be 255, 0, 255, 255 was 255, 0, 255, 255 PASS pixel 150, 75 should be 255, 0, 0, 255 was 255, 0, 0, 255 -PASS pixel 299, 75 should be 0, 255, 0, 255 was 0, 255, 0, 255 +FAIL pixel 299, 75 should be 0, 255, 0, 255 was 1, 255, 0, 255 PASS pixel 0, 0 should be 255, 0, 0, 255 was 255, 0, 0, 255 PASS pixel 150, 0 should be 255, 255, 0, 255 was 255, 255, 0, 255 PASS pixel 299, 0 should be 255, 0, 0, 255 was 255, 0, 0, 255 PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1740970 1 kbr 2021-03-17 17:36:01 -0700 This looks like perhaps the test's tolerance should just be increased. Feel free to propose a pull request at https://github.com/KhronosGroup/WebGL . 1741017 2 423557 dpino 2021-03-17 20:33:58 -0700 Created attachment 423557 Patch 1741019 3 dpino 2021-03-17 20:39:09 -0700 (In reply to Kenneth Russell from comment #1) > This looks like perhaps the test's tolerance should just be increased. Feel > free to propose a pull request at https://github.com/KhronosGroup/WebGL . It seems this test is not a test from the WebGL KhronosGroup test suite. I couldn't find this test in the repository, and neither the test has a KhronosGroup header, like other layout-tests (for instance, LayoutTests/fast/canvas/webgl/webgl-draw-buffers.html). 1741377 4 kbr 2021-03-18 13:27:10 -0700 Correct, the fast/canvas/webgl/ tests don't exist in the official conformance repository https://github.com/KhronosGroup/WebGL , but there are similar tests under: https://github.com/KhronosGroup/WebGL/tree/master/sdk/tests/conformance/textures https://github.com/KhronosGroup/WebGL/tree/master/sdk/tests/conformance2/textures and we'd certainly appreciate it if you'd check to see whether these cases are already covered, and if not, adding new tests to cover them. Thanks in advance for your help. 1741533 5 ews-feeder 2021-03-18 18:15:27 -0700 Committed r274694: <https://commits.webkit.org/r274694> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423557. 1741534 6 webkit-bug-importer 2021-03-18 18:16:16 -0700 <rdar://problem/75600645> 423557 2021-03-17 20:33:58 -0700 2021-03-18 18:15:28 -0700 Patch bug-223297-20210318033357.patch text/plain 4927 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NTQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTlhZTFmZGIxYWJkNTg3ODNkZTAw MWNiNTM2MTk1NTQwYWFiM2RiYy4uYWNjMzMwYzc1YjA2YzgxZjAyYjU3ZDYxOTkzYWNiMGFhOTA0 OGVlZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAzLTE3ICBEaWVnbyBQaW5vIEdhcmNp YSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIFJFR1JFU1NJT04ocjI3NDI3 Myk6IGZhc3QvY2FudmFzL3dlYmdsL2dsLXRleGltYWdlLWltYWdlYml0bWFwLmh0bWwgaXMgZmFp bGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIz Mjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyB0ZXN0IHN0YXJ0ZWQgZmFpbGluZyBpbiBHVEsgYWZ0ZXIgcjI3NDI3My4gVGhlIHRlc3QgZmFp bHMgZHVlIHRvIGEgcGl4ZWwgY29sb3IgZGlmZmVyZW5jZSBvZiAxLgorICAgICAgICBDaGFuZ2Ug ZmFpbGluZyB0ZXN0IHRvIGFsbG93IGEgdG9sZXJhbmNlIG9mIDEgd2hlbiBjb21wYXJpbmcgZXhw ZWN0ZWQgYW5kIGFjdHVhbCByZXN1bHRzLgorCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wv Z2wtdGV4aW1hZ2UtaW1hZ2ViaXRtYXAtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvY2Fu dmFzL3dlYmdsL2dsLXRleGltYWdlLWltYWdlYml0bWFwLmh0bWw6CisKIDIwMjEtMDMtMTYgIFJv YmVydCBKZW5uZXIgIDxqZW5uZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFsgbWFjT1Mgd2syIF0g bWVkaWEvbWVkaWEtZnVsbHNjcmVlbi1yZXR1cm4tdG8taW5saW5lLmh0bWwgaXMgYSBmbGFrZXkg dGV4dCBmYWlsdXJlIGFuZCBmbGFrZXkgdGltZW91dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvZ2wtdGV4aW1hZ2UtaW1hZ2ViaXRtYXAtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtdGV4aW1hZ2UtaW1hZ2ViaXRtYXAtZXhw ZWN0ZWQudHh0CmluZGV4IDQ3ZTFiMmMwMGQ3NmFkMzZmMjhlNjAyMTYxMzkyZDI5NzUyNzk1ZTYu LjE2MWQwNzIyN2MxYTY4MjViNGY1ZDZmODY5MTlmOThjZDQ0MTlkZWYgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLXRleGltYWdlLWltYWdlYml0bWFwLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC10ZXhpbWFnZS1p bWFnZWJpdG1hcC1leHBlY3RlZC50eHQKQEAgLTEsMTQgKzEsMTQgQEAKIFBBU1MgZ2V0RXJyb3Ig d2FzIGV4cGVjdGVkIHZhbHVlOiBOT19FUlJPUiA6IFNob3VsZCBiZSBubyBlcnJvcnMgZnJvbSBz ZXR1cC4KIFBBU1MgZ2V0RXJyb3Igd2FzIGV4cGVjdGVkIHZhbHVlOiBOT19FUlJPUiA6IFNob3Vs ZCBiZSBubyBlcnJvcnMgZnJvbSBzZXR1cAotUEFTUyBwaXhlbCAwLCAxNDkgc2hvdWxkIGJlIDAs IDAsIDAsIDI1NSB3YXMgMCwgMCwgMCwgMjU1Ci1QQVNTIHBpeGVsIDE1MCwgMTQ5IHNob3VsZCBi ZSAwLCAwLCAyNTUsIDI1NSB3YXMgMCwgMCwgMjU1LCAyNTUKLVBBU1MgcGl4ZWwgMjk5LCAxNDkg c2hvdWxkIGJlIDI1NSwgMCwgMCwgMjU1IHdhcyAyNTUsIDAsIDAsIDI1NQotUEFTUyBwaXhlbCAw LCA3NSBzaG91bGQgYmUgMjU1LCAwLCAyNTUsIDI1NSB3YXMgMjU1LCAwLCAyNTUsIDI1NQotUEFT UyBwaXhlbCAxNTAsIDc1IHNob3VsZCBiZSAyNTUsIDAsIDAsIDI1NSB3YXMgMjU1LCAwLCAwLCAy NTUKLVBBU1MgcGl4ZWwgMjk5LCA3NSBzaG91bGQgYmUgMCwgMjU1LCAwLCAyNTUgd2FzIDAsIDI1 NSwgMCwgMjU1Ci1QQVNTIHBpeGVsIDAsIDAgc2hvdWxkIGJlIDI1NSwgMCwgMCwgMjU1IHdhcyAy NTUsIDAsIDAsIDI1NQotUEFTUyBwaXhlbCAxNTAsIDAgc2hvdWxkIGJlIDI1NSwgMjU1LCAwLCAy NTUgd2FzIDI1NSwgMjU1LCAwLCAyNTUKLVBBU1MgcGl4ZWwgMjk5LCAwIHNob3VsZCBiZSAyNTUs IDAsIDAsIDI1NSB3YXMgMjU1LCAwLCAwLCAyNTUKK1BBU1MgcGl4ZWwgMCwgMTQ5IHdhcyAwLCAw LCAwLCAyNTUKK1BBU1MgcGl4ZWwgMTUwLCAxNDkgd2FzIDAsIDAsIDI1NSwgMjU1CitQQVNTIHBp eGVsIDI5OSwgMTQ5IHdhcyAyNTUsIDAsIDAsIDI1NQorUEFTUyBwaXhlbCAwLCA3NSB3YXMgMjU1 LCAwLCAyNTUsIDI1NQorUEFTUyBwaXhlbCAxNTAsIDc1IHdhcyAyNTUsIDAsIDAsIDI1NQorUEFT UyBwaXhlbCAyOTksIDc1IHdhcyAwLCAyNTUsIDAsIDI1NQorUEFTUyBwaXhlbCAwLCAwIHdhcyAy NTUsIDAsIDAsIDI1NQorUEFTUyBwaXhlbCAxNTAsIDAgd2FzIDI1NSwgMjU1LCAwLCAyNTUKK1BB U1MgcGl4ZWwgMjk5LCAwIHdhcyAyNTUsIDAsIDAsIDI1NQogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2NhbnZhcy93ZWJnbC9nbC10ZXhpbWFnZS1pbWFnZWJpdG1hcC5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvZ2wtdGV4aW1hZ2UtaW1hZ2ViaXRtYXAuaHRtbAppbmRleCAyNGEy YTgyNzI5Nzg3MjI5Y2FhNDNhODg3YzA4NGJhZDRjMzM4MTMxLi5jMmZlODkxOTMwMWQxMjEwZWVm ZTdkZWFmMDVhYTllYmJkN2M3NTRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy93ZWJnbC9nbC10ZXhpbWFnZS1pbWFnZWJpdG1hcC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvY2FudmFzL3dlYmdsL2dsLXRleGltYWdlLWltYWdlYml0bWFwLmh0bWwKQEAgLTE5LDkgKzE5 LDkgQEAgZnVuY3Rpb24gbG9hZEltYWdlKHVybCkgewogICB9KTsKIH0KIAotZnVuY3Rpb24gY2hl Y2tQaXhlbChidWYsIHdpZHRoLCB4LCB5LCBjb2xvcikgewotICB2YXIgb2ZmID0gKHkgKiB3aWR0 aCArIHgpICogNDsKLSAgdmFyIG1zZyA9ICJwaXhlbCAiICsgeCArICIsICIgKyB5ICsgIiBzaG91 bGQgYmUgIiArCitmdW5jdGlvbiBjaGVja1BpeGVsKGJ1Ziwgd2lkdGgsIHgsIHksIGNvbG9yLCB0 b2xlcmFuY2UpIHsKKyAgZnVuY3Rpb24gbXNnRmFpbGVkKCkgeworICAgIHJldHVybiAicGl4ZWwg IiArIHggKyAiLCAiICsgeSArICIgc2hvdWxkIGJlICIgKwogICAgICAgICAgICAgY29sb3JbMF0g KyAiLCAiICsKICAgICAgICAgICAgIGNvbG9yWzFdICsgIiwgIiArCiAgICAgICAgICAgICBjb2xv clsyXSArICIsICIgKwpAQCAtMzAsMTQgKzMwLDIzIEBAIGZ1bmN0aW9uIGNoZWNrUGl4ZWwoYnVm LCB3aWR0aCwgeCwgeSwgY29sb3IpIHsKICAgICAgICAgICAgIGJ1ZltvZmYgKyAxXSArICIsICIg KwogICAgICAgICAgICAgYnVmW29mZiArIDJdICsgIiwgIiArCiAgICAgICAgICAgICBidWZbb2Zm ICsgM107Ci0KKyAgfQorICBmdW5jdGlvbiBtc2dQYXNzZWQoKSB7CisgICAgcmV0dXJuICJwaXhl bCAiICsgeCArICIsICIgKyB5ICsgIiB3YXMgIiArCisgICAgICAgICAgICBjb2xvclswXSArICIs ICIgKworICAgICAgICAgICAgY29sb3JbMV0gKyAiLCAiICsKKyAgICAgICAgICAgIGNvbG9yWzJd ICsgIiwgIiArCisgICAgICAgICAgICBjb2xvclszXTsKKyAgfQorICB2YXIgb2ZmID0gKHkgKiB3 aWR0aCArIHgpICogNDsKICAgZm9yICh2YXIgaWkgPSAwOyBpaSA8IDQ7ICsraWkpIHsKLSAgICBp ZiAoYnVmW29mZiArIGlpXSAhPSBjb2xvcltpaV0pIHsKLSAgICAgIHRlc3RGYWlsZWQobXNnKTsK KyAgICB2YXIgZGVsdGEgPSBNYXRoLmFicyhidWZbb2ZmICsgaWldIC0gY29sb3JbaWldKTsKKyAg ICBpZiAoZGVsdGEgPiB0b2xlcmFuY2UpIHsKKyAgICAgIHRlc3RGYWlsZWQobXNnRmFpbGVkKCkp OwogICAgICAgcmV0dXJuOwogICAgIH0KICAgfQotICB0ZXN0UGFzc2VkKG1zZyk7CisgIHRlc3RQ YXNzZWQobXNnUGFzc2VkKCkpOwogfQogCiBmdW5jdGlvbiBjaGVja1BpeGVsUmFuZ2UoYnVmLCB3 aWR0aCwgeCwgeSwgY29sb3IsIGFsbG93ZWRSYW5nZSkgewpAQCAtMTAyLDYgKzExMSw3IEBAIGFz eW5jIGZ1bmN0aW9uIHRlc3QoKSB7CiAgIHZhciBidWYgPSBuZXcgVWludDhBcnJheSh3aWR0aCAq IGhlaWdodCAqIDQpOwogICBnbC5yZWFkUGl4ZWxzKDAsIDAsIHdpZHRoLCBoZWlnaHQsIGdsLlJH QkEsIGdsLlVOU0lHTkVEX0JZVEUsIGJ1Zik7CiAKKyAgdmFyIHRvbGVyYW5jZSA9IDE7CiAgIHZh ciBsZWZ0ID0gMDsKICAgdmFyIG1pZGRsZSA9IE1hdGguZmxvb3Iod2lkdGggLyAyKTsKICAgdmFy IHJpZ2h0ID0gd2lkdGggLSAxOwpAQCAtMTEzLDcgKzEyMyw3IEBAIGFzeW5jIGZ1bmN0aW9uIHRl c3QoKSB7CiAgIGNoZWNrUGl4ZWwoYnVmLCB3aWR0aCwgcmlnaHQsICB0b3AsICAgIFsyNTUsICAg MCwgICAwLCAyNTVdKTsKICAgY2hlY2tQaXhlbChidWYsIHdpZHRoLCBsZWZ0LCAgIGNlbnRlciwg WzI1NSwgICAwLCAyNTUsIDI1NV0pOwogICBjaGVja1BpeGVsKGJ1Ziwgd2lkdGgsIG1pZGRsZSwg Y2VudGVyLCBbMjU1LCAgIDAsICAgMCwgMjU1XSk7Ci0gIGNoZWNrUGl4ZWwoYnVmLCB3aWR0aCwg cmlnaHQsICBjZW50ZXIsIFsgIDAsIDI1NSwgICAwLCAyNTVdKTsKKyAgY2hlY2tQaXhlbChidWYs IHdpZHRoLCByaWdodCwgIGNlbnRlciwgWyAgMCwgMjU1LCAgIDAsIDI1NV0sIHRvbGVyYW5jZSk7 CiAgIGNoZWNrUGl4ZWwoYnVmLCB3aWR0aCwgbGVmdCwgICBib3R0b20sIFsyNTUsICAgMCwgICAw LCAyNTVdKTsKICAgY2hlY2tQaXhlbChidWYsIHdpZHRoLCBtaWRkbGUsIGJvdHRvbSwgWzI1NSwg MjU1LCAgIDAsIDI1NV0pOwogICBjaGVja1BpeGVsKGJ1Ziwgd2lkdGgsIHJpZ2h0LCAgYm90dG9t LCBbMjU1LCAgIDAsICAgMCwgMjU1XSk7Cg==