22329 2008-11-17 22:33:36 -0800 Improper bitwise and tests against 0 in Windows context menu code 2008-11-18 11:50:07 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 sfalken sfalken oldest_to_newest 99136 0 sfalken 2008-11-17 22:33:36 -0800 Microsoft's PREfast static code analysis flagged: c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(106) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(190) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags 99138 1 25231 sfalken 2008-11-17 22:40:17 -0800 Created attachment 25231 Fix bitwise ands against 0 99195 2 sfalken 2008-11-18 11:50:07 -0800 Fixed in r38565 25231 2008-11-17 22:40:17 -0800 2008-11-18 06:07:15 -0800 Fix bitwise ands against 0 diff.txt text/plain 1562 sfalken SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4NTQ2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEt MTcgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzMjkKKyAgICAgICAgSW1wcm9w ZXIgYml0d2lzZSBhbmQgdGVzdHMgYWdhaW5zdCAwIGluIFdpbmRvd3MgY29udGV4dCBtZW51IGNv ZGUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL3dpbi9Db250ZXh0TWVudUl0ZW1XaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29u dGV4dE1lbnVJdGVtOjp0eXBlKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbTo6 ZW5hYmxlZCk6CisKIDIwMDgtMTEtMTcgIE5pa29sYXMgWmltbWVybWFubiAgPG5pa29sYXMuemlt bWVybWFubkB0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dl LgpJbmRleDogcGxhdGZvcm0vd2luL0NvbnRleHRNZW51SXRlbVdpbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gcGxhdGZvcm0vd2luL0NvbnRleHRNZW51SXRlbVdpbi5jcHAJKHJldmlzaW9uIDM4NTEzKQor KysgcGxhdGZvcm0vd2luL0NvbnRleHRNZW51SXRlbVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwMiw4ICsxMDIsNyBAQCBMUE1FTlVJVEVNSU5GTyBDb250ZXh0TWVudUl0ZW06OnJlbGVhc2VQ CiBDb250ZXh0TWVudUl0ZW1UeXBlIENvbnRleHRNZW51SXRlbTo6dHlwZSgpIGNvbnN0CiB7CiAg ICAgQ29udGV4dE1lbnVJdGVtVHlwZSB0eXBlID0gQWN0aW9uVHlwZTsKLQotICAgIGlmICgobV9w bGF0Zm9ybURlc2NyaXB0aW9uLT5mVHlwZSAmIE1GVF9TVFJJTkcpICYmIG1fcGxhdGZvcm1EZXNj cmlwdGlvbi0+aFN1Yk1lbnUpCisgICAgaWYgKCgobV9wbGF0Zm9ybURlc2NyaXB0aW9uLT5mVHlw ZSAmIH5NRlRfT1dORVJEUkFXKSA9PSBNRlRfU1RSSU5HKSAmJiBtX3BsYXRmb3JtRGVzY3JpcHRp b24tPmhTdWJNZW51KQogICAgICAgICB0eXBlID0gU3VibWVudVR5cGU7CiAgICAgZWxzZSBpZiAo bV9wbGF0Zm9ybURlc2NyaXB0aW9uLT5mVHlwZSAmIE1GVF9TRVBBUkFUT1IpCiAgICAgICAgIHR5 cGUgPSBTZXBhcmF0b3JUeXBlOwpAQCAtMTg3LDcgKzE4Niw3IEBAIHZvaWQgQ29udGV4dE1lbnVJ dGVtOjpzZXRFbmFibGVkKGJvb2wgZW4KIAogYm9vbCBDb250ZXh0TWVudUl0ZW06OmVuYWJsZWQo KSBjb25zdAogewotICAgIHJldHVybiBtX3BsYXRmb3JtRGVzY3JpcHRpb24tPmZTdGF0ZSAmIE1G U19FTkFCTEVEOworICAgIHJldHVybiAhKG1fcGxhdGZvcm1EZXNjcmlwdGlvbi0+ZlN0YXRlICYg TUZTX0RJU0FCTEVEKTsKIH0KIAogfQo=