<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>223283</bug_id>
          
          <creation_ts>2021-03-16 14:53:56 -0700</creation_ts>
          <short_desc>REGRESSION (r274461): [macOS wk1] fast/repaint/canvas-object-fit.html is flakey text failing</short_desc>
          <delta_ts>2023-03-21 11:52:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>254200</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=254200</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robert Jenner">jenner</reporter>
          <assigned_to name="Simon Fraser (smfr)">simon.fraser</assigned_to>
          <cc>hhjalmarsson</cc>
    
    <cc>rniwa</cc>
    
    <cc>sabouhallawa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>tsavell</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1740225</commentid>
    <comment_count>0</comment_count>
    <who name="Robert Jenner">jenner</who>
    <bug_when>2021-03-16 14:53:56 -0700</bug_when>
    <thetext>fast/repaint/canvas-object-fit.html

is a flakey text failure in macOS Catalina and BigSur in release and debug on Intel and Apple Silicon only in wk1. 


HISTORY URL:
https://results.webkit.org/?suite=layout-tests&amp;test=fast%2Frepaint%2Fcanvas-object-fit.html&amp;platform=mac

TEXT DIFF:
@@ -10,9 +10,6 @@
           (position 8.00 8.00)
           (bounds 202.00 102.00)
           (drawsContent 1)
-          (repaint rects
-            (rect 70.00 20.00 7.00 7.00)
-          )
         )
       )
     )

It is a flakey text failure, but the failures to appear to happen more often than not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740226</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-16 14:54:25 -0700</bug_when>
    <thetext>&lt;rdar://problem/75495803&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740238</commentid>
    <comment_count>2</comment_count>
    <who name="Robert Jenner">jenner</who>
    <bug_when>2021-03-16 15:08:57 -0700</bug_when>
    <thetext>Was able to reproduce and bisect to a regression point.


I reproduced the failure using the following test:
run-webkit-test fast/repaint/canvas-object-fit.html --iterations 100 -f -1

The test produced the text failure at ToT, and 274461. Failures did not occur at 274460. 

Changes in 274460 do appear to be related to the test that is failing. 
https://trac.webkit.org/changeset/274461/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740269</commentid>
    <comment_count>3</comment_count>
    <who name="Robert Jenner">jenner</who>
    <bug_when>2021-03-16 15:45:08 -0700</bug_when>
    <thetext>Updated test expectations for this test in wk1 to Pass Failure while test is being reviewed: 
https://trac.webkit.org/changeset/274525/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740301</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-03-16 16:25:45 -0700</bug_when>
    <thetext>Bad:

16:23:02.570 41683   Page::updateRendering
16:23:02.570 41683   CanvasRenderingContext2DBase::didDraw
16:23:02.570 41683   HTMLCanvasElement::didDraw - 0.0,0.0 200.0x200.0
16:23:02.570 41683   CanvasRenderingContext2DBase::didDraw
16:23:02.570 41683   HTMLCanvasElement::didDraw - null rect
16:23:02.570 41683   Page::updateRendering
16:23:02.570 41683   HTMLCanvasElement 0x160430108 paint
16:23:02.570 41683   Page::updateRendering

Good:

16:23:02.499 41683   CanvasRenderingContext2DBase::didDraw
16:23:02.499 41683   HTMLCanvasElement::didDraw - 0.0,0.0 200.0x200.0
16:23:02.499 41683   HTMLCanvasElement 0x1609f2850 paint
16:23:02.499 41683   CanvasRenderingContext2DBase::didDraw
16:23:02.499 41683   HTMLCanvasElement::didDraw - 40.0,40.0 10.0x10.0
16:23:02.499 41683   Page::updateRendering
16:23:02.499 41683   HTMLCanvasElement 0x1609f2850 paint
16:23:02.499 41683   Page::updateRendering

Note the &quot;HTMLCanvasElement 0x1609f2850 paint&quot; is missing in the bad case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740304</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-03-16 16:37:58 -0700</bug_when>
    <thetext>Bad:
16:36:19.749 46316   WebViewLayerFlushScheduler::schedule()
16:36:19.749 46316   WebViewLayerFlushScheduler::layerFlushCallback()
16:36:19.749 46316   LayerFlushController::flushLayers()
16:36:19.749 46316   WebView 0x7f800b40bec0 _updateRendering
16:36:19.750 46316   Page::updateRendering
16:36:19.750 46316   CanvasRenderingContext2DBase::didDraw
16:36:19.750 46316   HTMLCanvasElement::didDraw - 0.0,0.0 200.0x200.0
16:36:19.750 46316   CanvasRenderingContext2DBase::didDraw
16:36:19.750 46316   HTMLCanvasElement::didDraw - null rect
16:36:19.750 46316   WebViewLayerFlushScheduler::schedule()
16:36:19.750 46316   _forceRepaintForTesting
16:36:19.750 46316   WebView 0x7f800b40bec0 _updateRendering
16:36:19.750 46316   Page::updateRendering
16:36:19.750 46316   _forceRepaintForTesting - flushing
16:36:19.750 46316   WebSimpleLayer display
16:36:19.750 46316   HTMLCanvasElement 0x15df38210 paint
16:36:19.750 46316   WebViewLayerFlushScheduler::layerFlushCallback()
16:36:19.750 46316   LayerFlushController::flushLayers()
16:36:19.750 46316   WebView 0x7f800b40bec0 _updateRendering
16:36:19.750 46316   Page::updateRendering

Good:
16:36:19.675 46316   WebViewLayerFlushScheduler::schedule()
16:36:19.675 46316   CanvasRenderingContext2DBase::didDraw
16:36:19.675 46316   HTMLCanvasElement::didDraw - 0.0,0.0 200.0x200.0
16:36:19.675 46316   WebSimpleLayer display
16:36:19.675 46316   HTMLCanvasElement 0x15df38108 paint
16:36:19.675 46316   WebViewLayerFlushScheduler::schedule()
16:36:19.675 46316   CanvasRenderingContext2DBase::didDraw
16:36:19.675 46316   HTMLCanvasElement::didDraw - 40.0,40.0 10.0x10.0
16:36:19.675 46316   WebViewLayerFlushScheduler::schedule()
16:36:19.675 46316   _forceRepaintForTesting
16:36:19.675 46316   WebView 0x7f800b40bec0 _updateRendering
16:36:19.675 46316   Page::updateRendering
16:36:19.675 46316   _forceRepaintForTesting - flushing
16:36:19.675 46316   WebSimpleLayer display
16:36:19.675 46316   HTMLCanvasElement 0x15df38108 paint
16:36:19.675 46316   WebViewLayerFlushScheduler::layerFlushCallback()
16:36:19.675 46316   LayerFlushController::flushLayers()
16:36:19.675 46316   WebView 0x7f800b40bec0 _updateRendering
16:36:19.675 46316   Page::updateRendering</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740307</commentid>
    <comment_count>6</comment_count>
      <attachid>423413</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-03-16 16:49:28 -0700</bug_when>
    <thetext>Created attachment 423413
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1740310</commentid>
    <comment_count>7</comment_count>
      <attachid>423416</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-03-16 16:54:43 -0700</bug_when>
    <thetext>Created attachment 423416
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1751996</commentid>
    <comment_count>8</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2021-04-19 15:03:24 -0700</bug_when>
    <thetext>Is this good to land?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1752001</commentid>
    <comment_count>9</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-19 15:11:10 -0700</bug_when>
    <thetext>Tools/Scripts/svn-apply failed to apply attachment 423416 to trunk.
Please resolve the conflicts and upload a new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1756314</commentid>
    <comment_count>10</comment_count>
      <attachid>427600</attachid>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2021-05-03 13:51:22 -0700</bug_when>
    <thetext>Created attachment 427600
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1756320</commentid>
    <comment_count>11</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-03 14:22:06 -0700</bug_when>
    <thetext>Committed r276924 (237266@main): &lt;https://commits.webkit.org/237266@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427600.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1756671</commentid>
    <comment_count>12</comment_count>
    <who name="Truitt Savell">tsavell</who>
    <bug_when>2021-05-04 14:16:43 -0700</bug_when>
    <thetext>This change https://trac.webkit.org/changeset/276924/webkit

unfortunately did not fix this test. History still shows flaky failures and the same diff.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1770243</commentid>
    <comment_count>13</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2021-06-16 10:17:07 -0700</bug_when>
    <thetext>Marked test as flaky again in https://trac.webkit.org/changeset/278938/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1784568</commentid>
    <comment_count>14</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-08-16 10:04:38 -0700</bug_when>
    <thetext>Reproduced with run-webkit-tests -1 --iterations=300 --force fast/repaint/canvas-object-fit.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1906612</commentid>
    <comment_count>15</comment_count>
    <who name="Hercules Hjalmarsson">hhjalmarsson</who>
    <bug_when>2022-10-18 14:56:46 -0700</bug_when>
    <thetext>*** Bug 246653 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1906618</commentid>
    <comment_count>16</comment_count>
    <who name="Hercules Hjalmarsson">hhjalmarsson</who>
    <bug_when>2022-10-18 15:03:44 -0700</bug_when>
    <thetext>*** Bug 245902 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1942890</commentid>
    <comment_count>17</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2023-03-21 11:52:52 -0700</bug_when>
    <thetext>This should be fixed by the fix of bug 254200.

*** This bug has been marked as a duplicate of bug 254200 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>423413</attachid>
            <date>2021-03-16 16:49:28 -0700</date>
            <delta_ts>2021-03-16 16:54:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223283-20210316164927.patch</filename>
            <type>text/plain</type>
            <size>2455</size>
            <attacher name="Simon Fraser (smfr)">simon.fraser</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NTI0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmM5NTVkMmMzZDM0MDdiZmNhZDgw
N2YyM2ZmOTQ1ZmM1MjE2MTZlMy4uOTFlOTQyZGYxNjRlNTE0ZDc1MTI3NjEyMjExMjU5NGEyY2Fh
MWJiZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTE2ICBTaW1vbiBGcmFzZXIgIDxz
aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNzQ0NjEpOiBb
bWFjT1Mgd2sxXSBmYXN0L3JlcGFpbnQvY2FudmFzLW9iamVjdC1maXQuaHRtbCBpcyBmbGFrZXkg
dGV4dCBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMjMyODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg
ICAgCisgICAgICAgIFdLMSByZXBhaW50IHRlc3RzIGFyZSBzZW5zaXRpdmUgdG8gdGhlIHRpbWlu
ZyBvZiBwYWludHMsIHdoaWNoIGFyZSBjb250cm9sbGVkIGJ5IAorICAgICAgICBXZWJWaWV3TGF5
ZXJGbHVzaFNjaGVkdWxlciBsYXllckZsdXNoQ2FsbGJhY2soKSB0aW1pbmcsIHdoaWNoIGluIHR1
cm4gaXMgYWZmZWN0ZWQgYnkgdGhlCisgICAgICAgIHN0YXRlIG9mIC1bTlNXaW5kb3cgYXV0b2Rp
c3BsYXldLCB3aGljaCBEdW1wUmVuZGVyVHJlZSBzZXRzIHRvIE5PLCBidXQgd2UgZmxpcCB0byBZ
RVMKKyAgICAgICAgd2hlbiB3ZSBzZWUgY29tcG9zaXRlZCBsYXllcnMgKHdoaWNoIGNhbnZhcyB0
cmlnZ2VycykuCisgICAgICAgIAorICAgICAgICBUbyBhdm9pZCB0aGlzIGZyYWdpbGUgbWVzcywg
aGF2ZSB0aGUgdGVzdCB0cmlnZ2VyIGNvbXBvc2l0aW5nIGVhcmx5IG9uIGJ5IG1ha2luZyB0aGUg
MkQKKyAgICAgICAgY2FudmFzIGNvbnRleHQsIHRoZW4gd2FpdCBmb3IgYSBmcmFtZSBiZWZvcmUg
dGhlIHJlcGFpbnQgcGFydCBvZiB0aGUgdGVzdC4KKworICAgICAgICAqIGZhc3QvcmVwYWludC9j
YW52YXMtb2JqZWN0LWZpdC5odG1sOgorCiAyMDIxLTAzLTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1v
bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtCaWdTdXIgYXJtNjRdIGNvbXBvc2l0aW5n
L3otb3JkZXIvcmVidWlsZC1zaWJsaW5nLW9mLWxheWVyLXdpdGgtZm9yZWdyb3VuZC1sYXllci5o
dG1sIGlzIGEgZmxha2V5IGltYWdlIGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh
c3QvcmVwYWludC9jYW52YXMtb2JqZWN0LWZpdC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBh
aW50L2NhbnZhcy1vYmplY3QtZml0Lmh0bWwKaW5kZXggMWQwZjE2Y2UxYzA2MDllNDQxYWNiMmJm
Mzg0MGVlM2VmNmU2ZWU1OS4uNGJhOGI0Yjk2NTk0Y2ZmOTQ0MDU0MmRlNTBmYjJkNzU1MWRjZjRj
ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L2NhbnZhcy1vYmplY3QtZml0
Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L2NhbnZhcy1vYmplY3QtZml0Lmh0
bWwKQEAgLTE3LDExICsxNyw3IEBACiAgICAgICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERv
bmUoKTsKICAgICAgICAgfQogICAgICAgICAgICAgCi0gICAgICAgIHZhciBjYW52YXMgPSBkb2N1
bWVudC5nZXRFbGVtZW50QnlJZCgnY2FudmFzJyk7Ci0gICAgICAgIHZhciBjdHggPSBjYW52YXMu
Z2V0Q29udGV4dCgnMmQnKTsKLQotICAgICAgICBjdHguZmlsbFN0eWxlID0gInJnYigwLCAxMjgs
IDApIjsKLSAgICAgICAgY3R4LmZpbGxSZWN0KDAsIDAsIDIwMCwgMjAwKTsKKyAgICAgICAgdmFy
IGN0eDsKICAgICAgICAgCiAgICAgICAgIGZ1bmN0aW9uIHJlcGFpbnRUZXN0KCkKICAgICAgICAg
ewpAQCAtNDAsOSArMzYsMTUgQEAKICAgICAgICAgCiAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0VGVz
dCgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAg
ICAgICAgICB2YXIgY2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NhbnZhcycpOwor
ICAgICAgICAgICAgY3R4ID0gY2FudmFzLmdldENvbnRleHQoJzJkJyk7CisKKyAgICAgICAgICAg
IGN0eC5maWxsU3R5bGUgPSAicmdiKDAsIDEyOCwgMCkiOworICAgICAgICAgICAgY3R4LmZpbGxS
ZWN0KDAsIDAsIDIwMCwgMjAwKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgcmVxdWVzdEFu
aW1hdGlvbkZyYW1lKCgpID0+IHsKICAgICAgICAgICAgICAgICByZXBhaW50VGVzdCgpOwotICAg
ICAgICAgICAgfSwgMCkKKyAgICAgICAgICAgIH0pOwogICAgICAgICB9CiAgICAgICAgIHdpbmRv
dy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgc3RhcnRUZXN0LCBmYWxzZSk7CiAgICAgPC9zY3Jp
cHQ+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>423416</attachid>
            <date>2021-03-16 16:54:43 -0700</date>
            <delta_ts>2021-05-03 13:51:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-223283-20210316165443.patch</filename>
            <type>text/plain</type>
            <size>3246</size>
            <attacher name="Simon Fraser (smfr)">simon.fraser</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NTMyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzVkZjY2ODQ4YjQ5MTY3MjhiMGVj
ZmZiMTM1ODY4MTYzNjVlMzkxMi4uNjhkODk2NmI5NjlhZGU4MDY1MDg0NjdiNGJmNTdhODEzY2Qw
MmVhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAzLTE2ICBTaW1vbiBGcmFzZXIgIDxz
aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNzQ0NjEpOiBb
bWFjT1Mgd2sxXSBmYXN0L3JlcGFpbnQvY2FudmFzLW9iamVjdC1maXQuaHRtbCBpcyBmbGFrZXkg
dGV4dCBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMjMyODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg
ICAgCisgICAgICAgIFdLMSByZXBhaW50IHRlc3RzIGFyZSBzZW5zaXRpdmUgdG8gdGhlIHRpbWlu
ZyBvZiBwYWludHMsIHdoaWNoIGFyZSBjb250cm9sbGVkIGJ5IAorICAgICAgICBXZWJWaWV3TGF5
ZXJGbHVzaFNjaGVkdWxlciBsYXllckZsdXNoQ2FsbGJhY2soKSB0aW1pbmcsIHdoaWNoIGluIHR1
cm4gaXMgYWZmZWN0ZWQgYnkgdGhlCisgICAgICAgIHN0YXRlIG9mIC1bTlNXaW5kb3cgYXV0b2Rp
c3BsYXldLCB3aGljaCBEdW1wUmVuZGVyVHJlZSBzZXRzIHRvIE5PLCBidXQgd2UgZmxpcCB0byBZ
RVMKKyAgICAgICAgd2hlbiB3ZSBzZWUgY29tcG9zaXRlZCBsYXllcnMgKHdoaWNoIGNhbnZhcyB0
cmlnZ2VycykuCisgICAgICAgIAorICAgICAgICBUbyBhdm9pZCB0aGlzIGZyYWdpbGUgbWVzcywg
aGF2ZSB0aGUgdGVzdCB0cmlnZ2VyIGNvbXBvc2l0aW5nIGVhcmx5IG9uIGJ5IG1ha2luZyB0aGUg
MkQKKyAgICAgICAgY2FudmFzIGNvbnRleHQsIHRoZW4gd2FpdCBmb3IgYSBmcmFtZSBiZWZvcmUg
dGhlIHJlcGFpbnQgcGFydCBvZiB0aGUgdGVzdC4KKworICAgICAgICAqIGZhc3QvcmVwYWludC9j
YW52YXMtb2JqZWN0LWZpdC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azEvVGVzdEV4
cGVjdGF0aW9uczoKKwogMjAyMS0wMy0xNSAgRWJyYWhpbSBCeWFnb3dpIDxlYnJhaGltQGdudS5v
cmc+IGFuZCBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAg
ICAgPGltZz4gaXNuJ3QgYWJsZSB0byByZW5kZXIgUlRMIHRleHQgY29ycmVjdGx5IGluIEFMVCB0
ZXh0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvY2FudmFzLW9iamVjdC1m
aXQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9jYW52YXMtb2JqZWN0LWZpdC5odG1s
CmluZGV4IDFkMGYxNmNlMWMwNjA5ZTQ0MWFjYjJiZjM4NDBlZTNlZjZlNmVlNTkuLjRiYThiNGI5
NjU5NGNmZjk0NDA1NDJkZTUwZmIyZDc1NTFkY2Y0Y2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz
L2Zhc3QvcmVwYWludC9jYW52YXMtb2JqZWN0LWZpdC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zh
c3QvcmVwYWludC9jYW52YXMtb2JqZWN0LWZpdC5odG1sCkBAIC0xNywxMSArMTcsNyBAQAogICAg
ICAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CiAgICAgICAgIH0KICAgICAgICAg
ICAgIAotICAgICAgICB2YXIgY2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NhbnZh
cycpOwotICAgICAgICB2YXIgY3R4ID0gY2FudmFzLmdldENvbnRleHQoJzJkJyk7Ci0KLSAgICAg
ICAgY3R4LmZpbGxTdHlsZSA9ICJyZ2IoMCwgMTI4LCAwKSI7Ci0gICAgICAgIGN0eC5maWxsUmVj
dCgwLCAwLCAyMDAsIDIwMCk7CisgICAgICAgIHZhciBjdHg7CiAgICAgICAgIAogICAgICAgICBm
dW5jdGlvbiByZXBhaW50VGVzdCgpCiAgICAgICAgIHsKQEAgLTQwLDkgKzM2LDE1IEBACiAgICAg
ICAgIAogICAgICAgICBmdW5jdGlvbiBzdGFydFRlc3QoKQogICAgICAgICB7Ci0gICAgICAgICAg
ICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgdmFyIGNhbnZhcyA9IGRvY3Vt
ZW50LmdldEVsZW1lbnRCeUlkKCdjYW52YXMnKTsKKyAgICAgICAgICAgIGN0eCA9IGNhbnZhcy5n
ZXRDb250ZXh0KCcyZCcpOworCisgICAgICAgICAgICBjdHguZmlsbFN0eWxlID0gInJnYigwLCAx
MjgsIDApIjsKKyAgICAgICAgICAgIGN0eC5maWxsUmVjdCgwLCAwLCAyMDAsIDIwMCk7CisgICAg
ICAgICAgICAKKyAgICAgICAgICAgIHJlcXVlc3RBbmltYXRpb25GcmFtZSgoKSA9PiB7CiAgICAg
ICAgICAgICAgICAgcmVwYWludFRlc3QoKTsKLSAgICAgICAgICAgIH0sIDApCisgICAgICAgICAg
ICB9KTsKICAgICAgICAgfQogICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcs
IHN0YXJ0VGVzdCwgZmFsc2UpOwogICAgIDwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz
dHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGM2MDg5MDBhZWY1YTY1ZDgzMWNhOGMy
NTU3OWRiYTVjMTE2NTY2N2EuLjMwMDg3Y2U2NjZjOTdjOThlNGY4MzBmNWY1ZTkxYmEyMjI3OGJm
NDUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0
aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMK
QEAgLTEyNjcsNSArMTI2NywzIEBAIHdlYmtpdC5vcmcvYi8yMjMxOTMgaW1wb3J0ZWQvdzNjL2Nh
bnZhcy8yZC5wYXRoLnN0cm9rZS5zY2FsZTIuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9i
LzIyMzE5MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL2VsZW1l
bnQvcGF0aC1vYmplY3RzLzJkLnBhdGguc3Ryb2tlLnNjYWxlMi5odG1sIFsgRmFpbHVyZSBdCiAK
IHdlYmtpdC5vcmcvYi8yMjMyNzEgWyBCaWdTdXIgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBs
YXRmb3JtLXRlc3RzL3hoci9zZW5kLXJlc3BvbnNlLWV2ZW50LW9yZGVyLmh0bSBbIFBhc3MgRmFp
bHVyZSBdCi0KLXdlYmtpdC5vcmcvYi8yMjMyODMgZmFzdC9yZXBhaW50L2NhbnZhcy1vYmplY3Qt
Zml0Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427600</attachid>
            <date>2021-05-03 13:51:22 -0700</date>
            <delta_ts>2021-05-03 14:22:08 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-223283-20210503135122.patch</filename>
            <type>text/plain</type>
            <size>3305</size>
            <attacher name="Ryan Haddad">ryanhaddad</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2OTIyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2Y3M2Y3NTkxY2QzNmEwZTAyOTBm
ZjI4OTFkZDliZjZmYmU3ZDQwMC4uOWVjMzY3NDA3YjIzYWRjNzFkZDdiM2QxMzk2ZmE1YTI0YWUz
OWVhNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA1LTAzICBTaW1vbiBGcmFzZXIgIDxz
aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNzQ0NjEpOiBb
bWFjT1Mgd2sxXSBmYXN0L3JlcGFpbnQvY2FudmFzLW9iamVjdC1maXQuaHRtbCBpcyBmbGFrZXkg
dGV4dCBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMjMyODMKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisgICAgICAg
IAorICAgICAgICBXSzEgcmVwYWludCB0ZXN0cyBhcmUgc2Vuc2l0aXZlIHRvIHRoZSB0aW1pbmcg
b2YgcGFpbnRzLCB3aGljaCBhcmUgY29udHJvbGxlZCBieSAKKyAgICAgICAgV2ViVmlld0xheWVy
Rmx1c2hTY2hlZHVsZXIgbGF5ZXJGbHVzaENhbGxiYWNrKCkgdGltaW5nLCB3aGljaCBpbiB0dXJu
IGlzIGFmZmVjdGVkIGJ5IHRoZQorICAgICAgICBzdGF0ZSBvZiAtW05TV2luZG93IGF1dG9kaXNw
bGF5XSwgd2hpY2ggRHVtcFJlbmRlclRyZWUgc2V0cyB0byBOTywgYnV0IHdlIGZsaXAgdG8gWUVT
CisgICAgICAgIHdoZW4gd2Ugc2VlIGNvbXBvc2l0ZWQgbGF5ZXJzICh3aGljaCBjYW52YXMgdHJp
Z2dlcnMpLgorICAgICAgICAKKyAgICAgICAgVG8gYXZvaWQgdGhpcyBmcmFnaWxlIG1lc3MsIGhh
dmUgdGhlIHRlc3QgdHJpZ2dlciBjb21wb3NpdGluZyBlYXJseSBvbiBieSBtYWtpbmcgdGhlIDJE
CisgICAgICAgIGNhbnZhcyBjb250ZXh0LCB0aGVuIHdhaXQgZm9yIGEgZnJhbWUgYmVmb3JlIHRo
ZSByZXBhaW50IHBhcnQgb2YgdGhlIHRlc3QuCisKKyAgICAgICAgKiBmYXN0L3JlcGFpbnQvY2Fu
dmFzLW9iamVjdC1maXQuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBl
Y3RhdGlvbnM6CisKIDIwMjEtMDUtMDMgIFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNv
bT4KIAogICAgICAgICBbIEJpZyBTdXIgXSB3ZWJydGMvdmlkZW8tdnA4LXZpZGVvcmFuZ2UuaHRt
bCBpcyBmYWxpbmcgb24gbWFjbWluaTgsMQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9y
ZXBhaW50L2NhbnZhcy1vYmplY3QtZml0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQv
Y2FudmFzLW9iamVjdC1maXQuaHRtbAppbmRleCAxZDBmMTZjZTFjMDYwOWU0NDFhY2IyYmYzODQw
ZWUzZWY2ZTZlZTU5Li40YmE4YjRiOTY1OTRjZmY5NDQwNTQyZGU1MGZiMmQ3NTUxZGNmNGNmIDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvY2FudmFzLW9iamVjdC1maXQuaHRt
bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvY2FudmFzLW9iamVjdC1maXQuaHRtbApA
QCAtMTcsMTEgKzE3LDcgQEAKICAgICAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgp
OwogICAgICAgICB9CiAgICAgICAgICAgICAKLSAgICAgICAgdmFyIGNhbnZhcyA9IGRvY3VtZW50
LmdldEVsZW1lbnRCeUlkKCdjYW52YXMnKTsKLSAgICAgICAgdmFyIGN0eCA9IGNhbnZhcy5nZXRD
b250ZXh0KCcyZCcpOwotCi0gICAgICAgIGN0eC5maWxsU3R5bGUgPSAicmdiKDAsIDEyOCwgMCki
OwotICAgICAgICBjdHguZmlsbFJlY3QoMCwgMCwgMjAwLCAyMDApOworICAgICAgICB2YXIgY3R4
OwogICAgICAgICAKICAgICAgICAgZnVuY3Rpb24gcmVwYWludFRlc3QoKQogICAgICAgICB7CkBA
IC00MCw5ICszNiwxNSBAQAogICAgICAgICAKICAgICAgICAgZnVuY3Rpb24gc3RhcnRUZXN0KCkK
ICAgICAgICAgewotICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAg
ICAgIHZhciBjYW52YXMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY2FudmFzJyk7CisgICAg
ICAgICAgICBjdHggPSBjYW52YXMuZ2V0Q29udGV4dCgnMmQnKTsKKworICAgICAgICAgICAgY3R4
LmZpbGxTdHlsZSA9ICJyZ2IoMCwgMTI4LCAwKSI7CisgICAgICAgICAgICBjdHguZmlsbFJlY3Qo
MCwgMCwgMjAwLCAyMDApOworICAgICAgICAgICAgCisgICAgICAgICAgICByZXF1ZXN0QW5pbWF0
aW9uRnJhbWUoKCkgPT4gewogICAgICAgICAgICAgICAgIHJlcGFpbnRUZXN0KCk7Ci0gICAgICAg
ICAgICB9LCAwKQorICAgICAgICAgICAgfSk7CiAgICAgICAgIH0KICAgICAgICAgd2luZG93LmFk
ZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBzdGFydFRlc3QsIGZhbHNlKTsKICAgICA8L3NjcmlwdD4K
ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9u
cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA0
ZGYyZDYwOWEwNWVlNTk0ZWM1ZjJhNzBjM2RmYTEwMjRkNjFhNThhLi45YjZjN2YyNDI0ZmJlMWQw
ODY0ZDRlMWVlYmI3OGRlNDFiMDUyODg4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y
bS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj
LXdrMS9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMjM3LDggKzEyMzcsNiBAQCB3ZWJraXQub3JnL2Iv
MjIzMTkzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvZWxlbWVu
dC9wYXRoLW9iagogCiB3ZWJraXQub3JnL2IvMjIzMjcxIFsgQmlnU3VyIERlYnVnIF0gaW1wb3J0
ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvc2VuZC1yZXNwb25zZS1ldmVudC1vcmRlci5o
dG0gWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMjIzMjgzIGZhc3QvcmVwYWludC9j
YW52YXMtb2JqZWN0LWZpdC5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzIy
MjU2MyBodHRwL3Rlc3RzL2xvYWRpbmcvYmFzaWMtYXV0aC1sb2FkLVVSTC13aXRoLWNvbnNlY3V0
aXZlLXNsYXNoZXMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8yMjI2ODYg
aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1kZWZpbml0
aW9uL2dyaWQtYXV0by1yZXBlYXQtbWF4LXNpemUtMDAxLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>