223275 2021-03-16 12:58:42 -0700 [Swift] Ambiguous use of 'closeAllMediaPresentations' 2021-03-16 14:18:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney achristensen james.savage thorton webkit-bug-importer oldest_to_newest 1740137 0 katherine_cheney 2021-03-16 12:58:42 -0700 [Swift] Ambiguous use of 'closeAllMediaPresentations' 1740138 1 423384 katherine_cheney 2021-03-16 12:59:11 -0700 Created attachment 423384 Patch 1740139 2 katherine_cheney 2021-03-16 12:59:14 -0700 <rdar://problem/75447989> 1740149 3 423384 james.savage 2021-03-16 13:06:22 -0700 Comment on attachment 423384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423384&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:3342 > +#ifndef __swift__ I'd drop this from the implementation. It will never be the case that __swift__ is defined for this compilation unit, so it just adds confusion about whether this bit of code is actually conditional or not. The issue here is just about how the interface is perceived by the Swift compiler, so all that's need are the changes in the header. 1740152 4 423389 katherine_cheney 2021-03-16 13:10:18 -0700 Created attachment 423389 Patch 1740191 5 ews-feeder 2021-03-16 14:17:58 -0700 Committed r274516: <https://commits.webkit.org/r274516> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423389. 423384 2021-03-16 12:59:11 -0700 2021-03-16 13:10:16 -0700 Patch bug-223275-20210316125910.patch text/plain 3738 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNhNTVmMGNmMDgwZmE1NTY0 ZmQ5M2FkMjhmMzRjZTRhMjYxZDgxZGIuLjU2ZGE4YjNlMzI3ODQyNzIwNGE4MDc1ZTEzMDg4ZDYz OWZhODQ2YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDMtMTYgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgW1N3aWZ0XSBBbWJp Z3VvdXMgdXNlIG9mICdjbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9ucycKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzI3NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNzU0NDc5ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2UgYWRkZWQgYmFjayBkZXByZWNhdGVkIG1lZGlhIHBsYXliYWNrIGNvbnRy b2wgQVBJcyBpbgorICAgICAgICBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjcz MTg2L3dlYmtpdCBhZnRlciBhIG5hbWUgY2hhbmdlCisgICAgICAgIHRvIHN1cHBvcnQgZWFybHkg YWRvcHRvcnMuIEltcG9ydGluZyB0aGVzZSBtZXRob2RzIHRvIFN3aWZ0IGNhdXNlcworICAgICAg ICBhIG1ldGhvZCByZWRlZmluaXRpb24gZXJyb3IgYmVjYXVzZSB0aGUgY29tcGxldGlvbiBoYW5k bGVyIGluIGJvdGgKKyAgICAgICAgY2FzZXMgaXMgbnVsbGFibGUuIFdlIHNob3VsZCBpZ25vcmUg dGhlIGRlcHJlY2F0ZWQgQVBJcyBmb3IgU3dpZnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tOgorCiAyMDIxLTAzLTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVGVybWluYXRlIG5ldHdvcmsgcHJvY2VzcyB3aGVuIG1ha2lu ZyBuZXcgV2ViUHJvY2Vzc1Bvb2wgaW4gTHV0cm9uIEFwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5oIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5oCmluZGV4IGNkYWIzZGU2Zjg4YzI4MDNjY2IxMmIz YWRkMTU3MGRjNDM2MDA5ZWUuLjExNjZjNGY3ZWQ1MjUzOWM1YzQ4MDEyYTdlZDA1OTlkNDI1YjRj Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3LmgK QEAgLTUzMiwxMiArNTMyLDEzIEBAIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTUuNCkpCiAK IEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSwgY29weSkgTlNBcnJheSAqY2VydGlmaWNh dGVDaGFpbiBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJzZXJ2ZXJUcnVzdCIs IG1hY29zKDEwLjExLCAxMC4xMiksIGlvcyg5LjAsIDEwLjApKTsKIAorI2lmbmRlZiBfX3N3aWZ0 X18KIC0gKHZvaWQpcGF1c2VBbGxNZWRpYVBsYXliYWNrOih2b2lkICheX051bGxhYmxlKSh2b2lk KSljb21wbGV0aW9uSGFuZGxlciBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJw YXVzZUFsbE1lZGlhUGxheWJhY2tXaXRoQ29tcGxldGlvbkhhbmRsZXIiLCBtYWNvcyhXS19NQUNf VEJBLCBXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEsIFdLX0lPU19UQkEpKTsKIC0gKHZvaWQp c3VzcGVuZEFsbE1lZGlhUGxheWJhY2s6KHZvaWQgKF5fTnVsbGFibGUpKHZvaWQpKWNvbXBsZXRp b25IYW5kbGVyIFdLX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQoInNldEFsbE1lZGlh UGxheWJhY2tTdXNwZW5kZWQ6c3VzcGVuZGVkIiwgbWFjb3MoV0tfTUFDX1RCQSwgV0tfTUFDX1RC QSksIGlvcyhXS19JT1NfVEJBLCBXS19JT1NfVEJBKSk7CiAtICh2b2lkKXJlc3VtZUFsbE1lZGlh UGxheWJhY2s6KHZvaWQgKF4gX051bGxhYmxlKSh2b2lkKSljb21wbGV0aW9uSGFuZGxlciBXS19B UElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJzZXRBbGxNZWRpYVBsYXliYWNrU3VzcGVu ZGVkOnN1c3BlbmRlZCIsIG1hY29zKFdLX01BQ19UQkEsIFdLX01BQ19UQkEpLCBpb3MoV0tfSU9T X1RCQSwgV0tfSU9TX1RCQSkpOwogLSAodm9pZCljbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9uczoo dm9pZCAoXl9OdWxsYWJsZSkodm9pZCkpY29tcGxldGlvbkhhbmRsZXIgV0tfQVBJX0RFUFJFQ0FU RURfV0lUSF9SRVBMQUNFTUVOVCgiY2xvc2VBbGxNZWRpYVByZXNlbnRhdGlvbnNXaXRoQ29tcGxl dGlvbkhhbmRsZXIiLCBtYWNvcyhXS19NQUNfVEJBLCBXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19U QkEsIFdLX0lPU19UQkEpKTsKIC0gKHZvaWQpcmVxdWVzdE1lZGlhUGxheWJhY2tTdGF0ZToodm9p ZCAoXikoV0tNZWRpYVBsYXliYWNrU3RhdGUpKWNvbXBsZXRpb25IYW5kbGVyIFdLX0FQSV9ERVBS RUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQoInJlcXVlc3RNZWRpYVBsYXliYWNrU3RhdGVXaXRoQ29t cGxldGlvbkhhbmRsZXIiLCBtYWNvcyhXS19NQUNfVEJBLCBXS19NQUNfVEJBKSwgaW9zKFdLX0lP U19UQkEsIFdLX0lPU19UQkEpKTsKLQorI2VuZGlmCiBAZW5kCiAKIE5TX0FTU1VNRV9OT05OVUxM X0VORApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0K aW5kZXggOGU1MWU1ODUwMWEzNDA1MzhhYzc1ZjhkZTBlMTY1NjIxMDMyZDM3Ny4uMzU2ZTBjYjZi ODU4NDI2NzgzODJkYWZjZWQyOTQxZjZhZjU5NDY0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0zMzM5LDYgKzMzMzksNyBAQCBzdGF0 aWMgaW5saW5lIE9wdGlvblNldDxXZWJLaXQ6OkZpbmRPcHRpb25zPiB0b0ZpbmRPcHRpb25zKF9X S0ZpbmRPcHRpb25zIHdrRmluZAogICAgIHJldHVybiAoX19icmlkZ2UgTlNBcnJheSAqKWNlcnRp ZmljYXRlSW5mby0+Y2VydGlmaWNhdGVJbmZvKCkuY2VydGlmaWNhdGVDaGFpbigpID86IEBbIF07 CiB9CiAKKyNpZm5kZWYgX19zd2lmdF9fCiAtICh2b2lkKXBhdXNlQWxsTWVkaWFQbGF5YmFjazoo dm9pZCAoXikodm9pZCkpY29tcGxldGlvbkhhbmRsZXIKIHsKICAgICBbc2VsZiBwYXVzZUFsbE1l ZGlhUGxheWJhY2tXaXRoQ29tcGxldGlvbkhhbmRsZXI6Y29tcGxldGlvbkhhbmRsZXJdOwpAQCAt MzM2Myw3ICszMzY0LDcgQEAgc3RhdGljIGlubGluZSBPcHRpb25TZXQ8V2ViS2l0OjpGaW5kT3B0 aW9ucz4gdG9GaW5kT3B0aW9ucyhfV0tGaW5kT3B0aW9ucyB3a0ZpbmQKIHsKICAgICBbc2VsZiBy ZXF1ZXN0TWVkaWFQbGF5YmFja1N0YXRlV2l0aENvbXBsZXRpb25IYW5kbGVyOmNvbXBsZXRpb25I YW5kbGVyXTsKIH0KLQorI2VuZGlmCiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXS1dlYlZpZXcg KFdLQmluYXJ5Q29tcGF0aWJpbGl0eVdpdGhJT1MxMCkK 423389 2021-03-16 13:10:18 -0700 2021-03-16 14:17:59 -0700 Patch bug-223275-20210316131017.patch text/plain 2753 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNhNTVmMGNmMDgwZmE1NTY0 ZmQ5M2FkMjhmMzRjZTRhMjYxZDgxZGIuLjMxNWJjNzYyZmE2YjZiMzY5ZDAzZDVmNDdkMGVkNjFi NTYyYjYxZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDMtMTYgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgW1N3aWZ0XSBBbWJp Z3VvdXMgdXNlIG9mICdjbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9ucycKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzI3NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNzU0NDc5ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2UgYWRkZWQgYmFjayBkZXByZWNhdGVkIG1lZGlhIHBsYXliYWNrIGNvbnRy b2wgQVBJcyBpbgorICAgICAgICBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjcz MTg2L3dlYmtpdCBhZnRlciBhIG5hbWUgY2hhbmdlCisgICAgICAgIHRvIHN1cHBvcnQgZWFybHkg YWRvcHRvcnMuIEltcG9ydGluZyB0aGVzZSBtZXRob2RzIHRvIFN3aWZ0IGNhdXNlcworICAgICAg ICBhIG1ldGhvZCByZWRlZmluaXRpb24gZXJyb3IgYmVjYXVzZSB0aGUgY29tcGxldGlvbiBoYW5k bGVyIGluIGJvdGgKKyAgICAgICAgY2FzZXMgaXMgbnVsbGFibGUuIFdlIHNob3VsZCBpZ25vcmUg dGhlIGRlcHJlY2F0ZWQgQVBJcyBmb3IgU3dpZnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5oOgorCiAyMDIxLTAzLTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVGVybWluYXRlIG5ldHdvcmsgcHJvY2Vz cyB3aGVuIG1ha2luZyBuZXcgV2ViUHJvY2Vzc1Bvb2wgaW4gTHV0cm9uIEFwcApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5oIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5oCmluZGV4IGNkYWIzZGU2Zjg4 YzI4MDNjY2IxMmIzYWRkMTU3MGRjNDM2MDA5ZWUuLjExNjZjNGY3ZWQ1MjUzOWM1YzQ4MDEyYTdl ZDA1OTlkNDI1YjRjY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3LmgKQEAgLTUzMiwxMiArNTMyLDEzIEBAIFdLX0FQSV9BVkFJTEFCTEUobWFjb3Mo MTAuMTUuNCkpCiAKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSwgY29weSkgTlNBcnJh eSAqY2VydGlmaWNhdGVDaGFpbiBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJz ZXJ2ZXJUcnVzdCIsIG1hY29zKDEwLjExLCAxMC4xMiksIGlvcyg5LjAsIDEwLjApKTsKIAorI2lm bmRlZiBfX3N3aWZ0X18KIC0gKHZvaWQpcGF1c2VBbGxNZWRpYVBsYXliYWNrOih2b2lkICheX051 bGxhYmxlKSh2b2lkKSljb21wbGV0aW9uSGFuZGxlciBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JF UExBQ0VNRU5UKCJwYXVzZUFsbE1lZGlhUGxheWJhY2tXaXRoQ29tcGxldGlvbkhhbmRsZXIiLCBt YWNvcyhXS19NQUNfVEJBLCBXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEsIFdLX0lPU19UQkEp KTsKIC0gKHZvaWQpc3VzcGVuZEFsbE1lZGlhUGxheWJhY2s6KHZvaWQgKF5fTnVsbGFibGUpKHZv aWQpKWNvbXBsZXRpb25IYW5kbGVyIFdLX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQo InNldEFsbE1lZGlhUGxheWJhY2tTdXNwZW5kZWQ6c3VzcGVuZGVkIiwgbWFjb3MoV0tfTUFDX1RC QSwgV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBLCBXS19JT1NfVEJBKSk7CiAtICh2b2lkKXJl c3VtZUFsbE1lZGlhUGxheWJhY2s6KHZvaWQgKF4gX051bGxhYmxlKSh2b2lkKSljb21wbGV0aW9u SGFuZGxlciBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJzZXRBbGxNZWRpYVBs YXliYWNrU3VzcGVuZGVkOnN1c3BlbmRlZCIsIG1hY29zKFdLX01BQ19UQkEsIFdLX01BQ19UQkEp LCBpb3MoV0tfSU9TX1RCQSwgV0tfSU9TX1RCQSkpOwogLSAodm9pZCljbG9zZUFsbE1lZGlhUHJl c2VudGF0aW9uczoodm9pZCAoXl9OdWxsYWJsZSkodm9pZCkpY29tcGxldGlvbkhhbmRsZXIgV0tf QVBJX0RFUFJFQ0FURURfV0lUSF9SRVBMQUNFTUVOVCgiY2xvc2VBbGxNZWRpYVByZXNlbnRhdGlv bnNXaXRoQ29tcGxldGlvbkhhbmRsZXIiLCBtYWNvcyhXS19NQUNfVEJBLCBXS19NQUNfVEJBKSwg aW9zKFdLX0lPU19UQkEsIFdLX0lPU19UQkEpKTsKIC0gKHZvaWQpcmVxdWVzdE1lZGlhUGxheWJh Y2tTdGF0ZToodm9pZCAoXikoV0tNZWRpYVBsYXliYWNrU3RhdGUpKWNvbXBsZXRpb25IYW5kbGVy IFdLX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQoInJlcXVlc3RNZWRpYVBsYXliYWNr U3RhdGVXaXRoQ29tcGxldGlvbkhhbmRsZXIiLCBtYWNvcyhXS19NQUNfVEJBLCBXS19NQUNfVEJB KSwgaW9zKFdLX0lPU19UQkEsIFdLX0lPU19UQkEpKTsKLQorI2VuZGlmCiBAZW5kCiAKIE5TX0FT U1VNRV9OT05OVUxMX0VORAo=