223267 2021-03-16 11:46:22 -0700 Web Automation: Web Share menu being open causes hang in `Automation.isShowingJavaScriptDialog` 2021-03-16 13:06:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle bburg inspector-bugzilla-changes pangle webkit-bug-importer oldest_to_newest 1740077 0 pangle 2021-03-16 11:46:22 -0700 . 1740078 1 pangle 2021-03-16 11:46:49 -0700 <rdar://74197601> 1740098 2 423376 pangle 2021-03-16 12:06:07 -0700 Created attachment 423376 Patch v1.0 1740100 3 423376 bburg 2021-03-16 12:08:13 -0700 Comment on attachment 423376 Patch v1.0 r=me 1740134 4 bburg 2021-03-16 12:55:51 -0700 commit-queue is hitting some tests that flakily time out, but I don't think it's related to this change. 1740147 5 ews-feeder 2021-03-16 13:05:22 -0700 Committed r274509: <https://commits.webkit.org/r274509> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423376. 1740148 6 pangle 2021-03-16 13:06:15 -0700 (In reply to BJ Burg from comment #4) > commit-queue is hitting some tests that flakily time out, but I don't think > it's related to this change. I agree they appear unrelated, plus I can't see a way that any of these tests could fail based on what this change actually is. The one test that crashed appears to have a history of doing so as well. 423376 2021-03-16 12:06:07 -0700 2021-03-16 13:05:22 -0700 Patch v1.0 bug-223267-20210316120607.patch text/plain 1706 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk2MzI1YjdkYjE3MTll ZDQ4MmQ5OWY4MjYxMzEzNDAxNjQ4NTZjNC4uNGY1ZTI1Yzg4NTM3Yjg1MTE1YmZkYzY2ZGViMTIx MjAwOGMzZDhlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTE2ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgQXV0b21hdGlvbjog V2ViIFNoYXJlIG1lbnUgYmVpbmcgb3BlbiBjYXVzZXMgaGFuZyBpbiBgQXV0b21hdGlvbi5pc1No b3dpbmdKYXZhU2NyaXB0RGlhbG9nYAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjIzMjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIFdlYiBTaGFyZSBtZW51IHNob3VsZCBhdXRvbWF0aWNhbGx5IHJl c29sdmUgaWYgdGhlIHBhZ2UgaXMgYmVpbmcgY29udHJvbGxlZCBieSBhdXRvbWF0aW9uIGFuZCBh bGwgb3RoZXIKKyAgICAgICAgY29uZGl0aW9ucyBmb3IgZGlzcGxheSBhcmUgbWV0ICh3ZSBoYXZl IG5vIHJlYXNvbiB0byByZWplY3QgdGhlIHByb21pc2UpIGluIG9yZGVyIHRvIHByZXZlbnQgaGFu Z2luZyBhbgorICAgICAgICBhdXRvbWF0aW9uIHNlc3Npb24gb24gYSBtZW51IHRoYXQgY2FuIG5v dCBiZSBpbnRlcmFjdGVkIHdpdGguCisKKyAgICAgICAgKiBwYWdlL05hdmlnYXRvci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpOYXZpZ2F0b3I6OnNob3dTaGFyZURhdGEpOgorCiAyMDIxLTAzLTE1 ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFBDTTogU3Bs aXQgYXR0cmlidXRpb25SZXBvcnRVUkwoKSBpbnRvIGF0dHJpYnV0aW9uUmVwb3J0U291cmNlVVJM KCkgYW5kIGF0dHJpYnV0aW9uUmVwb3J0QXR0cmlidXRlT25VUkwoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZp Z2F0b3IuY3BwCmluZGV4IDJmNDUzNGE1MzIwMTMyNTQ2NTBmYzI4MDBmNTQ2MDg3YjQ5YjYyMzAu LmJiNWYxZmM2MGZiNDNmMzcxYmVkNTlhZGMwYmI3Y2I5NjVjYmFlYmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L05hdmlnYXRvci5jcHAKQEAgLTE4Niw2ICsxODYsMTEgQEAgdm9pZCBOYXZpZ2F0b3I6OnNob3dT aGFyZURhdGEoRXhjZXB0aW9uT3I8U2hhcmVEYXRhV2l0aFBhcnNlZFVSTCY+IHJlYWREYXRhLCBS ZWYKICAgICBhdXRvKiBmcmFtZSA9IHRoaXMtPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSB8fCAh ZnJhbWUtPnBhZ2UoKSkKICAgICAgICAgcmV0dXJuOworCisgICAgaWYgKGZyYW1lLT5wYWdlKCkt PmlzQ29udHJvbGxlZEJ5QXV0b21hdGlvbigpKSB7CisgICAgICAgIHByb21pc2UtPnJlc29sdmUo KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KICAgICAKICAgICBtX2hhc1BlbmRpbmdTaGFyZSA9 IHRydWU7CiAgICAgYXV0byBzaGFyZURhdGEgPSByZWFkRGF0YS5yZXR1cm5WYWx1ZSgpOwo=