223255 2021-03-16 08:11:39 -0700 [Nicosia] Add support for scroll-snap when handling wheel events 2021-03-16 11:04:22 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrobinson mrobinson cmarcelo ews-watchlist fred.wang jamesr luiz simon.fraser tonikitoo webkit-bug-importer zdobersek oldest_to_newest 1739943 0 mrobinson 2021-03-16 08:11:39 -0700 When Nicosia handles a wheel event, it should trigger scroll snapping. 1739944 1 423331 mrobinson 2021-03-16 08:13:56 -0700 Created attachment 423331 Patch 1740035 2 423331 mrobinson 2021-03-16 10:54:34 -0700 Comment on attachment 423331 Patch Thanks for the review! 1740045 3 ews-feeder 2021-03-16 11:03:49 -0700 Committed r274495: <https://commits.webkit.org/r274495> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423331. 1740047 4 webkit-bug-importer 2021-03-16 11:04:22 -0700 <rdar://problem/75484655> 423331 2021-03-16 08:13:56 -0700 2021-03-16 11:03:50 -0700 Patch bug-223255-20210316161354.patch text/plain 4491 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZiMmJhODZmYzViMDA3 NjQwZGQxMDg3NGYzZmYyMWM5YjllMDdmMi4uOGZiMjI3NTg5MzdmOTc3YTc2MjliMGY1NjEzNTQ2 Y2Y5NTk0NDA4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAzLTE2ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbTmljb3NpYV0g QWRkIHN1cHBvcnQgZm9yIHNjcm9sbC1zbmFwIHdoZW4gaGFuZGxpbmcgd2hlZWwgZXZlbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjMyNTUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIFRoaXMgZml4ZXMgY3NzMy9zY3JvbGwtc25hcC9zY3JvbGwtc25hcC13aGVlbC1ldmVudC5o dG1sCisgICAgICAgIGZvciBOaWNvc2lhIHBvcnRzLgorCisgICAgICAgICogcGFnZS9zY3JvbGxp bmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZURlbGVnYXRlTmljb3NpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZURlbGVnYXRlTmlj b3NpYTo6aGFuZGxlV2hlZWxFdmVudCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUcmVl U2Nyb2xsaW5nTm9kZURlbGVnYXRlTmljb3NpYTo6cGFnZVNjYWxlRmFjdG9yKToKKyAgICAgICAg KiBwYWdlL3Njcm9sbGluZy9uaWNvc2lhL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlRGVsZWdh dGVOaWNvc2lhLmg6CisKIDIwMjEtMDMtMTYgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW1NPVVBdIEZpeCBTT1VQMyBkZWJ1ZyBidWlsZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlU2Nyb2xs aW5nTm9kZURlbGVnYXRlTmljb3NpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9uaWNvc2lhL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlRGVsZWdhdGVOaWNvc2lhLmNwcApp bmRleCAyYTM1MGQ5N2RiNjgxZmJkMzc0M2E5Y2Q3ZDJlZTYyODE4N2VjZDBmLi4zMzkwZGJjMjg1 MTExNjI1ODVhNGFiMTg1ZTk1ZTg3M2FiOTBmOGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lhL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlRGVsZWdh dGVOaWNvc2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lh L1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlRGVsZWdhdGVOaWNvc2lhLmNwcApAQCAtMTYzLDE3 ICsxNjMsMzMgQEAgV2hlZWxFdmVudEhhbmRsaW5nUmVzdWx0IFNjcm9sbGluZ1RyZWVTY3JvbGxp bmdOb2RlRGVsZWdhdGVOaWNvc2lhOjpoYW5kbGVXaGVlbEUKICAgICAgICAgfQogICAgIH0KIAor ICAgIGRlbHRhWCA9IC1kZWx0YVg7CisgICAgZGVsdGFZID0gLWRlbHRhWTsKKworICAgIGlmICgh c2Nyb2xsaW5nTm9kZSgpLnNuYXBPZmZzZXRzSW5mbygpLmlzRW1wdHkoKSkgeworICAgICAgICBm bG9hdCBzY2FsZSA9IHBhZ2VTY2FsZUZhY3RvcigpOworICAgICAgICBGbG9hdFBvaW50IG9yaWdp bmFsT2Zmc2V0ID0gTGF5b3V0UG9pbnQoc2Nyb2xsaW5nTm9kZSgpLmN1cnJlbnRTY3JvbGxPZmZz ZXQoKS54KCkgLyBzY2FsZSwgc2Nyb2xsaW5nTm9kZSgpLmN1cnJlbnRTY3JvbGxPZmZzZXQoKS55 KCkgLyBzY2FsZSk7CisgICAgICAgIEZsb2F0UG9pbnQgbmV3RmxvYXRPZmZzZXQgPSBzY3JvbGxp bmdOb2RlKCkuY3VycmVudFNjcm9sbE9mZnNldCgpICsgRmxvYXRTaXplKGRlbHRhWCwgZGVsdGFZ KTsKKyAgICAgICAgYXV0byBuZXdPZmZzZXQgPSBMYXlvdXRQb2ludChuZXdGbG9hdE9mZnNldC54 KCkgLyBzY2FsZSwgbmV3RmxvYXRPZmZzZXQueSgpIC8gc2NhbGUpOworCisgICAgICAgIGF1dG8g b2Zmc2V0WCA9IHNjcm9sbGluZ05vZGUoKS5zbmFwT2Zmc2V0c0luZm8oKS5jbG9zZXN0U25hcE9m ZnNldChTY3JvbGxFdmVudEF4aXM6Okhvcml6b250YWwsIG5ld09mZnNldC54KCksIGRlbHRhWCwg b3JpZ2luYWxPZmZzZXQueCgpKS5maXJzdDsKKyAgICAgICAgYXV0byBvZmZzZXRZID0gc2Nyb2xs aW5nTm9kZSgpLnNuYXBPZmZzZXRzSW5mbygpLmNsb3Nlc3RTbmFwT2Zmc2V0KFNjcm9sbEV2ZW50 QXhpczo6VmVydGljYWwsIG5ld09mZnNldC55KCksIGRlbHRhWSwgb3JpZ2luYWxPZmZzZXQueSgp KS5maXJzdDsKKworICAgICAgICBkZWx0YVggPSAob2Zmc2V0WCAtIG9yaWdpbmFsT2Zmc2V0Lngo KSkgKiBzY2FsZTsKKyAgICAgICAgZGVsdGFZID0gKG9mZnNldFkgLSBvcmlnaW5hbE9mZnNldC55 KCkpICogc2NhbGU7CisgICAgfQorCiAjaWYgRU5BQkxFKFNNT09USF9TQ1JPTExJTkcpCiAgICAg aWYgKG1fc2Nyb2xsQW5pbWF0b3JFbmFibGVkICYmICF3aGVlbEV2ZW50Lmhhc1ByZWNpc2VTY3Jv bGxpbmdEZWx0YXMoKSkgewogICAgICAgICBlbnN1cmVTY3JvbGxBbmltYXRpb25TbW9vdGgoKTsK LSAgICAgICAgbV9zbW9vdGhBbmltYXRpb24tPnNjcm9sbChIb3Jpem9udGFsU2Nyb2xsYmFyLCBT Y3JvbGxCeVBpeGVsLCAxLCAtZGVsdGFYKTsKLSAgICAgICAgbV9zbW9vdGhBbmltYXRpb24tPnNj cm9sbChWZXJ0aWNhbFNjcm9sbGJhciwgU2Nyb2xsQnlQaXhlbCwgMSwgLWRlbHRhWSk7CisgICAg ICAgIG1fc21vb3RoQW5pbWF0aW9uLT5zY3JvbGwoSG9yaXpvbnRhbFNjcm9sbGJhciwgU2Nyb2xs QnlQaXhlbCwgMSwgZGVsdGFYKTsKKyAgICAgICAgbV9zbW9vdGhBbmltYXRpb24tPnNjcm9sbChW ZXJ0aWNhbFNjcm9sbGJhciwgU2Nyb2xsQnlQaXhlbCwgMSwgZGVsdGFZKTsKICAgICAgICAgcmV0 dXJuIFdoZWVsRXZlbnRIYW5kbGluZ1Jlc3VsdDo6aGFuZGxlZCgpOwogICAgIH0KICNlbmRpZgog CiAgICAgYXV0byB1cGRhdGVTY29wZSA9IGNyZWF0ZVVwZGF0ZVNjb3BlKCk7Ci0gICAgc2Nyb2xs aW5nTm9kZSgpLnNjcm9sbEJ5KHsgLWRlbHRhWCwgLWRlbHRhWSB9KTsKKyAgICBzY3JvbGxpbmdO b2RlKCkuc2Nyb2xsQnkoeyBkZWx0YVgsIGRlbHRhWSB9KTsKIAogICAgIHJldHVybiBXaGVlbEV2 ZW50SGFuZGxpbmdSZXN1bHQ6OmhhbmRsZWQoKTsKIH0KQEAgLTE5Miw2ICsyMDgsMTQgQEAgdm9p ZCBTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZURlbGVnYXRlTmljb3NpYTo6c3RvcFNjcm9sbEFu aW1hdGlvbnMoKQogI2VuZGlmCiB9CiAKK2Zsb2F0IFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2Rl RGVsZWdhdGVOaWNvc2lhOjpwYWdlU2NhbGVGYWN0b3IoKQoreworICAgIC8vIEZJWE1FOiBXaGF0 IHNob3VsZCB0aGlzIHJldHVybiBmb3Igbm9uLXJvb3QgZnJhbWVzLCBhbmQgb3ZlcmZsb3c/Cisg ICAgLy8gQWxzbywgdGhpcyBzaG91bGQgbm90IGhhdmUgdG8gYWNjZXNzIFNjcm9sbGluZ1RyZWVG cmFtZVNjcm9sbGluZ05vZGUuCisgICAgcmV0dXJuIGlzPFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9s bGluZ05vZGU+KHNjcm9sbGluZ05vZGUoKSkgPworICAgICAgICBkb3duY2FzdDxTY3JvbGxpbmdU cmVlRnJhbWVTY3JvbGxpbmdOb2RlPihzY3JvbGxpbmdOb2RlKCkpLmZyYW1lU2NhbGVGYWN0b3Io KSA6IDEuOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUo QVNZTkNfU0NST0xMSU5HKSAmJiBVU0UoTklDT1NJQSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL25pY29zaWEvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGVEZWxl Z2F0ZU5pY29zaWEuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL25pY29zaWEvU2Ny b2xsaW5nVHJlZVNjcm9sbGluZ05vZGVEZWxlZ2F0ZU5pY29zaWEuaAppbmRleCBkMDIxODhlMGM3 N2Y3YTdlZTkyMGY4YzMzOGY1NzlmMzZjNGYzZTEwLi5kMWFkMjczYWFiZmYxMDBhZWY3YmQ5MDUw MmQyZWFhOTZjMWJiOWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9uaWNvc2lhL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlRGVsZWdhdGVOaWNvc2lhLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlU2Ny b2xsaW5nTm9kZURlbGVnYXRlTmljb3NpYS5oCkBAIC01Nyw2ICs1Nyw3IEBAIHB1YmxpYzoKIAog cHJpdmF0ZToKICAgICBib29sIG1fc2Nyb2xsQW5pbWF0b3JFbmFibGVkIHsgZmFsc2UgfTsKKyAg ICBmbG9hdCBwYWdlU2NhbGVGYWN0b3IoKTsKIAogI2lmIEVOQUJMRShLSU5FVElDX1NDUk9MTElO RykKICAgICB2b2lkIGVuc3VyZVNjcm9sbEFuaW1hdGlvbktpbmV0aWMoKTsK