223250 2021-03-16 05:29:51 -0700 adjust-angle-include-paths.py is making the maintenance more difficult than it should be 2021-03-23 05:30:16 -0700 1 1 1 Unclassified WebKit WebGL Other Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 223470 221664 1 kkinnunen kkinnunen ap dino kbr kkinnunen webkit-bug-importer oldest_to_newest 1739908 0 kkinnunen 2021-03-16 05:29:51 -0700 adjust-angle-include-paths.py is making the maintenance more difficult than it should be Problems: * The WebCore part has to jump multiple hoops just to include angle headers * Angle headers are not complete, preventing explicit context API usage Currently: 1) copy partial amount of public headers 2) regex-patch the headers to fix the shortcoming that the folder structure was flattened by 1 Most likely the problem should be solved one of a) publish the public headers via publishing the folder reference of ANGLE/include b) copy public headers via script https://stackoverflow.com/questions/3807241/keeping-directory-structure-when-creating-frameworks-in-xcode 1741617 1 kkinnunen 2021-03-19 01:10:06 -0700 In this bug we could address the difference, if it's desired: WTF has "Copy WTF Headers" build target where it rsyncs the headers, preserving the directory structure, to the header path. wtf does not have Xcode public/private headers, only project headers. libwebrtc has "Copy libwebrtc headers" build target where it rsyncs the headers, preserving the directory structure, to the header path. libwebrtc does not have Xcode public/private headers, only project headers. ANGLE has "Adjust ANGLE paths" *build phase* where it regex-replaces some #includes to not have directories. ANGLE has Xcode public headers. 1741618 2 kkinnunen 2021-03-19 01:14:13 -0700 The explicit headers part is addressed by bug 223470 1741787 3 ap 2021-03-19 10:57:59 -0700 At some point, we should be switching from script phases to using a copy headers phase with APPLY_RULES_IN_COPY_HEADERS, as that enables a much easier way to track dependencies. This feature is new build system only, so it cannot be done right now. 1742761 4 webkit-bug-importer 2021-03-23 05:30:16 -0700 <rdar://problem/75734268>