223246 2021-03-16 01:33:35 -0700 Protect DOMFileSystem when hopping to a background thread 2021-03-16 09:22:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez webkit-bug-importer oldest_to_newest 1739870 0 youennf 2021-03-16 01:33:35 -0700 Protect DOMFileSystem when hopping to a background thread 1739895 1 423317 youennf 2021-03-16 04:05:17 -0700 Created attachment 423317 Patch 1739930 2 423317 youennf 2021-03-16 07:29:02 -0700 Comment on attachment 423317 Patch AIUI, this is not strictly needed as the caller of these methods makes sure to ref DOMFileSystem in our code path. It seems safer to ref it anyway. 1739968 3 ews-feeder 2021-03-16 09:21:07 -0700 Committed r274482: <https://commits.webkit.org/r274482> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423317. 1739969 4 webkit-bug-importer 2021-03-16 09:22:15 -0700 <rdar://problem/75479783> 423317 2021-03-16 04:05:17 -0700 2021-03-16 09:21:08 -0700 Patch bug-223246-20210316120516.patch text/plain 4934 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDdkY2U2YTJiZjM1NjJk MWJlZTQyZDIwYjlkZTUyNjFlNjkzY2JhOS4uMjBhNjNmY2E4NzAzYWUyMjA5NzU4NmY2OTNkZjQ5 MWUxOTgxOWViNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAzLTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBQcm90ZWN0IERPTUZpbGVT eXN0ZW0gd2hlbiBob3BwaW5nIHRvIGEgYmFja2dyb3VuZCB0aHJlYWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzI0NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0byByZWYgd2hlbiBo b3BwaW5nIHRvIGJhY2tncm91bmQgdGhyZWFkIGFuZCBob3AgYmFjayB0byBtYWluIHRocmVhZCB0 byB1bnJlZi4KKworICAgICAgICAqIE1vZHVsZXMvZW50cmllc2FwaS9ET01GaWxlU3lzdGVtLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTUZpbGVTeXN0ZW06OmdldFBhcmVudCk6CisgICAgICAg IChXZWJDb3JlOjpET01GaWxlU3lzdGVtOjpnZXRFbnRyeSk6CisKIDIwMjEtMDMtMTYgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFwcGx5IHBlcm1pc3Npb24g cG9saWN5IHRvIGdlb2xvY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2VudHJpZXNhcGkvRE9NRmlsZVN5c3RlbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2Vu dHJpZXNhcGkvRE9NRmlsZVN5c3RlbS5jcHAKaW5kZXggZGE5ZDlmNGMwZDA0NzFkYTRjMTZkMTBm OTc1YTc1ZmNiZTFiMDYxZS4uMzY3M2M3NjI0MWE2ZjRmNzhkYzhlZjZkNWRiOGJlMjcyMmM0NGZm MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9lbnRyaWVzYXBpL0RPTUZpbGVT eXN0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZW50cmllc2FwaS9ET01GaWxl U3lzdGVtLmNwcApAQCAtMjcwLDEzICsyNzAsMTMgQEAgdm9pZCBET01GaWxlU3lzdGVtOjpnZXRQ YXJlbnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCwgRmlsZVN5c3RlbUVudHJ5Jgog ICAgIGF1dG8gdmlydHVhbFBhdGggPSByZXNvbHZlUmVsYXRpdmVWaXJ0dWFsUGF0aChlbnRyeS52 aXJ0dWFsUGF0aCgpLCAiLi4iKTsKICAgICBBU1NFUlQodmlydHVhbFBhdGhbMF0gPT0gJy8nKTsK ICAgICBhdXRvIGZ1bGxQYXRoID0gZXZhbHVhdGVQYXRoKHZpcnR1YWxQYXRoKTsKLSAgICBtX3dv cmtRdWV1ZS0+ZGlzcGF0Y2goW3RoaXMsIGNvbnRleHQgPSBtYWtlUmVmKGNvbnRleHQpLCBmdWxs UGF0aCA9IGNyb3NzVGhyZWFkQ29weShmdWxsUGF0aCksIHZpcnR1YWxQYXRoID0gY3Jvc3NUaHJl YWRDb3B5KHZpcnR1YWxQYXRoKSwgY29tcGxldGlvbkNhbGxiYWNrID0gV1RGTW92ZShjb21wbGV0 aW9uQ2FsbGJhY2spXSgpIG11dGFibGUgeworICAgIG1fd29ya1F1ZXVlLT5kaXNwYXRjaChbcHJv dGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBjb250ZXh0ID0gbWFrZVJlZihjb250ZXh0KSwg ZnVsbFBhdGggPSBjcm9zc1RocmVhZENvcHkoZnVsbFBhdGgpLCB2aXJ0dWFsUGF0aCA9IGNyb3Nz VGhyZWFkQ29weSh2aXJ0dWFsUGF0aCksIGNvbXBsZXRpb25DYWxsYmFjayA9IFdURk1vdmUoY29t cGxldGlvbkNhbGxiYWNrKV0oKSBtdXRhYmxlIHsKICAgICAgICAgYXV0byB2YWxpZGF0ZWRWaXJ0 dWFsUGF0aCA9IHZhbGlkYXRlUGF0aElzRXhwZWN0ZWRUeXBlKGZ1bGxQYXRoLCBXVEZNb3ZlKHZp cnR1YWxQYXRoKSwgRmlsZU1ldGFkYXRhOjpUeXBlOjpEaXJlY3RvcnkpOwotICAgICAgICBjYWxs T25NYWluVGhyZWFkKFt0aGlzLCBjb250ZXh0ID0gV1RGTW92ZShjb250ZXh0KSwgdmFsaWRhdGVk VmlydHVhbFBhdGggPSBjcm9zc1RocmVhZENvcHkodmFsaWRhdGVkVmlydHVhbFBhdGgpLCBjb21w bGV0aW9uQ2FsbGJhY2sgPSBXVEZNb3ZlKGNvbXBsZXRpb25DYWxsYmFjayldKCkgbXV0YWJsZSB7 CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3Byb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3Rl Y3RlZFRoaXMpLCBjb250ZXh0ID0gV1RGTW92ZShjb250ZXh0KSwgdmFsaWRhdGVkVmlydHVhbFBh dGggPSBjcm9zc1RocmVhZENvcHkodmFsaWRhdGVkVmlydHVhbFBhdGgpLCBjb21wbGV0aW9uQ2Fs bGJhY2sgPSBXVEZNb3ZlKGNvbXBsZXRpb25DYWxsYmFjayldKCkgbXV0YWJsZSB7CiAgICAgICAg ICAgICBpZiAodmFsaWRhdGVkVmlydHVhbFBhdGguaGFzRXhjZXB0aW9uKCkpCiAgICAgICAgICAg ICAgICAgY29tcGxldGlvbkNhbGxiYWNrKHZhbGlkYXRlZFZpcnR1YWxQYXRoLnJlbGVhc2VFeGNl cHRpb24oKSk7CiAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgY29tcGxldGlvbkNh bGxiYWNrKEZpbGVTeXN0ZW1EaXJlY3RvcnlFbnRyeTo6Y3JlYXRlKGNvbnRleHQsICp0aGlzLCB2 YWxpZGF0ZWRWaXJ0dWFsUGF0aC5yZWxlYXNlUmV0dXJuVmFsdWUoKSkpOworICAgICAgICAgICAg ICAgIGNvbXBsZXRpb25DYWxsYmFjayhGaWxlU3lzdGVtRGlyZWN0b3J5RW50cnk6OmNyZWF0ZShj b250ZXh0LCBwcm90ZWN0ZWRUaGlzLmdldCgpLCB2YWxpZGF0ZWRWaXJ0dWFsUGF0aC5yZWxlYXNl UmV0dXJuVmFsdWUoKSkpOwogICAgICAgICB9KTsKICAgICB9KTsKIH0KQEAgLTMxMSwxOSArMzEx LDE5IEBAIHZvaWQgRE9NRmlsZVN5c3RlbTo6Z2V0RW50cnkoU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCYgY29udGV4dCwgRmlsZVN5c3RlbURpcmVjdG9yCiAgICAgICAgIHJldHVybjsKICAgICB9CiAK LSAgICBtX3dvcmtRdWV1ZS0+ZGlzcGF0Y2goW3RoaXMsIGNvbnRleHQgPSBtYWtlUmVmKGNvbnRl eHQpLCBmdWxsUGF0aCA9IGNyb3NzVGhyZWFkQ29weShmdWxsUGF0aCksIHJlc29sdmVkVmlydHVh bFBhdGggPSBjcm9zc1RocmVhZENvcHkocmVzb2x2ZWRWaXJ0dWFsUGF0aCksIGNvbXBsZXRpb25D YWxsYmFjayA9IFdURk1vdmUoY29tcGxldGlvbkNhbGxiYWNrKV0oKSBtdXRhYmxlIHsKKyAgICBt X3dvcmtRdWV1ZS0+ZGlzcGF0Y2goW3Byb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgY29u dGV4dCA9IG1ha2VSZWYoY29udGV4dCksIGZ1bGxQYXRoID0gY3Jvc3NUaHJlYWRDb3B5KGZ1bGxQ YXRoKSwgcmVzb2x2ZWRWaXJ0dWFsUGF0aCA9IGNyb3NzVGhyZWFkQ29weShyZXNvbHZlZFZpcnR1 YWxQYXRoKSwgY29tcGxldGlvbkNhbGxiYWNrID0gV1RGTW92ZShjb21wbGV0aW9uQ2FsbGJhY2sp XSgpIG11dGFibGUgewogICAgICAgICBhdXRvIGVudHJ5VHlwZSA9IGZpbGVUeXBlKGZ1bGxQYXRo KTsKLSAgICAgICAgY2FsbE9uTWFpblRocmVhZChbdGhpcywgY29udGV4dCA9IFdURk1vdmUoY29u dGV4dCksIHJlc29sdmVkVmlydHVhbFBhdGggPSBjcm9zc1RocmVhZENvcHkocmVzb2x2ZWRWaXJ0 dWFsUGF0aCksIGVudHJ5VHlwZSwgY29tcGxldGlvbkNhbGxiYWNrID0gV1RGTW92ZShjb21wbGV0 aW9uQ2FsbGJhY2spXSgpIG11dGFibGUgeworICAgICAgICBjYWxsT25NYWluVGhyZWFkKFtwcm90 ZWN0ZWRUaGlzID0gV1RGTW92ZShwcm90ZWN0ZWRUaGlzKSwgY29udGV4dCA9IFdURk1vdmUoY29u dGV4dCksIHJlc29sdmVkVmlydHVhbFBhdGggPSBjcm9zc1RocmVhZENvcHkocmVzb2x2ZWRWaXJ0 dWFsUGF0aCksIGVudHJ5VHlwZSwgY29tcGxldGlvbkNhbGxiYWNrID0gV1RGTW92ZShjb21wbGV0 aW9uQ2FsbGJhY2spXSgpIG11dGFibGUgewogICAgICAgICAgICAgaWYgKCFlbnRyeVR5cGUpIHsK ICAgICAgICAgICAgICAgICBjb21wbGV0aW9uQ2FsbGJhY2soRXhjZXB0aW9uIHsgTm90Rm91bmRF cnJvciwgIkNhbm5vdCBmaW5kIGVudHJ5IGF0IGdpdmVuIHBhdGgiX3MgfSk7CiAgICAgICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgc3dpdGNoIChlbnRyeVR5 cGUudmFsdWUoKSkgewogICAgICAgICAgICAgY2FzZSBGaWxlTWV0YWRhdGE6OlR5cGU6OkRpcmVj dG9yeToKLSAgICAgICAgICAgICAgICBjb21wbGV0aW9uQ2FsbGJhY2soUmVmPEZpbGVTeXN0ZW1F bnRyeT4geyBGaWxlU3lzdGVtRGlyZWN0b3J5RW50cnk6OmNyZWF0ZShjb250ZXh0LCAqdGhpcywg cmVzb2x2ZWRWaXJ0dWFsUGF0aCkgfSk7CisgICAgICAgICAgICAgICAgY29tcGxldGlvbkNhbGxi YWNrKFJlZjxGaWxlU3lzdGVtRW50cnk+IHsgRmlsZVN5c3RlbURpcmVjdG9yeUVudHJ5OjpjcmVh dGUoY29udGV4dCwgcHJvdGVjdGVkVGhpcy5nZXQoKSwgcmVzb2x2ZWRWaXJ0dWFsUGF0aCkgfSk7 CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIEZpbGVNZXRhZGF0YTo6 VHlwZTo6RmlsZToKLSAgICAgICAgICAgICAgICBjb21wbGV0aW9uQ2FsbGJhY2soUmVmPEZpbGVT eXN0ZW1FbnRyeT4geyBGaWxlU3lzdGVtRmlsZUVudHJ5OjpjcmVhdGUoY29udGV4dCwgKnRoaXMs IHJlc29sdmVkVmlydHVhbFBhdGgpIH0pOworICAgICAgICAgICAgICAgIGNvbXBsZXRpb25DYWxs YmFjayhSZWY8RmlsZVN5c3RlbUVudHJ5PiB7IEZpbGVTeXN0ZW1GaWxlRW50cnk6OmNyZWF0ZShj b250ZXh0LCBwcm90ZWN0ZWRUaGlzLmdldCgpLCByZXNvbHZlZFZpcnR1YWxQYXRoKSB9KTsKICAg ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAg ICAgY29tcGxldGlvbkNhbGxiYWNrKEV4Y2VwdGlvbiB7IE5vdEZvdW5kRXJyb3IsICJDYW5ub3Qg ZmluZCBlbnRyeSBhdCBnaXZlbiBwYXRoIl9zIH0pOwo=