223235 2021-03-15 20:46:45 -0700 [git-webkit] Showing help instead of raising an exception with no command 2021-03-16 13:51:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa jbedard jbedard webkit-bug-importer oldest_to_newest 1739822 0 rniwa 2021-03-15 20:46:45 -0700 Instead of raising an exception, show the help when there is no command specified. % ./Tools/Scripts/git-webkit Traceback (most recent call last): File "./Tools/Scripts/git-webkit", line 45, in <module> sys.exit(program.main( File "./Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 76, in main return parsed.main( AttributeError: 'Namespace' object has no attribute 'main' 1739980 1 webkit-bug-importer 2021-03-16 09:47:27 -0700 <rdar://problem/75480951> 1739981 2 jbedard 2021-03-16 09:47:42 -0700 Just an overbite that this isn't the case now. 1739983 3 423343 jbedard 2021-03-16 09:50:27 -0700 Created attachment 423343 Patch 1739994 4 jbedard 2021-03-16 10:01:32 -0700 (In reply to Jonathan Bedard from comment #2) > Just an overbite that this isn't the case now. *oversite 1740170 5 ews-feeder 2021-03-16 13:51:14 -0700 Committed r274512: <https://commits.webkit.org/r274512> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423343. 423343 2021-03-16 09:50:27 -0700 2021-03-16 13:51:15 -0700 Patch bug-223235-20210316095026.patch text/plain 2580 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDQ4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAzLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbZ2l0LXdlYmtpdF0gU2hvd2luZyBoZWxwIGluc3RlYWQgb2YgcmFpc2lu ZyBhbiBleGNlcHRpb24gd2l0aCBubyBjb21tYW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjMyMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1 NDgwOTUxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4K KyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2lu aXRfXy5weTogRGl0dG8uCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv d2Via2l0c2NtcHkvcHJvZ3JhbS9fX2luaXRfXy5weToKKyAgICAgICAgKG1haW4pOgorCiAyMDIx LTAzLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBb d2Via2l0c2NtcHldIERlY29kZSBtdWx0aXBsZSBjb21taXQgcmVwcmVzZW50YXRpb25zCkluZGV4 OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS9zZXR1cC5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS9zZXR1cC5weQkocmV2aXNp b24gMjc0NDgzKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAu cHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDcgQEAgZGVmIHJlYWRtZSgpOgogCiBzZXR1 cCgKICAgICBuYW1lPSd3ZWJraXRzY21weScsCi0gICAgdmVyc2lvbj0nMC4xMy4yJywKKyAgICB2 ZXJzaW9uPScwLjEzLjMnLAogICAgIGRlc2NyaXB0aW9uPSdMaWJyYXJ5IGRlc2lnbmVkIHRvIGlu dGVyYWN0IHdpdGggZ2l0IGFuZCBzdm4gcmVwb3NpdG9yaWVzLicsCiAgICAgbG9uZ19kZXNjcmlw dGlvbj1yZWFkbWUoKSwKICAgICBjbGFzc2lmaWVycz1bCkluZGV4OiBUb29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRf Xy5weQkocmV2aXNpb24gMjc0NDgzKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDcgKzQ2 LDcgQEAgZXhjZXB0IEltcG9ydEVycm9yOgogICAgICAgICAiUGxlYXNlIGluc3RhbGwgd2Via2l0 Y29yZXB5IHdpdGggYHBpcCBpbnN0YWxsIHdlYmtpdGNvcmVweSAtLWV4dHJhLWluZGV4LXVybCA8 cGFja2FnZSBpbmRleCBVUkw+YCIKICAgICApCiAKLXZlcnNpb24gPSBWZXJzaW9uKDAsIDEzLCAy KQordmVyc2lvbiA9IFZlcnNpb24oMCwgMTMsIDMpCiAKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ2Zhc3RlbmVycycsIFZlcnNpb24oMCwgMTUsIDApKSkKIEF1dG9JbnN0YWxsLnJlZ2lz dGVyKFBhY2thZ2UoJ21vbm90b25pYycsIFZlcnNpb24oMSwgNSkpKQpJbmRleDogVG9vbHMvU2Ny aXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9fX2luaXRfXy5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJr aXRzY21weS9wcm9ncmFtL19faW5pdF9fLnB5CShyZXZpc2lvbiAyNzQ0ODMpCisrKyBUb29scy9T Y3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9wcm9ncmFtL19faW5pdF9f LnB5CSh3b3JraW5nIGNvcHkpCkBAIC03Myw2ICs3MywxMCBAQCBkZWYgbWFpbihhcmdzPU5vbmUs IHBhdGg9Tm9uZSwgbG9nZ2Vycz1OCiAgICAgZWxzZToKICAgICAgICAgcmVwb3NpdG9yeSA9IGxv Y2FsLlNjbS5mcm9tX3BhdGgocGF0aD1wYXJzZWQucmVwb3NpdG9yeSwgY29udHJpYnV0b3JzPWNv bnRyaWJ1dG9ycykKIAorICAgIGlmIG5vdCBnZXRhdHRyKHBhcnNlZCwgJ21haW4nLCBOb25lKToK KyAgICAgICAgcGFyc2VyLnByaW50X2hlbHAoKQorICAgICAgICByZXR1cm4gLTEKKwogICAgIHJl dHVybiBwYXJzZWQubWFpbigKICAgICAgICAgYXJncz1wYXJzZWQsCiAgICAgICAgIHJlcG9zaXRv cnk9cmVwb3NpdG9yeSwK