22323 2008-11-17 14:01:23 -0800 Enable pixel tests by default on Mac 2009-03-12 11:30:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 NEW P4 Normal --- 22271 1 pol webkit-unassigned mitz mjs oldest_to_newest 99103 0 pol 2008-11-17 14:01:23 -0800 Following a discussion on IRC, we should figure out if we want to enable pixel tests by default on Mac 99106 1 pol 2008-11-17 14:04:31 -0800 First of all, it would be for Mac and OS X Leopard only for now: - on other platforms, pixel tests aren't really supported - on Tiger, too many images slightly differ (because of very minor differences in font rendering), which makes the fast hash comparison fail, and require ImageDiff to run and slows down everything 99190 2 pol 2008-11-18 10:56:32 -0800 r38525 build debug on iMac Intel w/ 10.5.4: - /LayoutTests w/ pixel tests disabled: 474.57s - /LayoutTests w/ pixel tests enabled: 561.61s (+18.3%) - /LayoutTests/fast w/ pixel tests disabled: 140.98s - /LayoutTests/fast w/ pixel tests enabled: 157.22s (+11.5%) 99193 3 pol 2008-11-18 11:46:04 -0800 Second run on /LayoutTests:using the same configuration: - pixel tests disabled: 497.92s = pixel tests enabled: 565.44s (+13.5%) 99375 4 pol 2008-11-19 13:33:03 -0800 Some other stats using r38600 Release on a Mac Book Pro with 10.5.4: - /LayoutTests w/ pixel tests disabled: 555.34s - /LayoutTests w/ pixel tests enabled: 601.47s (+8.3%) It'd be good to have data on a PPC machine as there can be minor differences in CG rendering, then we should have all the needed info to decide!