223227 2021-03-15 17:20:54 -0700 RunLoop::isMain() should not need to do any heap allocations 2021-03-16 14:33:40 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223226 1 cdumez cdumez achristensen ap benjamin cmarcelo darin ews-watchlist ggaren sam webkit-bug-importer oldest_to_newest 1739753 0 cdumez 2021-03-15 17:20:54 -0700 RunLoop::isMain() should not need to do any heap allocations. 1739755 1 423268 cdumez 2021-03-15 17:23:08 -0700 Created attachment 423268 Patch 1739789 2 ews-feeder 2021-03-15 18:57:06 -0700 Committed r274458: <https://commits.webkit.org/r274458> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423268. 1739791 3 webkit-bug-importer 2021-03-15 18:58:18 -0700 <rdar://problem/75458639> 1739949 4 423268 ap 2021-03-16 08:37:26 -0700 Comment on attachment 423268 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423268&action=review > Source/WTF/wtf/RunLoop.cpp:65 > +auto RunLoop::runLoopHolder() -> ThreadSpecific<Holder>& Is this style better? 1739953 5 cdumez 2021-03-16 08:42:24 -0700 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 423268 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423268&action=review > > > Source/WTF/wtf/RunLoop.cpp:65 > > +auto RunLoop::runLoopHolder() -> ThreadSpecific<Holder>& > > Is this style better? I use it whenever it makes the type shorter. I would have needed to use 'ThreadSpecific<RunLoop::Holder>&' otherwise. I don't think we have a style rule either way but I have seen other people (including Darin) use it in such cases. 1740212 6 darin 2021-03-16 14:33:40 -0700 (In reply to Chris Dumez from comment #5) > I use it whenever it makes the type shorter. Yes, I do it whenever it makes the type significantly shorter. 423268 2021-03-15 17:23:08 -0700 2021-03-15 18:57:07 -0700 Patch bug-223227-20210315172308.patch text/plain 3023 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYwZmM2OWM1NTQ3NDAzZTEwZmVkN2Nk MWJkMmU3ZmMyOGYwN2Y1NGEuLmVhMDhlZjRiNGExMGM5YzljYWM1MWY0MmYwY2VmM2JhOWNhZjBi ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDMtMTUgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBSdW5Mb29wOjppc01haW4oKSBzaG91bGQgbm90IG5lZWQg dG8gZG8gYW55IGhlYXAgYWxsb2NhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyMzIyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJ1bkxvb3A6OmlzTWFpbigpIHNob3VsZCBub3QgbmVlZCB0byBk byBhbnkgaGVhcCBhbGxvY2F0aW9ucy4gQmVmb3JlIHRoaXMgY2hhbmdlLAorICAgICAgICBjYWxs aW5nIFJ1bkxvb3A6OmlzTWFpbigpIG9uIGEgbm9uLW1haW4gdGhyZWFkIHdvdWxkIGNhbGwgUnVu TG9vcDo6Y3VycmVudCgpIHdoaWNoCisgICAgICAgIHdvdWxkIGFsbG9jYXRlIHRoZSBSdW5Mb29w IGZvciB0aGUgY3VycmVudCB0aHJlYWQuIFRoaXMgaXMgaW5lZmZpY2llbnQgYW5kIGFuIGlzc3Vl CisgICAgICAgIGZvciBXZWJBdWRpbyBzaW5jZSB3ZSdyZSBub3QgYWxsb3dlZCB0byBkbyBoZWFw IGFsbG9jYXRpb24gb24gdGhlIGF1ZGlvIHJlbmRlcmluZworICAgICAgICB0aHJlYWQuCisKKyAg ICAgICAgKiB3dGYvUnVuTG9vcC5jcHA6CisgICAgICAgIChXVEY6OlJ1bkxvb3A6OnJ1bkxvb3BI b2xkZXIpOgorICAgICAgICAoV1RGOjpSdW5Mb29wOjpjdXJyZW50KToKKyAgICAgICAgKFdURjo6 UnVuTG9vcDo6aXNNYWluKToKKyAgICAgICAgKiB3dGYvUnVuTG9vcC5oOgorCiAyMDIxLTAzLTE1 ICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgVHVybiBDU1MgYXNwZWN0 LXJhdGlvIG9uIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3Au Y3BwIGIvU291cmNlL1dURi93dGYvUnVuTG9vcC5jcHAKaW5kZXggNzdkMDUzMzRhODk2ZWExNzBk MDlhYTIwNWRlYjc2Mjc3ZWQ5YTdkOS4uZjczOTQ3YTU2MGI5MWZlNzQxMGYyZDAxYzY1ZjZiZDU5 M2Y5YTBkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUnVuTG9vcC5jcHAKKysrIGIvU291 cmNlL1dURi93dGYvUnVuTG9vcC5jcHAKQEAgLTI4LDcgKzI4LDYgQEAKIAogI2luY2x1ZGUgPHd0 Zi9OZXZlckRlc3Ryb3llZC5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KLSNpbmNs dWRlIDx3dGYvVGhyZWFkU3BlY2lmaWMuaD4KIAogbmFtZXNwYWNlIFdURiB7CiAKQEAgLTYzLDE0 ICs2MiwxOSBAQCB2b2lkIFJ1bkxvb3A6OmluaXRpYWxpemVNYWluKCkKICAgICBzX21haW5SdW5M b29wID0gJlJ1bkxvb3A6OmN1cnJlbnQoKTsKIH0KIAotUnVuTG9vcCYgUnVuTG9vcDo6Y3VycmVu dCgpCithdXRvIFJ1bkxvb3A6OnJ1bkxvb3BIb2xkZXIoKSAtPiBUaHJlYWRTcGVjaWZpYzxIb2xk ZXI+JgogewogICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8VGhyZWFkU3BlY2lmaWM8SG9s ZGVyPj4gcnVuTG9vcEhvbGRlcjsKICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZUtleTsK ICAgICBzdGQ6OmNhbGxfb25jZShvbmNlS2V5LCBbJl0gewogICAgICAgICBydW5Mb29wSG9sZGVy LmNvbnN0cnVjdCgpOwogICAgIH0pOwotICAgIHJldHVybiBydW5Mb29wSG9sZGVyLmdldCgpLT5y dW5Mb29wKCk7CisgICAgcmV0dXJuIHJ1bkxvb3BIb2xkZXI7Cit9CisKK1J1bkxvb3AmIFJ1bkxv b3A6OmN1cnJlbnQoKQoreworICAgIHJldHVybiBydW5Mb29wSG9sZGVyKCktPnJ1bkxvb3AoKTsK IH0KIAogUnVuTG9vcCYgUnVuTG9vcDo6bWFpbigpCkBAIC0xMDEsNyArMTA1LDggQEAgUnVuTG9v cCogUnVuTG9vcDo6d2ViSWZFeGlzdHMoKQogYm9vbCBSdW5Mb29wOjppc01haW4oKQogewogICAg IEFTU0VSVChzX21haW5SdW5Mb29wKTsKLSAgICByZXR1cm4gc19tYWluUnVuTG9vcCA9PSAmUnVu TG9vcDo6Y3VycmVudCgpOworICAgIC8vIEF2b2lkIGNvbnN0cnVjdGluZyB0aGUgUnVuTG9vcCBm b3IgdGhlIGN1cnJlbnQgdGhyZWFkIGlmIGl0IGhhcyBub3QgYmVlbiBjcmVhdGVkIHlldC4KKyAg ICByZXR1cm4gcnVuTG9vcEhvbGRlcigpLmlzU2V0KCkgJiYgc19tYWluUnVuTG9vcCA9PSAmUnVu TG9vcDo6Y3VycmVudCgpOwogfQogCiB2b2lkIFJ1bkxvb3A6OnBlcmZvcm1Xb3JrKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3AuaCBiL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3Au aAppbmRleCAwNDY2ZDQ0NTlkNmI3NGJjYzFjZTRkODQyMDM3MzY4NzI2MDdjYTM0Li5iODUzZmY5 NTM2NjU5MTYyODllYWYxNjUyOWE3N2E5ZWI3MWI5Y2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9SdW5Mb29wLmgKKysrIGIvU291cmNlL1dURi93dGYvUnVuTG9vcC5oCkBAIC0zNiw2ICsz Niw3IEBACiAjaW5jbHVkZSA8d3RmL09ic2VydmVyLmg+CiAjaW5jbHVkZSA8d3RmL1JldGFpblB0 ci5oPgogI2luY2x1ZGUgPHd0Zi9TZWNvbmRzLmg+CisjaW5jbHVkZSA8d3RmL1RocmVhZFNwZWNp ZmljLmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZGluZ1ByaW1pdGl2ZXMuaD4KICNpbmNsdWRlIDx3 dGYvV2Vha0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KQEAgLTE5 MCw2ICsxOTEsNyBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgY2xhc3MgSG9sZGVyOworICAg IHN0YXRpYyBUaHJlYWRTcGVjaWZpYzxIb2xkZXI+JiBydW5Mb29wSG9sZGVyKCk7CiAKICAgICBj bGFzcyBEaXNwYXRjaFRpbWVyIGZpbmFsIDogcHVibGljIFRpbWVyQmFzZSB7CiAgICAgcHVibGlj Ogo=