223225 2021-03-15 17:19:42 -0700 [prepare-ChangeLog] Assigning a multiline comment to a variable breaks change detection 2021-03-16 09:07:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dean_johnson dean_johnson aakash_jain ap dean_johnson jbedard webkit-bug-importer oldest_to_newest 1739751 0 dean_johnson 2021-03-15 17:19:42 -0700 As of bug 182405 / http://trac.webkit.org/changeset/228131/webkit, prepare-ChangeLog fails to correctly detect changes to a Python file when a multiline comment is defined and assigned to a variable. Failure case: TABLE_CSS_STYLING = ''' <style> ... (Unimportant) ... </style> ''' Changing the TABLE_CSS_STYLING definition makes prepare-ChangeLog work again: TABLE_CSS_STYLING = \ ''' <style> ... (Unimportant) ... </style> ''' prepare-ChangeLog should support multiline string assignment on the same line. 1739765 1 423273 dean_johnson 2021-03-15 17:37:01 -0700 Created attachment 423273 fix-multiline-string-variable-definition_v1 1739963 2 ews-feeder 2021-03-16 09:06:01 -0700 Committed r274481: <https://commits.webkit.org/r274481> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423273. 1739964 3 webkit-bug-importer 2021-03-16 09:07:18 -0700 <rdar://problem/75479145> 423273 2021-03-15 17:37:01 -0700 2021-03-16 09:06:02 -0700 fix-multiline-string-variable-definition_v1 fix-multiline-string-variable-definiion_v1.patch text/plain 3006 dean_johnson ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZjYx YTAzNjk4NjMuLjRmMzMyMjFjMzRkZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTE1ICBEZWFuIEpvaG5z b24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgorCisgICAgICAgIFtwcmVwYXJlLUNoYW5nZUxv Z10gQXNzaWduaW5nIGEgbXVsdGlsaW5lIGNvbW1lbnQgdG8gYSB2YXJpYWJsZSBicmVha3MgY2hh bmdlIGRldGVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIzMjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAoZ2V0X2Z1bmN0aW9u X2xpbmVfcmFuZ2VzX2Zvcl9weXRob24pOiBSZW1vdmUgJ14nIHByZWZpeCBmcm9tIHJlZ2V4IHNv IHdlIG1hdGNoIG11bHRpbGluZQorICAgICAgICBzdHJpbmdzIGFzc2lnbmVkIHRvIHZhcmlhYmxl cy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRl c3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvcHl0 aG9uX3VuaXR0ZXN0cy5weTogQWRkIG11bHRpbGluZSBzdHJpbmcKKyAgICAgICAgdmFyaWFibGUg ZGVmaW5pdGlvbiwgd2hpY2ggcHJldmlvdXNseSB3b3VsZCBjYXVzZSBwcmVwYXJlLUNoYW5nZUxv ZyB0byBwYXJzZSB0aGUgcmVtYWluZGVyIG9mIHRoZSBmaWxlCisgICAgICAgIGFzIGEgbXVsdGls aW5lIGNvbW1lbnQuIEFsc28gYWRkIGEgbmV3IHRlc3QgdG8gZW5zdXJlIGl0J3Mgbm90IHNraXBw ZWQgYnkgbXVsdGlsaW5lIGxvZ2ljLgorICAgICAgICAoQ2xhc3M4Ll9faW5pdF9fKToKKyAgICAg ICAgKENsYXNzOSk6CisKIDIwMjEtMDItMTUgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtld3NdIEFkZCBweXRob24gMyBzdXBwb3J0IC0gcGFydCAyCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvVG9vbHMvU2NyaXB0 cy9wcmVwYXJlLUNoYW5nZUxvZwppbmRleCA4NTJkYzU3MTc5MTMuLjJkNzc0Mzk0MjNhOCAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZworKysgYi9Ub29scy9TY3Jp cHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC0xNzk4LDcgKzE3OTgsNyBAQCBzdWIgZ2V0X2Z1bmN0 aW9uX2xpbmVfcmFuZ2VzX2Zvcl9weXRob24oJCQpCiAgICAgbXkgQHJhbmdlczsKIAogICAgIG15 ICRtdWx0aWxpbmVTdHJpbmdMaXRlcmFsU2VudGluZWxSZWdFeCA9IHFyIyg/OiIiInwnJycpIzsK LSAgICBteSAkbXVsdGlsaW5lU3RyaW5nTGl0ZXJhbFN0YXJ0UmVnRXggPSBxciNeXHMqJG11bHRp bGluZVN0cmluZ0xpdGVyYWxTZW50aW5lbFJlZ0V4IzsKKyAgICBteSAkbXVsdGlsaW5lU3RyaW5n TGl0ZXJhbFN0YXJ0UmVnRXggPSBxciNccyokbXVsdGlsaW5lU3RyaW5nTGl0ZXJhbFNlbnRpbmVs UmVnRXgjOwogICAgIG15ICRtdWx0aWxpbmVTdHJpbmdMaXRlcmFsRW5kUmVnRXggPSBxciMkbXVs dGlsaW5lU3RyaW5nTGl0ZXJhbFNlbnRpbmVsUmVnRXhccyokIzsKIAogICAgIG15IEBzY29wZVN0 YWNrID0gKHsgbGluZSA9PiAwLCBpbmRlbnQgPT4gLTEsIG5hbWUgPT4gdW5kZWYgfSk7CmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRl c3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMtZXhwZWN0ZWQudHh0IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9weXRob25f dW5pdHRlc3RzLWV4cGVjdGVkLnR4dAppbmRleCAzNDkyYWU5NDRmMzMuLjdiNGQ4ZmVhYmIzOSAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3Vu aXR0ZXN0L3Jlc291cmNlcy9weXRob25fdW5pdHRlc3RzLWV4cGVjdGVkLnR4dAorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2Vz L3B5dGhvbl91bml0dGVzdHMtZXhwZWN0ZWQudHh0CkBAIC0xNjksOCArMTY5LDEzIEBACiAgICAg XSwKICAgICBbCiAgICAgICAnMTQyJywKLSAgICAgICcxNDMnLAorICAgICAgJzE0NScsCiAgICAg ICAnQ2xhc3M4Ll9faW5pdF9fJwogICAgIF0sCisgICAgWworICAgICAgJzE1MScsCisgICAgICAn MTUyJywKKyAgICAgICdDbGFzczknCisgICAgXSwKICAgXQogfQpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9w eXRob25fdW5pdHRlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hh bmdlTG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9weXRob25fdW5pdHRlc3RzLnB5CmluZGV4IDA5ZGRk OWY2NWE0OC4uZmU1ZmJmMzY0Y2M2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBl cmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0 ZXN0L3Jlc291cmNlcy9weXRob25fdW5pdHRlc3RzLnB5CkBAIC0xNDEsMyArMTQxLDEyIEBAIGNs YXNzIENsYXNzODoKICAgICAiIiIKICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIHBh c3MKKworCitNVUxUSUxJTkVfU1RSSU5HX1ZBUklBQkxFID0gJycnCitzb21lIHRleHQKK3NvbWUg bW9yZSB0ZXh0CisnJycKKworY2xhc3MgQ2xhc3M5OgorICAgIHBhc3MK