223199 2021-03-15 11:28:21 -0700 Image overlay creation should be idempotent 2021-03-15 15:40:15 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1739545 0 wenson_hsieh 2021-03-15 11:28:21 -0700 . 1739556 1 423207 wenson_hsieh 2021-03-15 11:37:06 -0700 Created attachment 423207 Patch 1739705 2 ews-feeder 2021-03-15 15:39:20 -0700 Committed r274443: <https://commits.webkit.org/r274443> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423207. 1739707 3 webkit-bug-importer 2021-03-15 15:40:15 -0700 <rdar://problem/75451468> 423207 2021-03-15 11:37:06 -0700 2021-03-15 15:39:22 -0700 Patch bug-223199-20210315113705.patch text/plain 5619 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWEyNTBmM2QwYmQ4Mzgx ZjRmZjc2ZDkwNjEzOTBkMDg3NTU5ZDBlNC4uMDIxYmE1YWNkNmE1MDljNjQ4ZGVmM2RlMjIzZGZk MDg5ZmRkOTdkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAzLTE1ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEltYWdlIG92ZXJs YXkgY3JlYXRpb24gc2hvdWxkIGJlIGlkZW1wb3RlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzE5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0aGF0IGB1cGRhdGVXaXRoSW1hZ2VF eHRyYWN0aW9uUmVzdWx0YCBpcyBpZGVtcG90ZW50IGdpdmVuIHRoZSBzYW1lIHJlc3VsdHMgb2Jq ZWN0LCBhbmQgZG9lcyBub3QKKyAgICAgICAgaW5qZWN0IHJlZHVuZGFudCBzdHlsZXMgb3IgRE9N IGVsZW1lbnRzIGluIHRoZSB1c2VyIGFnZW50IHNoYWRvdyByb290LgorCisgICAgICAgIFRlc3Q6 IGZhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vaW1hZ2Utb3ZlcmxheS1jcmVhdGlvbi1pcy1p ZGVtcG90ZW50Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTEVsZW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6OnVwZGF0ZVdpdGhJbWFnZUV4dHJhY3Rpb25SZXN1bHQp OgorCisgICAgICAgIFdoZW4gdXBkYXRpbmcgdGhlIGltYWdlIG92ZXJsYXksIHJlbW92ZSB0aGUg ZXhpc3Rpbmcgb3ZlcmxheSBjb250YWluZXIgZWxlbWVudCBpZiBuZWVkZWQsIGFuZCBkb24ndCBi b3RoZXIKKyAgICAgICAgcmUtaW5qZWN0aW5nIHRoZSBzdHlsZSBzaGVldCBpZiBpdCBoYXMgYWxy ZWFkeSBiZWVuIGNyZWF0ZWQgYW5kIGluc2VydGVkLgorCiAyMDIxLTAzLTE1ICBaYWxhbiBCdWp0 YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml0LWJvcmRlci10by1saW5lIG1heSBj aGFuZ2UgdGhlIGxheW91dCBjb25zdHJhaW50cyBiZXR3ZWVuIDIgcGFnaW5hdGVkIGxpbmUgbGF5 b3V0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAppbmRleCA0MmNmOWFlYzM3ZmZkODZi M2VmYTI5YjYyYWYwMmUwYThlZjc1YmRjLi4xNWRiNDNjMWQzNTRjNTM5M2M2NzNhMjM0ZmNhMDQx NmU2N2NmOWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcApAQCAtMTI1Niw2ICsx MjU2LDIwIEBAIGJvb2wgSFRNTEVsZW1lbnQ6OmlzSW1hZ2VPdmVybGF5VGV4dChjb25zdCBOb2Rl JiBub2RlKQogCiB2b2lkIEhUTUxFbGVtZW50Ojp1cGRhdGVXaXRoSW1hZ2VFeHRyYWN0aW9uUmVz dWx0KEltYWdlRXh0cmFjdGlvblJlc3VsdCYmIHJlc3VsdCkKIHsKKyAgICBSZWZQdHI8SFRNTERp dkVsZW1lbnQ+IHByZXZpb3VzQ29udGFpbmVyOworICAgIGlmIChhdXRvIHNoYWRvd1Jvb3QgPSB1 c2VyQWdlbnRTaGFkb3dSb290KCk7IHNoYWRvd1Jvb3QgJiYgaGFzSW1hZ2VPdmVybGF5KCkpIHsK KyAgICAgICAgZm9yIChhdXRvJiBjaGlsZCA6IGNoaWxkcmVuT2ZUeXBlPEhUTUxEaXZFbGVtZW50 Pigqc2hhZG93Um9vdCkpIHsKKyAgICAgICAgICAgIGlmIChjaGlsZC5nZXRJZEF0dHJpYnV0ZSgp ID09IGltYWdlT3ZlcmxheUVsZW1lbnRJZGVudGlmaWVyKCkpIHsKKyAgICAgICAgICAgICAgICBw cmV2aW91c0NvbnRhaW5lciA9ICZjaGlsZDsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgICAgIH0KKyAgICAgICAgfQorICAgICAgICBpZiAocHJldmlvdXNDb250YWluZXIpCisgICAg ICAgICAgICBwcmV2aW91c0NvbnRhaW5lci0+cmVtb3ZlKCk7CisgICAgICAgIGVsc2UKKyAgICAg ICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIH0KKwogICAgIGlmIChyZXN1bHQuaXNF bXB0eSgpKQogICAgICAgICByZXR1cm47CiAKQEAgLTEyNjYsMTIgKzEyODAsMTMgQEAgdm9pZCBI VE1MRWxlbWVudDo6dXBkYXRlV2l0aEltYWdlRXh0cmFjdGlvblJlc3VsdChJbWFnZUV4dHJhY3Rp b25SZXN1bHQmJiByZXN1bHQKICAgICAgICAgZG93bmNhc3Q8UmVuZGVySW1hZ2U+KCpyZW5kZXJl cikuc2V0SGFzSW1hZ2VPdmVybGF5KCk7CiAgICAgfQogCi0gICAgc3RhdGljIE5ldmVyRGVzdHJv eWVkPGNvbnN0IFN0cmluZz4gc2hhZG93U3R5bGUoaW1hZ2VPdmVybGF5VXNlckFnZW50U3R5bGVT aGVldCwgU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCk7Ci0gICAgYXV0byBzdHlsZSA9IEhU TUxTdHlsZUVsZW1lbnQ6OmNyZWF0ZShIVE1MTmFtZXM6OnN0eWxlVGFnLCBkb2N1bWVudCgpLCBm YWxzZSk7Ci0gICAgc3R5bGUtPnNldFRleHRDb250ZW50KHNoYWRvd1N0eWxlKTsKLQogICAgIGF1 dG8gc2hhZG93Um9vdCA9IG1ha2VSZWYoZW5zdXJlVXNlckFnZW50U2hhZG93Um9vdCgpKTsKLSAg ICBzaGFkb3dSb290LT5hcHBlbmRDaGlsZChXVEZNb3ZlKHN0eWxlKSk7CisgICAgaWYgKCFwcmV2 aW91c0NvbnRhaW5lcikgeworICAgICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3Ry aW5nPiBzaGFkb3dTdHlsZShpbWFnZU92ZXJsYXlVc2VyQWdlbnRTdHlsZVNoZWV0LCBTdHJpbmc6 OkNvbnN0cnVjdEZyb21MaXRlcmFsKTsKKyAgICAgICAgYXV0byBzdHlsZSA9IEhUTUxTdHlsZUVs ZW1lbnQ6OmNyZWF0ZShIVE1MTmFtZXM6OnN0eWxlVGFnLCBkb2N1bWVudCgpLCBmYWxzZSk7Cisg ICAgICAgIHN0eWxlLT5zZXRUZXh0Q29udGVudChzaGFkb3dTdHlsZSk7CisgICAgICAgIHNoYWRv d1Jvb3QtPmFwcGVuZENoaWxkKFdURk1vdmUoc3R5bGUpKTsKKyAgICB9CiAKICAgICBhdXRvIGNv bnRhaW5lciA9IEhUTUxEaXZFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQoKSk7CiAgICAgY29udGFp bmVyLT5zZXRJZEF0dHJpYnV0ZShpbWFnZU92ZXJsYXlFbGVtZW50SWRlbnRpZmllcigpKTsKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCAwNjUxNzU1OWVkY2MyOTc2YzVmOWVhM2MzM2IxMjRhNGM2YmQ3OGFlLi4zNTY0Mjg2Y2Iy OGFlYjFmYzMzYzI5OGZhZjZjMDNlOWY0M2Q2OGM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjEtMDMtMTUgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAg ICAgSW1hZ2Ugb3ZlcmxheSBjcmVhdGlvbiBzaG91bGQgYmUgaWRlbXBvdGVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzMTk5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2ltYWdlcy9pbWFn ZS1leHRyYWN0aW9uL2ltYWdlLW92ZXJsYXktY3JlYXRpb24taXMtaWRlbXBvdGVudC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vaW1h Z2Utb3ZlcmxheS1jcmVhdGlvbi1pcy1pZGVtcG90ZW50Lmh0bWw6IEFkZGVkLgorCiAyMDIxLTAz LTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml0LWJvcmRl ci10by1saW5lIG1heSBjaGFuZ2UgdGhlIGxheW91dCBjb25zdHJhaW50cyBiZXR3ZWVuIDIgcGFn aW5hdGVkIGxpbmUgbGF5b3V0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMv aW1hZ2UtZXh0cmFjdGlvbi9pbWFnZS1vdmVybGF5LWNyZWF0aW9uLWlzLWlkZW1wb3RlbnQtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvaW1hZ2UtZXh0cmFjdGlvbi9pbWFn ZS1vdmVybGF5LWNyZWF0aW9uLWlzLWlkZW1wb3RlbnQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjBjNWU2NzMwNWExMDA5Njc3NzJlZjk3MmI1Y2YyNmNkOGRhMTBkNTMKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9pbWFnZS1leHRyYWN0aW9uL2ltYWdlLW92ZXJs YXktY3JlYXRpb24taXMtaWRlbXBvdGVudC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1IEBACitQ QVNTIGludGVybmFscy5zaGFkb3dSb290KGltYWdlKS5jaGlsZEVsZW1lbnRDb3VudCBpcyAyCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvaW1hZ2UtZXh0cmFjdGlvbi9pbWFnZS1vdmVy bGF5LWNyZWF0aW9uLWlzLWlkZW1wb3RlbnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2Vz L2ltYWdlLWV4dHJhY3Rpb24vaW1hZ2Utb3ZlcmxheS1jcmVhdGlvbi1pcy1pZGVtcG90ZW50Lmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNWRjOTA4NGIyM2NlYzJlYjdlNmY4ZDhjYTBlYmUwOTZhNTZmNjE5Mgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rp b24vaW1hZ2Utb3ZlcmxheS1jcmVhdGlvbi1pcy1pZGVtcG90ZW50Lmh0bWwKQEAgLTAsMCArMSwy MiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNv dXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8Ym9keT4KKzxpbWcgc3JjPSIuLi9yZXNvdXJj ZXMvZ3JlZW4tNDAweDQwMC5wbmciPjwvaW1nPgorPHNjcmlwdD4KK2FkZEV2ZW50TGlzdGVuZXIo ImxvYWQiLCAoKSA9PiB7CisgICAgaW1hZ2UgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJpbWci KTsKKyAgICBmb3IgKGxldCBpID0gMDsgaSA8IDEwOyArK2kpIHsKKyAgICAgICAgaW50ZXJuYWxz Lmluc3RhbGxJbWFnZU92ZXJsYXkoaW1hZ2UsIFt7CisgICAgICAgICAgICB0ZXh0IDogIkhlbGxv IiwKKyAgICAgICAgICAgIHRvcExlZnQgOiBuZXcgRE9NUG9pbnRSZWFkT25seSgwLjUsIDAuNSks CisgICAgICAgICAgICB0b3BSaWdodCA6IG5ldyBET01Qb2ludFJlYWRPbmx5KDEsIDAuNSksCisg ICAgICAgICAgICBib3R0b21SaWdodCA6IG5ldyBET01Qb2ludFJlYWRPbmx5KDEsIDEpLAorICAg ICAgICAgICAgYm90dG9tTGVmdCA6IG5ldyBET01Qb2ludFJlYWRPbmx5KDAuNSwgMSksCisgICAg ICAgIH1dKTsKKyAgICB9CisgICAgc2hvdWxkQmUoImludGVybmFscy5zaGFkb3dSb290KGltYWdl KS5jaGlsZEVsZW1lbnRDb3VudCIsICIyIik7Cit9KTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK