223197 2021-03-15 11:23:27 -0700 Avoid doing a heap allocation in AudioParam::calculateFinalValues() on the audio thread 2021-03-15 12:51:29 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1739541 0 cdumez 2021-03-15 11:23:27 -0700 Avoid doing a heap allocation in AudioParam::calculateFinalValues() on the audio thread, for performance reasons. 1739542 1 cdumez 2021-03-15 11:23:45 -0700 <rdar://60700260> 1739555 2 423206 cdumez 2021-03-15 11:33:23 -0700 Created attachment 423206 Patch 1739611 3 ews-feeder 2021-03-15 12:51:26 -0700 Committed r274432: <https://commits.webkit.org/r274432> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423206. 423206 2021-03-15 11:33:23 -0700 2021-03-15 12:51:27 -0700 Patch bug-223197-20210315113323.patch text/plain 3568 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2MwMmFlMWNjNGQ1NzM3 NWU3MTkzY2ZkZTkwMjNhYWFmMGY1OTBkZC4uZjBhNGUxMTJhNzk4ZTJjNjBlNDI3MzNiMTA4M2I5 NmQwZjE5ZDg1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgZG9pbmcgYSBoZWFw IGFsbG9jYXRpb24gaW4gQXVkaW9QYXJhbTo6Y2FsY3VsYXRlRmluYWxWYWx1ZXMoKSBvbiB0aGUg YXVkaW8gdGhyZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjMxOTcKKyAgICAgICAgPHJkYXI6Ly82MDcwMDI2MD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCBkb2luZyBhIGhlYXAgYWxsb2Nh dGlvbiBpbiBBdWRpb1BhcmFtOjpjYWxjdWxhdGVGaW5hbFZhbHVlcygpIG9uIHRoZSBhdWRpbyB0 aHJlYWQsIGZvcgorICAgICAgICBwZXJmb3JtYW5jZSByZWFzb25zLgorCisgICAgICAgICogTW9k dWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvUGFy YW06OkF1ZGlvUGFyYW0pOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9QYXJhbTo6Y2FsY3VsYXRl RmluYWxWYWx1ZXMpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5oOgor CiAyMDIxLTAzLTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg U3RvcCBjYWxsaW5nIFtOU0hUVFBDb29raWVTdG9yYWdlIHNoYXJlZEhUVFBDb29raWVTdG9yYWdl XSBpbiB0aGUgV2ViUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9BdWRpb1BhcmFtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8v QXVkaW9QYXJhbS5jcHAKaW5kZXggMzU5ODQ3ZDc3ZDM5MDk2NDA1ZTcxMTUzOTM3Y2VmMDdiYWE1 OGU0Yy4uOGRkZDg2YzY0MTNhMzFkMmExMDk0MzUyNjAzYjIwOTYyMmY2YWZkNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uY3BwCkBAIC00OSw2ICs0 OSw3IEBAIEF1ZGlvUGFyYW06OkF1ZGlvUGFyYW0oQmFzZUF1ZGlvQ29udGV4dCYgY29udGV4dCwg Y29uc3QgU3RyaW5nJiBuYW1lLCBmbG9hdCBkZWZhCiAgICAgLCBtX2F1dG9tYXRpb25SYXRlKGF1 dG9tYXRpb25SYXRlKQogICAgICwgbV9hdXRvbWF0aW9uUmF0ZU1vZGUoYXV0b21hdGlvblJhdGVN b2RlKQogICAgICwgbV9zbW9vdGhlZFZhbHVlKGRlZmF1bHRWYWx1ZSkKKyAgICAsIG1fc3VtbWlu Z0J1cyhBdWRpb0J1czo6Y3JlYXRlKDEsIEF1ZGlvVXRpbGl0aWVzOjpyZW5kZXJRdWFudHVtU2l6 ZSwgZmFsc2UpLnJlbGVhc2VOb25OdWxsKCkpCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECiAg ICAgLCBtX2xvZ2dlcihjb250ZXh0LmxvZ2dlcigpKQogICAgICwgbV9sb2dJZGVudGlmaWVyKGNv bnRleHQubmV4dEF1ZGlvUGFyYW1ldGVyTG9nSWRlbnRpZmllcigpKQpAQCAtMjc0LDEyICsyNzUs MTEgQEAgdm9pZCBBdWRpb1BhcmFtOjpjYWxjdWxhdGVGaW5hbFZhbHVlcyhmbG9hdCogdmFsdWVz LCB1bnNpZ25lZCBudW1iZXJPZlZhbHVlcywgYm8KIAogICAgIC8vIE5vdyBzdW0gYWxsIG9mIHRo ZSBhdWRpby1yYXRlIGNvbm5lY3Rpb25zIHRvZ2V0aGVyICh1bml0eS1nYWluIHN1bW1pbmcganVu Y3Rpb24pLgogICAgIC8vIE5vdGUgdGhhdCBjb25uZWN0aW9ucyB3b3VsZCBub3JtYWxseSBiZSBt b25vLCBidXQgd2UgbWl4IGRvd24gdG8gbW9ubyBpZiBuZWNlc3NhcnkuCi0gICAgYXV0byBzdW1t aW5nQnVzID0gQXVkaW9CdXM6OmNyZWF0ZSgxLCBudW1iZXJPZlZhbHVlcywgZmFsc2UpOwotCiAg ICAgLy8gSWYgd2UncmUgbm90IHNhbXBsZSBhY2N1cmF0ZSwgd2Ugb25seSBuZWVkIG9uZSB2YWx1 ZSwgc28gbWFrZSB0aGUgc3VtbWluZwogICAgIC8vIGJ1cyBoYXZlIGxlbmd0aCAxLiBXaGVuIHRo ZSBjb25uZWN0aW9ucyBhcmUgYWRkZWQgaW4sIG9ubHkgdGhlIGZpcnN0CiAgICAgLy8gdmFsdWUg d2lsbCBiZSBhZGRlZC4gV2hpY2ggaXMgZXhhY3RseSB3aGF0IHdlIHdhbnQuCi0gICAgc3VtbWlu Z0J1cy0+c2V0Q2hhbm5lbE1lbW9yeSgwLCB2YWx1ZXMsIHNhbXBsZUFjY3VyYXRlID8gbnVtYmVy T2ZWYWx1ZXMgOiAxKTsKKyAgICBBU1NFUlQobnVtYmVyT2ZWYWx1ZXMgPD0gQXVkaW9VdGlsaXRp ZXM6OnJlbmRlclF1YW50dW1TaXplKTsKKyAgICBtX3N1bW1pbmdCdXMtPnNldENoYW5uZWxNZW1v cnkoMCwgdmFsdWVzLCBzYW1wbGVBY2N1cmF0ZSA/IG51bWJlck9mVmFsdWVzIDogMSk7CiAKICAg ICBmb3IgKGF1dG8mIG91dHB1dCA6IG1fcmVuZGVyaW5nT3V0cHV0cykgewogICAgICAgICBBU1NF UlQob3V0cHV0KTsKQEAgLTI4OCw3ICsyODgsNyBAQCB2b2lkIEF1ZGlvUGFyYW06OmNhbGN1bGF0 ZUZpbmFsVmFsdWVzKGZsb2F0KiB2YWx1ZXMsIHVuc2lnbmVkIG51bWJlck9mVmFsdWVzLCBibwog ICAgICAgICBBdWRpb0J1cyogY29ubmVjdGlvbkJ1cyA9IG91dHB1dC0+cHVsbCgwLCBBdWRpb1V0 aWxpdGllczo6cmVuZGVyUXVhbnR1bVNpemUpOwogCiAgICAgICAgIC8vIFN1bSwgd2l0aCB1bml0 eS1nYWluLgotICAgICAgICBzdW1taW5nQnVzLT5zdW1Gcm9tKCpjb25uZWN0aW9uQnVzKTsKKyAg ICAgICAgbV9zdW1taW5nQnVzLT5zdW1Gcm9tKCpjb25uZWN0aW9uQnVzKTsKICAgICB9CiAKICAg ICAvLyBJZiB3ZSdyZSBub3Qgc2FtcGxlIGFjY3VyYXRlLCBkdXBsaWNhdGUgdGhlIGZpcnN0IGVs ZW1lbnQgb2YgfHZhbHVlc3wgdG8gYWxsIG9mIHRoZSBlbGVtZW50cy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtLmgKaW5kZXggNzYwY2I3YzY4ZTk5MTQyYzY1 MmJmMjY3Yjk4OGI5YmNlM2I3MjU2OS4uZjllMzI0ZTIxMjY3YTAxNDhkYjdiNzZjOWJjNzdiMGZl NjAwOGJhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRp b1BhcmFtLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1BhcmFt LmgKQEAgLTE0Myw2ICsxNDMsNyBAQCBwcml2YXRlOgogICAgIGZsb2F0IG1fc21vb3RoZWRWYWx1 ZTsKICAgICAKICAgICBBdWRpb1BhcmFtVGltZWxpbmUgbV90aW1lbGluZTsKKyAgICBSZWY8QXVk aW9CdXM+IG1fc3VtbWluZ0J1czsKIAogI2lmICFSRUxFQVNFX0xPR19ESVNBQkxFRAogICAgIG11 dGFibGUgUmVmPGNvbnN0IExvZ2dlcj4gbV9sb2dnZXI7Cg==