223173 2021-03-15 00:42:53 -0700 Use references instead of pointers as animation wrapper function arguments in CSSPropertyAnimation.cpp 2021-04-12 13:12:23 -0700 1 1 1 Unclassified WebKit Animations Safari Technology Preview Unspecified Unspecified RESOLVED DUPLICATE 224433 https://bugs.webkit.org/show_bug.cgi?id=223148 InRadar P2 Normal --- 1 graouts webkit-unassigned darin dino graouts sam webkit-bug-importer oldest_to_newest 1739319 0 graouts 2021-03-15 00:42:53 -0700 This is a followup to bug 223148 to address some additional review feedback that Darin Adler provided. 1739340 1 graouts 2021-03-15 03:09:41 -0700 Actually, looking at the code again: double aspectRatioDst = WebCore::blend(log(a->logicalAspectRatio()), log(b->logicalAspectRatio()), progress); dst->setAspectRatio(exp(aspectRatioDst), 1); dst->setAspectRatioType(progress < 0.5 ? a->aspectRatioType() : b->aspectRatioType()); Since in the discrete case the progress is either 0 or 1, I think the blend function could be just those three lines. While it's a bit extra work to actually blend the values when we know it'll be one or the other, it simplifies the logic. That assumes that canInterpolate() will correctly identify all cases where the animation should be discrete, which is its contract. 1739343 2 graouts 2021-03-15 03:12:46 -0700 Don't mind this last comment, it was mistakenly typed in this bug rather than bug 220848. 1739469 3 ap 2021-03-15 09:12:29 -0700 *** Bug 223172 has been marked as a duplicate of this bug. *** 1742180 4 webkit-bug-importer 2021-03-22 04:35:57 -0700 <rdar://problem/75685299> 1749347 5 graouts 2021-04-12 13:12:23 -0700 Will address this in a larger refactor in bug 224433. *** This bug has been marked as a duplicate of bug 224433 ***