22314 2008-11-17 09:13:35 -0800 Adopt check-for-global-initializers on Windows 2016-07-28 12:58:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP NEW https://bugs.webkit.org/show_bug.cgi?id=22315 https://bugs.webkit.org/show_bug.cgi?id=160302 P2 Normal --- 1 aroben webkit-unassigned bfulgham darin ddkilzer pvollan oldest_to_newest 99050 0 aroben 2008-11-17 09:13:35 -0800 It would be good to adopt the check-for-global-initializers script on Windows. I've done a little investigation into what would have to change in the script to make it work on Windows. Here's what I've come up with (based on <http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/check-for-global-initializers?rev=38440>): 1. Use of Xcode-specific environment variables We can either set similar variables on Windows or pass the relevant values as parameters. 2. Use of a "link file list" We can get the list of object files linked into the executable by using "dumpbin.exe /archivemembers". 3. Searching for "__GLOBAL__I" to indicate a global initializer On Windows, global initializers are indicated by "symbol$initializer$", where "symbol" is the symbol being initialized. 4. List of files to skip uses .o extension On Windows, these files have a .obj extension. We could just use the part of the filename before the extension instead. 99055 1 aroben 2008-11-17 09:17:04 -0800 See bug 22315 about adopting check-for-exit-time-destructors as well. 1215344 2 ddkilzer 2016-07-28 12:58:32 -0700 NOTE: Bug 160302 is going to remove these scripts. However, I think the scripts would have had to use different tools to make them work on Windows. (Maybe MSVC++ has a switch similar to -Wglobal-constructors instead?)