223138 2021-03-12 13:32:10 -0800 AX: PDF frame conversion routines need to be updated 2021-03-12 18:26:54 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach darin webkit-bug-importer oldest_to_newest 1739012 0 cfleizach 2021-03-12 13:32:10 -0800 PDF bounding boxes are wrong in WebKit because 1) there's no way for PDF objects to get the primary screen height 2) the PDFPluginAXObject's position is not being converted correctly <rdar://75368260> 1739014 1 423078 cfleizach 2021-03-12 13:34:42 -0800 Created attachment 423078 patch 1739089 2 ews-feeder 2021-03-12 18:26:53 -0800 Committed r274377: <https://commits.webkit.org/r274377> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423078. 423078 2021-03-12 13:34:42 -0800 2021-03-12 18:26:54 -0800 patch file_223138.txt text/plain 4104 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cNCmluZGV4IDg5ZTg2MzI4ZjZmZS4uZDFhMmM2YzU3ZDFmIDEwMDY0NA0KLS0tIGEvU291 cmNlL1dlYktpdC9DaGFuZ2VMb2cNCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nDQpAQCAt MSwzICsxLDIyIEBADQorMjAyMS0wMy0xMiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBw bGUuY29tPg0KKw0KKyAgICAgICAgQVg6IFBERiBmcmFtZSBjb252ZXJzaW9uIHJvdXRpbmVzIG5l ZWQgdG8gYmUgdXBkYXRlZA0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyMzEzOA0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku DQorDQorICAgICAgICBQREYgYm91bmRpbmcgYm94ZXMgYXJlIHdyb25nIGluIFdlYktpdCBiZWNh dXNlLg0KKyAgICAgICAgICAxKSBUaGVyZSdzIG5vIHdheSBmb3IgUERGIG9iamVjdHMgdG8gZ2V0 IHRoZSBwcmltYXJ5IHNjcmVlbiBoZWlnaHQuIFNvIHdlIG5lZWQgdG8gYmUgYWJsZSB0byByZXR1 cm4gdGhlIHByaW1hcnkNCisgICAgICAgICAgICAgc2NyZWVuIGhlaWdodCBmcm9tIGFuIG9iamVj dCBpbiB0aGUgUERGIGhpZXJhcmNoeS4NCisgICAgICAgICAgMikgVGhlIFdLUERGUGx1Z2luQWNj ZXNzaWJpbGl0eU9iamVjdCdzIHBvc2l0aW9uIHdhcyBub3QgYmVpbmcgY29udmVydGVkIGNvcnJl Y3RseS4NCisNCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW06 DQorICAgICAgICAoLVtXS1BERlBsdWdpbkFjY2Vzc2liaWxpdHlPYmplY3QgYWNjZXNzaWJpbGl0 eUF0dHJpYnV0ZVZhbHVlOl0pOg0KKyAgICAgICAgKC1bV0tQREZQbHVnaW5BY2Nlc3NpYmlsaXR5 T2JqZWN0IEFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0VORF0pOg0KKyAgICAgICAg KFdlYktpdDo6UERGUGx1Z2luOjpib3VuZHNPblNjcmVlbiBjb25zdCk6DQorICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9tYWMvV0tBY2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdE1hYy5tbToN CisgICAgICAgICgtW1dLQWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3QgYWNjZXNzaWJpbGl0eUF0 dHJpYnV0ZVZhbHVlOl0pOg0KKw0KIDIwMjEtMDMtMTIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4NCiANCiAgICAgICAgIFJlZHVjZSBtYXhpbXVtIEhhc2hUYWJs ZSBlbnRyeSBzaXplIHRvIDQwMCBieXRlcw0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tDQppbmRleCBhZThhNGRmYWY3NWUuLmYyMzQ4Zjg1 MjRlOSAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0NCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0NCkBAIC0yMjYsNiArMjI2LDggQEAgQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1F TlRBVElPTlNfRU5EDQogICAgICAgICByZXR1cm4gQFsgX3BkZkxheWVyQ29udHJvbGxlciBdOw0K ICAgICBpZiAoW2F0dHJpYnV0ZSBpc0VxdWFsVG9TdHJpbmc6TlNBY2Nlc3NpYmlsaXR5Um9sZUF0 dHJpYnV0ZV0pDQogICAgICAgICByZXR1cm4gTlNBY2Nlc3NpYmlsaXR5R3JvdXBSb2xlOw0KKyAg ICBpZiAoW2F0dHJpYnV0ZSBpc0VxdWFsVG9TdHJpbmc6TlNBY2Nlc3NpYmlsaXR5UHJpbWFyeVNj cmVlbkhlaWdodEF0dHJpYnV0ZV0pDQorICAgICAgICByZXR1cm4gW19wYXJlbnQgYWNjZXNzaWJp bGl0eUF0dHJpYnV0ZVZhbHVlOk5TQWNjZXNzaWJpbGl0eVByaW1hcnlTY3JlZW5IZWlnaHRBdHRy aWJ1dGVdOw0KIA0KICAgICByZXR1cm4gMDsNCiB9DQpAQCAtMjY5LDcgKzI3MSw4IEBAIEFMTE9X X0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0VORA0KICAgICAgICAgTlNBY2Nlc3NpYmlsaXR5 UG9zaXRpb25BdHRyaWJ1dGUsDQogICAgICAgICBOU0FjY2Vzc2liaWxpdHlGb2N1c2VkQXR0cmli dXRlLA0KICAgICAgICAgLy8gUERGTGF5ZXJDb250cm9sbGVyIGhhcyBpdHMgb3duIGFjY2Vzc2li aWxpdHlDaGlsZHJlbi4NCi0gICAgICAgIE5TQWNjZXNzaWJpbGl0eUNoaWxkcmVuQXR0cmlidXRl DQorICAgICAgICBOU0FjY2Vzc2liaWxpdHlDaGlsZHJlbkF0dHJpYnV0ZSwNCisgICAgICAgIE5T QWNjZXNzaWJpbGl0eVByaW1hcnlTY3JlZW5IZWlnaHRBdHRyaWJ1dGUNCiAgICAgXTsNCiANCiAg ICAgcmV0dXJuIGF0dHJpYnV0ZU5hbWVzLmdldCgpLmdldCgpOw0KQEAgLTIwNDksNyArMjA1Miwx MCBAQCBJbnRSZWN0IFBERlBsdWdpbjo6Ym91bmRzT25TY3JlZW4oKSBjb25zdA0KIA0KICAgICBG bG9hdFJlY3QgYm91bmRzID0gRmxvYXRSZWN0KEZsb2F0UG9pbnQoKSwgc2l6ZSgpKTsNCiAgICAg RmxvYXRSZWN0IHJlY3RJblJvb3RWaWV3Q29vcmRpbmF0ZXMgPSBtX3Jvb3RWaWV3VG9QbHVnaW5U cmFuc2Zvcm0uaW52ZXJzZSgpLnZhbHVlT3IoQWZmaW5lVHJhbnNmb3JtKCkpLm1hcFJlY3QoYm91 bmRzKTsNCi0gICAgcmV0dXJuIGZyYW1lVmlldy0+Y29udGVudHNUb1NjcmVlbihlbmNsb3NpbmdJ bnRSZWN0KHJlY3RJblJvb3RWaWV3Q29vcmRpbmF0ZXMpKTsNCisgICAgYXV0byogcGFnZSA9IG1f ZnJhbWUtPmNvcmVGcmFtZSgpLT5wYWdlKCk7DQorICAgIGlmICghcGFnZSkNCisgICAgICAgIHJl dHVybiB7IH07DQorICAgIHJldHVybiBwYWdlLT5jaHJvbWUoKS5yb290Vmlld1RvU2NyZWVuKGVu Y2xvc2luZ0ludFJlY3QocmVjdEluUm9vdFZpZXdDb29yZGluYXRlcykpOw0KIH0NCiANCiB2b2lk IFBERlBsdWdpbjo6dmlzaWJpbGl0eURpZENoYW5nZShib29sIHZpc2libGUpDQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dLQWNjZXNzaWJpbGl0eVdl YlBhZ2VPYmplY3RNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMv V0tBY2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdE1hYy5tbQ0KaW5kZXggMGI5NGE0NjE0NTg1Li4y OTZlMjI5MjZkZWQgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvV0tBY2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdE1hYy5tbQ0KKysrIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dLQWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3RN YWMubW0NCkBAIC00Miw2ICs0Miw3IEBADQogI2ltcG9ydCA8V2ViQ29yZS9GcmFtZVZpZXcuaD4N CiAjaW1wb3J0IDxXZWJDb3JlL1BhZ2UuaD4NCiAjaW1wb3J0IDxXZWJDb3JlL1BhZ2VPdmVybGF5 Q29udHJvbGxlci5oPg0KKyNpbXBvcnQgPFdlYkNvcmUvUGxhdGZvcm1TY3JlZW4uaD4NCiAjaW1w b3J0IDxXZWJDb3JlL1Njcm9sbFZpZXcuaD4NCiAjaW1wb3J0IDxXZWJDb3JlL1Njcm9sbGJhci5o Pg0KICNpbXBvcnQgPFdlYkNvcmUvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMuaD4N CkBAIC0xODQsNyArMTg1LDcgQEAgQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElPTlNfRU5E DQogICAgICAgICByZXR1cm4gW3NlbGYgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVBvc2l0aW9uVmFs dWVdOw0KICAgICANCiAgICAgaWYgKFthdHRyaWJ1dGUgaXNFcXVhbFRvU3RyaW5nOk5TQWNjZXNz aWJpbGl0eVByaW1hcnlTY3JlZW5IZWlnaHRBdHRyaWJ1dGVdKQ0KLSAgICAgICAgcmV0dXJuIFtb c2VsZiBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXJdIGFjY2Vzc2liaWxpdHlBdHRyaWJ1 dGVWYWx1ZTphdHRyaWJ1dGVdOw0KKyAgICAgICAgcmV0dXJuIEAoV2ViQ29yZTo6c2NyZWVuUmVj dEZvclByaW1hcnlTY3JlZW4oKS5zaXplKCkuaGVpZ2h0KCkpOw0KICAgICANCiAgICAgaWYgKFth dHRyaWJ1dGUgaXNFcXVhbFRvU3RyaW5nOk5TQWNjZXNzaWJpbGl0eVNpemVBdHRyaWJ1dGVdKQ0K ICAgICAgICAgcmV0dXJuIFtzZWxmIGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVTaXplVmFsdWVdOw0K