223137 2021-03-12 13:07:54 -0800 move LayoutTestFinder.split_into_chunks to Manager 2021-03-13 19:23:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gsnedders gsnedders ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1739005 0 gsnedders 2021-03-12 13:07:54 -0800 move LayoutTestFinder.split_into_chunks to Manager 1739007 1 423077 gsnedders 2021-03-12 13:10:32 -0800 Created attachment 423077 Patch 1739009 2 423077 jbedard 2021-03-12 13:16:31 -0800 Comment on attachment 423077 Patch r=me, although I think we want to see a layout test run succeed to EWS before sending this to commit queue 1739193 3 ews-feeder 2021-03-13 19:22:23 -0800 Committed r274394: <https://commits.webkit.org/r274394> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423077. 1739194 4 webkit-bug-importer 2021-03-13 19:23:13 -0800 <rdar://problem/75400492> 423077 2021-03-12 13:10:32 -0800 2021-03-13 19:22:23 -0800 Patch bug-223137-20210312211031.patch text/plain 7651 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MjIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTQ3MmViYjQ1ZTRlNzBlZjFmZjU0YzhhMzFjOTZiZTk0 NTA3OWYwMi4uNjkyNWQ0NDJjNjUxNWUwNTI1OGNlOGE3YzMwNTVhY2QwYTM1ZGQ4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTAzLTEyICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAg ICAgICAgTW92ZSBMYXlvdXRUZXN0RmluZGVyLnNwbGl0X2ludG9fY2h1bmtzIHRvIE1hbmFnZXIu X3NwbGl0X2ludG9fY2h1bmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjMxMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL2xh eW91dF90ZXN0X2ZpbmRlci5weToKKyAgICAgICAgKExheW91dFRlc3RGaW5kZXIuc3BsaXRfaW50 b19jaHVua3MpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRy b2xsZXJzL21hbmFnZXIucHk6CisgICAgICAgIChNYW5hZ2VyLl9zcGxpdF9pbnRvX2NodW5rcyk6 CisgICAgICAgIChNYW5hZ2VyLl9wcmVwYXJlX2xpc3RzKToKKwogMjAyMS0wMy0xMCAgU2FtIFNu ZWRkb24gIDxnc25lZGRlcnNAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGluZyBQeXRob24gdHlw ZSBhbm5vdGF0aW9ucyB0byB0ZXN0X2V4cGVjdGF0aW9ucy5weQpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5b3V0X3Rlc3RfZmlu ZGVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMv bGF5b3V0X3Rlc3RfZmluZGVyLnB5CmluZGV4IDRmNDAzNzNlNmJhZjE1MTE4NjE3ZWNlZmU3YWE5 MGRkOWY3MWYwZTcuLmEzY2I3NmFiNzRkOWY5Y2I2ZGE1MGVlNzAyYjg1YjNiMzkwNzkwZTUgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJz L2xheW91dF90ZXN0X2ZpbmRlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9jb250cm9sbGVycy9sYXlvdXRfdGVzdF9maW5kZXIucHkKQEAgLTE4OSw2MiArMTg5 LDMgQEAgY2xhc3MgTGF5b3V0VGVzdEZpbmRlcihvYmplY3QpOgogICAgICAgICAgICAgcmV0dXJu IE5vbmUKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJldHVybiBsaW5lCi0KLSAgICBkZWYg c3BsaXRfaW50b19jaHVua3Moc2VsZiwgdGVzdF9uYW1lcyk6Ci0gICAgICAgICIiInNwbGl0IGlu dG8gYSBsaXN0IHRvIHJ1biBhbmQgYSBzZXQgdG8gc2tpcCwgYmFzZWQgb24gLS1ydW4tY2h1bmsg YW5kIC0tcnVuLXBhcnQuIiIiCi0gICAgICAgIGlmIG5vdCBzZWxmLl9vcHRpb25zLnJ1bl9jaHVu ayBhbmQgbm90IHNlbGYuX29wdGlvbnMucnVuX3BhcnQ6Ci0gICAgICAgICAgICByZXR1cm4gdGVz dF9uYW1lcywgc2V0KCkKLQotICAgICAgICAjIElmIHRoZSB1c2VyIHNwZWNpZmllcyB0aGV5IGp1 c3Qgd2FudCB0byBydW4gYSBzdWJzZXQgb2YgdGhlIHRlc3RzLAotICAgICAgICAjIGp1c3QgZ3Jh YiBhIHN1YnNldCBvZiB0aGUgbm9uLXNraXBwZWQgdGVzdHMuCi0gICAgICAgIGNodW5rX3ZhbHVl ID0gc2VsZi5fb3B0aW9ucy5ydW5fY2h1bmsgb3Igc2VsZi5fb3B0aW9ucy5ydW5fcGFydAotICAg ICAgICB0cnk6Ci0gICAgICAgICAgICAoY2h1bmtfbnVtLCBjaHVua19sZW4pID0gY2h1bmtfdmFs dWUuc3BsaXQoIjoiKQotICAgICAgICAgICAgY2h1bmtfbnVtID0gaW50KGNodW5rX251bSkKLSAg ICAgICAgICAgIGFzc2VydChjaHVua19udW0gPj0gMCkKLSAgICAgICAgICAgIHRlc3Rfc2l6ZSA9 IGludChjaHVua19sZW4pCi0gICAgICAgICAgICBhc3NlcnQodGVzdF9zaXplID4gMCkKLSAgICAg ICAgZXhjZXB0IEFzc2VydGlvbkVycm9yOgotICAgICAgICAgICAgX2xvZy5jcml0aWNhbCgiaW52 YWxpZCBjaHVuayAnJXMnIiAlIGNodW5rX3ZhbHVlKQotICAgICAgICAgICAgcmV0dXJuIChOb25l LCBOb25lKQotCi0gICAgICAgICMgR2V0IHRoZSBudW1iZXIgb2YgdGVzdHMKLSAgICAgICAgbnVt X3Rlc3RzID0gbGVuKHRlc3RfbmFtZXMpCi0KLSAgICAgICAgIyBHZXQgdGhlIHN0YXJ0IG9mZnNl dCBvZiB0aGUgc2xpY2UuCi0gICAgICAgIGlmIHNlbGYuX29wdGlvbnMucnVuX2NodW5rOgotICAg ICAgICAgICAgY2h1bmtfbGVuID0gdGVzdF9zaXplCi0gICAgICAgICAgICAjIEluIHRoaXMgY2Fz ZSBjaHVua19udW0gY2FuIGJlIHJlYWxseSBsYXJnZS4gV2UgbmVlZAotICAgICAgICAgICAgIyB0 byBtYWtlIHRoZSB3b3JrZXIgZml0IGluIHRoZSBjdXJyZW50IG51bWJlciBvZiB0ZXN0cy4KLSAg ICAgICAgICAgIHNsaWNlX3N0YXJ0ID0gKGNodW5rX251bSAqIGNodW5rX2xlbikgJSBudW1fdGVz dHMKLSAgICAgICAgZWxzZToKLSAgICAgICAgICAgICMgVmFsaWRhdGUgdGhlIGRhdGEuCi0gICAg ICAgICAgICBhc3NlcnQodGVzdF9zaXplIDw9IG51bV90ZXN0cykKLSAgICAgICAgICAgIGFzc2Vy dChjaHVua19udW0gPD0gdGVzdF9zaXplKQotCi0gICAgICAgICAgICAjIFRvIGNvdW50IHRoZSBj aHVua19sZW4sIGFuZCBtYWtlIHN1cmUgd2UgZG9uJ3Qgc2tpcAotICAgICAgICAgICAgIyBzb21l IHRlc3RzLCB3ZSByb3VuZCB0byB0aGUgbmV4dCB2YWx1ZSB0aGF0IGZpdHMgZXhhY3RseQotICAg ICAgICAgICAgIyBhbGwgdGhlIHBhcnRzLgotICAgICAgICAgICAgcm91bmRlZF90ZXN0cyA9IG51 bV90ZXN0cwotICAgICAgICAgICAgaWYgcm91bmRlZF90ZXN0cyAlIHRlc3Rfc2l6ZSAhPSAwOgot ICAgICAgICAgICAgICAgIHJvdW5kZWRfdGVzdHMgPSAobnVtX3Rlc3RzICsgdGVzdF9zaXplIC0g KG51bV90ZXN0cyAlIHRlc3Rfc2l6ZSkpCi0KLSAgICAgICAgICAgIGNodW5rX2xlbiA9IHJvdW5k ZWRfdGVzdHMgLy8gdGVzdF9zaXplCi0gICAgICAgICAgICBzbGljZV9zdGFydCA9IGNodW5rX2xl biAqIChjaHVua19udW0gLSAxKQotICAgICAgICAgICAgIyBJdCBkb2VzIG5vdCBtaW5kIGlmIHdl IGdvIG92ZXIgdGVzdF9zaXplLgotCi0gICAgICAgICMgR2V0IHRoZSBlbmQgb2Zmc2V0IG9mIHRo ZSBzbGljZS4KLSAgICAgICAgc2xpY2VfZW5kID0gbWluKG51bV90ZXN0cywgc2xpY2Vfc3RhcnQg KyBjaHVua19sZW4pCi0KLSAgICAgICAgdGVzdHNfdG9fcnVuID0gdGVzdF9uYW1lc1tzbGljZV9z dGFydDpzbGljZV9lbmRdCi0KLSAgICAgICAgX2xvZy5kZWJ1ZygnY2h1bmsgc2xpY2UgWyVkOiVk XSBvZiAlZCBpcyAlZCB0ZXN0cycgJSAoc2xpY2Vfc3RhcnQsIHNsaWNlX2VuZCwgbnVtX3Rlc3Rz LCAoc2xpY2VfZW5kIC0gc2xpY2Vfc3RhcnQpKSkKLQotICAgICAgICAjIElmIHdlIHJlYWNoZWQg dGhlIGVuZCBhbmQgd2UgZG9uJ3QgaGF2ZSBlbm91Z2ggdGVzdHMsIHdlIHJ1biBzb21lCi0gICAg ICAgICMgZnJvbSB0aGUgYmVnaW5uaW5nLgotICAgICAgICBpZiBzbGljZV9lbmQgLSBzbGljZV9z dGFydCA8IGNodW5rX2xlbjoKLSAgICAgICAgICAgIGV4dHJhID0gY2h1bmtfbGVuIC0gKHNsaWNl X2VuZCAtIHNsaWNlX3N0YXJ0KQotICAgICAgICAgICAgX2xvZy5kZWJ1ZygnICAgbGFzdCBjaHVu ayBpcyBwYXJ0aWFsLCBhcHBlbmRpbmcgWzA6JWRdJyAlIGV4dHJhKQotICAgICAgICAgICAgdGVz dHNfdG9fcnVuLmV4dGVuZCh0ZXN0X25hbWVzWzA6ZXh0cmFdKQotCi0gICAgICAgIHJldHVybiAo dGVzdHNfdG9fcnVuLCBzZXQodGVzdF9uYW1lcykgLSBzZXQodGVzdHNfdG9fcnVuKSkKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21h bmFnZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9tYW5hZ2VyLnB5CmluZGV4IDM0NzU3MjEzN2Q1OTZmOWJiODI0MzQ1ZmI5MjRhODkyNDEyOGI5 ZTAuLjA4MGY0MzQwMWJkOWI4MGYyMjhjZWQxYmQyOTEzM2Q4ZTU1ZmRmODEgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMv bWFuYWdlci5weQpAQCAtMTI4LDYgKzEyOCw2NSBAQCBjbGFzcyBNYW5hZ2VyKG9iamVjdCk6CiAK ICAgICAgICAgcmV0dXJuIHRlc3RzX3RvX3NraXAKIAorICAgIGRlZiBfc3BsaXRfaW50b19jaHVu a3Moc2VsZiwgdGVzdF9uYW1lcyk6CisgICAgICAgICIiInNwbGl0IGludG8gYSBsaXN0IHRvIHJ1 biBhbmQgYSBzZXQgdG8gc2tpcCwgYmFzZWQgb24gLS1ydW4tY2h1bmsgYW5kIC0tcnVuLXBhcnQu IiIiCisgICAgICAgIGlmIG5vdCBzZWxmLl9vcHRpb25zLnJ1bl9jaHVuayBhbmQgbm90IHNlbGYu X29wdGlvbnMucnVuX3BhcnQ6CisgICAgICAgICAgICByZXR1cm4gdGVzdF9uYW1lcywgc2V0KCkK KworICAgICAgICAjIElmIHRoZSB1c2VyIHNwZWNpZmllcyB0aGV5IGp1c3Qgd2FudCB0byBydW4g YSBzdWJzZXQgb2YgdGhlIHRlc3RzLAorICAgICAgICAjIGp1c3QgZ3JhYiBhIHN1YnNldCBvZiB0 aGUgbm9uLXNraXBwZWQgdGVzdHMuCisgICAgICAgIGNodW5rX3ZhbHVlID0gc2VsZi5fb3B0aW9u cy5ydW5fY2h1bmsgb3Igc2VsZi5fb3B0aW9ucy5ydW5fcGFydAorICAgICAgICB0cnk6CisgICAg ICAgICAgICAoY2h1bmtfbnVtLCBjaHVua19sZW4pID0gY2h1bmtfdmFsdWUuc3BsaXQoIjoiKQor ICAgICAgICAgICAgY2h1bmtfbnVtID0gaW50KGNodW5rX251bSkKKyAgICAgICAgICAgIGFzc2Vy dChjaHVua19udW0gPj0gMCkKKyAgICAgICAgICAgIHRlc3Rfc2l6ZSA9IGludChjaHVua19sZW4p CisgICAgICAgICAgICBhc3NlcnQodGVzdF9zaXplID4gMCkKKyAgICAgICAgZXhjZXB0IEFzc2Vy dGlvbkVycm9yOgorICAgICAgICAgICAgX2xvZy5jcml0aWNhbCgiaW52YWxpZCBjaHVuayAnJXMn IiAlIGNodW5rX3ZhbHVlKQorICAgICAgICAgICAgcmV0dXJuIChOb25lLCBOb25lKQorCisgICAg ICAgICMgR2V0IHRoZSBudW1iZXIgb2YgdGVzdHMKKyAgICAgICAgbnVtX3Rlc3RzID0gbGVuKHRl c3RfbmFtZXMpCisKKyAgICAgICAgIyBHZXQgdGhlIHN0YXJ0IG9mZnNldCBvZiB0aGUgc2xpY2Uu CisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMucnVuX2NodW5rOgorICAgICAgICAgICAgY2h1bmtf bGVuID0gdGVzdF9zaXplCisgICAgICAgICAgICAjIEluIHRoaXMgY2FzZSBjaHVua19udW0gY2Fu IGJlIHJlYWxseSBsYXJnZS4gV2UgbmVlZAorICAgICAgICAgICAgIyB0byBtYWtlIHRoZSB3b3Jr ZXIgZml0IGluIHRoZSBjdXJyZW50IG51bWJlciBvZiB0ZXN0cy4KKyAgICAgICAgICAgIHNsaWNl X3N0YXJ0ID0gKGNodW5rX251bSAqIGNodW5rX2xlbikgJSBudW1fdGVzdHMKKyAgICAgICAgZWxz ZToKKyAgICAgICAgICAgICMgVmFsaWRhdGUgdGhlIGRhdGEuCisgICAgICAgICAgICBhc3NlcnQo dGVzdF9zaXplIDw9IG51bV90ZXN0cykKKyAgICAgICAgICAgIGFzc2VydChjaHVua19udW0gPD0g dGVzdF9zaXplKQorCisgICAgICAgICAgICAjIFRvIGNvdW50IHRoZSBjaHVua19sZW4sIGFuZCBt YWtlIHN1cmUgd2UgZG9uJ3Qgc2tpcAorICAgICAgICAgICAgIyBzb21lIHRlc3RzLCB3ZSByb3Vu ZCB0byB0aGUgbmV4dCB2YWx1ZSB0aGF0IGZpdHMgZXhhY3RseQorICAgICAgICAgICAgIyBhbGwg dGhlIHBhcnRzLgorICAgICAgICAgICAgcm91bmRlZF90ZXN0cyA9IG51bV90ZXN0cworICAgICAg ICAgICAgaWYgcm91bmRlZF90ZXN0cyAlIHRlc3Rfc2l6ZSAhPSAwOgorICAgICAgICAgICAgICAg IHJvdW5kZWRfdGVzdHMgPSAobnVtX3Rlc3RzICsgdGVzdF9zaXplIC0gKG51bV90ZXN0cyAlIHRl c3Rfc2l6ZSkpCisKKyAgICAgICAgICAgIGNodW5rX2xlbiA9IHJvdW5kZWRfdGVzdHMgLy8gdGVz dF9zaXplCisgICAgICAgICAgICBzbGljZV9zdGFydCA9IGNodW5rX2xlbiAqIChjaHVua19udW0g LSAxKQorICAgICAgICAgICAgIyBJdCBkb2VzIG5vdCBtaW5kIGlmIHdlIGdvIG92ZXIgdGVzdF9z aXplLgorCisgICAgICAgICMgR2V0IHRoZSBlbmQgb2Zmc2V0IG9mIHRoZSBzbGljZS4KKyAgICAg ICAgc2xpY2VfZW5kID0gbWluKG51bV90ZXN0cywgc2xpY2Vfc3RhcnQgKyBjaHVua19sZW4pCisK KyAgICAgICAgdGVzdHNfdG9fcnVuID0gdGVzdF9uYW1lc1tzbGljZV9zdGFydDpzbGljZV9lbmRd CisKKyAgICAgICAgX2xvZy5kZWJ1ZygnY2h1bmsgc2xpY2UgWyVkOiVkXSBvZiAlZCBpcyAlZCB0 ZXN0cycgJSAoc2xpY2Vfc3RhcnQsIHNsaWNlX2VuZCwgbnVtX3Rlc3RzLCAoc2xpY2VfZW5kIC0g c2xpY2Vfc3RhcnQpKSkKKworICAgICAgICAjIElmIHdlIHJlYWNoZWQgdGhlIGVuZCBhbmQgd2Ug ZG9uJ3QgaGF2ZSBlbm91Z2ggdGVzdHMsIHdlIHJ1biBzb21lCisgICAgICAgICMgZnJvbSB0aGUg YmVnaW5uaW5nLgorICAgICAgICBpZiBzbGljZV9lbmQgLSBzbGljZV9zdGFydCA8IGNodW5rX2xl bjoKKyAgICAgICAgICAgIGV4dHJhID0gY2h1bmtfbGVuIC0gKHNsaWNlX2VuZCAtIHNsaWNlX3N0 YXJ0KQorICAgICAgICAgICAgX2xvZy5kZWJ1ZygnICAgbGFzdCBjaHVuayBpcyBwYXJ0aWFsLCBh cHBlbmRpbmcgWzA6JWRdJyAlIGV4dHJhKQorICAgICAgICAgICAgdGVzdHNfdG9fcnVuLmV4dGVu ZCh0ZXN0X25hbWVzWzA6ZXh0cmFdKQorCisgICAgICAgIHJldHVybiAodGVzdHNfdG9fcnVuLCBz ZXQodGVzdF9uYW1lcykgLSBzZXQodGVzdHNfdG9fcnVuKSkKKwogICAgIGRlZiBfcHJlcGFyZV9s aXN0cyhzZWxmLCBwYXRocywgdGVzdF9uYW1lcywgZGV2aWNlX3R5cGU9Tm9uZSk6CiAgICAgICAg IHRlc3RzX3RvX3NraXAgPSBzZWxmLl9za2lwX3Rlc3RzKHRlc3RfbmFtZXMsIHNlbGYuX2V4cGVj dGF0aW9uc1tkZXZpY2VfdHlwZV0sIHNlbGYuX2h0dHBfdGVzdHModGVzdF9uYW1lcykpCiAgICAg ICAgIHRlc3RzX3RvX3J1biA9IFt0ZXN0IGZvciB0ZXN0IGluIHRlc3RfbmFtZXMgaWYgdGVzdCBu b3QgaW4gdGVzdHNfdG9fc2tpcF0KQEAgLTEzOSw3ICsxOTgsNyBAQCBjbGFzcyBNYW5hZ2VyKG9i amVjdCk6CiAgICAgICAgIGVsaWYgc2VsZi5fb3B0aW9ucy5vcmRlciA9PSAncmFuZG9tJzoKICAg ICAgICAgICAgIHJhbmRvbS5zaHVmZmxlKHRlc3RzX3RvX3J1bikKIAotICAgICAgICB0ZXN0c190 b19ydW4sIHRlc3RzX2luX290aGVyX2NodW5rcyA9IHNlbGYuX2ZpbmRlci5zcGxpdF9pbnRvX2No dW5rcyh0ZXN0c190b19ydW4pCisgICAgICAgIHRlc3RzX3RvX3J1biwgdGVzdHNfaW5fb3RoZXJf Y2h1bmtzID0gc2VsZi5fc3BsaXRfaW50b19jaHVua3ModGVzdHNfdG9fcnVuKQogICAgICAgICBz ZWxmLl9leHBlY3RhdGlvbnNbZGV2aWNlX3R5cGVdLmFkZF9za2lwcGVkX3Rlc3RzKHRlc3RzX2lu X290aGVyX2NodW5rcykKICAgICAgICAgdGVzdHNfdG9fc2tpcC51cGRhdGUodGVzdHNfaW5fb3Ro ZXJfY2h1bmtzKQogCg==