223125 2021-03-12 09:25:33 -0800 document pictureInPictureElement is null if you Enter Picture in Picture from contextual menu 2021-03-16 21:23:16 -0700 1 1 1 Unclassified WebKit Media Safari 14 Mac (Apple Silicon) macOS 11 RESOLVED FIXED InRadar P2 Normal --- 1 opendarwin peng.liu6 cdumez changseok darin eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble kondapallykalyan mitz pdr peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1738925 0 opendarwin 2021-03-12 09:25:33 -0800 Overview: If you enter PiP using the contextual menu item "Enter Picture in Picture", then document.pictureInPictureElement is null. Whereas document.pictureInPictureElement returns the <video> element if you enter PiP using the widget at the top left corner of the video. Steps to Reproduce: 1) Open https://developer.apple.com/videos/play/wwdc2020/102/ 2) Start playing the video 3) Open contextual menu on the video and select "Enter Picture in Picture" 4) Show JavaScript Console 5) document.pictureInPictureElement Expected Results: <video id="video"... Actual Results: null Additional Builds and Platforms: This also happens in Safari 14.0.3 on macOS 10.14.6. And it happens with the latest Safari Technology Preview 122 on macOS 11. 1738946 1 opendarwin 2021-03-12 10:37:51 -0800 I also just discovered that the video enterpictureinpicture event doesn't get posted when you using the contextual menu. The enterpictureinpicture does get posted when you use the PiP widget. 1739227 2 opendarwin 2021-03-14 07:37:16 -0700 I debugged with the WebKit source code and discovered the problem. In the case of clicking the PiP widget it follows this code path: HTMLVideoElementPictureInPicture::requestPictureInPicture HTMLVideoElement::setPresentationMode HTMLMediaElement::enterFullscreen In the case of the contextual menu it follows this code path: HitTestResult::toggleEnhancedFullscreenForVideo HTMLMediaElement::enterFullscreen In both cases, eventually this code gets called at https://github.com/WebKit/WebKit/blob/main/Source/WebCore/html/HTMLVideoElement.cpp#L504 void HTMLVideoElement::didEnterFullscreenOrPictureInPicture(const FloatSize& size) { if (m_enteringPictureInPicture) { However, m_enteringPictureInPicture is false with the contextual menu. With the PiP widget m_enteringPictureInPicture is true, because it gets set to true in HTMLVideoElement::setPresentationMode at https://github.com/WebKit/WebKit/blob/main/Source/WebCore/html/HTMLVideoElement.cpp#L490 1739837 3 peng.liu6 2021-03-15 22:20:51 -0700 Thanks for the investigation! I will upload a patch to fix it. 1739840 4 423299 peng.liu6 2021-03-15 22:30:52 -0700 Created attachment 423299 Patch 1740373 5 ews-feeder 2021-03-16 21:22:10 -0700 Committed r274551: <https://commits.webkit.org/r274551> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423299. 1740374 6 webkit-bug-importer 2021-03-16 21:23:16 -0700 <rdar://problem/75510164> 423299 2021-03-15 22:30:52 -0700 2021-03-16 21:22:12 -0700 Patch bug-223125-20210315223051.patch text/plain 3265 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWEyNTBmM2QwYmQ4Mzgx ZjRmZjc2ZDkwNjEzOTBkMDg3NTU5ZDBlNC4uZGE0MzJjMzJmZDVlYWIwM2UxMTEwOWRhODI2OTMz MmQ4YTc5MGJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTE1ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgZG9jdW1lbnQgcGljdHVyZUlu UGljdHVyZUVsZW1lbnQgaXMgbnVsbCBpZiB5b3UgRW50ZXIgUGljdHVyZSBpbiBQaWN0dXJlIGZy b20gY29udGV4dHVhbCBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjMxMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVc2UgSFRNTFZpZGVvRWxlbWVudCdzIGZ1bmN0aW9ucyB0byBjaGFuZ2Ugdmlk ZW8gcHJlc2VudGF0aW9uIG1vZGUgdG8gZW5zdXJlIHRoYXQKKyAgICAgICAgZG9jdW1lbnQucGlj dHVyZUluUGljdHVyZUVsZW1lbnQgaXMgdXBkYXRlZCBwcm9wZXJseSBhbmQgY29ycmVjdCBldmVu dHMgYXJlIGZpcmVkLgorCisgICAgICAgIENvdmVyZWQgYnkgbWFudWFsIHRlc3RzLgorCisgICAg ICAgICogaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcDoKKyAgICAgICAgKiByZW5kZXJpbmcvSGl0 VGVzdFJlc3VsdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXRUZXN0UmVzdWx0OjplbnRlckZ1 bGxzY3JlZW5Gb3JWaWRlbyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpIaXRUZXN0UmVzdWx0 Ojp0b2dnbGVFbmhhbmNlZEZ1bGxzY3JlZW5Gb3JWaWRlbyBjb25zdCk6CisKIDIwMjEtMDMtMTUg IFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXQtYm9yZGVyLXRv LWxpbmUgbWF5IGNoYW5nZSB0aGUgbGF5b3V0IGNvbnN0cmFpbnRzIGJldHdlZW4gMiBwYWdpbmF0 ZWQgbGluZSBsYXlvdXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRl b0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcApp bmRleCBhZWJkY2Y4NjU0MjMyODhiNjkyOTllOGUwMTg4MTMyMWI5NzFiMDg5Li45YzNmZDVhNjNk MzllYjVjYjVlN2NkMzYxOWJlYWQyYWIzOTBlMzA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFZpZGVvRWxlbWVudC5jcHAKQEAgLTIwMyw3ICsyMDMsNiBAQCBib29sIEhUTUxWaWRlb0VsZW1l bnQ6OnN1cHBvcnRzRnVsbHNjcmVlbihIVE1MTWVkaWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNj cmVlbgogI2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1JTFkpCiB9CiAKLQogI2lmIEVOQUJMRShG VUxMU0NSRUVOX0FQSSkgJiYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKIHZvaWQgSFRNTFZpZGVvRWxl bWVudDo6d2Via2l0UmVxdWVzdEZ1bGxzY3JlZW4oKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0hpdFRlc3RSZXN1bHQuY3BwCmluZGV4IDQ5M2I4NTliODYzYWRlYjQyYjU5YjEzNjc4Mjdh ZDYwMDU2NDA2NjYuLmYxNDBkZmEwMjViMjAyMDYxYWQyZjZkYzBiMWExNzc1NzM5OGM0Y2UgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHAKQEAgLTQ3Myw3ICs0 NzMsNyBAQCB2b2lkIEhpdFRlc3RSZXN1bHQ6OmVudGVyRnVsbHNjcmVlbkZvclZpZGVvKCkgY29u c3QKICAgICAgICAgSFRNTFZpZGVvRWxlbWVudCYgdmlkZW9FbGVtZW50ID0gZG93bmNhc3Q8SFRN TFZpZGVvRWxlbWVudD4oKm1lZGlhRWxlbWVudCk7CiAgICAgICAgIGlmICghdmlkZW9FbGVtZW50 LmlzRnVsbHNjcmVlbigpICYmIG1lZGlhRWxlbWVudC0+c3VwcG9ydHNGdWxsc2NyZWVuKEhUTUxN ZWRpYUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZVN0YW5kYXJkKSkgewogICAgICAg ICAgICAgVXNlckdlc3R1cmVJbmRpY2F0b3IgaW5kaWNhdG9yKFByb2Nlc3NpbmdVc2VyR2VzdHVy ZSwgJm1lZGlhRWxlbWVudC0+ZG9jdW1lbnQoKSk7Ci0gICAgICAgICAgICB2aWRlb0VsZW1lbnQu ZW50ZXJGdWxsc2NyZWVuKCk7CisgICAgICAgICAgICB2aWRlb0VsZW1lbnQud2Via2l0RW50ZXJG dWxsc2NyZWVuKCk7CiAgICAgICAgIH0KICAgICB9CiAjZW5kaWYKQEAgLTc4MywxMCArNzgzLDEw IEBAIHZvaWQgSGl0VGVzdFJlc3VsdDo6dG9nZ2xlRW5oYW5jZWRGdWxsc2NyZWVuRm9yVmlkZW8o KSBjb25zdAogCiAgICAgSFRNTFZpZGVvRWxlbWVudCYgdmlkZW9FbGVtZW50ID0gZG93bmNhc3Q8 SFRNTFZpZGVvRWxlbWVudD4oKm1lZGlhRWxlbWVudCk7CiAgICAgVXNlckdlc3R1cmVJbmRpY2F0 b3IgaW5kaWNhdG9yKFByb2Nlc3NpbmdVc2VyR2VzdHVyZSwgJm1lZGlhRWxlbWVudC0+ZG9jdW1l bnQoKSk7Ci0gICAgaWYgKHZpZGVvRWxlbWVudC5mdWxsc2NyZWVuTW9kZSgpID09IEhUTUxNZWRp YUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZVBpY3R1cmVJblBpY3R1cmUpCi0gICAg ICAgIHZpZGVvRWxlbWVudC5leGl0RnVsbHNjcmVlbigpOworICAgIGlmICh2aWRlb0VsZW1lbnQu d2Via2l0UHJlc2VudGF0aW9uTW9kZSgpID09IEhUTUxWaWRlb0VsZW1lbnQ6OlZpZGVvUHJlc2Vu dGF0aW9uTW9kZTo6UGljdHVyZUluUGljdHVyZSkKKyAgICAgICAgdmlkZW9FbGVtZW50LndlYmtp dFNldFByZXNlbnRhdGlvbk1vZGUoSFRNTFZpZGVvRWxlbWVudDo6VmlkZW9QcmVzZW50YXRpb25N b2RlOjpJbmxpbmUpOwogICAgIGVsc2UKLSAgICAgICAgdmlkZW9FbGVtZW50LmVudGVyRnVsbHNj cmVlbihIVE1MTWVkaWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNjcmVlbk1vZGVQaWN0dXJlSW5Q aWN0dXJlKTsKKyAgICAgICAgdmlkZW9FbGVtZW50LndlYmtpdFNldFByZXNlbnRhdGlvbk1vZGUo SFRNTFZpZGVvRWxlbWVudDo6VmlkZW9QcmVzZW50YXRpb25Nb2RlOjpQaWN0dXJlSW5QaWN0dXJl KTsKICNlbmRpZgogfQogCg==