223122 2021-03-12 07:53:11 -0800 [SameObject] is not applied in FrozenArrays or TypeArrays 2021-03-23 08:41:57 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ifernandez webkit-unassigned ashvayka cdumez sam webkit-bug-importer oldest_to_newest 1738894 0 ifernandez 2021-03-12 07:53:11 -0800 Hi, I'm trying to pass some WebXR [SameObject] related tests and found that [SameObject] doesn't work as expected with array related types. JS correctly receives the same object when using DOM wrappers but not when using FrozenArrays o TypedArrays (using Vec<T> and Float32Array in the C++ DOM class). Is there any problem in the binding code generation or Vec<T>/TypesArrays should be wrapped in a special way to be cached to comply with [SameObject], such as DOMStringList instead of Vec<String>/FrozenArray<String>? I didn't find good examples of other module specs using [SameObject] with FrozeArrays/TypedArrays, almost all of them are in WebXR spec :) 1741504 1 cdumez 2021-03-18 16:40:30 -0700 "SameObject": { "contextsAllowed": ["attribute"], "standard": { "url": "https://heycam.github.io/webidl/#SameObject" }, "unsupported": true }, We just don't support [SameObject] in WebKit right now. There are way to implement this with JS visitors or [CachedAttribute] though. We do this all the time. Where are you trying to use it exactly? 1741507 2 cdumez 2021-03-18 16:42:58 -0700 (In reply to Chris Dumez from comment #1) > "SameObject": { > "contextsAllowed": ["attribute"], > "standard": { > "url": "https://heycam.github.io/webidl/#SameObject" > }, > "unsupported": true > }, > > We just don't support [SameObject] in WebKit right now. There are way to > implement this with JS visitors or [CachedAttribute] though. We do this all > the time. > > Where are you trying to use it exactly? MessageEvent.ports seems to be an example of FrozenArray attribute where we've implementation our custom "SameObject" support. You may be able to use that as example. 1741718 3 webkit-bug-importer 2021-03-19 08:54:19 -0700 <rdar://problem/75622221> 1742808 4 ifernandez 2021-03-23 08:41:44 -0700 MessageEvent.ports was a great example, thanks! I implemented the related changes in bug 223635