<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22312</bug_id>
          
          <creation_ts>2008-11-17 08:28:06 -0800</creation_ts>
          <short_desc>Fix PCRE include path problem on Qt-port</short_desc>
          <delta_ts>2008-11-17 11:55:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Gabor Loki">loki</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>99035</commentid>
    <comment_count>0</comment_count>
    <who name="Gabor Loki">loki</who>
    <bug_when>2008-11-17 08:28:06 -0800</bug_when>
    <thetext>The pcre.pri contains wrong include path.

The &apos;INCLUDEPATH += $$PWD $$OUTPUT_DIR/JavaScriptCore/parser/tmp&apos; line should be &apos;INCLUDEPATH += $$PWD $$OUTPUT_DIR/JavaScriptCore/tmp&apos;.

No one creates &apos;parser&apos; directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99036</commentid>
    <comment_count>1</comment_count>
      <attachid>25216</attachid>
    <who name="Gabor Loki">loki</who>
    <bug_when>2008-11-17 08:29:31 -0800</bug_when>
    <thetext>Created attachment 25216
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99052</commentid>
    <comment_count>2</comment_count>
      <attachid>25216</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-11-17 09:16:03 -0800</bug_when>
    <thetext>Comment on attachment 25216
Proposed patch

&gt; diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
&gt; index 13e79c0..fbc2cea 100644
&gt; --- a/JavaScriptCore/ChangeLog
&gt; +++ b/JavaScriptCore/ChangeLog
&gt; @@ -1,3 +1,13 @@
&gt; +2008-11-17  Gabor Loki  &lt;loki@inf.u-szeged.hu&gt;
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +
&gt; +	&lt;https://bugs.webkit.org/show_bug.cgi?id=22312&gt;
&gt; +	Fix PCRE include path problem on Qt-port

Please don&apos;t put tabs in anything, including ChangeLog entries. This makes extra work for the committers, who has to change them into spaces.

&gt; +        * JavaScriptCore.pri:

This file is in the ChangeLog, but not changed in the patch.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99062</commentid>
    <comment_count>3</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2008-11-17 09:36:56 -0800</bug_when>
    <thetext>Committed revision 38508.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99079</commentid>
    <comment_count>4</comment_count>
    <who name="Gabor Loki">loki</who>
    <bug_when>2008-11-17 11:55:37 -0800</bug_when>
    <thetext>Opps. Sorry, I missed them.
At first I wanted to send this and bug #22313 together, but I changed my mind and accidentally left those in the ChangeLog.
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25216</attachid>
            <date>2008-11-17 08:29:31 -0800</date>
            <delta_ts>2008-11-17 09:16:03 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>fix-pcre.patch</filename>
            <type>text/plain</type>
            <size>949</size>
            <attacher name="Gabor Loki">loki</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCAxM2U3OWMwLi5mYmMyY2VhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMDgtMTEtMTcgIEdhYm9yIExva2kgIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCTxodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzMTI+CisJRml4IFBDUkUgaW5jbHVkZSBwYXRoIHByb2Js
ZW0gb24gUXQtcG9ydAorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUucHJpOgorICAgICAgICAq
IHBjcmUvcGNyZS5wcmk6CisKIDIwMDgtMTEtMTcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFw
cGxlLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0
Q29yZS9wY3JlL3BjcmUucHJpIGIvSmF2YVNjcmlwdENvcmUvcGNyZS9wY3JlLnByaQppbmRleCBl
ZDg2NmNmLi5jMzNjNjdjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9wY3JlL3BjcmUucHJp
CisrKyBiL0phdmFTY3JpcHRDb3JlL3BjcmUvcGNyZS5wcmkKQEAgLTEsNiArMSw2IEBACiAjIFBl
cmwgQ29tcGF0aWJsZSBSZWd1bGFyIEV4cHJlc3Npb25zIC0gUXQ0IGJ1aWxkIGluZm8KIFZQQVRI
ICs9ICQkUFdECi1JTkNMVURFUEFUSCArPSAkJFBXRCAkJE9VVFBVVF9ESVIvSmF2YVNjcmlwdENv
cmUvcGFyc2VyL3RtcAorSU5DTFVERVBBVEggKz0gJCRQV0QgJCRPVVRQVVRfRElSL0phdmFTY3Jp
cHRDb3JlL3RtcAogREVQRU5EUEFUSCArPSAkJFBXRAogCiBpc0VtcHR5KEdFTkVSQVRFRF9TT1VS
Q0VTX0RJUik6R0VORVJBVEVEX1NPVVJDRVNfRElSID0gdG1wCg==
</data>
<flag name="review"
          id="11646"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>