223092 2021-03-11 14:23:34 -0800 Use BinarySemaphore in callOnMainAndWait() 2021-03-11 18:39:59 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez benjamin cmarcelo ews-watchlist ggaren webkit-bug-importer ysuzuki oldest_to_newest 1738627 0 cdumez 2021-03-11 14:23:34 -0800 Use BinarySemaphore in callOnMainAndWait() instead of a Condition, this simplifies the code a bit. 1738628 1 422971 cdumez 2021-03-11 14:25:24 -0800 Created attachment 422971 Patch 1738632 2 422971 ggaren 2021-03-11 14:27:15 -0800 Comment on attachment 422971 Patch r=me 1738659 3 ews-feeder 2021-03-11 15:16:08 -0800 commit-queue failed to commit attachment 422971 to WebKit repository. To retry, please set cq+ flag again. 1738664 4 ews-feeder 2021-03-11 15:21:32 -0800 commit-queue failed to commit attachment 422971 to WebKit repository. To retry, please set cq+ flag again. 1738676 5 ews-feeder 2021-03-11 15:52:26 -0800 commit-queue failed to commit attachment 422971 to WebKit repository. To retry, please set cq+ flag again. 1738677 6 422971 cdumez 2021-03-11 15:54:23 -0800 Comment on attachment 422971 Patch Clearing flags on attachment: 422971 Committed r274304 (235198@main): <https://commits.webkit.org/235198@main> 1738678 7 cdumez 2021-03-11 15:54:26 -0800 All reviewed patches have been landed. Closing bug. 1738679 8 webkit-bug-importer 2021-03-11 15:55:16 -0800 <rdar://problem/75337063> 1738734 9 ysuzuki 2021-03-11 18:39:59 -0800 I'm happy to see that BinarySemaphore is used to clean up these things! 422971 2021-03-11 14:25:24 -0800 2021-03-11 15:54:23 -0800 Patch bug-223092-20210311142523.patch text/plain 3302 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNiNWY1ZGRiNTRjZjRlM2M0MmNjODE1 NzRhZDE5MDAyMzUwYjQ5YzMuLjM5N2MwYTMwODJkZWI5NDIyMmE2MTJiOTE4NzVkMDk1ZjQxODJl NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDMtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgQmluYXJ5U2VtYXBob3JlIGluIGNhbGxPbk1haW5B bmRXYWl0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyMzA5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSBCaW5hcnlTZW1hcGhvcmUgaW4gY2FsbE9uTWFpbkFuZFdhaXQoKSBpbnN0ZWFkIG9mIGEg Q29uZGl0aW9uLCB0aGlzIHNpbXBsaWZpZXMgdGhlIGNvZGUKKyAgICAgICAgYSBiaXQuIEFsc28g dGVtcGxhdGl6ZSB0aGUgZnVuY3Rpb24gdG8gbWFrZSBzdXJlIHdlIGF2b2lkIGFueSBydW50aW1l IGNoZWNrcyBmb3IgdGhlCisgICAgICAgIHRoZSAibWFpblN0eWxlIi4KKworICAgICAgICAqIHd0 Zi9NYWluVGhyZWFkLmNwcDoKKyAgICAgICAgKFdURjo6Y2FsbE9uTWFpbkFuZFdhaXQpOgorICAg ICAgICAoV1RGOjpjYWxsT25NYWluUnVuTG9vcEFuZFdhaXQpOgorICAgICAgICAoV1RGOjpjYWxs T25NYWluVGhyZWFkQW5kV2FpdCk6CisKIDIwMjEtMDMtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2UgV29ya1F1ZXVlOjptYWluKCkgdG8gZ2V0 IHRoZSBtYWluIHRocmVhZCdzIHdvcmsgcXVldWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L01haW5UaHJlYWQuY3BwIGIvU291cmNlL1dURi93dGYvTWFpblRocmVhZC5jcHAKaW5kZXggYzQ2 YzRiMGUyMjQ0ZmZiMmI3MDI2MTFkZjFjODFlNGMyNDA2OTAxOS4uNDFlOWQ5YTJkMzk4YmQ0MWMw YmM0YjVlYzg4ZTI4N2YwMDFhMDQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWFpblRo cmVhZC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvTWFpblRocmVhZC5jcHAKQEAgLTMwLDcgKzMw LDYgQEAKICNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5oPgogCiAjaW5jbHVkZSA8bXV0ZXg+Ci0j aW5jbHVkZSA8d3RmL0NvbmRpdGlvbi5oPgogI2luY2x1ZGUgPHd0Zi9EZXF1ZS5oPgogI2luY2x1 ZGUgPHd0Zi9Mb2NrLmg+CiAjaW5jbHVkZSA8d3RmL01vbm90b25pY1RpbWUuaD4KQEAgLTM4LDYg KzM3LDcgQEAKICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJF eHRyYXMuaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CisjaW5jbHVkZSA8d3RmL3RocmVh ZHMvQmluYXJ5U2VtYXBob3JlLmg+CiAKIG5hbWVzcGFjZSBXVEYgewogCkBAIC0xMDEsNyArMTAx LDggQEAgZW51bSBjbGFzcyBNYWluU3R5bGUgOiBib29sIHsKICAgICBSdW5Mb29wCiB9OwogCi1z dGF0aWMgdm9pZCBjYWxsT25NYWluQW5kV2FpdChXVEY6OkZ1bmN0aW9uPHZvaWQoKT4mJiBmdW5j dGlvbiwgTWFpblN0eWxlIG1haW5TdHlsZSkKK3RlbXBsYXRlIDxNYWluU3R5bGUgbWFpblN0eWxl Pgorc3RhdGljIHZvaWQgY2FsbE9uTWFpbkFuZFdhaXQoRnVuY3Rpb248dm9pZCgpPiYmIGZ1bmN0 aW9uKQogewogCiAgICAgaWYgKG1haW5TdHlsZSA9PSBNYWluU3R5bGU6OlRocmVhZCA/IGlzTWFp blRocmVhZCgpIDogaXNNYWluUnVuTG9vcCgpKSB7CkBAIC0xMDksMTcgKzExMCwxMCBAQCBzdGF0 aWMgdm9pZCBjYWxsT25NYWluQW5kV2FpdChXVEY6OkZ1bmN0aW9uPHZvaWQoKT4mJiBmdW5jdGlv biwgTWFpblN0eWxlIG1haW5TdAogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgTG9jayBt dXRleDsKLSAgICBDb25kaXRpb24gY29uZGl0aW9uVmFyaWFibGU7Ci0KLSAgICBib29sIGlzRmlu aXNoZWQgPSBmYWxzZTsKLQotICAgIGF1dG8gZnVuY3Rpb25JbXBsID0gWyYsIGZ1bmN0aW9uID0g V1RGTW92ZShmdW5jdGlvbildIHsKKyAgICBCaW5hcnlTZW1hcGhvcmUgc2VtYXBob3JlOworICAg IGF1dG8gZnVuY3Rpb25JbXBsID0gWyZzZW1hcGhvcmUsIGZ1bmN0aW9uID0gV1RGTW92ZShmdW5j dGlvbildIHsKICAgICAgICAgZnVuY3Rpb24oKTsKLQotICAgICAgICBhdXRvIGxvY2tlciA9IGhv bGRMb2NrKG11dGV4KTsKLSAgICAgICAgaXNGaW5pc2hlZCA9IHRydWU7Ci0gICAgICAgIGNvbmRp dGlvblZhcmlhYmxlLm5vdGlmeU9uZSgpOworICAgICAgICBzZW1hcGhvcmUuc2lnbmFsKCk7CiAg ICAgfTsKIAogICAgIHN3aXRjaCAobWFpblN0eWxlKSB7CkBAIC0xMjksMjEgKzEyMywxNyBAQCBz dGF0aWMgdm9pZCBjYWxsT25NYWluQW5kV2FpdChXVEY6OkZ1bmN0aW9uPHZvaWQoKT4mJiBmdW5j dGlvbiwgTWFpblN0eWxlIG1haW5TdAogICAgIGNhc2UgTWFpblN0eWxlOjpSdW5Mb29wOgogICAg ICAgICBjYWxsT25NYWluUnVuTG9vcChXVEZNb3ZlKGZ1bmN0aW9uSW1wbCkpOwogICAgIH07Ci0K LSAgICBzdGQ6OnVuaXF1ZV9sb2NrPExvY2s+IGxvY2sobXV0ZXgpOwotICAgIGNvbmRpdGlvblZh cmlhYmxlLndhaXQobG9jaywgWyZdIHsKLSAgICAgICAgcmV0dXJuIGlzRmluaXNoZWQ7Ci0gICAg fSk7CisgICAgc2VtYXBob3JlLndhaXQoKTsKIH0KIAotdm9pZCBjYWxsT25NYWluUnVuTG9vcEFu ZFdhaXQoV1RGOjpGdW5jdGlvbjx2b2lkKCk+JiYgZnVuY3Rpb24pCit2b2lkIGNhbGxPbk1haW5S dW5Mb29wQW5kV2FpdChGdW5jdGlvbjx2b2lkKCk+JiYgZnVuY3Rpb24pCiB7Ci0gICAgY2FsbE9u TWFpbkFuZFdhaXQoV1RGTW92ZShmdW5jdGlvbiksIE1haW5TdHlsZTo6UnVuTG9vcCk7CisgICAg Y2FsbE9uTWFpbkFuZFdhaXQ8TWFpblN0eWxlOjpSdW5Mb29wPihXVEZNb3ZlKGZ1bmN0aW9uKSk7 CiB9CiAKLXZvaWQgY2FsbE9uTWFpblRocmVhZEFuZFdhaXQoV1RGOjpGdW5jdGlvbjx2b2lkKCk+ JiYgZnVuY3Rpb24pCit2b2lkIGNhbGxPbk1haW5UaHJlYWRBbmRXYWl0KEZ1bmN0aW9uPHZvaWQo KT4mJiBmdW5jdGlvbikKIHsKLSAgICBjYWxsT25NYWluQW5kV2FpdChXVEZNb3ZlKGZ1bmN0aW9u KSwgTWFpblN0eWxlOjpUaHJlYWQpOworICAgIGNhbGxPbk1haW5BbmRXYWl0PE1haW5TdHlsZTo6 VGhyZWFkPihXVEZNb3ZlKGZ1bmN0aW9uKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdURgo=