223090 2021-03-11 14:05:03 -0800 Web Inspector: `WI.Object.singleFireEventListener` should not keep a strong reference to `thisObject` 2021-03-11 15:12:16 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196956 InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1738611 0 hi 2021-03-11 14:05:03 -0800 . 1738618 1 422965 hi 2021-03-11 14:13:07 -0800 Created attachment 422965 Patch 1738630 2 422965 bburg 2021-03-11 14:26:33 -0800 Comment on attachment 422965 Patch r=me Is this testable? 1738642 3 422965 hi 2021-03-11 14:49:19 -0800 Comment on attachment 422965 Patch (In reply to BJ Burg from comment #2) > Is this testable? not in any reliable way that I know of (especially given conservative GC) :/ 1738655 4 ews-feeder 2021-03-11 15:11:25 -0800 Committed r274303: <https://commits.webkit.org/r274303> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422965. 1738657 5 webkit-bug-importer 2021-03-11 15:12:16 -0800 <rdar://problem/75335202> 422965 2021-03-11 14:13:07 -0800 2021-03-11 15:11:26 -0800 Patch bug-223090-20210311151306.patch text/plain 2735 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE0NzliY2RjZDk5MDQ3NDFhOWVmOGE2OGQ1OWZh Zjk1ZjY1ZDExYzkuLjRiMWY2MjBmM2NkOGJkZDIwMjk3NGRmNGY0YTNlMDc4NTYyY2U3NGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAzLTExICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBg V0kuT2JqZWN0LnNpbmdsZUZpcmVFdmVudExpc3RlbmVyYCBzaG91bGQgbm90IGtlZXAgYSBzdHJv bmcgcmVmZXJlbmNlIHRvIGB0aGlzT2JqZWN0YAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzMDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvT2JqZWN0LmpzOgorICAg ICAgICAoV0kuT2JqZWN0LmFkZEV2ZW50TGlzdGVuZXIpOgorICAgICAgICAoV0kuT2JqZWN0LnNp bmdsZUZpcmVFdmVudExpc3RlbmVyKToKKwogMjAyMS0wMy0xMCAgTmlraXRhIFZhc2lseWV2ICA8 bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgY2hlY2ti b3ggdG8gdG9nZ2xlIGFsbCBncmlkIG92ZXJsYXlzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL09iamVjdC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvT2JqZWN0LmpzCmluZGV4IDM2OWI5ZDkxYjczYjQ4YzYy ODUyYTNjYjM0ZWU1NjEwY2E4ZmY5Y2QuLmM3Yzg3ODU2NzMyMjc1N2QxNDY5NzdlNGY1YzRhYTUz NGNmODA4NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvT2JqZWN0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvT2JqZWN0LmpzCkBAIC00NSw3ICs0NSw3IEBAIFdJLk9iamVjdCA9IGNsYXNzIFdlYklu c3BlY3Rvck9iamVjdAogICAgICAgICAgICAgdGhpc09iamVjdFdlYWtSZWY6IG5ldyBXZWFrUmVm KHRoaXNPYmplY3QpLAogICAgICAgICB9OwogCi0gICAgICAgIFdJLk9iamVjdC5fbGlzdGVuZXJU aGlzT2JqZWN0RmluYWxpemF0aW9uUmVnaXN0cnkucmVnaXN0ZXIodGhpc09iamVjdCwge2V2ZW50 VGFyZ2V0OiB0aGlzLCBldmVudFR5cGUsIGRhdGF9LCBkYXRhKTsKKyAgICAgICAgV0kuT2JqZWN0 Ll9saXN0ZW5lclRoaXNPYmplY3RGaW5hbGl6YXRpb25SZWdpc3RyeS5yZWdpc3Rlcih0aGlzT2Jq ZWN0LCB7ZXZlbnRUYXJnZXRXZWFrUmVmOiBuZXcgV2Vha1JlZih0aGlzKSwgZXZlbnRUeXBlLCBk YXRhfSwgZGF0YSk7CiAKICAgICAgICAgdGhpcy5fbGlzdGVuZXJzID8/PSBuZXcgTXVsdGltYXA7 CiAgICAgICAgIHRoaXMuX2xpc3RlbmVycy5hZGQoZXZlbnRUeXBlLCBkYXRhKTsKQEAgLTU3LDEy ICs1NywxMSBAQCBXSS5PYmplY3QgPSBjbGFzcyBXZWJJbnNwZWN0b3JPYmplY3QKIAogICAgIHN0 YXRpYyBzaW5nbGVGaXJlRXZlbnRMaXN0ZW5lcihldmVudFR5cGUsIGxpc3RlbmVyLCB0aGlzT2Jq ZWN0KQogICAgIHsKLSAgICAgICAgbGV0IHdyYXBwZWRDYWxsYmFjayA9ICguLi5hcmdzKSA9PiB7 Ci0gICAgICAgICAgICB0aGlzLnJlbW92ZUV2ZW50TGlzdGVuZXIoZXZlbnRUeXBlLCB3cmFwcGVk Q2FsbGJhY2ssIHRoaXNPYmplY3QpOwotICAgICAgICAgICAgbGlzdGVuZXIuYXBwbHkodGhpc09i amVjdCwgYXJncyk7Ci0gICAgICAgIH07Ci0gICAgICAgIHRoaXMuYWRkRXZlbnRMaXN0ZW5lcihl dmVudFR5cGUsIHdyYXBwZWRDYWxsYmFjaywgdGhpc09iamVjdCk7Ci0gICAgICAgIHJldHVybiB3 cmFwcGVkQ2FsbGJhY2s7CisgICAgICAgIGxldCBldmVudFRhcmdldFdlYWtSZWYgPSBuZXcgV2Vh a1JlZih0aGlzKTsKKyAgICAgICAgcmV0dXJuIHRoaXMuYWRkRXZlbnRMaXN0ZW5lcihldmVudFR5 cGUsIGZ1bmN0aW9uIHdyYXBwZWRDYWxsYmFjaygpIHsKKyAgICAgICAgICAgIGV2ZW50VGFyZ2V0 V2Vha1JlZi5kZXJlZigpPy5yZW1vdmVFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgd3JhcHBlZENh bGxiYWNrLCB0aGlzKTsKKyAgICAgICAgICAgIGxpc3RlbmVyLmFwcGx5KHRoaXMsIGFyZ3VtZW50 cyk7CisgICAgICAgIH0sIHRoaXNPYmplY3QpOwogICAgIH0KIAogICAgIHN0YXRpYyBhd2FpdEV2 ZW50KGV2ZW50VHlwZSwgdGhpc09iamVjdCkKQEAgLTE4MSw3ICsxODAsNyBAQCBXSS5PYmplY3Qg PSBjbGFzcyBXZWJJbnNwZWN0b3JPYmplY3QKIH07CiAKIFdJLk9iamVjdC5fbGlzdGVuZXJUaGlz T2JqZWN0RmluYWxpemF0aW9uUmVnaXN0cnkgPSBuZXcgRmluYWxpemF0aW9uUmVnaXN0cnkoKGhl bGRWYWx1ZSkgPT4gewotICAgIGhlbGRWYWx1ZS5ldmVudFRhcmdldC5fbGlzdGVuZXJzLmRlbGV0 ZShoZWxkVmFsdWUuZXZlbnRUeXBlLCBoZWxkVmFsdWUuZGF0YSk7CisgICAgaGVsZFZhbHVlLmV2 ZW50VGFyZ2V0V2Vha1JlZi5kZXJlZigpPy5fbGlzdGVuZXJzLmRlbGV0ZShoZWxkVmFsdWUuZXZl bnRUeXBlLCBoZWxkVmFsdWUuZGF0YSk7CiB9KTsKIAogV0kuRXZlbnQgPSBjbGFzcyBFdmVudAo=