223075 2021-03-11 09:52:54 -0800 [macOS] Selecting text via mouse drag in image documents shouldn't trigger click events 2021-03-15 06:36:59 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 223119 1 wenson_hsieh wenson_hsieh aakash_jain ap cdumez changseok commit-queue esprehn+autocc ews-watchlist gyuyoung.kim hi megan_gardner ryanhaddad thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1738496 0 wenson_hsieh 2021-03-11 09:52:54 -0800 . 1738645 1 422976 wenson_hsieh 2021-03-11 14:57:40 -0800 Created attachment 422976 Patch 1738646 2 webkit-bug-importer 2021-03-11 14:58:00 -0800 <rdar://problem/75334611> 1738670 3 422976 wenson_hsieh 2021-03-11 15:46:19 -0800 Comment on attachment 422976 Patch Thanks for the review! 1738680 4 ews-feeder 2021-03-11 15:55:45 -0800 Committed r274305: <https://commits.webkit.org/r274305> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422976. 1738861 5 aakash_jain 2021-03-12 06:22:31 -0800 (In reply to EWS from comment #4) > Committed r274305: <https://commits.webkit.org/r274305> This seems to have broken multiple layout tests on mac-debug. e.g.: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=editing%2Fselection%2Fselection-across-shadow-boundaries-mixed-editability-2.html&test=editing%2Fselection%2Fselection-across-shadow-boundaries-mixed-editability-3.html&test=editing%2Fselection%2Fselection-across-shadow-boundaries-readonly-2.html&style=debug 1738862 6 aakash_jain 2021-03-12 06:23:09 -0800 Crash: https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Debug-WK1-Tests-EWS/r423011-3298-rerun/editing/selection/selection-across-shadow-boundaries-mixed-editability-3-crash-log.txt stderr: ASSERTION FAILED: !shadowRoot() || shadowRoot()->mode() == ShadowRootMode::UserAgent ./dom/Element.cpp(2447) : RefPtr<WebCore::ShadowRoot> WebCore::Element::userAgentShadowRoot() const 1 0x10fb778e9 WTFCrash 2 0x12cbcbd4b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12fc60701 WebCore::Element::userAgentShadowRoot() const 4 0x130098307 WebCore::HTMLElement::isImageOverlayText(WebCore::Node const&) 5 0x130a4a4e0 WebCore::EventHandler::updateSelectionForMouseDrag(WebCore::HitTestResult const&) 6 0x130a48c97 WebCore::EventHandler::handleMouseDraggedEvent(WebCore::MouseEventWithHitTestResults const&, WebCore::CheckDragHysteresis) 1738864 7 commit-queue 2021-03-12 06:24:18 -0800 Re-opened since this is blocked by bug 223119 1739298 8 423140 wenson_hsieh 2021-03-14 20:17:30 -0700 Created attachment 423140 v2 (w/ tests) 1739420 9 ews-feeder 2021-03-15 06:36:56 -0700 Committed r274420: <https://commits.webkit.org/r274420> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423140. 422976 2021-03-11 14:57:40 -0800 2021-03-14 19:12:54 -0700 Patch bug-223075-20210311145739.patch text/plain 3291 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTBkYjgzZTM5ZDA5Nzhh MzlmMjlhODM4YTdkYmEwMjg3YWRiZDA5Zi4uYzExZmZlMmY2ZjRhMTVmNDM3YTcwMWNjMjFmZjgw NWE4OTI3MDU0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTExICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gU2Vs ZWN0aW5nIHRleHQgdmlhIG1vdXNlIGRyYWcgaW4gaW1hZ2UgZG9jdW1lbnRzIHNob3VsZG4ndCB0 cmlnZ2VyIGNsaWNrIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIzMDc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW1wcm92ZSBpbWFnZSBvdmVybGF5IHN1cHBvcnQgaW4gaW1hZ2UgZG9jdW1l bnRzLCBieSBzZXR0aW5nIGAtd2Via2l0LXVzZXItc2VsZWN0OiB0ZXh0O2Agb24gdGhlIGltYWdl IG92ZXJsYXkKKyAgICAgICAgY29udGFpbmVyIGFuZCBgY3Vyc29yOiB0ZXh0O2Agb24gZWFjaCBv ZiB0aGUgdGV4dCBjaGlsZHJlbi4gQWRkaXRpb25hbGx5LCBtYWtlIGl0IHNvIHRoYXQgdGV4dCBz ZWxlY3Rpb24gaW4KKyAgICAgICAgaW1hZ2Ugb3ZlcmxheXMgZG9lc24ndCB0cmlnZ2VyIGEgY2xp Y2sgZXZlbnQsIHNvIHRoYXQgYXR0ZW1wdGluZyB0byBzZWxlY3QgdGV4dCBkb2Vzbid0IHRyaWdn ZXIgY2xpY2sgZXZlbnRzLgorCisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MRWxlbWVudDo6dXBkYXRlV2l0aEltYWdlRXh0cmFjdGlvblJlc3Vs dCk6CisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RXZlbnRIYW5kbGVyOjp1cGRhdGVTZWxlY3Rpb25Gb3JNb3VzZURyYWcpOgorCiAyMDIxLTAzLTEx ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIEJpbmFyeVNl bWFwaG9yZSBpbiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OndyaXRlQmxvYnNUb0Rpc2tGb3JJbmRl eGVkREJTeW5jaHJvbm91c2x5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKaW5kZXgg M2JhMDg3NTBlYTUyYjg1YmVjZTRhZTAyOGVhYzU0Y2M4MGE4NWU5OC4uZWI4MzY1ODIzMWVmNjU4 MmEzNTFkMzQ2OTE3MjcyNzllM2NmOTY2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5j cHAKQEAgLTEyODAsNiArMTI4MCw4IEBAIHZvaWQgSFRNTEVsZW1lbnQ6OnVwZGF0ZVdpdGhJbWFn ZUV4dHJhY3Rpb25SZXN1bHQoSW1hZ2VFeHRyYWN0aW9uUmVzdWx0JiYgcmVzdWx0CiAKICAgICBh dXRvIGNvbnRhaW5lciA9IEhUTUxEaXZFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQoKSk7CiAgICAg Y29udGFpbmVyLT5zZXRJZEF0dHJpYnV0ZShpbWFnZU92ZXJsYXlFbGVtZW50SWRlbnRpZmllcigp KTsKKyAgICBpZiAoZG9jdW1lbnQoKS5pc0ltYWdlRG9jdW1lbnQoKSkKKyAgICAgICAgY29udGFp bmVyLT5zZXRJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0VXNlclNlbGVjdCwg Q1NTVmFsdWVUZXh0KTsKICAgICBzaGFkb3dSb290LT5hcHBlbmRDaGlsZChjb250YWluZXIpOwog CiAgICAgc3RhdGljIE1haW5UaHJlYWROZXZlckRlc3Ryb3llZDxjb25zdCBBdG9tU3RyaW5nPiBp bWFnZU92ZXJsYXlUZXh0Q2xhc3MoImltYWdlLW92ZXJsYXktdGV4dCIsIEF0b21TdHJpbmc6OkNv bnN0cnVjdEZyb21MaXRlcmFsKTsKQEAgLTEzMTIsNiArMTMxNCw5IEBAIHZvaWQgSFRNTEVsZW1l bnQ6OnVwZGF0ZVdpdGhJbWFnZUV4dHJhY3Rpb25SZXN1bHQoSW1hZ2VFeHRyYWN0aW9uUmVzdWx0 JiYgcmVzdWx0CiAgICAgICAgICAgICByb3RhdGlvblRyYW5zZm9ybWF0aW9uQXNUZXh0LAogICAg ICAgICAgICAgInNjYWxlKCJfcywgc2NhbGUud2lkdGgoKSwgIiwgIl9zLCBzY2FsZS5oZWlnaHQo KSwgIikgIl9zCiAgICAgICAgICkpOworCisgICAgICAgIGlmIChkb2N1bWVudCgpLmlzSW1hZ2VE b2N1bWVudCgpKQorICAgICAgICAgICAgY2hpbGQtPnNldElubGluZVN0eWxlUHJvcGVydHkoQ1NT UHJvcGVydHlDdXJzb3IsIENTU1ZhbHVlVGV4dCk7CiAgICAgfQogCiAgICAgaWYgKGF1dG8gZnJh bWUgPSBtYWtlUmVmUHRyKGRvY3VtZW50KCkuZnJhbWUoKSkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAKaW5kZXggM2ZlMWQyODdlY2U2NzU4OGVlMmE5ZThiN2IzZmIwYzNiNDhjOWZk ZS4uMTBiZTYyMDQ0NDBiZWFjODc4MTQ3NTM4ODRhYjViMDVjZDRiYWMxOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtOTk5LDYgKzk5OSwxMCBAQCB2b2lkIEV2ZW50SGFu ZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhp dFRlc3RSZXN1bAogCiAgICAgbV9mcmFtZS5zZWxlY3Rpb24oKS5zZXRTZWxlY3Rpb25CeU1vdXNl SWZEaWZmZXJlbnQobmV3U2VsZWN0aW9uLCBtX2ZyYW1lLnNlbGVjdGlvbigpLmdyYW51bGFyaXR5 KCksCiAgICAgICAgIEZyYW1lU2VsZWN0aW9uOjpFbmRQb2ludHNBZGp1c3RtZW50TW9kZTo6QWRq dXN0QXRCaWRpQm91bmRhcnkpOworCisgICAgaWYgKG5ld1NlbGVjdGlvbi5zdGFydCgpLmNvbnRh aW5lck5vZGUoKSAmJiBIVE1MRWxlbWVudDo6aXNJbWFnZU92ZXJsYXlUZXh0KCpuZXdTZWxlY3Rp b24uc3RhcnQoKS5jb250YWluZXJOb2RlKCkpCisgICAgICAgICYmIG5ld1NlbGVjdGlvbi5lbmQo KS5jb250YWluZXJOb2RlKCkgJiYgSFRNTEVsZW1lbnQ6OmlzSW1hZ2VPdmVybGF5VGV4dCgqbmV3 U2VsZWN0aW9uLmVuZCgpLmNvbnRhaW5lck5vZGUoKSkpCisgICAgICAgIGludmFsaWRhdGVDbGlj aygpOwogfQogI2VuZGlmIC8vIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAK 423140 2021-03-14 20:17:30 -0700 2021-03-15 06:36:58 -0700 v2 (w/ tests) bug-223075-20210314201729.patch text/plain 11106 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0Mzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmU1ZjcyNDg1Y2I0MjNj NDY4ZGNkNjY4YjFiMjhhMDdlYTJmNzU1Ni4uZjYyOTZiZmY5ZGI3NWVmZTY3MmZjZGEwMzJjMDky OTQ5ZjgzYTNjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIxLTAzLTE0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gU2Vs ZWN0aW5nIHRleHQgdmlhIG1vdXNlIGRyYWcgaW4gaW1hZ2UgZG9jdW1lbnRzIHNob3VsZG4ndCB0 cmlnZ2VyIGNsaWNrIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIzMDc1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTMzNDYxMT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXByb3ZlIGlt YWdlIG92ZXJsYXkgc3VwcG9ydCBpbiBpbWFnZSBkb2N1bWVudHMsIGJ5IHNldHRpbmcgYC13ZWJr aXQtdXNlci1zZWxlY3Q6IHRleHQ7YCBvbiB0aGUgaW1hZ2Ugb3ZlcmxheQorICAgICAgICBjb250 YWluZXIgYW5kIGBjdXJzb3I6IHRleHQ7YCBvbiBlYWNoIG9mIHRoZSB0ZXh0IGNoaWxkcmVuLiBB ZGRpdGlvbmFsbHksIG1ha2UgaXQgc28gdGhhdCB0ZXh0IHNlbGVjdGlvbiBpbgorICAgICAgICBp bWFnZSBvdmVybGF5cyBkb2Vzbid0IHRyaWdnZXIgYSBjbGljayBldmVudCwgc28gdGhhdCBhdHRl bXB0aW5nIHRvIHNlbGVjdCB0ZXh0IGRvZXNuJ3QgdHJpZ2dlciBjbGljayBldmVudHMuCisKKyAg ICAgICAgVGVzdHM6IGZhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vbWFjL3NlbGVjdC1pbWFn ZS1vdmVybGF5LXdpdGgtbW91c2UtZHJhZy1kb2VzLW5vdC1maXJlLWNsaWNrLmh0bWwKKyAgICAg ICAgICAgICAgIGZhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vbWFjL3NlbGVjdC1pbWFnZS1v dmVybGF5LXdpdGgtbW91c2UtZHJhZy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVtZW50Ojppc0ltYWdlT3ZlcmxheVRleHQp OgorCisgICAgICAgIE1ha2UgYSBzbGlnaHQgYWRqdXN0bWVudCBoZXJlIHRvIGhhbmRsZSB0aGUg Y2FzZSB3aGVyZSB0aGUgaG9zdCBlbGVtZW50J3Mgc2hhZG93IHJvb3QgaXMgbm90IGluc3RhbGxl ZCBieSB0aGUKKyAgICAgICAgdXNlciBhZ2VudCwgYW5kIGFsc28gc28gdGhhdCB3ZSByZXR1cm4g YHRydWVgIGZvciBhbGwgbm9kZXMgdW5kZXJuZWF0aCB0aGUgaW1hZ2Ugb3ZlcmxheSBjb250YWlu ZXIgYXMgd2VsbCAobm90CisgICAgICAgIGp1c3QgdGV4dCBub2RlcykuIFNlZSBgRHJhZ0NvbnRy b2xsZXJgIGNoYW5nZSBiZWxvdyBmb3IgbW9yZSBkZXRhaWxzLgorCisgICAgICAgIChXZWJDb3Jl OjpIVE1MRWxlbWVudDo6dXBkYXRlV2l0aEltYWdlRXh0cmFjdGlvblJlc3VsdCk6CisgICAgICAg ICogcGFnZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJv bGxlcjo6ZHJhZ2dhYmxlRWxlbWVudCBjb25zdCk6CisKKyAgICAgICAgTWFrZSBhbm90aGVyIGFk anVzdG1lbnQgdG8gYERyYWdDb250cm9sbGVyOjpkcmFnZ2FibGVFbGVtZW50YCwgc3VjaCB0aGF0 IHdlIGRvbid0IGluaXRpYXRlIGltYWdlIGRyYWdzIHdoZW4KKyAgICAgICAgZHJhZ2dpbmcgb3Zl ciB0ZXh0IGluc2lkZSB0aGUgaW1hZ2Ugb3ZlcmxheS4gTm90ZSB0aGF0IHRoaXMgZG9lcyBub3Qg cHJldmVudCBkcmFnIHN0YXJ0IHdoZW4gdGhlIHRleHQgaXMKKyAgICAgICAgc2VsZWN0ZWQsIHNp bmNlIHRoYXQgZG9lcyBub3QgcmVzdWx0IGluIGFuIGltYWdlIGRyYWcgKGkuZS4sIGBEcmFnU291 cmNlQWN0aW9uOjpJbWFnZWApLgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjp1cGRhdGVTZWxlY3Rpb25Gb3JNb3VzZURy YWcpOgorCiAyMDIxLTAzLTEzICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29t PgogCiAgICAgICAgIFtpT1NdIFNlbGVjdGluZyB0aGUgZmlyc3Qgd29yZCBpbiBhbiBpbWFnZSBv dmVybGF5IG1heSBzZWxlY3QgdGV4dCBpbiB0aGUgcHJldmlvdXMgbGluZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxFbGVtZW50LmNwcAppbmRleCAyMTY5YjVlZmE4OTg3ZGM5Mzk2MjFkNDM3YTQ1ZTFhMWFl Y2ZjY2FiLi40MmNmOWFlYzM3ZmZkODZiM2VmYTI5YjYyYWYwMmUwYThlZjc1YmRjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxFbGVtZW50LmNwcApAQCAtMTIzNiwyMiArMTIzNiwxNyBAQCBib29sIEhU TUxFbGVtZW50OjpoYXNJbWFnZU92ZXJsYXkoKSBjb25zdAogCiBib29sIEhUTUxFbGVtZW50Ojpp c0ltYWdlT3ZlcmxheVRleHQoY29uc3QgTm9kZSYgbm9kZSkKIHsKLSAgICBpZiAoIWlzPFRleHQ+ KG5vZGUpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICBhdXRvIHNoYWRvd0hvc3QgPSBu b2RlLnNoYWRvd0hvc3QoKTsKICAgICBpZiAoIXNoYWRvd0hvc3QpCiAgICAgICAgIHJldHVybiBm YWxzZTsKIAotICAgIGF1dG8gdXNlckFnZW50U2hhZG93Um9vdCA9IHNoYWRvd0hvc3QtPnVzZXJB Z2VudFNoYWRvd1Jvb3QoKTsKLSAgICBpZiAoIXVzZXJBZ2VudFNoYWRvd1Jvb3QpIHsKLSAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgYXV0byBzaGFkb3dSb290ID0gc2hhZG93SG9z dC0+c2hhZG93Um9vdCgpOworICAgIGlmICghc2hhZG93Um9vdCB8fCBzaGFkb3dSb290LT5tb2Rl KCkgIT0gU2hhZG93Um9vdE1vZGU6OlVzZXJBZ2VudCB8fCBzaGFkb3dSb290ICE9IG5vZGUuY29u dGFpbmluZ1NoYWRvd1Jvb3QoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KIAotICAg IGZvciAoYXV0byYgY2hpbGQgOiBjaGlsZHJlbk9mVHlwZTxIVE1MRGl2RWxlbWVudD4oKnVzZXJB Z2VudFNoYWRvd1Jvb3QpKSB7CisgICAgZm9yIChhdXRvJiBjaGlsZCA6IGNoaWxkcmVuT2ZUeXBl PEhUTUxEaXZFbGVtZW50Pigqc2hhZG93Um9vdCkpIHsKICAgICAgICAgaWYgKGNoaWxkLmdldElk QXR0cmlidXRlKCkgPT0gaW1hZ2VPdmVybGF5RWxlbWVudElkZW50aWZpZXIoKSkKLSAgICAgICAg ICAgIHJldHVybiBjaGlsZC5jb250YWlucygmbm9kZSk7CisgICAgICAgICAgICByZXR1cm4gbm9k ZS5pc0Rlc2NlbmRhbnRPZigmY2hpbGQpOwogICAgIH0KIAogICAgIHJldHVybiBmYWxzZTsKQEAg LTEyODAsNiArMTI3NSw4IEBAIHZvaWQgSFRNTEVsZW1lbnQ6OnVwZGF0ZVdpdGhJbWFnZUV4dHJh Y3Rpb25SZXN1bHQoSW1hZ2VFeHRyYWN0aW9uUmVzdWx0JiYgcmVzdWx0CiAKICAgICBhdXRvIGNv bnRhaW5lciA9IEhUTUxEaXZFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQoKSk7CiAgICAgY29udGFp bmVyLT5zZXRJZEF0dHJpYnV0ZShpbWFnZU92ZXJsYXlFbGVtZW50SWRlbnRpZmllcigpKTsKKyAg ICBpZiAoZG9jdW1lbnQoKS5pc0ltYWdlRG9jdW1lbnQoKSkKKyAgICAgICAgY29udGFpbmVyLT5z ZXRJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0VXNlclNlbGVjdCwgQ1NTVmFs dWVUZXh0KTsKICAgICBzaGFkb3dSb290LT5hcHBlbmRDaGlsZChjb250YWluZXIpOwogCiAgICAg c3RhdGljIE1haW5UaHJlYWROZXZlckRlc3Ryb3llZDxjb25zdCBBdG9tU3RyaW5nPiBpbWFnZU92 ZXJsYXlUZXh0Q2xhc3MoImltYWdlLW92ZXJsYXktdGV4dCIsIEF0b21TdHJpbmc6OkNvbnN0cnVj dEZyb21MaXRlcmFsKTsKQEAgLTEzMTIsNiArMTMwOSw5IEBAIHZvaWQgSFRNTEVsZW1lbnQ6OnVw ZGF0ZVdpdGhJbWFnZUV4dHJhY3Rpb25SZXN1bHQoSW1hZ2VFeHRyYWN0aW9uUmVzdWx0JiYgcmVz dWx0CiAgICAgICAgICAgICByb3RhdGlvblRyYW5zZm9ybWF0aW9uQXNUZXh0LAogICAgICAgICAg ICAgInNjYWxlKCJfcywgc2NhbGUud2lkdGgoKSwgIiwgIl9zLCBzY2FsZS5oZWlnaHQoKSwgIikg Il9zCiAgICAgICAgICkpOworCisgICAgICAgIGlmIChkb2N1bWVudCgpLmlzSW1hZ2VEb2N1bWVu dCgpKQorICAgICAgICAgICAgY2hpbGQtPnNldElubGluZVN0eWxlUHJvcGVydHkoQ1NTUHJvcGVy dHlDdXJzb3IsIENTU1ZhbHVlVGV4dCk7CiAgICAgfQogCiAgICAgaWYgKGF1dG8gZnJhbWUgPSBt YWtlUmVmUHRyKGRvY3VtZW50KCkuZnJhbWUoKSkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRy b2xsZXIuY3BwCmluZGV4IDg0MjFkMjU2MWY5MjlhMDY2NzU4ZTBhMzVjZTZiYzdhZDRkNDMzOTgu LjNmYjIxNzE5ZGZkNzQ0NmEzMGMzNzk3YWE0ZjAwZjIyOGUzZDY2OGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCkBAIC03OTgsNiArNzk4LDcgQEAgRWxlbWVudCogRHJh Z0NvbnRyb2xsZXI6OmRyYWdnYWJsZUVsZW1lbnQoY29uc3QgRnJhbWUqIHNvdXJjZUZyYW1lLCBF bGVtZW50KiBzdGEKICAgICAgICAgaWYgKGRyYWdNb2RlID09IFVzZXJEcmFnOjpBdXRvKSB7CiAg ICAgICAgICAgICBpZiAoKG1fZHJhZ1NvdXJjZUFjdGlvbi5jb250YWlucyhEcmFnU291cmNlQWN0 aW9uOjpJbWFnZSkpCiAgICAgICAgICAgICAgICAgJiYgaXM8SFRNTEltYWdlRWxlbWVudD4oKmVs ZW1lbnQpCisgICAgICAgICAgICAgICAgJiYgIUhUTUxFbGVtZW50Ojppc0ltYWdlT3ZlcmxheVRl eHQoKnN0YXJ0RWxlbWVudCkKICAgICAgICAgICAgICAgICAmJiBpbWFnZUVsZW1lbnRJc0RyYWdn YWJsZShkb3duY2FzdDxIVE1MSW1hZ2VFbGVtZW50PigqZWxlbWVudCksICpzb3VyY2VGcmFtZSkp IHsKICAgICAgICAgICAgICAgICBzdGF0ZS50eXBlLmFkZChEcmFnU291cmNlQWN0aW9uOjpJbWFn ZSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAKaW5kZXggMmYxOGUxZWVlOTg0ZTkwMWQxNGU1Yjk1MmVjNTFhMGIyM2FlNGU4 Yi4uMzcwZWFiM2IwZWZiNDc1ZTRlN2M4ZDI1NWFhOGM4NGQ4NTU0ZGQ5NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtOTk5LDYgKzk5OSwxMCBAQCB2b2lkIEV2ZW50SGFu ZGxlcjo6dXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhp dFRlc3RSZXN1bAogCiAgICAgbV9mcmFtZS5zZWxlY3Rpb24oKS5zZXRTZWxlY3Rpb25CeU1vdXNl SWZEaWZmZXJlbnQobmV3U2VsZWN0aW9uLCBtX2ZyYW1lLnNlbGVjdGlvbigpLmdyYW51bGFyaXR5 KCksCiAgICAgICAgIEZyYW1lU2VsZWN0aW9uOjpFbmRQb2ludHNBZGp1c3RtZW50TW9kZTo6QWRq dXN0QXRCaWRpQm91bmRhcnkpOworCisgICAgaWYgKG5ld1NlbGVjdGlvbi5zdGFydCgpLmNvbnRh aW5lck5vZGUoKSAmJiBIVE1MRWxlbWVudDo6aXNJbWFnZU92ZXJsYXlUZXh0KCpuZXdTZWxlY3Rp b24uc3RhcnQoKS5jb250YWluZXJOb2RlKCkpCisgICAgICAgICYmIG5ld1NlbGVjdGlvbi5lbmQo KS5jb250YWluZXJOb2RlKCkgJiYgSFRNTEVsZW1lbnQ6OmlzSW1hZ2VPdmVybGF5VGV4dCgqbmV3 U2VsZWN0aW9uLmVuZCgpLmNvbnRhaW5lck5vZGUoKSkpCisgICAgICAgIGludmFsaWRhdGVDbGlj aygpOwogfQogI2VuZGlmIC8vIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4OTM3NjVi Y2IwNzczYWI3MzBmNDU5ZjdhODhlZWZlN2JkMDlkYWE1Li5iOGFmNjFhMmY1MTkzZjBkODkwNWVi NmJiNTYzMGFlMGUxNmFlYjg0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDMtMTQgIFdl bnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBT ZWxlY3RpbmcgdGV4dCB2aWEgbW91c2UgZHJhZyBpbiBpbWFnZSBkb2N1bWVudHMgc2hvdWxkbid0 IHRyaWdnZXIgY2xpY2sgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjMwNzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1MzM0NjExPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNv dXBsZSBvZiBuZXcgbGF5b3V0IHRlc3RzIHRvIGV4ZXJjaXNlIHRoZSBuZXcgYmVoYXZpb3IuCisK KyAgICAgICAgKiBmYXN0L2ltYWdlcy9pbWFnZS1leHRyYWN0aW9uL21hYy9zZWxlY3QtaW1hZ2Ut b3ZlcmxheS13aXRoLW1vdXNlLWRyYWctZG9lcy1ub3QtZmlyZS1jbGljay1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vbWFjL3NlbGVj dC1pbWFnZS1vdmVybGF5LXdpdGgtbW91c2UtZHJhZy1kb2VzLW5vdC1maXJlLWNsaWNrLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vbWFjL3NlbGVj dC1pbWFnZS1vdmVybGF5LXdpdGgtbW91c2UtZHJhZy1leHBlY3RlZC1taXNtYXRjaC5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2ltYWdlcy9pbWFnZS1leHRyYWN0aW9uL21hYy9zZWxlY3Qt aW1hZ2Utb3ZlcmxheS13aXRoLW1vdXNlLWRyYWcuaHRtbDogQWRkZWQuCisKIDIwMjEtMDMtMTMg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g U2VsZWN0aW5nIHRoZSBmaXJzdCB3b3JkIGluIGFuIGltYWdlIG92ZXJsYXkgbWF5IHNlbGVjdCB0 ZXh0IGluIHRoZSBwcmV2aW91cyBsaW5lCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2lt YWdlcy9pbWFnZS1leHRyYWN0aW9uL21hYy9zZWxlY3QtaW1hZ2Utb3ZlcmxheS13aXRoLW1vdXNl LWRyYWctZG9lcy1ub3QtZmlyZS1jbGljay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2ltYWdlcy9pbWFnZS1leHRyYWN0aW9uL21hYy9zZWxlY3QtaW1hZ2Utb3ZlcmxheS13aXRoLW1v dXNlLWRyYWctZG9lcy1ub3QtZmlyZS1jbGljay1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDNl NWVlZWRiZjFiNDM1Zjk2YzNhMjBiZjgxNDAxYWVlNDMzMTk4MQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vbWFjL3NlbGVjdC1pbWFn ZS1vdmVybGF5LXdpdGgtbW91c2UtZHJhZy1kb2VzLW5vdC1maXJlLWNsaWNrLWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxLDQgQEAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVT VCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9pbWFnZS1l eHRyYWN0aW9uL21hYy9zZWxlY3QtaW1hZ2Utb3ZlcmxheS13aXRoLW1vdXNlLWRyYWctZG9lcy1u b3QtZmlyZS1jbGljay5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvaW1hZ2UtZXh0cmFj dGlvbi9tYWMvc2VsZWN0LWltYWdlLW92ZXJsYXktd2l0aC1tb3VzZS1kcmFnLWRvZXMtbm90LWZp cmUtY2xpY2suaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYzJhODI5ZTRkNTkzNDhkZmM5NTViNjVkMTQxNzcw ZGRlNzE4ODEyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvaW1h Z2UtZXh0cmFjdGlvbi9tYWMvc2VsZWN0LWltYWdlLW92ZXJsYXktd2l0aC1tb3VzZS1kcmFnLWRv ZXMtbm90LWZpcmUtY2xpY2suaHRtbApAQCAtMCwwICsxLDM3IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QuanMiPjwvc2NyaXB0PgorPHN0eWxlPgoraW1nIHsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7 CisgICAgdG9wOiAwOworICAgIGxlZnQ6IDA7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+ Cis8aW1nIHNyYz0iLi4vLi4vcmVzb3VyY2VzL2dyZWVuLTQwMHg0MDAucG5nIj48L2ltZz4KKzxz Y3JpcHQ+CithZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgKCkgPT4geworICAgIGxldCBpbWFnZSA9 IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoImltZyIpOworICAgIGludGVybmFscy5pbnN0YWxsSW1h Z2VPdmVybGF5KGltYWdlLCBbeworICAgICAgICB0ZXh0IDogImhlbGxvIiwKKyAgICAgICAgdG9w TGVmdCA6IG5ldyBET01Qb2ludFJlYWRPbmx5KDAsIDAuNSksCisgICAgICAgIHRvcFJpZ2h0IDog bmV3IERPTVBvaW50UmVhZE9ubHkoMSwgMC41KSwKKyAgICAgICAgYm90dG9tUmlnaHQgOiBuZXcg RE9NUG9pbnRSZWFkT25seSgxLCAxKSwKKyAgICAgICAgYm90dG9tTGVmdCA6IG5ldyBET01Qb2lu dFJlYWRPbmx5KDAsIDEpLAorICAgIH1dKTsKKworICAgIGltYWdlLmFkZEV2ZW50TGlzdGVuZXIo ImNsaWNrIiwgZXZlbnQgPT4geworICAgICAgICB0ZXN0RmFpbGVkKCJPYnNlcnZlZCBjbGljay4i KTsKKyAgICB9KTsKKworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDUwLCAzMDApOworICAg IGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDM1 MCwgMzAwKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Cit9KTsKKzwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vbWFjL3NlbGVjdC1pbWFnZS1v dmVybGF5LXdpdGgtbW91c2UtZHJhZy1leHBlY3RlZC1taXNtYXRjaC5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9pbWFnZXMvaW1hZ2UtZXh0cmFjdGlvbi9tYWMvc2VsZWN0LWltYWdlLW92ZXJsYXkt d2l0aC1tb3VzZS1kcmFnLWV4cGVjdGVkLW1pc21hdGNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzdmNGM3 NzQ1MDI4MzZjMWQzYjc3NjFiNGM3MTYyNjM1ZDlhNjZiNgotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2ltYWdlLWV4dHJhY3Rpb24vbWFjL3NlbGVjdC1pbWFnZS1v dmVybGF5LXdpdGgtbW91c2UtZHJhZy1leHBlY3RlZC1taXNtYXRjaC5odG1sCkBAIC0wLDAgKzEs MTUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KK2ltZyB7Cisg ICAgcG9zaXRpb246IGFic29sdXRlOworICAgIHRvcDogMDsKKyAgICBsZWZ0OiAwOworfQorPC9z dHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPGltZyBzcmM9Ii4uLy4uL3Jlc291cmNlcy9ncmVlbi00 MDB4NDAwLnBuZyI+PC9pbWc+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQg b2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvaW1hZ2UtZXh0cmFj dGlvbi9tYWMvc2VsZWN0LWltYWdlLW92ZXJsYXktd2l0aC1tb3VzZS1kcmFnLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2ltYWdlcy9pbWFnZS1leHRyYWN0aW9uL21hYy9zZWxlY3QtaW1hZ2Utb3Zl cmxheS13aXRoLW1vdXNlLWRyYWcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xMmIzNjBhOThiOWRhNWQ3NWJl ZGVmZjVkMjMyNWFjMzY5MGRhNjEzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9pbWFnZXMvaW1hZ2UtZXh0cmFjdGlvbi9tYWMvc2VsZWN0LWltYWdlLW92ZXJsYXktd2l0aC1t b3VzZS1kcmFnLmh0bWwKQEAgLTAsMCArMSwzMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K KzxoZWFkPgorPHN0eWxlPgoraW1nIHsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgdG9w OiAwOworICAgIGxlZnQ6IDA7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8aW1nIHNy Yz0iLi4vLi4vcmVzb3VyY2VzL2dyZWVuLTQwMHg0MDAucG5nIj48L2ltZz4KKzxzY3JpcHQ+Cith ZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgKCkgPT4geworICAgIGxldCBpbWFnZSA9IGRvY3VtZW50 LnF1ZXJ5U2VsZWN0b3IoImltZyIpOworICAgIGludGVybmFscy5pbnN0YWxsSW1hZ2VPdmVybGF5 KGltYWdlLCBbeworICAgICAgICB0ZXh0IDogImhlbGxvIiwKKyAgICAgICAgdG9wTGVmdCA6IG5l dyBET01Qb2ludFJlYWRPbmx5KDAsIDAuNSksCisgICAgICAgIHRvcFJpZ2h0IDogbmV3IERPTVBv aW50UmVhZE9ubHkoMSwgMC41KSwKKyAgICAgICAgYm90dG9tUmlnaHQgOiBuZXcgRE9NUG9pbnRS ZWFkT25seSgxLCAxKSwKKyAgICAgICAgYm90dG9tTGVmdCA6IG5ldyBET01Qb2ludFJlYWRPbmx5 KDAsIDEpLAorICAgIH1dKTsKKworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDUwLCAzMDAp OworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92 ZVRvKDM1MCwgMzAwKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Cit9KTsKKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK