223051 2021-03-10 15:21:28 -0800 [BigSur wk1 arm64] platform/mac/fast/objc/longlongTest.html is a consistent failure 2021-03-11 16:56:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223050 InRadar P2 Normal --- 1 amir_mark mark.lam cdumez mark.lam webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1738269 0 amir_mark 2021-03-10 15:21:28 -0800 platform/mac/fast/objc/longlongTest.html Is a consistent failure on Big Sur Wk1 Apple Silicon machines. History: https://results.webkit.org/?suite=layout-tests&test=platform%2Fmac%2Ffast%2Fobjc%2FlonglongTest.html Diff: --- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/platform/mac/fast/objc/longlongTest-expected.txt +++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/platform/mac/fast/objc/longlongTest-actual.txt @@ -1,7 +1,7 @@ PASS Test LongLong: result is 0 as expected! PASS Test LongLong: result is 1 as expected! PASS Test LongLong: result is -1 as expected! -PASS Test LongLong: result is -9223372036854776000 as expected! +FAIL Test LongLong: result is 9223372036854776000, should be -9223372036854776000 PASS Test LongLong: result is -9223372036854776000 as expected! PASS Test UnsignedLongLong: result is 0 as expected! PASS Test UnsignedLongLong: result is 1 as expected! 1738270 1 webkit-bug-importer 2021-03-10 15:21:52 -0800 <rdar://problem/75286103> 1738273 2 amir_mark 2021-03-10 15:23:45 -0800 I cannot reproduce failure due to not having access to an Apple Silicon machine. 1738349 3 cdumez 2021-03-10 20:38:07 -0800 Similar to https://bugs.webkit.org/show_bug.cgi?id=223050, I will look tomorrow. 1738591 4 mark.lam 2021-03-11 13:13:23 -0800 *** Bug 223084 has been marked as a duplicate of this bug. *** 1738592 5 mark.lam 2021-03-11 13:14:51 -0800 The issue is that the test is expecting convertValueToObjcValue()'s conversion of double to long long to follow x86_64 semantics. I don't think there's a specification for this behaviors (falls under undefined behavior). I'll just change the code such that it emulates x86_64 behavior to placate the test. 1738593 6 422959 mark.lam 2021-03-11 13:20:12 -0800 Created attachment 422959 proposed patch. 1738594 7 422959 ysuzuki 2021-03-11 13:23:38 -0800 Comment on attachment 422959 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=422959&action=review r=me too > Source/WebCore/bridge/objc/objc_utility.mm:87 > +#if CPU(ARM64) > + // Match x86_64 semantics which allows for overflow. > + long long potentiallyOverflowed = (unsigned long long)d; > + if (potentiallyOverflowed < (long long)d) > + return potentiallyOverflowed; > +#endif Why not always using this path? 1738595 8 mark.lam 2021-03-11 13:25:43 -0800 (In reply to Yusuke Suzuki from comment #7) > Comment on attachment 422959 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422959&action=review > > r=me too > > > Source/WebCore/bridge/objc/objc_utility.mm:87 > > +#if CPU(ARM64) > > + // Match x86_64 semantics which allows for overflow. > > + long long potentiallyOverflowed = (unsigned long long)d; > > + if (potentiallyOverflowed < (long long)d) > > + return potentiallyOverflowed; > > +#endif > > Why not always using this path? I guess I can make it do that. 1738598 9 422961 mark.lam 2021-03-11 13:28:38 -0800 Created attachment 422961 patch for landing. 1738710 10 422961 mark.lam 2021-03-11 16:52:24 -0800 Comment on attachment 422961 patch for landing. Thanks for the reviews. Landing now. 1738715 11 ews-feeder 2021-03-11 16:56:32 -0800 Committed r274313: <https://commits.webkit.org/r274313> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422961. 422959 2021-03-11 13:20:12 -0800 2021-03-11 13:28:38 -0800 proposed patch. bug-223051.patch text/plain 2562 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NDI5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAzLTExICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBbQmlnU3VyIHdrMSBhcm02NF0gcGxh dGZvcm0vbWFjL2Zhc3Qvb2JqYy9sb25nbG9uZ1Rlc3QuaHRtbCBpcyBhIGNvbnNpc3RlbnQgZmFp bHVyZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy MzA1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBpc3N1ZSBpcyB0aGF0IHRoZSB0ZXN0IGlzIGV4cGVjdGluZyBjb252ZXJ0VmFsdWVUb09iamNW YWx1ZSgpJ3MgY29udmVyc2lvbiBvZgorICAgICAgICBkb3VibGUgdG8gbG9uZyBsb25nIHRvIGZv bGxvdyB4ODZfNjQgc2VtYW50aWNzLiAgSSBkb24ndCB0aGluayB0aGVyZSdzIGEKKyAgICAgICAg c3BlY2lmaWNhdGlvbiBmb3IgdGhpcyBiZWhhdmlvcnMgKGZhbGxzIHVuZGVyIHVuZGVmaW5lZCBi ZWhhdmlvcikuICBJJ2xsIGp1c3QKKyAgICAgICAgY2hhbmdlIHRoZSBjb2RlIHN1Y2ggdGhhdCBp dCBlbXVsYXRlcyB4ODZfNjQgYmVoYXZpb3IgdG8gcGxhY2F0ZSB0aGUgdGVzdC4KKworICAgICAg ICBUZXN0IGNvdmVyZWQgYnkgcGxhdGZvcm0vbWFjL2Zhc3Qvb2JqYy9sb25nbG9uZ1Rlc3QuaHRt bC4KKworICAgICAgICAqIGJyaWRnZS9vYmpjL29iamNfdXRpbGl0eS5tbToKKyAgICAgICAgKEpT Qzo6QmluZGluZ3M6OmNvbnZlcnREb3VibGVUb0xvbmdMb25nKToKKyAgICAgICAgKEpTQzo6Qmlu ZGluZ3M6OmNvbnZlcnRWYWx1ZVRvT2JqY1ZhbHVlKToKKwogMjAyMS0wMy0xMSAgRGV2aW4gUm91 c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgVmlkZW8gY29udHJvbHMgc3RheSBv biBzY3JlZW4gaW5kZWZpbml0ZWx5IGFmdGVyIGludGVyYWN0aW5nIHdpdGggdGltZSBzY3J1YmJl cgpJbmRleDogU291cmNlL1dlYkNvcmUvYnJpZGdlL29iamMvb2JqY191dGlsaXR5Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9vYmpjL29iamNfdXRpbGl0eS5tbQkocmV2 aXNpb24gMjc0Mjk2KQorKysgU291cmNlL1dlYkNvcmUvYnJpZGdlL29iamMvb2JqY191dGlsaXR5 Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykg MjAwNC0yMDE5IEFwcGxlIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQg KEMpIDIwMDQtMjAyMSBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC03Niw2ICs3NiwxOCBAQCBuYW1lc3BhY2UgQmluZGlu Z3MgewogICAgIFtdLCBvdGhlciAgICAgICBleGNlcHRpb24KIAogKi8KKworc3RhdGljIGxvbmcg bG9uZyBjb252ZXJ0RG91YmxlVG9Mb25nTG9uZyhkb3VibGUgZCkKK3sKKyNpZiBDUFUoQVJNNjQp CisgICAgLy8gTWF0Y2ggeDg2XzY0IHNlbWFudGljcyB3aGljaCBhbGxvd3MgZm9yIG92ZXJmbG93 LgorICAgIGxvbmcgbG9uZyBwb3RlbnRpYWxseU92ZXJmbG93ZWQgPSAodW5zaWduZWQgbG9uZyBs b25nKWQ7CisgICAgaWYgKHBvdGVudGlhbGx5T3ZlcmZsb3dlZCA8IChsb25nIGxvbmcpZCkKKyAg ICAgICAgcmV0dXJuIHBvdGVudGlhbGx5T3ZlcmZsb3dlZDsKKyNlbmRpZgorICAgIHJldHVybiAo bG9uZyBsb25nKWQ7Cit9CisKIE9iamNWYWx1ZSBjb252ZXJ0VmFsdWVUb09iamNWYWx1ZShKU0ds b2JhbE9iamVjdCogbGV4aWNhbEdsb2JhbE9iamVjdCwgSlNWYWx1ZSB2YWx1ZSwgT2JqY1ZhbHVl VHlwZSB0eXBlKQogewogICAgIE9iamNWYWx1ZSByZXN1bHQ7CkBAIC0xMjksNyArMTQxLDcgQEAg T2JqY1ZhbHVlIGNvbnZlcnRWYWx1ZVRvT2JqY1ZhbHVlKEpTR2xvYgogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIGNhc2UgT2JqY0xvbmdMb25nVHlwZToKICAgICAgICAgY2FzZSBPYmpjVW5z aWduZWRMb25nTG9uZ1R5cGU6Ci0gICAgICAgICAgICByZXN1bHQubG9uZ0xvbmdWYWx1ZSA9IChs b25nIGxvbmcpZDsKKyAgICAgICAgICAgIHJlc3VsdC5sb25nTG9uZ1ZhbHVlID0gY29udmVydERv dWJsZVRvTG9uZ0xvbmcoZCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBPYmpj RmxvYXRUeXBlOgogICAgICAgICAgICAgcmVzdWx0LmZsb2F0VmFsdWUgPSAoZmxvYXQpZDsK 422961 2021-03-11 13:28:38 -0800 2021-03-11 16:56:34 -0800 patch for landing. bug-223051.patch text/plain 2586 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NDI5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAzLTExICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBbQmlnU3VyIHdrMSBhcm02NF0gcGxh dGZvcm0vbWFjL2Zhc3Qvb2JqYy9sb25nbG9uZ1Rlc3QuaHRtbCBpcyBhIGNvbnNpc3RlbnQgZmFp bHVyZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy MzA1MQorCisgICAgICAgIFJldmlld2VkIGJ5IENocmlzIER1bWV6IGFuZCBZdXN1a2UgU3V6dWtp LgorCisgICAgICAgIFRoZSBpc3N1ZSBpcyB0aGF0IHRoZSB0ZXN0IGlzIGV4cGVjdGluZyBjb252 ZXJ0VmFsdWVUb09iamNWYWx1ZSgpJ3MgY29udmVyc2lvbiBvZgorICAgICAgICBkb3VibGUgdG8g bG9uZyBsb25nIHRvIGZvbGxvdyB4ODZfNjQgc2VtYW50aWNzLiAgSSBkb24ndCB0aGluayB0aGVy ZSdzIGEKKyAgICAgICAgc3BlY2lmaWNhdGlvbiBmb3IgdGhpcyBiZWhhdmlvciAoZmFsbHMgdW5k ZXIgdW5kZWZpbmVkIGJlaGF2aW9yKS4gIEknbGwganVzdAorICAgICAgICBjaGFuZ2UgdGhlIGNv ZGUgc3VjaCB0aGF0IGl0IGVtdWxhdGVzIHg4Nl82NCBiZWhhdmlvciB0byBwbGFjYXRlIHRoZSB0 ZXN0LgorCisgICAgICAgIFRlc3QgY292ZXJlZCBieSBwbGF0Zm9ybS9tYWMvZmFzdC9vYmpjL2xv bmdsb25nVGVzdC5odG1sLgorCisgICAgICAgICogYnJpZGdlL29iamMvb2JqY191dGlsaXR5Lm1t OgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6Y29udmVydERvdWJsZVRvTG9uZ0xvbmcpOgorICAg ICAgICAoSlNDOjpCaW5kaW5nczo6Y29udmVydFZhbHVlVG9PYmpjVmFsdWUpOgorCiAyMDIxLTAz LTExICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBWaWRlbyBj b250cm9scyBzdGF5IG9uIHNjcmVlbiBpbmRlZmluaXRlbHkgYWZ0ZXIgaW50ZXJhY3Rpbmcgd2l0 aCB0aW1lIHNjcnViYmVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9icmlkZ2Uvb2JqYy9vYmpjX3V0 aWxpdHkubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYnJpZGdlL29iamMvb2JqY191 dGlsaXR5Lm1tCShyZXZpc2lvbiAyNzQyOTYpCisrKyBTb3VyY2UvV2ViQ29yZS9icmlkZ2Uvb2Jq Yy9vYmpjX3V0aWxpdHkubW0JKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICog Q29weXJpZ2h0IChDKSAyMDA0LTIwMTkgQXBwbGUgSW5jLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyAqIENvcHlyaWdodCAoQykgMjAwNC0yMDIxIEFwcGxlIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTc2LDYgKzc2LDE2IEBAIG5h bWVzcGFjZSBCaW5kaW5ncyB7CiAgICAgW10sIG90aGVyICAgICAgIGV4Y2VwdGlvbgogCiAqLwor CitzdGF0aWMgbG9uZyBsb25nIGNvbnZlcnREb3VibGVUb0xvbmdMb25nKGRvdWJsZSBkKQorewor ICAgIC8vIEVuc3VyZSB0aGF0IG5vbi14ODZfNjQgcG9ydHMgd2lsbCBtYXRjaCB4ODZfNjQgc2Vt YW50aWNzIHdoaWNoIGFsbG93cyBmb3Igb3ZlcmZsb3cuCisgICAgbG9uZyBsb25nIHBvdGVudGlh bGx5T3ZlcmZsb3dlZCA9ICh1bnNpZ25lZCBsb25nIGxvbmcpZDsKKyAgICBpZiAocG90ZW50aWFs bHlPdmVyZmxvd2VkIDwgKGxvbmcgbG9uZylkKQorICAgICAgICByZXR1cm4gcG90ZW50aWFsbHlP dmVyZmxvd2VkOworICAgIHJldHVybiAobG9uZyBsb25nKWQ7Cit9CisKIE9iamNWYWx1ZSBjb252 ZXJ0VmFsdWVUb09iamNWYWx1ZShKU0dsb2JhbE9iamVjdCogbGV4aWNhbEdsb2JhbE9iamVjdCwg SlNWYWx1ZSB2YWx1ZSwgT2JqY1ZhbHVlVHlwZSB0eXBlKQogewogICAgIE9iamNWYWx1ZSByZXN1 bHQ7CkBAIC0xMjksNyArMTM5LDcgQEAgT2JqY1ZhbHVlIGNvbnZlcnRWYWx1ZVRvT2JqY1ZhbHVl KEpTR2xvYgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgT2JqY0xvbmdMb25nVHlw ZToKICAgICAgICAgY2FzZSBPYmpjVW5zaWduZWRMb25nTG9uZ1R5cGU6Ci0gICAgICAgICAgICBy ZXN1bHQubG9uZ0xvbmdWYWx1ZSA9IChsb25nIGxvbmcpZDsKKyAgICAgICAgICAgIHJlc3VsdC5s b25nTG9uZ1ZhbHVlID0gY29udmVydERvdWJsZVRvTG9uZ0xvbmcoZCk7CiAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgY2FzZSBPYmpjRmxvYXRUeXBlOgogICAgICAgICAgICAgcmVzdWx0LmZs b2F0VmFsdWUgPSAoZmxvYXQpZDsK