223050 2021-03-10 15:05:18 -0800 [ macOS debug arm64 ] fast/dom/Range/compareBoundaryPoints-compareHow-exception.html is a constant text failure 2021-03-11 09:56:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223051 InRadar P2 Normal --- 1 jenner cdumez ap cdumez ggaren mark.lam rbuis rniwa sam thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1738260 0 jenner 2021-03-10 15:05:18 -0800 fast/dom/Range/compareBoundaryPoints-compareHow-exception.html is a constant text failure in macOS debug on Apple Silicon only. HISTORY URL: https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2FRange%2FcompareBoundaryPoints-compareHow-exception.html DIFF TEXT: --- /Volumes/Data/worker/bigsur-debug-applesilicon-tests-wk2/build/layout-test-results/fast/dom/Range/compareBoundaryPoints-compareHow-exception-expected.txt +++ /Volumes/Data/worker/bigsur-debug-applesilicon-tests-wk2/build/layout-test-results/fast/dom/Range/compareBoundaryPoints-compareHow-exception-actual.txt @@ -8,7 +8,7 @@ PASS range.compareBoundaryPoints(Range.END_TO_END, sourceRange) is -1 PASS range.compareBoundaryPoints(Range.END_TO_START, sourceRange) is -1 PASS range.compareBoundaryPoints(65536, sourceRange) is -1 -PASS range.compareBoundaryPoints(-1, sourceRange) threw exception NotSupportedError: The operation is not supported.. +FAIL range.compareBoundaryPoints(-1, sourceRange) should throw a NotSupportedError. Did not throw. PASS range.compareBoundaryPoints(4, sourceRange) threw exception NotSupportedError: The operation is not supported.. PASS range.compareBoundaryPoints(100, sourceRange) threw exception NotSupportedError: The operation is not supported.. PASS range.compareBoundaryPoints(65535, sourceRange) threw exception NotSupportedError: The operation is not supported.. 1738261 1 jenner 2021-03-10 15:05:38 -0800 I cannot reproduce the failure because I do not have access to an Apple Silicon Mac. 1738262 2 webkit-bug-importer 2021-03-10 15:06:02 -0800 <rdar://problem/75284949> 1738268 3 cdumez 2021-03-10 15:20:52 -0800 We are passing -1 as 'how' parameter (of type unsigned short). I would expect this to wrap around and become a very large number. Valid values for 'how' are in the range [0, 3]. We would throw if getting anything outside the range. I am unclear how we went from -1 to [0, 3] for now. 1738345 4 422896 cdumez 2021-03-10 20:07:18 -0800 Created attachment 422896 Patch 1738346 5 cdumez 2021-03-10 20:13:52 -0800 Credits to Alexey who helped identify the undefined behavior and Tim who helped with debugging on Apple Silicon. 1738386 6 ews-feeder 2021-03-11 01:10:37 -0800 Committed r274271: <https://commits.webkit.org/r274271> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422896. 1738498 7 ap 2021-03-11 09:53:31 -0800 *** Bug 223054 has been marked as a duplicate of this bug. *** 1738501 8 ap 2021-03-11 09:56:04 -0800 *** Bug 223053 has been marked as a duplicate of this bug. *** 422896 2021-03-10 20:07:18 -0800 2021-03-11 01:10:39 -0800 Patch bug-223050-20210310200717.patch text/plain 1802 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RjN2EyMjU0NDBlNzM4 MzgwMDRkODYyOGFiNDUyZDg2MjMwOTJhYy4uM2JhZGZjNWY2NWJjMmVmOTU4YjYyMTE5Nzg1YWUy MmUwOGRhYjBlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBtYWNPUyBkZWJ1ZyBhcm02 NCBdZmFzdC9kb20vUmFuZ2UvY29tcGFyZUJvdW5kYXJ5UG9pbnRzLWNvbXBhcmVIb3ctZXhjZXB0 aW9uLmh0bWwgaXMgYSBjb25zdGFudCB0ZXh0IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzA1MAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNzUyODQ5NDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2FzdGluZyBhIG5lZ2F0aXZlIGRvdWJsZSB0byBhbiB1bnNpZ25lZCBpbnRlZ2VyIHR5 cGUgaXMgdW5kZWZpbmVkIGJlaGF2aW9yLgorICAgICAgICBXZSBuZWVkIHRvIG1ha2Ugc3VyZSB0 aGUgZG91YmxlIHZhbHVlIGlzIHBvc2l0aXZlIGJlZm9yZSBjYXN0aW5nLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogYmluZGlu Z3MvanMvSlNET01Db252ZXJ0TnVtYmVycy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b1NtYWxs ZXJVSW50KToKKwogMjAyMS0wMy0xMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIGFub3RoZXIgV2luZG93cyBidWlsZCBmaXggYWZ0ZXIgcjI3 NDI1Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQ29udmVy dE51bWJlcnMuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Db252ZXJ0TnVt YmVycy5jcHAKaW5kZXggZWE5MmQ3N2Y3MDU1Yjk4YTI1MGFkYTc0ODE0N2Q4MTUwY2U3MTYzMS4u M2MxNTY5N2MwNTc1MTU0ZDk0ZTNjZWRlNWE1YTlmY2M1Y2M4Yjc5OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Db252ZXJ0TnVtYmVycy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Db252ZXJ0TnVtYmVycy5jcHAKQEAgLTE4NCw3 ICsxODQsMTAgQEAgc3RhdGljIGlubGluZSBUIHRvU21hbGxlclVJbnQoSlNHbG9iYWxPYmplY3Qm IGxleGljYWxHbG9iYWxPYmplY3QsIEpTVmFsdWUgdmFsdWUKICAgICAgICAgcmV0dXJuIDA7CiAK ICAgICB4ID0geCA8IDAgPyAtZmxvb3IoZmFicyh4KSkgOiBmbG9vcihmYWJzKHgpKTsKLSAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8VD4oZm1vZCh4LCBMaW1pdHNUcmFpdDo6bnVtYmVyT2ZWYWx1ZXMp KTsKKyAgICB4ID0gZm1vZCh4LCBMaW1pdHNUcmFpdDo6bnVtYmVyT2ZWYWx1ZXMpOworICAgIGlm ICh4IDwgMCkKKyAgICAgICAgeCArPSBMaW1pdHNUcmFpdDo6bnVtYmVyT2ZWYWx1ZXM7CisgICAg cmV0dXJuIHN0YXRpY19jYXN0PFQ+KHgpOwogfQogCiB0ZW1wbGF0ZTw+IGludDhfdCBjb252ZXJ0 VG9JbnRlZ2VyRW5mb3JjZVJhbmdlPGludDhfdD4oSlNDOjpKU0dsb2JhbE9iamVjdCYgbGV4aWNh bEdsb2JhbE9iamVjdCwgSlNDOjpKU1ZhbHVlIHZhbHVlKQo=