223040 2021-03-10 12:46:36 -0800 Use std::forward for forwarding references instead of WTFMove 2021-03-10 14:08:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1738185 0 dino 2021-03-10 12:46:36 -0800 Use std::forward for forwarding references instead of WTFMove 1738187 1 422861 dino 2021-03-10 12:48:35 -0800 Created attachment 422861 Patch 1738191 2 darin 2021-03-10 13:04:11 -0800 Thank you Dean, thank you clang. 1738225 3 ews-feeder 2021-03-10 14:07:54 -0800 Committed r274241: <https://commits.webkit.org/r274241> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422861. 1738226 4 webkit-bug-importer 2021-03-10 14:08:17 -0800 <rdar://problem/75281496> 422861 2021-03-10 12:48:35 -0800 2021-03-10 14:07:55 -0800 Patch bug-223040-20210311074834.patch text/plain 4725 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA3MTYwMDMxNTlhM2RjZDY3MzY4NDlh ZmE1MjQ2MzhhOTVkOTQxOWEuLjVhNjhmOTIwNGViM2I3NjMyNjNjYmMyYTcwZGE0ZTlhZTAzYTc2 OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDMtMTAgIERlYW4gSmFja3NvbiAgPGRpbm9A YXBwbGUuY29tPgorCisgICAgICAgIFVzZSBzdGQ6OmZvcndhcmQgZm9yIGZvcndhcmRpbmcgcmVm ZXJlbmNlcyBpbnN0ZWFkIG9mIFdURk1vdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyMzA0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEEgbmV3ZXIgdmVyc2lvbiBvZiBjbGFuZyBwcm9kdWNlZCBhIGhl bHBmdWwgd2FybmluZyB0aGF0IHRvbGQKKyAgICAgICAgdXMgd2Ugd2VyZSB1c2luZyBXVEZNb3Zl IGluIHBsYWNlcyB3aGVyZSB3ZSBzaG91bGQgdXNlIHN0ZDo6Zm9yd2FyZC4KKworICAgICAgICAq IHd0Zi9FeHBlY3RlZC5oOgorICAgICAgICAoc3RkOjpleHBlcmltZW50YWw6OmZ1bmRhbWVudGFs c192Mzo6ZXhwZWN0ZWQ6Om9wZXJhdG9yPSk6CisgICAgICAgICogd3RmL0Z1bmN0aW9uLmg6Cisg ICAgICAgIChXVEY6OkZ1bmN0aW9uPE91dCk6CisgICAgICAgICogd3RmL05ldmVyRGVzdHJveWVk Lmg6CisgICAgICAgIChXVEY6Om1ha2VOZXZlckRlc3Ryb3llZCk6CisKIDIwMjEtMDMtMDkgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVzaW5nIGNhbGxP bk1haW5UaHJlYWQoKSAvIGlzTWFpblRocmVhZCgpIGluIFdlYktpdDIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL0V4cGVjdGVkLmggYi9Tb3VyY2UvV1RGL3d0Zi9FeHBlY3RlZC5oCmluZGV4 IGU1NDA3NWFmNWRkY2I2YjI5MWYzODk4NjllODgxZDJlNmQ5NTUwMTEuLjc0NzJmZmFhMjIyY2Rj ZmE1NDQ5MTQzYzMzNmI0NzgxZGNkMDRhN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0V4 cGVjdGVkLmgKKysrIGIvU291cmNlL1dURi93dGYvRXhwZWN0ZWQuaApAQCAtNDUyLDcgKzQ1Miw3 IEBAIHB1YmxpYzoKIAogICAgIGV4cGVjdGVkJiBvcGVyYXRvcj0oY29uc3QgZXhwZWN0ZWQmIGUp IHsgdHlwZShlKS5zd2FwKCp0aGlzKTsgcmV0dXJuICp0aGlzOyB9CiAgICAgZXhwZWN0ZWQmIG9w ZXJhdG9yPShleHBlY3RlZCYmIGUpIHsgdHlwZShzdGQ6Om1vdmUoZSkpLnN3YXAoKnRoaXMpOyBy ZXR1cm4gKnRoaXM7IH0KLSAgICB0ZW1wbGF0ZTxjbGFzcyBVPiBleHBlY3RlZCYgb3BlcmF0b3I9 KFUmJiB1KSB7IHR5cGUoc3RkOjptb3ZlKHUpKS5zd2FwKCp0aGlzKTsgcmV0dXJuICp0aGlzOyB9 CisgICAgdGVtcGxhdGU8Y2xhc3MgVT4gZXhwZWN0ZWQmIG9wZXJhdG9yPShVJiYgdSkgeyB0eXBl KHN0ZDo6Zm9yd2FyZDxVPih1KSkuc3dhcCgqdGhpcyk7IHJldHVybiAqdGhpczsgfQogICAgIGV4 cGVjdGVkJiBvcGVyYXRvcj0oY29uc3QgdW5leHBlY3RlZF90eXBlJiB1KSB7IHR5cGUodSkuc3dh cCgqdGhpcyk7IHJldHVybiAqdGhpczsgfQogICAgIGV4cGVjdGVkJiBvcGVyYXRvcj0odW5leHBl Y3RlZF90eXBlJiYgdSkgeyB0eXBlKHN0ZDo6bW92ZSh1KSkuc3dhcCgqdGhpcyk7IHJldHVybiAq dGhpczsgfQogICAgIC8vIHRlbXBsYXRlPGNsYXNzLi4uIEFyZ3M+IHZvaWQgZW1wbGFjZShBcmdz JiYuLi4pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRnVuY3Rpb24uaCBiL1NvdXJjZS9X VEYvd3RmL0Z1bmN0aW9uLmgKaW5kZXggZTE1NDE4YWEyYmM3MmE3ZTQ2NWI5YjY3NGYyYTMzNzc2 NzMxMjM4Zi4uMmFhMGQxYWI2M2I3NDY1NzQ2OGE2MTY5MWJkMjkzMzc3OTA5YjE4NiAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvRnVuY3Rpb24uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GdW5j dGlvbi5oCkBAIC03MSwxMSArNzEsMTEgQEAgcHVibGljOgogCiAgICAgdGVtcGxhdGU8dHlwZW5h bWUgQ2FsbGFibGVUeXBlLCBjbGFzcyA9IHR5cGVuYW1lIHN0ZDo6ZW5hYmxlX2lmPCEoc3RkOjpp c19wb2ludGVyPENhbGxhYmxlVHlwZT46OnZhbHVlICYmIHN0ZDo6aXNfZnVuY3Rpb248dHlwZW5h bWUgc3RkOjpyZW1vdmVfcG9pbnRlcjxDYWxsYWJsZVR5cGU+Ojp0eXBlPjo6dmFsdWUpICYmIHN0 ZDo6aXNfcnZhbHVlX3JlZmVyZW5jZTxDYWxsYWJsZVR5cGUmJj46OnZhbHVlPjo6dHlwZT4KICAg ICBGdW5jdGlvbihDYWxsYWJsZVR5cGUmJiBjYWxsYWJsZSkKLSAgICAgICAgOiBtX2NhbGxhYmxl V3JhcHBlcihtYWtlVW5pcXVlPERldGFpbDo6Q2FsbGFibGVXcmFwcGVyPENhbGxhYmxlVHlwZSwg T3V0LCBJbi4uLj4+KFdURk1vdmUoY2FsbGFibGUpKSkgeyB9CisgICAgICAgIDogbV9jYWxsYWJs ZVdyYXBwZXIobWFrZVVuaXF1ZTxEZXRhaWw6OkNhbGxhYmxlV3JhcHBlcjxDYWxsYWJsZVR5cGUs IE91dCwgSW4uLi4+PihzdGQ6OmZvcndhcmQ8Q2FsbGFibGVUeXBlPihjYWxsYWJsZSkpKSB7IH0K IAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEZ1bmN0aW9uVHlwZSwgY2xhc3MgPSB0eXBlbmFtZSBz dGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX3BvaW50ZXI8RnVuY3Rpb25UeXBlPjo6dmFsdWUgJiYgc3Rk Ojppc19mdW5jdGlvbjx0eXBlbmFtZSBzdGQ6OnJlbW92ZV9wb2ludGVyPEZ1bmN0aW9uVHlwZT46 OnR5cGU+Ojp2YWx1ZT46OnR5cGU+CiAgICAgRnVuY3Rpb24oRnVuY3Rpb25UeXBlIGYpCi0gICAg ICAgIDogbV9jYWxsYWJsZVdyYXBwZXIobWFrZVVuaXF1ZTxEZXRhaWw6OkNhbGxhYmxlV3JhcHBl cjxGdW5jdGlvblR5cGUsIE91dCwgSW4uLi4+PihXVEZNb3ZlKGYpKSkgeyB9CisgICAgICAgIDog bV9jYWxsYWJsZVdyYXBwZXIobWFrZVVuaXF1ZTxEZXRhaWw6OkNhbGxhYmxlV3JhcHBlcjxGdW5j dGlvblR5cGUsIE91dCwgSW4uLi4+PihzdGQ6OmZvcndhcmQ8RnVuY3Rpb25UeXBlPihmKSkpIHsg fQogCiAgICAgT3V0IG9wZXJhdG9yKCkoSW4uLi4gaW4pIGNvbnN0CiAgICAgewpAQCAtODgsMTQg Kzg4LDE0IEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBDYWxsYWJsZVR5cGUsIGNs YXNzID0gdHlwZW5hbWUgc3RkOjplbmFibGVfaWY8IShzdGQ6OmlzX3BvaW50ZXI8Q2FsbGFibGVU eXBlPjo6dmFsdWUgJiYgc3RkOjppc19mdW5jdGlvbjx0eXBlbmFtZSBzdGQ6OnJlbW92ZV9wb2lu dGVyPENhbGxhYmxlVHlwZT46OnR5cGU+Ojp2YWx1ZSkgJiYgc3RkOjppc19ydmFsdWVfcmVmZXJl bmNlPENhbGxhYmxlVHlwZSYmPjo6dmFsdWU+Ojp0eXBlPgogICAgIEZ1bmN0aW9uJiBvcGVyYXRv cj0oQ2FsbGFibGVUeXBlJiYgY2FsbGFibGUpCiAgICAgewotICAgICAgICBtX2NhbGxhYmxlV3Jh cHBlciA9IG1ha2VVbmlxdWU8RGV0YWlsOjpDYWxsYWJsZVdyYXBwZXI8Q2FsbGFibGVUeXBlLCBP dXQsIEluLi4uPj4oV1RGTW92ZShjYWxsYWJsZSkpOworICAgICAgICBtX2NhbGxhYmxlV3JhcHBl ciA9IG1ha2VVbmlxdWU8RGV0YWlsOjpDYWxsYWJsZVdyYXBwZXI8Q2FsbGFibGVUeXBlLCBPdXQs IEluLi4uPj4oc3RkOjpmb3J3YXJkPENhbGxhYmxlVHlwZT4oY2FsbGFibGUpKTsKICAgICAgICAg cmV0dXJuICp0aGlzOwogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEZ1bmN0aW9uVHlw ZSwgY2xhc3MgPSB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX3BvaW50ZXI8RnVuY3Rp b25UeXBlPjo6dmFsdWUgJiYgc3RkOjppc19mdW5jdGlvbjx0eXBlbmFtZSBzdGQ6OnJlbW92ZV9w b2ludGVyPEZ1bmN0aW9uVHlwZT46OnR5cGU+Ojp2YWx1ZT46OnR5cGU+CiAgICAgRnVuY3Rpb24m IG9wZXJhdG9yPShGdW5jdGlvblR5cGUgZikKICAgICB7Ci0gICAgICAgIG1fY2FsbGFibGVXcmFw cGVyID0gbWFrZVVuaXF1ZTxEZXRhaWw6OkNhbGxhYmxlV3JhcHBlcjxGdW5jdGlvblR5cGUsIE91 dCwgSW4uLi4+PihXVEZNb3ZlKGYpKTsKKyAgICAgICAgbV9jYWxsYWJsZVdyYXBwZXIgPSBtYWtl VW5pcXVlPERldGFpbDo6Q2FsbGFibGVXcmFwcGVyPEZ1bmN0aW9uVHlwZSwgT3V0LCBJbi4uLj4+ KHN0ZDo6Zm9yd2FyZDxGdW5jdGlvblR5cGU+KGYpKTsKICAgICAgICAgcmV0dXJuICp0aGlzOwog ICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTmV2ZXJEZXN0cm95ZWQuaCBiL1Nv dXJjZS9XVEYvd3RmL05ldmVyRGVzdHJveWVkLmgKaW5kZXggYjUyZWFiYTliNTQ1ZDIzMjcwZDEx MTRiZDZkZjM3YWE3MDE4ZWU0Zi4uZmEwNWU5M2RmMTNlMGE4NmUyZjk2ZmQwM2M2MDZiYWE2ZTNh YjZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTmV2ZXJEZXN0cm95ZWQuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oCkBAIC0xODEsNyArMTgxLDcgQEAgcHJpdmF0 ZToKIAogdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgQWNjZXNzVHJhaXRzPiBpbmxpbmUg TmV2ZXJEZXN0cm95ZWQ8VCwgQWNjZXNzVHJhaXRzPiBtYWtlTmV2ZXJEZXN0cm95ZWQoVCYmIGFy Z3VtZW50KQogewotICAgIHJldHVybiBXVEZNb3ZlKGFyZ3VtZW50KTsKKyAgICByZXR1cm4gc3Rk Ojpmb3J3YXJkPFQ+KGFyZ3VtZW50KTsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4K