223032 2021-03-10 10:57:09 -0800 Make the options argument to CanvasRenderingContext2DBase::didDraw() an OptionSet<> 2021-03-10 13:12:11 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=222532 P2 Normal --- 1 simon.fraser simon.fraser sabouhallawa simon.fraser oldest_to_newest 1738130 0 simon.fraser 2021-03-10 10:57:09 -0800 Make the options argument o CanvasRenderingContext2DBase::didDraw() an OptionSet<> 1738132 1 422848 simon.fraser 2021-03-10 10:58:08 -0800 Created attachment 422848 Patch 1738141 2 422848 simon.fraser 2021-03-10 11:04:20 -0800 Comment on attachment 422848 Patch Darin made the same change. 422848 2021-03-10 10:58:08 -0800 2021-03-10 11:04:20 -0800 Patch bug-223032-20210310105807.patch text/plain 5181 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTAxMWVlNGVlZDAyZGUw MzVjYzU3MTMxNGRmMTA3ZmU0ZGZlNGU2Yi4uMGJkMjc2NWQ5NjE1MDNiMWFlOGVlMzAyYTUyYmY3 ZWU3NTMwNzNiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTEwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgdGhlIG9w dGlvbnMgYXJndW1lbnQgdG8gQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6ZGlkRHJhdygp IGFuIE9wdGlvblNldDw+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjMwMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYWtlIENhbnZhc0RpZERyYXdPcHRpb24gYW4gZW51bSBjbGFzcyBhbmQgcGFzcyBh biBPcHRpb25TZXQ8Q2FudmFzRGlkRHJhd09wdGlvbj4gdG8gCisgICAgICAgIENhbnZhc1JlbmRl cmluZ0NvbnRleHQyREJhc2U6OmRpZERyYXcoKS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFz UmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6ZGlkRHJhd0VudGlyZUNhbnZhcyk6CisgICAgICAgIChX ZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpkaWREcmF3KToKKyAgICAgICAg KFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OnB1dEltYWdlRGF0YSk6Cisg ICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5oOgorCiAy MDIxLTAzLTA4ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI3MzE5Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAK aW5kZXggY2E2ZGQwNWZmMzY3NzRjNjc3MWM3NGM0OThkNThjZTEwZGNkMGRhYS4uMzZkZjNmZGQ0 ZjBlYjBlNDdhMjlkNDA4NDg5MDFjOWQ3NzViMjk2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAK QEAgLTIwMTAsMTAgKzIwMTAsMTAgQEAgRXhjZXB0aW9uT3I8UmVmUHRyPENhbnZhc1BhdHRlcm4+ PiBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpjcmVhdGVQYXR0ZXJuKFQKIAogdm9pZCBD YW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpkaWREcmF3RW50aXJlQ2FudmFzKCkKIHsKLSAg ICBkaWREcmF3KEZsb2F0UmVjdChGbG9hdFBvaW50Ojp6ZXJvKCksIGNhbnZhc0Jhc2UoKS5zaXpl KCkpLCBDYW52YXNEaWREcmF3QXBwbHlDbGlwKTsKKyAgICBkaWREcmF3KEZsb2F0UmVjdChGbG9h dFBvaW50Ojp6ZXJvKCksIGNhbnZhc0Jhc2UoKS5zaXplKCkpLCBDYW52YXNEaWREcmF3T3B0aW9u OjpBcHBseUNsaXApOwogfQogCi12b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OmRp ZERyYXcoY29uc3QgRmxvYXRSZWN0JiByLCB1bnNpZ25lZCBvcHRpb25zKQordm9pZCBDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpkaWREcmF3KGNvbnN0IEZsb2F0UmVjdCYgciwgT3B0aW9u U2V0PENhbnZhc0RpZERyYXdPcHRpb24+IG9wdGlvbnMpCiB7CiAgICAgYXV0byogYyA9IGRyYXdp bmdDb250ZXh0KCk7CiAgICAgaWYgKCFjKQpAQCAtMjAyMiwxMiArMjAyMiwxMiBAQCB2b2lkIENh bnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OmRpZERyYXcoY29uc3QgRmxvYXRSZWN0JiByLCB1 bnNpZ25lZCBvcHRpb25zKQogICAgICAgICByZXR1cm47CiAKICAgICBGbG9hdFJlY3QgZGlydHlS ZWN0ID0gcjsKLSAgICBpZiAob3B0aW9ucyAmIENhbnZhc0RpZERyYXdBcHBseVRyYW5zZm9ybSkg eworICAgIGlmIChvcHRpb25zLmNvbnRhaW5zKENhbnZhc0RpZERyYXdPcHRpb246OkFwcGx5VHJh bnNmb3JtKSkgewogICAgICAgICBBZmZpbmVUcmFuc2Zvcm0gY3RtID0gc3RhdGUoKS50cmFuc2Zv cm07CiAgICAgICAgIGRpcnR5UmVjdCA9IGN0bS5tYXBSZWN0KHIpOwogICAgIH0KIAotICAgIGlm IChvcHRpb25zICYgQ2FudmFzRGlkRHJhd0FwcGx5U2hhZG93ICYmIHN0YXRlKCkuc2hhZG93Q29s b3IuaXNWaXNpYmxlKCkpIHsKKyAgICBpZiAob3B0aW9ucy5jb250YWlucyhDYW52YXNEaWREcmF3 T3B0aW9uOjpBcHBseVNoYWRvdykgJiYgc3RhdGUoKS5zaGFkb3dDb2xvci5pc1Zpc2libGUoKSkg ewogICAgICAgICAvLyBUaGUgc2hhZG93IGdldHMgYXBwbGllZCBhZnRlciB0cmFuc2Zvcm1hdGlv bgogICAgICAgICBGbG9hdFJlY3Qgc2hhZG93UmVjdChkaXJ0eVJlY3QpOwogICAgICAgICBzaGFk b3dSZWN0Lm1vdmUoc3RhdGUoKS5zaGFkb3dPZmZzZXQpOwpAQCAtMjAzNSw3ICsyMDM1LDcgQEAg dm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpkaWREcmF3KGNvbnN0IEZsb2F0UmVj dCYgciwgdW5zaWduZWQgb3B0aW9ucykKICAgICAgICAgZGlydHlSZWN0LnVuaXRlKHNoYWRvd1Jl Y3QpOwogICAgIH0KIAotICAgIGlmIChvcHRpb25zICYgQ2FudmFzRGlkRHJhd0FwcGx5Q2xpcCkg eworICAgIGlmIChvcHRpb25zLmNvbnRhaW5zKENhbnZhc0RpZERyYXdPcHRpb246OkFwcGx5Q2xp cCkpIHsKICAgICAgICAgLy8gRklYTUU6IGFwcGx5IHRoZSBjdXJyZW50IGNsaXAgdG8gdGhlIHJl Y3RhbmdsZS4gVW5mb3J0dW5hdGVseSB3ZSBjYW4ndCBnZXQgdGhlIGNsaXAKICAgICAgICAgLy8g YmFjayBvdXQgb2YgdGhlIEdyYXBoaWNzQ29udGV4dCwgc28gdG8gdGFrZSBjbGlwIGludG8gYWNj b3VudCBmb3IgaW5jcmVtZW50YWwgcGFpbnRpbmcsCiAgICAgICAgIC8vIHdlJ2QgaGF2ZSB0byBr ZWVwIHRoZSBjbGlwIHBhdGggYXJvdW5kLgpAQCAtMjIxMCw3ICsyMjEwLDcgQEAgdm9pZCBDYW52 YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpwdXRJbWFnZURhdGEoSW1hZ2VEYXRhJiBkYXRhLCBm bG9hdCBkeCwgZmxvYXQKICAgICBpZiAoIXNvdXJjZVJlY3QuaXNFbXB0eSgpKQogICAgICAgICBi dWZmZXItPnB1dEltYWdlRGF0YShBbHBoYVByZW11bHRpcGxpY2F0aW9uOjpVbnByZW11bHRpcGxp ZWQsIGRhdGEsIHNvdXJjZVJlY3QsIEludFBvaW50KGRlc3RPZmZzZXQpKTsKIAotICAgIGRpZERy YXcoZGVzdFJlY3QsIENhbnZhc0RpZERyYXdBcHBseU5vbmUpOyAvLyBpZ25vcmUgdHJhbnNmb3Jt LCBzaGFkb3cgYW5kIGNsaXAKKyAgICBkaWREcmF3KGRlc3RSZWN0LCB7IH0pOwogfQogCiB2b2lk IENhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OmluZmxhdGVTdHJva2VSZWN0KEZsb2F0UmVj dCYgcmVjdCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz L0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuaAppbmRleCA5NGFmZWEzOWYwMTg5MjAzY2Nm NWE4NGQ4NWJjNzZmNTY4MDVmNDczLi5hMWRjZDIzNzEwNzRkNWIxODBiZDZlYmE4NGIzYjA5YTFm YmMxYTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5k ZXJpbmdDb250ZXh0MkRCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5oCkBAIC0yOTUsMTIgKzI5NSwxNiBAQCBwcm90ZWN0 ZWQ6CiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IERlZmF1bHRGb250RmFtaWx5OwogICAg IHN0YXRpYyBjb25zdCBjaGFyKiBjb25zdCBEZWZhdWx0Rm9udDsKIAotICAgIGVudW0gQ2FudmFz RGlkRHJhd09wdGlvbiB7Ci0gICAgICAgIENhbnZhc0RpZERyYXdBcHBseU5vbmUgPSAwLAotICAg ICAgICBDYW52YXNEaWREcmF3QXBwbHlUcmFuc2Zvcm0gPSAxLAotICAgICAgICBDYW52YXNEaWRE cmF3QXBwbHlTaGFkb3cgPSAxIDw8IDEsCi0gICAgICAgIENhbnZhc0RpZERyYXdBcHBseUNsaXAg PSAxIDw8IDIsCi0gICAgICAgIENhbnZhc0RpZERyYXdBcHBseUFsbCA9IDB4ZmZmZmZmZmYKKyAg ICBlbnVtIGNsYXNzIENhbnZhc0RpZERyYXdPcHRpb24geworICAgICAgICBBcHBseVRyYW5zZm9y bSAgICAgPSAxIDw8IDAsCisgICAgICAgIEFwcGx5U2hhZG93ICAgICAgICA9IDEgPDwgMSwKKyAg ICAgICAgQXBwbHlDbGlwICAgICAgICAgID0gMSA8PCAyLAorICAgIH07CisgICAgCisgICAgc3Rh dGljIGNvbnN0ZXhwciBPcHRpb25TZXQ8Q2FudmFzRGlkRHJhd09wdGlvbj4gY2FudmFzRGlkRHJh d0FwcGx5QWxsID0geworICAgICAgICBDYW52YXNEaWREcmF3T3B0aW9uOjpBcHBseVRyYW5zZm9y bSwKKyAgICAgICAgQ2FudmFzRGlkRHJhd09wdGlvbjo6QXBwbHlTaGFkb3csCisgICAgICAgIENh bnZhc0RpZERyYXdPcHRpb246OkFwcGx5Q2xpcCwKICAgICB9OwogCiAgICAgYm9vbCBpc0Z1bGxD YW52YXNDb21wb3NpdGVNb2RlKENvbXBvc2l0ZU9wZXJhdG9yKTsKQEAgLTMxMiw3ICszMTYsNyBA QCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCBhcHBseVNoYWRvdygpOwogICAgIGJvb2wgc2hvdWxkRHJh d1NoYWRvd3MoKSBjb25zdDsKIAotICAgIHZvaWQgZGlkRHJhdyhjb25zdCBGbG9hdFJlY3QmLCB1 bnNpZ25lZCBvcHRpb25zID0gQ2FudmFzRGlkRHJhd0FwcGx5QWxsKTsKKyAgICB2b2lkIGRpZERy YXcoY29uc3QgRmxvYXRSZWN0JiwgT3B0aW9uU2V0PENhbnZhc0RpZERyYXdPcHRpb24+ID0gY2Fu dmFzRGlkRHJhd0FwcGx5QWxsKTsKICAgICB2b2lkIGRpZERyYXdFbnRpcmVDYW52YXMoKTsKIAog ICAgIHZvaWQgcGFpbnRSZW5kZXJpbmdSZXN1bHRzVG9DYW52YXMoKSBvdmVycmlkZTsK