223011 2021-03-09 17:32:15 -0800 [build.webkit.org] Update RunJavaScriptCoreTests step for new buildbot 2021-03-10 07:33:52 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1737875 0 aakash_jain 2021-03-09 17:32:15 -0800 We have upgraded build.webkit.org to latest Buildbot. We should update RunJavaScriptCoreTests as per new Buildbot, e.g.: use logobserver instead of cmd.logs['stdio'].getText() 1737876 1 422785 aakash_jain 2021-03-09 17:38:38 -0800 Created attachment 422785 Patch 1737879 2 422785 dewei_zhu 2021-03-09 18:10:21 -0800 Comment on attachment 422785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review > Tools/CISupport/build-webkit-org/steps.py:437 > + self.failedTestCount = 0 Is this used anywhere in this change? 1737885 3 422785 aakash_jain 2021-03-09 18:26:33 -0800 Comment on attachment 422785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review >> Tools/CISupport/build-webkit-org/steps.py:437 >> + self.failedTestCount = 0 > > Is this used anywhere in this change? It is used by the base class TestWithFailureCount (inside getResultSummary()) 1737890 4 422785 dewei_zhu 2021-03-09 18:48:11 -0800 Comment on attachment 422785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review >>> Tools/CISupport/build-webkit-org/steps.py:437 >>> + self.failedTestCount = 0 >> >> Is this used anywhere in this change? > > It is used by the base class TestWithFailureCount (inside getResultSummary()) Why was it working before this change? By checking the code, it looks like it will be set by `TestWithFailureCount.commandComplete`. Anyway, initialize an variable in the here seems no harm. 1737891 5 dewei_zhu 2021-03-09 18:48:23 -0800 r=me 1738021 6 422785 aakash_jain 2021-03-10 04:34:28 -0800 Comment on attachment 422785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review > Why was it working before this change? This wasn't working properly after the upgrade. logText in countFailures was empty (as deprecated cmd.logs['stdio'].getText() return empty string in new buildbot), and so custom step message wasn't being set. It should be set now, e.g.: '2 JSC tests failed' in https://build.webkit-dev.org/#/builders/84/builds/3 1738023 7 ews-feeder 2021-03-10 04:52:39 -0800 Committed r274209: <https://commits.webkit.org/r274209> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422785. 1738024 8 webkit-bug-importer 2021-03-10 04:53:14 -0800 <rdar://problem/75260591> 1738053 9 aakash_jain 2021-03-10 07:33:52 -0800 Restated buildbot to pick up this change this morning. Seems to be working fine. e.g.: https://build.webkit.org/#/builders/102/builds/90 now says: "29 JSC tests failed", while earlier it used to say: "jscore-test (failure)" 422785 2021-03-09 17:38:38 -0800 2021-03-10 04:52:40 -0800 Patch bug-223011-20210309203837.patch text/plain 5325 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDE4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIxLTAzLTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXBkYXRlIFJ1bkphdmFTY3JpcHRDb3Jl VGVzdHMgc3RlcCBmb3IgbmV3IGJ1aWxkYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjMwMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzLnB5 OgorICAgICAgICAoUnVuSmF2YVNjcmlwdENvcmVUZXN0cy5zdGFydCk6IFVzZWQgbG9nb2JzZXJ2 ZXIuCisgICAgICAgIChSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLmNvdW50RmFpbHVyZXMpOgorICAg ICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzX3VuaXR0ZXN0LnB5OgorICAg ICAgICAoVGVzdFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMudGVzdF9zdWNjZXNzKTogQWRkZWQgdW5p dC10ZXN0LgorICAgICAgICAoVGVzdFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMudGVzdF9mYWlsdXJl KTogRGl0dG8uCisKIDIwMjEtMDMtMDkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFw cGxlLmNvbT4KIAogICAgICAgICBNb3Rpb25NYXJrIHNjb3JlcyBhcmUgc3VwZXIgc2Vuc2l0aXZl IHRvIGEgc2luZ2xlIGxvbmcgZnJhbWUKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJr aXQtb3JnL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJr aXQtb3JnL3N0ZXBzLnB5CShyZXZpc2lvbiAyNzQxODgpCisrKyBUb29scy9DSVN1cHBvcnQvYnVp bGQtd2Via2l0LW9yZy9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNDMyLDYgKzQzMiwxMCBA QCBjbGFzcyBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKFRlc3RXaXRoRmFpCiAKICAgICBkZWYgc3Rh cnQoc2VsZik6CiAgICAgICAgIHNlbGYud29ya2VyRW52aXJvbm1lbnRbUkVTVUxUU19TRVJWRVJf QVBJX0tFWV0gPSBvcy5nZXRlbnYoUkVTVUxUU19TRVJWRVJfQVBJX0tFWSkKKyAgICAgICAgc2Vs Zi5sb2dfb2JzZXJ2ZXIgPSBsb2dvYnNlcnZlci5CdWZmZXJMb2dPYnNlcnZlcigpCisgICAgICAg IHNlbGYuYWRkTG9nT2JzZXJ2ZXIoJ3N0ZGlvJywgc2VsZi5sb2dfb2JzZXJ2ZXIpCisgICAgICAg IHNlbGYuZmFpbGVkVGVzdENvdW50ID0gMAorCiAgICAgICAgIHBsYXRmb3JtID0gc2VsZi5nZXRQ cm9wZXJ0eSgncGxhdGZvcm0nKQogICAgICAgICBhcmNoaXRlY3R1cmUgPSBzZWxmLmdldFByb3Bl cnR5KCJhcmNoaXRlY3R1cmUiKQogICAgICAgICAjIEN1cnJlbnRseSBydW4tamF2YXNjcmlwdGNv cmUtdGVzdCBkb2Vzbid0IHN1cHBvcnQgcnVuIGphdmFzY3JpcHQgY29yZSB0ZXN0IGJpbmFyaWVz IGxpc3QgYmVsb3cgcmVtb3RlbHkKQEAgLTQ0OSw3ICs0NTMsNyBAQCBjbGFzcyBSdW5KYXZhU2Ny aXB0Q29yZVRlc3RzKFRlc3RXaXRoRmFpCiAgICAgICAgIHJldHVybiBzaGVsbC5UZXN0LnN0YXJ0 KHNlbGYpCiAKICAgICBkZWYgY291bnRGYWlsdXJlcyhzZWxmLCBjbWQpOgotICAgICAgICBsb2dU ZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCisgICAgICAgIGxvZ1RleHQgPSBzZWxm LmxvZ19vYnNlcnZlci5nZXRTdGRvdXQoKQogICAgICAgICBjb3VudCA9IDAKIAogICAgICAgICBt YXRjaCA9IHJlLnNlYXJjaChyJ15SZXN1bHRzIGZvciBKU0Mgc3RyZXNzIHRlc3RzOlxyP1xuXHMr KFxkKykgZmFpbHVyZScsIGxvZ1RleHQsIHJlLk1VTFRJTElORSkKSW5kZXg6IFRvb2xzL0NJU3Vw cG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lv biAyNzQxODgpCisrKyBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwc191bml0 dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtOTA5LDMgKzkwOSw1NiBAQCBjbGFzcyBUZXN0UnVu V2ViS2l0VGVzdHMoQnVpbGRTdGVwTWl4aW5BCiAgICAgICAgICkKICAgICAgICAgc2VsZi5leHBl Y3RPdXRjb21lKHJlc3VsdD1FWENFUFRJT04sIHN0YXRlX3N0cmluZz0nbGF5b3V0LXRlc3RzIChl eGNlcHRpb24pJykKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKworY2xhc3MgVGVz dFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0 LlRlc3RDYXNlKToKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNlbGYubG9uZ01lc3Nh Z2UgPSBUcnVlCisgICAgICAgIG9zLmVudmlyb25bJ1JFU1VMVFNfU0VSVkVSX0FQSV9LRVknXSA9 ICd0ZXN0LWFwaS1rZXknCisgICAgICAgIHNlbGYuanNvbkZpbGVOYW1lID0gJ2pzY19yZXN1bHRz Lmpzb24nCisgICAgICAgIHJldHVybiBzZWxmLnNldFVwQnVpbGRTdGVwKCkKKworICAgIGRlZiB0 ZWFyRG93bihzZWxmKToKKyAgICAgICAgZGVsIG9zLmVudmlyb25bJ1JFU1VMVFNfU0VSVkVSX0FQ SV9LRVknXQorICAgICAgICByZXR1cm4gc2VsZi50ZWFyRG93bkJ1aWxkU3RlcCgpCisKKyAgICBk ZWYgY29uZmlndXJlU3RlcChzZWxmLCBwbGF0Zm9ybT1Ob25lLCBmdWxsUGxhdGZvcm09Tm9uZSwg Y29uZmlndXJhdGlvbj1Ob25lKToKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoUnVuSmF2YVNjcmlw dENvcmVUZXN0cygpKQorICAgICAgICBpZiBwbGF0Zm9ybToKKyAgICAgICAgICAgIHNlbGYuc2V0 UHJvcGVydHkoJ3BsYXRmb3JtJywgcGxhdGZvcm0pCisgICAgICAgIGlmIGZ1bGxQbGF0Zm9ybToK KyAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScsIGZ1bGxQbGF0Zm9y bSkKKyAgICAgICAgaWYgY29uZmlndXJhdGlvbjoKKyAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVy dHkoJ2NvbmZpZ3VyYXRpb24nLCBjb25maWd1cmF0aW9uKQorICAgICAgICBzZWxmLnNldFByb3Bl cnR5KCdidWlsZGVybmFtZScsICdKU0MtVGVzdHMnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5 KCdidWlsZG51bWJlcicsICcxMDEnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCd3b3JrZXJu YW1lJywgJ2JvdDEwMCcpCisKKyAgICBkZWYgdGVzdF9zdWNjZXNzKHNlbGYpOgorICAgICAgICBz ZWxmLmNvbmZpZ3VyZVN0ZXAocGxhdGZvcm09J21hYycsIGZ1bGxQbGF0Zm9ybT0nbWFjLWhpZ2hz aWVycmEnLCBjb25maWd1cmF0aW9uPSdyZWxlYXNlJykKKyAgICAgICAgc2VsZi5leHBlY3RSZW1v dGVDb21tYW5kcygKKyAgICAgICAgICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAg ICAgICAgICAgICAgICAgICAgICAgIGxvZ0Vudmlyb249RmFsc2UsCisgICAgICAgICAgICAgICAg ICAgICAgICBjb21tYW5kPVsncGVybCcsICcuL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRj b3JlLXRlc3RzJywgJy0tbm8tYnVpbGQnLCAnLS1uby1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1 dD17MH0nLmZvcm1hdChzZWxmLmpzb25GaWxlTmFtZSksICctLXJlbGVhc2UnLCAnLS1idWlsZGVy LW5hbWUnLCAnSlNDLVRlc3RzJywgJy0tYnVpbGQtbnVtYmVyJywgJzEwMScsICctLWJ1aWxkYm90 LXdvcmtlcicsICdib3QxMDAnLCAnLS1idWlsZGJvdC1tYXN0ZXInLCBDVVJSRU5UX0hPU1ROQU1F LCAnLS1yZXBvcnQnLCAnaHR0cHM6Ly9yZXN1bHRzLndlYmtpdC5vcmcnXSwKKyAgICAgICAgICAg ICAgICAgICAgICAgIGxvZ2ZpbGVzPXsnanNvbic6IHNlbGYuanNvbkZpbGVOYW1lfSwKKyAgICAg ICAgICAgICAgICAgICAgICAgIGVudj17J1JFU1VMVFNfU0VSVkVSX0FQSV9LRVknOiAndGVzdC1h cGkta2V5J30KKyAgICAgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgICsgMCwKKyAg ICAgICAgKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRl X3N0cmluZz0nanNjb3JlLXRlc3QnKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKwor ICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6CisgICAgICAgIHNlbGYuY29uZmlndXJlU3RlcChw bGF0Zm9ybT0nbWFjJywgZnVsbFBsYXRmb3JtPSdtYWMtaGlnaHNpZXJyYScsIGNvbmZpZ3VyYXRp b249J2RlYnVnJykKKyAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKKyAgICAgICAg ICAgIEV4cGVjdFNoZWxsKHdvcmtkaXI9J3drZGlyJywKKyAgICAgICAgICAgICAgICAgICAgICAg IGxvZ0Vudmlyb249RmFsc2UsCisgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncGVy bCcsICcuL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8tYnVp bGQnLCAnLS1uby1mYWlsLWZhc3QnLCAnLS1qc29uLW91dHB1dD17MH0nLmZvcm1hdChzZWxmLmpz b25GaWxlTmFtZSksICctLWRlYnVnJywgJy0tYnVpbGRlci1uYW1lJywgJ0pTQy1UZXN0cycsICct LWJ1aWxkLW51bWJlcicsICcxMDEnLCAnLS1idWlsZGJvdC13b3JrZXInLCAnYm90MTAwJywgJy0t YnVpbGRib3QtbWFzdGVyJywgQ1VSUkVOVF9IT1NUTkFNRSwgJy0tcmVwb3J0JywgJ2h0dHBzOi8v cmVzdWx0cy53ZWJraXQub3JnJ10sCisgICAgICAgICAgICAgICAgICAgICAgICBsb2dmaWxlcz17 J2pzb24nOiBzZWxmLmpzb25GaWxlTmFtZX0sCisgICAgICAgICAgICAgICAgICAgICAgICBlbnY9 eydSRVNVTFRTX1NFUlZFUl9BUElfS0VZJzogJ3Rlc3QtYXBpLWtleSd9CisgICAgICAgICAgICAg ICAgICAgICAgICApCisgICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRv dXQ9J1Jlc3VsdHMgZm9yIEpTQyBzdHJlc3MgdGVzdHM6XG4gOSBmYWlsdXJlcyBmb3VuZC4nKQor ICAgICAgICAgICAgKyAyLAorICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShy ZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSc5IEpTQyB0ZXN0cyBmYWlsZWQnKQorICAgICAg ICByZXR1cm4gc2VsZi5ydW5TdGVwKCkK