223010 2021-03-09 17:07:51 -0800 Logic for updating the text selection when dragging selection handles should account for image overlays 2021-03-10 08:19:16 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim hi megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1737867 0 wenson_hsieh 2021-03-09 17:07:51 -0800 . 1737870 1 422783 wenson_hsieh 2021-03-09 17:14:54 -0800 Created attachment 422783 Patch 1738065 2 422783 wenson_hsieh 2021-03-10 08:04:54 -0800 Comment on attachment 422783 Patch Thanks for the review! 1738069 3 ews-feeder 2021-03-10 08:18:10 -0800 Committed r274215: <https://commits.webkit.org/r274215> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422783. 1738070 4 webkit-bug-importer 2021-03-10 08:19:16 -0800 <rdar://problem/75265485> 422783 2021-03-09 17:14:54 -0800 2021-03-10 08:18:12 -0800 Patch bug-223010-20210309171453.patch text/plain 5905 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWUxMGI3MWRhOWNiODlh NmEzMjlhNzMxNTA2ZjdlZmFiZWUwNTY0NS4uMDRkNWY0MmE0NWFlNDEzYzA0OWE2NDc3YjJmZTcw YjllZmEwZGJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTA5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIExvZ2ljIGZvciB1 cGRhdGluZyB0aGUgdGV4dCBzZWxlY3Rpb24gd2hlbiBkcmFnZ2luZyBzZWxlY3Rpb24gaGFuZGxl cyBzaG91bGQgYWNjb3VudCBmb3IgaW1hZ2Ugb3ZlcmxheXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzAxMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBgc2hvdWxkVXBkYXRlU2VsZWN0aW9u Rm9yTW91c2VEcmFnYCB0byBgc2hvdWxkRXh0ZW5kU2VsZWN0aW9uVG9UYXJnZXROb2RlYC4gU2Vl IFdlYktpdCBDaGFuZ2Vsb2cgZm9yIG1vcmUKKyAgICAgICAgZGV0YWlscy4KKworICAgICAgICAq IGh0bWwvSFRNTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6OnNo b3VsZEV4dGVuZFNlbGVjdGlvblRvVGFyZ2V0Tm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1M RWxlbWVudDo6c2hvdWxkVXBkYXRlU2VsZWN0aW9uRm9yTW91c2VEcmFnKTogRGVsZXRlZC4KKyAg ICAgICAgKiBodG1sL0hUTUxFbGVtZW50Lmg6CisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjp1cGRhdGVTZWxlY3Rpb25Gb3JN b3VzZURyYWcpOgorCiAyMDIxLTAzLTA5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0aGUgRU5BQkxFKEFQUF9ISUdITElH SFRTKSBidWlsZCBhZnRlciByMjc0MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwYzY4OWI2NWM4YzgzMjVkY2Mx MGM3OTIxZmU4ZmJiN2UwODU5MGYuLjI4MzRhNWRiOGFkZGRjNGJjZTA0OTQwMDFhY2E3Mzk4OTJl Yjc3MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDMtMDkgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgTG9naWMgZm9yIHVwZGF0aW5n IHRoZSB0ZXh0IHNlbGVjdGlvbiB3aGVuIGRyYWdnaW5nIHNlbGVjdGlvbiBoYW5kbGVzIHNob3Vs ZCBhY2NvdW50IGZvciBpbWFnZSBvdmVybGF5cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIzMDEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQXBwbHkgdGhlIHNhbWUgbG9naWMgaW50cm9kdWNlZCBpbiBy MjcyNTAzIHRvIGlPUywgd2hlbiBleHRlbmRpbmcgdGhlIHNlbGVjdGlvbiBieSBtb3Zpbmcgc2Vs ZWN0aW9uIGhhbmRsZXMuIEluCisgICAgICAgIHRoZSBjYXNlIHdoZXJlIHRoZSBoaXQtdGVzdGVk IG5vZGUgaXMgdGhlIGltYWdlIG92ZXJsYXkgY29udGFpbmVyIChhcyBvcHBvc2VkIHRvIGFueSB0 ZXh0IGluc2lkZSB0aGUgY29udGFpbmVyKSwKKyAgICAgICAgaXQncyBiZXR0ZXIgYXZvaWQgdXBk YXRpbmcgdGhlIHNlbGVjdGlvbiwgcmF0aGVyIHRoYW4gZXh0ZW5kIHRoZSBzZWxlY3Rpb24gdG8g dGhlIHN0YXJ0IG9mIHRoZSBpbWFnZSBvdmVybGF5LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpyYW5nZUZvclBvaW50 SW5Sb290Vmlld0Nvb3JkaW5hdGVzKToKKwogMjAyMS0wMy0wOSAgQmVuIE5oYW0gIDxuaGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBBZG9wdCBuZXcgTlNVUkxTZXNzaW9uQ29uZmlndXJhdGlvbiBT UEkgZm9yIGNvbm5lY3Rpb24gY2FjaGUgY29uZmlndXJhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxF bGVtZW50LmNwcAppbmRleCAzYzJiYWViZTQ4OTQxMWY3MjRhYWYzYmVjOTkyYTBlMzYwZjcxYzUz Li4zZDkxOGY2M2Y0OTFlNGNhNWVjZDZiYjljZmYyYmMxYjNmNDZhZGE2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxFbGVtZW50LmNwcApAQCAtMTIwMSw3ICsxMjAxLDcgQEAgc3RhdGljIGNvbnN0IEF0 b21TdHJpbmcmIGltYWdlT3ZlcmxheUVsZW1lbnRJZGVudGlmaWVyKCkKICAgICByZXR1cm4gaWRl bnRpZmllcjsKIH0KIAotYm9vbCBIVE1MRWxlbWVudDo6c2hvdWxkVXBkYXRlU2VsZWN0aW9uRm9y TW91c2VEcmFnKGNvbnN0IE5vZGUmIHRhcmdldE5vZGUsIGNvbnN0IFZpc2libGVTZWxlY3Rpb24m IHNlbGVjdGlvbkJlZm9yZVVwZGF0ZSkKK2Jvb2wgSFRNTEVsZW1lbnQ6OnNob3VsZEV4dGVuZFNl bGVjdGlvblRvVGFyZ2V0Tm9kZShjb25zdCBOb2RlJiB0YXJnZXROb2RlLCBjb25zdCBWaXNpYmxl U2VsZWN0aW9uJiBzZWxlY3Rpb25CZWZvcmVVcGRhdGUpCiB7CiAgICAgaWYgKCFpczxIVE1MRGl2 RWxlbWVudD4odGFyZ2V0Tm9kZSkpCiAgICAgICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRWxlbWVudC5oCmluZGV4IGU3Yzc1YzNjZGE1MjQ5Y2RjYTcxNzNmZTA4MzM5NzRkZDYzNDVm NGUuLmJkOTAyNDZjYmM1ZWMxMjE1ZGQ5ODljZDhhNTYzZTU0Y2NjYmM3ZjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxFbGVtZW50LmgKQEAgLTEyNiw3ICsxMjYsNyBAQCBwdWJsaWM6CiAgICAgU3RyaW5n IGVudGVyS2V5SGludCgpIGNvbnN0OwogICAgIHZvaWQgc2V0RW50ZXJLZXlIaW50KGNvbnN0IFN0 cmluZyYgdmFsdWUpOwogCi0gICAgc3RhdGljIGJvb2wgc2hvdWxkVXBkYXRlU2VsZWN0aW9uRm9y TW91c2VEcmFnKGNvbnN0IE5vZGUmIHRhcmdldE5vZGUsIGNvbnN0IFZpc2libGVTZWxlY3Rpb24m IHNlbGVjdGlvbkJlZm9yZVVwZGF0ZSk7CisgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIGJvb2wg c2hvdWxkRXh0ZW5kU2VsZWN0aW9uVG9UYXJnZXROb2RlKGNvbnN0IE5vZGUmIHRhcmdldE5vZGUs IGNvbnN0IFZpc2libGVTZWxlY3Rpb24mIHNlbGVjdGlvbkJlZm9yZVVwZGF0ZSk7CiAgICAgYm9v bCBoYXNJbWFnZU92ZXJsYXkoKSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgYm9v bCBpc0ltYWdlT3ZlcmxheVRleHQoY29uc3QgTm9kZSYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAKaW5kZXggNmEzOTUyNTFiMTEwMDI5YTNmYTVlMGM5MjBhMGFjMWE3Y2FiMjUz Ny4uYWFlMzdlNzRjN2I2MjA3YzRkZGIzODkxZjMzN2JkNWQxMTZlMmZkNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtOTQxLDcgKzk0MSw3IEBAIHZvaWQgRXZlbnRIYW5k bGVyOjp1cGRhdGVTZWxlY3Rpb25Gb3JNb3VzZURyYWcoY29uc3QgSGl0VGVzdFJlc3VsdCYgaGl0 VGVzdFJlc3VsCiAgICAgaWYgKCF0YXJnZXQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICgh SFRNTEVsZW1lbnQ6OnNob3VsZFVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZygqdGFyZ2V0LCBt X2ZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlvbigpKSkKKyAgICBpZiAoIUhUTUxFbGVtZW50Ojpz aG91bGRFeHRlbmRTZWxlY3Rpb25Ub1RhcmdldE5vZGUoKnRhcmdldCwgbV9mcmFtZS5zZWxlY3Rp b24oKS5zZWxlY3Rpb24oKSkpCiAgICAgICAgIHJldHVybjsKIAogICAgIFZpc2libGVQb3NpdGlv biB0YXJnZXRQb3NpdGlvbiA9IHNlbGVjdGlvbkV4dGVudFJlc3BlY3RpbmdFZGl0aW5nQm91bmRh cnkobV9mcmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKSwgaGl0VGVzdFJlc3VsdC5sb2NhbFBv aW50KCksIHRhcmdldCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IDUyZDhmMWQ5MTdhOTdmOWI5M2E2ZTUxYzdiMmNiYjEx Zjg2ODBiYjMuLmM3ZTNkODdkYTc4MjQ0MjFiYTY0N2QyYTYwYWE5NWM5MzY2Y2RiY2YgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1t CkBAIC0xNTEzLDEzICsxNTEzLDIwIEBAIHN0YXRpYyBPcHRpb25hbDxTaW1wbGVSYW5nZT4gcmFu Z2VGb3JQb2ludEluUm9vdFZpZXdDb29yZGluYXRlcyhGcmFtZSYgZnJhbWUsIGNvCiAgICAgICAg ICAgICAgICAgcG9pbnRJbkRvY3VtZW50LnNldFkoZW5kWSk7CiAgICAgICAgIH0KICAgICB9Ci0g ICAgCi0gICAgVmlzaWJsZVBvc2l0aW9uIHJlc3VsdDsKLSAgICBPcHRpb25hbDxTaW1wbGVSYW5n ZT4gcmFuZ2U7CiAKLSAgICBjb25zdGV4cHIgT3B0aW9uU2V0PEhpdFRlc3RSZXF1ZXN0OjpSZXF1 ZXN0VHlwZT4gaGl0VHlwZSB7IEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSwgSGl0VGVzdFJlcXVl c3Q6OkFjdGl2ZSwgSGl0VGVzdFJlcXVlc3Q6OkFsbG93VmlzaWJsZUNoaWxkRnJhbWVDb250ZW50 T25seSB9OwotICAgIGF1dG8gaGl0VGVzdCA9IGZyYW1lLmV2ZW50SGFuZGxlcigpLmhpdFRlc3RS ZXN1bHRBdFBvaW50KHBvaW50SW5Eb2N1bWVudCwgaGl0VHlwZSk7CisgICAgYXV0byBoaXRUZXN0 ID0gZnJhbWUuZXZlbnRIYW5kbGVyKCkuaGl0VGVzdFJlc3VsdEF0UG9pbnQocG9pbnRJbkRvY3Vt ZW50LCB7CisgICAgICAgIEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSwKKyAgICAgICAgSGl0VGVz dFJlcXVlc3Q6OkFjdGl2ZSwKKyAgICAgICAgSGl0VGVzdFJlcXVlc3Q6OkFsbG93VmlzaWJsZUNo aWxkRnJhbWVDb250ZW50T25seSwKKyAgICB9KTsKKwogICAgIGF1dG8gdGFyZ2V0Tm9kZSA9IG1h a2VSZWZQdHIoaGl0VGVzdC50YXJnZXROb2RlKCkpOworICAgIGlmICh0YXJnZXROb2RlICYmICFI VE1MRWxlbWVudDo6c2hvdWxkRXh0ZW5kU2VsZWN0aW9uVG9UYXJnZXROb2RlKCp0YXJnZXROb2Rl LCBleGlzdGluZ1NlbGVjdGlvbikpCisgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CisKKyAg ICBPcHRpb25hbDxTaW1wbGVSYW5nZT4gcmFuZ2U7CisgICAgVmlzaWJsZVBvc2l0aW9uIHJlc3Vs dDsKKwogICAgIGlmICh0YXJnZXROb2RlKQogICAgICAgICByZXN1bHQgPSBmcmFtZS5ldmVudEhh bmRsZXIoKS5zZWxlY3Rpb25FeHRlbnRSZXNwZWN0aW5nRWRpdGluZ0JvdW5kYXJ5KGZyYW1lLnNl bGVjdGlvbigpLnNlbGVjdGlvbigpLCBoaXRUZXN0LmxvY2FsUG9pbnQoKSwgdGFyZ2V0Tm9kZS5n ZXQoKSkuZGVlcEVxdWl2YWxlbnQoKTsKICAgICBlbHNlCg==