223008 2021-03-09 16:43:27 -0800 Use RELEASE_ASSERT() for Deque bounds checks 2021-03-09 19:39:16 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen benjamin bfulgham cmarcelo darin ddkilzer ews-watchlist ggaren sam webkit-bug-importer oldest_to_newest 1737855 0 cdumez 2021-03-09 16:43:27 -0800 Use RELEASE_ASSERT() for Deque bounds checks instead of ASSERT(), similarly to what we did for Vector. 1737858 1 422777 cdumez 2021-03-09 16:46:05 -0800 Created attachment 422777 Patch 1737903 2 ews-feeder 2021-03-09 19:38:29 -0800 Committed r274193: <https://commits.webkit.org/r274193> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422777. 1737904 3 webkit-bug-importer 2021-03-09 19:39:16 -0800 <rdar://problem/75247267> 422777 2021-03-09 16:46:05 -0800 2021-03-09 19:38:30 -0800 Patch bug-223008-20210309164604.patch text/plain 2494 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE0YTNiNjc0YWYyNTYyNjUyZjE2YjVm MjZmODUyNDExZGY2Y2U5NDIuLmExODgyMGQ4NzBlMDQ5ZTg1OWUwY2ZiZTcyNDFlZTdlNzMwYmQy MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDMtMDkgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgUkVMRUFTRV9BU1NFUlQoKSBmb3IgRGVxdWUgYm91 bmRzIGNoZWNrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIzMDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVXNlIFJFTEVBU0VfQVNTRVJUKCkgZm9yIERlcXVlIGJvdW5kcyBjaGVja3MgaW5zdGVhZCBv ZiBBU1NFUlQoKSwgc2ltaWxhcmx5IHRvIHdoYXQgd2UgZGlkIGZvciBWZWN0b3IuCisKKyAgICAg ICAgKiB3dGYvRGVxdWUuaDoKKyAgICAgICAgKFdURjo6aW5saW5lQ2FwYWNpdHk+OjpyZW1vdmVG aXJzdCk6CisgICAgICAgIChXVEY6OmlubGluZUNhcGFjaXR5Pjo6cmVtb3ZlTGFzdCk6CisKIDIw MjEtMDMtMDkgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAg W0dQVVBdIEVuYWJsZSAyRCBDYW52YXMgaW4gbGF5b3V0IHRlc3RzIGJ5IGRlZmF1bHQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL0RlcXVlLmggYi9Tb3VyY2UvV1RGL3d0Zi9EZXF1ZS5oCmlu ZGV4IDBkNzM0NjVhZTFlYzBkMzgxNWYxNjU3MDVlY2JiYjkzODZiNjEwZWEuLmE4OTIzNDkyMGIw MzM2YmVlMDcxNTRkMmVkYmM1OGY2NjNhZDRhZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L0RlcXVlLmgKKysrIGIvU291cmNlL1dURi93dGYvRGVxdWUuaApAQCAtNzgsMTIgKzc4LDEyIEBA IHB1YmxpYzoKICAgICAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBib29sIGNvbnRhaW5zKGNv bnN0IFUmKSBjb25zdDsKIAotICAgIFQmIGZpcnN0KCkgeyBBU1NFUlQobV9zdGFydCAhPSBtX2Vu ZCk7IHJldHVybiBtX2J1ZmZlci5idWZmZXIoKVttX3N0YXJ0XTsgfQotICAgIGNvbnN0IFQmIGZp cnN0KCkgY29uc3QgeyBBU1NFUlQobV9zdGFydCAhPSBtX2VuZCk7IHJldHVybiBtX2J1ZmZlci5i dWZmZXIoKVttX3N0YXJ0XTsgfQorICAgIFQmIGZpcnN0KCkgeyBSRUxFQVNFX0FTU0VSVChtX3N0 YXJ0ICE9IG1fZW5kKTsgcmV0dXJuIG1fYnVmZmVyLmJ1ZmZlcigpW21fc3RhcnRdOyB9CisgICAg Y29uc3QgVCYgZmlyc3QoKSBjb25zdCB7IFJFTEVBU0VfQVNTRVJUKG1fc3RhcnQgIT0gbV9lbmQp OyByZXR1cm4gbV9idWZmZXIuYnVmZmVyKClbbV9zdGFydF07IH0KICAgICBUIHRha2VGaXJzdCgp OwogCi0gICAgVCYgbGFzdCgpIHsgQVNTRVJUKG1fc3RhcnQgIT0gbV9lbmQpOyByZXR1cm4gKigt LWVuZCgpKTsgfQotICAgIGNvbnN0IFQmIGxhc3QoKSBjb25zdCB7IEFTU0VSVChtX3N0YXJ0ICE9 IG1fZW5kKTsgcmV0dXJuICooLS1lbmQoKSk7IH0KKyAgICBUJiBsYXN0KCkgeyBSRUxFQVNFX0FT U0VSVChtX3N0YXJ0ICE9IG1fZW5kKTsgcmV0dXJuICooLS1lbmQoKSk7IH0KKyAgICBjb25zdCBU JiBsYXN0KCkgY29uc3QgeyBSRUxFQVNFX0FTU0VSVChtX3N0YXJ0ICE9IG1fZW5kKTsgcmV0dXJu ICooLS1lbmQoKSk7IH0KICAgICBUIHRha2VMYXN0KCk7CiAKICAgICB2b2lkIGFwcGVuZChUJiYg dmFsdWUpIHsgYXBwZW5kPFQ+KHN0ZDo6Zm9yd2FyZDxUPih2YWx1ZSkpOyB9CkBAIC00OTksNyAr NDk5LDcgQEAgaW5saW5lIHZvaWQgRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+OjpyZW1vdmVGaXJz dCgpCiB7CiAgICAgY2hlY2tWYWxpZGl0eSgpOwogICAgIGludmFsaWRhdGVJdGVyYXRvcnMoKTsK LSAgICBBU1NFUlQoIWlzRW1wdHkoKSk7CisgICAgUkVMRUFTRV9BU1NFUlQoIWlzRW1wdHkoKSk7 CiAgICAgVHlwZU9wZXJhdGlvbnM6OmRlc3RydWN0KHN0ZDo6YWRkcmVzc29mKG1fYnVmZmVyLmJ1 ZmZlcigpW21fc3RhcnRdKSwgc3RkOjphZGRyZXNzb2YobV9idWZmZXIuYnVmZmVyKClbbV9zdGFy dCArIDFdKSk7CiAgICAgaWYgKG1fc3RhcnQgPT0gbV9idWZmZXIuY2FwYWNpdHkoKSAtIDEpCiAg ICAgICAgIG1fc3RhcnQgPSAwOwpAQCAtNTEzLDcgKzUxMyw3IEBAIGlubGluZSB2b2lkIERlcXVl PFQsIGlubGluZUNhcGFjaXR5Pjo6cmVtb3ZlTGFzdCgpCiB7CiAgICAgY2hlY2tWYWxpZGl0eSgp OwogICAgIGludmFsaWRhdGVJdGVyYXRvcnMoKTsKLSAgICBBU1NFUlQoIWlzRW1wdHkoKSk7Cisg ICAgUkVMRUFTRV9BU1NFUlQoIWlzRW1wdHkoKSk7CiAgICAgaWYgKCFtX2VuZCkKICAgICAgICAg bV9lbmQgPSBtX2J1ZmZlci5jYXBhY2l0eSgpIC0gMTsKICAgICBlbHNlCg==