223006 2021-03-09 16:31:56 -0800 REGRESSION: two webkitscmpy.test.svn_unittest.TestRemoteSvn tests are flaky failures 2021-03-12 11:05:20 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222946 InRadar P2 Normal --- 1 ryanhaddad jbedard aakash_jain ap dewei_zhu jbedard lmoura webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1737848 0 ryanhaddad 2021-03-09 16:31:56 -0800 The following two webkitscmpy tests appear to have become flaky failures recently https://results.webkit.org/?suite=webkitpy-tests&suite=webkitpy-tests&test=webkitscmpy.test.svn_unittest.TestRemoteSvn.test_identifier&test=webkitscmpy.test.svn_unittest.TestRemoteSvn.test_non_cannonical_identifiers [1956/1972] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_non_cannonical_identifiers erred: Traceback (most recent call last): File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 305, in test_non_cannonical_identifiers self.assertEqual('2@trunk', str(remote.Svn(self.remote).commit(identifier='0@branch-a'))) File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py", line 374, in commit info = self.info(cached=True, branch=branch, revision=revision) File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/decorators.py", line 55, in decorator value = function(*args, **kwargs) File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py", line 124, in info }, data='<propfind xmlns="DAV:">\n' File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py", line 120, in <lambda> patch('requests.request', new=lambda *args, **kwargs: Session().request(*args, **kwargs)), File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py", line 115, in request return this.request(method, url, **kwargs) File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py", line 263, in request datetime.fromtimestamp(commit.timestamp, tz=tzoffset(None, -7 * 60 * 60)).strftime('%Y-%m-%dT%H:%M:%S.103754Z'), File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/libraries/autoinstalled/python-3/dateutil/tz/_common.py", line 140, in fromutc raise TypeError("fromutc() requires a datetime argument") TypeError: fromutc() requires a datetime argument [1954/1972] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_identifier erred: Traceback (most recent call last): File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 294, in test_identifier self.assertEqual(1, remote.Svn(self.remote).commit(identifier='1@trunk').revision) File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py", line 374, in commit info = self.info(cached=True, branch=branch, revision=revision) File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/decorators.py", line 55, in decorator value = function(*args, **kwargs) File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py", line 117, in info response = requests.request( File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py", line 120, in <lambda> patch('requests.request', new=lambda *args, **kwargs: Session().request(*args, **kwargs)), File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py", line 115, in request return this.request(method, url, **kwargs) File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py", line 263, in request datetime.fromtimestamp(commit.timestamp, tz=tzoffset(None, -7 * 60 * 60)).strftime('%Y-%m-%dT%H:%M:%S.103754Z'), File "/Volumes/Data/worker/bigsur-debug-tests-wk1/build/Tools/Scripts/libraries/autoinstalled/python-3/dateutil/tz/_common.py", line 140, in fromutc raise TypeError("fromutc() requires a datetime argument") TypeError: fromutc() requires a datetime argument 1737850 1 ryanhaddad 2021-03-09 16:33:04 -0800 Maybe related to https://trac.webkit.org/changeset/274127/webkit? 1737865 2 jbedard 2021-03-09 17:05:32 -0800 Do not understand how this can possibly be flakey, taking a closer look. 1738166 3 lmoura 2021-03-10 12:18:48 -0800 I also getting these locally kinda often, and a webkitpy patch failed once in EWS earlier today. Adding some prints to `dateutil` where it is triggered (_common.py:140), the `dt` parameter is indeed a `datetime.datetime` object, but the imported `datetime` name in this module sometimes points to `FakeDateTime` (which is a subclass of `datetime.datetime`), making the `isinstance` call to return False. 1738172 4 jbedard 2021-03-10 12:25:22 -0800 (In reply to Lauro Moura from comment #3) > I also getting these locally kinda often, and a webkitpy patch failed once > in EWS earlier today. > > Adding some prints to `dateutil` where it is triggered (_common.py:140), the > `dt` parameter is indeed a `datetime.datetime` object, but the imported > `datetime` name in this module sometimes points to `FakeDateTime` (which is > a subclass of `datetime.datetime`), making the `isinstance` call to return > False. I have a partial change locally that just abandons timezone shenanigans entirely and prints the time as utc shifted 7 hours (which is California time for our SVN server, which is the whole point of all of this anyways) 1738208 5 422865 jbedard 2021-03-10 13:37:53 -0800 Created attachment 422865 Patch 1738213 6 lmoura 2021-03-10 13:50:21 -0800 (In reply to Jonathan Bedard from comment #4) > I have a partial change locally that just abandons timezone shenanigans > entirely and prints the time as utc shifted 7 hours (which is California > time for our SVN server, which is the whole point of all of this anyways) Nice, hopefully this will be enough for this error. Given the flakiness and the import issue, it kinda looks like a test patching datetime to mock it has this mocked datetime "leaking" to other tests not expecting it later, no? Btw, I found this old freezegun patch with isinstance issues when working together with dateutil: https://github.com/spulec/freezegun/commit/0453e5f47efd1d0d79af973e5ddcf9fa83b2ca40 1738765 7 lmoura 2021-03-11 21:03:00 -0800 Tested here a few dozen times and no more flakiness nor regresssions. 1738924 8 ews-feeder 2021-03-12 09:18:42 -0800 commit-queue failed to commit attachment 422865 to WebKit repository. To retry, please set cq+ flag again. 1738965 9 ews-feeder 2021-03-12 11:04:07 -0800 Committed r274366: <https://commits.webkit.org/r274366> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422865. 1738967 10 webkit-bug-importer 2021-03-12 11:05:20 -0800 <rdar://problem/75369005> 422865 2021-03-10 13:37:53 -0800 2021-03-12 11:04:07 -0800 Patch bug-223006-20210310133752.patch text/plain 1931 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDIyNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTAzLTEwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OOiB0d28gd2Via2l0c2NtcHkudGVzdC5zdm5fdW5pdHRl c3QuVGVzdFJlbW90ZVN2biB0ZXN0cyBhcmUgZmxha3kgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMzAwNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Vi a2l0c2NtcHkvd2Via2l0c2NtcHkvbW9ja3MvcmVtb3RlL3N2bi5weToKKyAgICAgICAgKFN2bi5y ZXF1ZXN0KTogSGFyZC1jb2RlIHRpbWV6b25lIGRlbHRhIGZvciBTdWJ2ZXJzaW9uIHNlcnZlci4K KwogMjAyMS0wMy0xMCAgU2FtIFNuZWRkb24gIDxnc25lZGRlcnNAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZGluZyBQeXRob24gdHlwZSBhbm5vdGF0aW9ucyB0byB0ZXN0X2V4cGVjdGF0aW9ucy5w eQpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkv bW9ja3MvcmVtb3RlL3N2bi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmll cy93ZWJraXRzY21weS93ZWJraXRzY21weS9tb2Nrcy9yZW1vdGUvc3ZuLnB5CShyZXZpc2lvbiAy NzQyMjcpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21w eS9tb2Nrcy9yZW1vdGUvc3ZuLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMzIsOCArMTMyLDcgQEAg Y2xhc3MgU3ZuKG1vY2tzLlJlcXVlc3RzKToKICAgICAgICAgcmV0dXJuIHJlc3VsdAogCiAgICAg ZGVmIHJlcXVlc3Qoc2VsZiwgbWV0aG9kLCB1cmwsIGRhdGE9Tm9uZSwgKiprd2FyZ3MpOgotICAg ICAgICBmcm9tIGRhdGV0aW1lIGltcG9ydCBkYXRldGltZQotICAgICAgICBmcm9tIGRhdGV1dGls LnR6IGltcG9ydCB0em9mZnNldAorICAgICAgICBmcm9tIGRhdGV0aW1lIGltcG9ydCBkYXRldGlt ZSwgdGltZWRlbHRhCiAKICAgICAgICAgaWYgbm90IHVybC5zdGFydHN3aXRoKCdodHRwOi8vJykg YW5kIG5vdCB1cmwuc3RhcnRzd2l0aCgnaHR0cHM6Ly8nKToKICAgICAgICAgICAgIHJldHVybiBt b2Nrcy5SZXNwb25zZS5jcmVhdGU0MDQodXJsKQpAQCAtMjYwLDcgKzI1OSw3IEBAIGNsYXNzIFN2 bihtb2Nrcy5SZXF1ZXN0cyk6CiAgICAgICAgICAgICAgICAgICAgICc8L0Q6bXVsdGlzdGF0dXM+ XG4nLmZvcm1hdCgKICAgICAgICAgICAgICAgICAgICAgICAgIHN0cmlwcGVkX3VybCwKICAgICAg ICAgICAgICAgICAgICAgICAgIGNvbW1pdC5yZXZpc2lvbiwKLSAgICAgICAgICAgICAgICAgICAg ICAgIGRhdGV0aW1lLmZyb210aW1lc3RhbXAoY29tbWl0LnRpbWVzdGFtcCwgdHo9dHpvZmZzZXQo Tm9uZSwgLTcgKiA2MCAqIDYwKSkuc3RyZnRpbWUoJyVZLSVtLSVkVCVIOiVNOiVTLjEwMzc1NFon KSwKKyAgICAgICAgICAgICAgICAgICAgICAgIGRhdGV0aW1lLnV0Y2Zyb210aW1lc3RhbXAoY29t bWl0LnRpbWVzdGFtcCAtIHRpbWVkZWx0YShob3Vycz03KS5zZWNvbmRzKS5zdHJmdGltZSgnJVkt JW0tJWRUJUg6JU06JVMuMTAzNzU0WicpLAogICAgICAgICAgICAgICAgICAgICAgICAgY29tbWl0 LmF1dGhvci5lbWFpbCwKICAgICAgICAgICAgICAgICApLAogICAgICAgICAgICAgKQo=