222996 2021-03-09 14:48:59 -0800 CRASH in MergeUVRow_AVX2 2021-03-10 13:56:49 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble eric.carlson ggaren peng.liu6 webkit-bug-importer youennf oldest_to_newest 1737776 0 jer.noble 2021-03-09 14:48:59 -0800 CRASH in MergeUVRow_AVX2 1737780 1 jer.noble 2021-03-09 14:49:38 -0800 <rdar://75183835> 1737781 2 webkit-bug-importer 2021-03-09 14:49:57 -0800 <rdar://problem/75236308> 1737785 3 422764 jer.noble 2021-03-09 14:55:46 -0800 Created attachment 422764 Patch 1737799 4 422764 ggaren 2021-03-09 15:24:21 -0800 Comment on attachment 422764 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422764&action=review r=me > Source/ThirdParty/libwebrtc/ChangeLog:13 > + > + Crash logging shows occasional crashes in MergeUVRow_AVX2; the explanation > + for these crashes seems to be a mismatch between the size of the libvpx > + output frame and the size of the CVPixelBuffer where the converted frame > + data is being stored. Add a pre-flight check that will bail out early in > + this scenario. At first I thought this might not be great behavior; but your comment in Radar convinced me. Might be helpful to add that comment in your ChangeLog or in the code. 1737800 5 ggaren 2021-03-09 15:24:40 -0800 Side note: I think Youenn was looking at a similar crash. 1738081 6 jer.noble 2021-03-10 09:20:22 -0800 <rdar://75183835> 1738082 7 422837 jer.noble 2021-03-10 09:20:55 -0800 Created attachment 422837 Patch for landing 1738217 8 ews-feeder 2021-03-10 13:56:47 -0800 Committed r274237: <https://commits.webkit.org/r274237> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422837. 422764 2021-03-09 14:55:46 -0800 2021-03-09 15:24:21 -0800 Patch bug-222996-20210309145545.patch text/plain 2811 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA0ZDU3ZjFhNTNhOWYyOTdhNzEwNzliZWZhMjE5ZmUwNzQ1ODcyYmZhLi5iYThh YWViYjQ2YTU1ZGE1YzIyMzM4Zjk1YTIxM2Y0MjY3YWRiNDE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAyMS0wMy0wOSAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBDUkFTSCBpbiBNZXJnZVVWUm93X0FW WDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjk5 NgorICAgICAgICA8cmRhcjovLzc1MTgzODM1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGxvZ2dpbmcgc2hvd3Mgb2NjYXNpb25hbCBjcmFz aGVzIGluIE1lcmdlVVZSb3dfQVZYMjsgdGhlIGV4cGxhbmF0aW9uCisgICAgICAgIGZvciB0aGVz ZSBjcmFzaGVzIHNlZW1zIHRvIGJlIGEgbWlzbWF0Y2ggYmV0d2VlbiB0aGUgc2l6ZSBvZiB0aGUg bGlidnB4CisgICAgICAgIG91dHB1dCBmcmFtZSBhbmQgdGhlIHNpemUgb2YgdGhlIENWUGl4ZWxC dWZmZXIgd2hlcmUgdGhlIGNvbnZlcnRlZCBmcmFtZQorICAgICAgICBkYXRhIGlzIGJlaW5nIHN0 b3JlZC4gQWRkIGEgcHJlLWZsaWdodCBjaGVjayB0aGF0IHdpbGwgYmFpbCBvdXQgZWFybHkgaW4K KyAgICAgICAgdGhpcyBzY2VuYXJpby4KKworICAgICAgICAqIFNvdXJjZS93ZWJydGMvc2RrL1dl YktpdC9XZWJLaXRVdGlsaXRpZXMubW06CisgICAgICAgICh3ZWJydGM6OkNvcHlWaWRlb0ZyYW1l VG9QaXhlbEJ1ZmZlcik6CisKIDIwMjEtMDMtMDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIFVzZSBOT19NQUlOX1RIUkVBRF9XUkFQUElORyB0byBjb21waWxl IGxpYndlYnJ0YwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJj ZS93ZWJydGMvc2RrL1dlYktpdC9XZWJLaXRVdGlsaXRpZXMubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1dlYktpdFV0aWxpdGllcy5tbQpp bmRleCAxYjY0NDQ5ZWQ0YjJkZDcyZTIzZDE2YjJlNTI1ZmMzZWU5NWI4YTAzLi43MzQzZjc0YWVj ODM3MjM4M2NjZTYwMjNhNmZmNjNjZjI4MzJkOTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1dlYktpdFV0aWxpdGllcy5t bQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvV2Vi S2l0L1dlYktpdFV0aWxpdGllcy5tbQpAQCAtNjAsMTEgKzYwLDI2IEBAIHN0YXRpYyBib29sIENv cHlWaWRlb0ZyYW1lVG9QaXhlbEJ1ZmZlcihjb25zdCB3ZWJydGM6Okk0MjBCdWZmZXJJbnRlcmZh Y2UqIGZyYW1lCiAgICAgaWYgKENWUGl4ZWxCdWZmZXJMb2NrQmFzZUFkZHJlc3MocGl4ZWxfYnVm ZmVyLCAwKSAhPSBrQ1ZSZXR1cm5TdWNjZXNzKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAg ICBhdXRvIHNyY193aWR0aF95ID0gZnJhbWUtPndpZHRoKCk7CisgICAgYXV0byBzcmNfaGVpZ2h0 X3kgPSBmcmFtZS0+aGVpZ2h0KCk7CisgICAgYXV0byBzcmNfd2lkdGhfdXYgPSBmcmFtZS0+Q2hy b21hV2lkdGgoKTsKKyAgICBhdXRvIHNyY19oZWlnaHRfdXYgPSBmcmFtZS0+Q2hyb21hSGVpZ2h0 KCk7CisKICAgICB1aW50OF90KiBkc3RfeSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KENW UGl4ZWxCdWZmZXJHZXRCYXNlQWRkcmVzc09mUGxhbmUocGl4ZWxfYnVmZmVyLCAwKSk7CiAgICAg aW50IGRzdF9zdHJpZGVfeSA9IENWUGl4ZWxCdWZmZXJHZXRCeXRlc1BlclJvd09mUGxhbmUocGl4 ZWxfYnVmZmVyLCAwKTsKKyAgICBhdXRvIGRzdF93aWR0aF95ID0gQ1ZQaXhlbEJ1ZmZlckdldFdp ZHRoT2ZQbGFuZShwaXhlbF9idWZmZXIsIDApOworICAgIGF1dG8gZHN0X2hlaWdodF95ID0gQ1ZQ aXhlbEJ1ZmZlckdldEhlaWdodE9mUGxhbmUocGl4ZWxfYnVmZmVyLCAwKTsKIAogICAgIHVpbnQ4 X3QqIGRzdF91diA9IHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KENWUGl4ZWxCdWZmZXJHZXRC YXNlQWRkcmVzc09mUGxhbmUocGl4ZWxfYnVmZmVyLCAxKSk7CiAgICAgaW50IGRzdF9zdHJpZGVf dXYgPSBDVlBpeGVsQnVmZmVyR2V0Qnl0ZXNQZXJSb3dPZlBsYW5lKHBpeGVsX2J1ZmZlciwgMSk7 CisgICAgYXV0byBkc3Rfd2lkdGhfdXYgPSBDVlBpeGVsQnVmZmVyR2V0V2lkdGhPZlBsYW5lKHBp eGVsX2J1ZmZlciwgMSk7CisgICAgYXV0byBkc3RfaGVpZ2h0X3V2ID0gQ1ZQaXhlbEJ1ZmZlckdl dEhlaWdodE9mUGxhbmUocGl4ZWxfYnVmZmVyLCAxKTsKKworICAgIGlmIChzcmNfd2lkdGhfeSAh PSBkc3Rfd2lkdGhfeQorICAgICAgICB8fCBzcmNfaGVpZ2h0X3kgIT0gZHN0X2hlaWdodF95Cisg ICAgICAgIHx8IHNyY193aWR0aF91diAhPSBkc3Rfd2lkdGhfdXYKKyAgICAgICAgfHwgc3JjX2hl aWdodF91diAhPSBkc3RfaGVpZ2h0X3V2KQorICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBp bnQgcmVzdWx0ID0gbGlieXV2OjpJNDIwVG9OVjEyKAogICAgICAgICBmcmFtZS0+RGF0YVkoKSwg ZnJhbWUtPlN0cmlkZVkoKSwK 422837 2021-03-10 09:20:55 -0800 2021-03-10 13:56:48 -0800 Patch for landing bug-222996-20210310092054.patch text/plain 3605 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA0NDk5ZTVmYzMwOTJiMGNjMzBiODEwYjcxMDM2MzBhYTQ5MzE2NTdlLi42YTdh OWJmYTUzNzU5YjQ2ZGUzNDhlMjE0MGM1MmMwMWY2NzAzYzNmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAyMS0wMy0wOSAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBDUkFTSCBpbiBNZXJnZVVWUm93X0FW WDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjk5 NgorICAgICAgICA8cmRhcjovLzc1MTgzODM1PgorCisgICAgICAgIFJldmlld2VkIGJ5IEdlb2Zm IEdhcmVuLgorCisgICAgICAgIENyYXNoIGxvZ2dpbmcgc2hvd3Mgb2NjYXNpb25hbCBjcmFzaGVz IGluIE1lcmdlVVZSb3dfQVZYMi4gVGhlc2UgY3Jhc2hlcyAgYWxsIG9jY3VyIHdoZW4KKyAgICAg ICAgY2FsbGluZyAtW0FWQXNzZXRJbWFnZUdlbmVyYXRvciBjb3B5Q0dJbWFnZUF0VGltZTphY3R1 YWxUaW1lOmVycm9yOl0uIFRoaXMgcGF0aCBpcyBvbmx5IHVzZWQKKyAgICAgICAgd2hlbiB0aGVy ZSB3YXMgbm8gcHJpb3IgaW1hZ2UgZ2VuZXJhdGVkLCBhbmQgYSBuZXcgaW1hZ2UgaXMgbm90IGF2 YWlsYWJsZSBmcm9tCisgICAgICAgIEFWUGxheWVySXRlbVZpZGVvT3V0cHV0LCB3aGljaCBpcyBh IHNjZW5hcmlvIHdoaWNoIG9ubHkgb2NjdXJzIHdoZW4gZG9pbmcgYSBzb2Z0d2FyZS1wYWludAor ICAgICAgICBpbW1lZGF0ZWx5IGFmdGVyIGEgPHZpZGVvPiBlbGVtZW50IGJlZ2lucyBsb2FkaW5n LiBXaGlsZSB3ZSBzaG91bGQgcHJvYmFibHkgc3RvcCB1c2luZworICAgICAgICBBVkFzc2V0SW1h Z2VHZW5lcmF0b3IsIHRoYXQgd291bGQgYmUgYSBtdWNoIHJpc2tpZXIgY2hhbmdlLCBhbmQgd291 bGRuJ3QgYWRkcmVzcyB0aGUKKyAgICAgICAgdW5kZXJseWluZyBjYXVzZSBvZiB0aGUgY3Jhc2gu IEluc3RlYWQsIGJhaWxpbmcgb3V0IGVhcmx5IHdoZW4gaW4gdGhpcyBzdGF0ZSB3b3VsZCBjYXVz ZQorICAgICAgICBkZWNvZGluZyB0byBmYWlsLCBidXQgc2luY2UgdGhpcyBzY2VuYXJpbyBvbmx5 IGFwcGVhcnMgdG8gb2NjdXIgZm9yIHRoZQorICAgICAgICBBVkFzc2V0SW1hZ2VHZW5lcmF0b3Ig cGF0aCwgcGFpbnRpbmcgd291bGQgcXVpY2tseSByZWNvdmVyIGFzIHNvb24gYXMKKyAgICAgICAg QVZQbGF5ZXJJdGVtVmlkZW9PdXRwdXQgYmVnaW5zIGVtaXR0aW5nIGZyYW1lcy4KKworICAgICAg ICBUaGUgZXhwbGFuYXRpb24gZm9yIHRoZXNlIGNyYXNoZXMgc2VlbXMgdG8gYmUgYSBtaXNtYXRj aCBiZXR3ZWVuIHRoZSBzaXplIG9mIHRoZSBsaWJ2cHgKKyAgICAgICAgb3V0cHV0IGZyYW1lIGFu ZCB0aGUgc2l6ZSBvZiB0aGUgQ1ZQaXhlbEJ1ZmZlciB3aGVyZSB0aGUgY29udmVydGVkIGZyYW1l IGRhdGEgaXMgYmVpbmcKKyAgICAgICAgc3RvcmVkLiBBZGQgYSBwcmUtZmxpZ2h0IGNoZWNrIHRo YXQgd2lsbCBiYWlsIG91dCBlYXJseSBpbiB0aGlzIHNjZW5hcmlvLgorCisgICAgICAgICogU291 cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1dlYktpdFV0aWxpdGllcy5tbToKKyAgICAgICAgKHdlYnJ0 Yzo6Q29weVZpZGVvRnJhbWVUb1BpeGVsQnVmZmVyKToKKwogMjAyMS0wMy0wOSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRHVwbGljYXRlIGhlYWRlcnMgaW4g V2ViUlRDCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dl YnJ0Yy9zZGsvV2ViS2l0L1dlYktpdFV0aWxpdGllcy5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvV2ViS2l0VXRpbGl0aWVzLm1tCmluZGV4 IDFiNjQ0NDllZDRiMmRkNzJlMjNkMTZiMmU1MjVmYzNlZTk1YjhhMDMuLjczNDNmNzRhZWM4Mzcy MzgzY2NlNjAyM2E2ZmY2M2NmMjgzMmQ5MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvV2ViS2l0VXRpbGl0aWVzLm1tCisr KyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQv V2ViS2l0VXRpbGl0aWVzLm1tCkBAIC02MCwxMSArNjAsMjYgQEAgc3RhdGljIGJvb2wgQ29weVZp ZGVvRnJhbWVUb1BpeGVsQnVmZmVyKGNvbnN0IHdlYnJ0Yzo6STQyMEJ1ZmZlckludGVyZmFjZSog ZnJhbWUKICAgICBpZiAoQ1ZQaXhlbEJ1ZmZlckxvY2tCYXNlQWRkcmVzcyhwaXhlbF9idWZmZXIs IDApICE9IGtDVlJldHVyblN1Y2Nlc3MpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGF1 dG8gc3JjX3dpZHRoX3kgPSBmcmFtZS0+d2lkdGgoKTsKKyAgICBhdXRvIHNyY19oZWlnaHRfeSA9 IGZyYW1lLT5oZWlnaHQoKTsKKyAgICBhdXRvIHNyY193aWR0aF91diA9IGZyYW1lLT5DaHJvbWFX aWR0aCgpOworICAgIGF1dG8gc3JjX2hlaWdodF91diA9IGZyYW1lLT5DaHJvbWFIZWlnaHQoKTsK KwogICAgIHVpbnQ4X3QqIGRzdF95ID0gcmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4oQ1ZQaXhl bEJ1ZmZlckdldEJhc2VBZGRyZXNzT2ZQbGFuZShwaXhlbF9idWZmZXIsIDApKTsKICAgICBpbnQg ZHN0X3N0cmlkZV95ID0gQ1ZQaXhlbEJ1ZmZlckdldEJ5dGVzUGVyUm93T2ZQbGFuZShwaXhlbF9i dWZmZXIsIDApOworICAgIGF1dG8gZHN0X3dpZHRoX3kgPSBDVlBpeGVsQnVmZmVyR2V0V2lkdGhP ZlBsYW5lKHBpeGVsX2J1ZmZlciwgMCk7CisgICAgYXV0byBkc3RfaGVpZ2h0X3kgPSBDVlBpeGVs QnVmZmVyR2V0SGVpZ2h0T2ZQbGFuZShwaXhlbF9idWZmZXIsIDApOwogCiAgICAgdWludDhfdCog ZHN0X3V2ID0gcmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4oQ1ZQaXhlbEJ1ZmZlckdldEJhc2VB ZGRyZXNzT2ZQbGFuZShwaXhlbF9idWZmZXIsIDEpKTsKICAgICBpbnQgZHN0X3N0cmlkZV91diA9 IENWUGl4ZWxCdWZmZXJHZXRCeXRlc1BlclJvd09mUGxhbmUocGl4ZWxfYnVmZmVyLCAxKTsKKyAg ICBhdXRvIGRzdF93aWR0aF91diA9IENWUGl4ZWxCdWZmZXJHZXRXaWR0aE9mUGxhbmUocGl4ZWxf YnVmZmVyLCAxKTsKKyAgICBhdXRvIGRzdF9oZWlnaHRfdXYgPSBDVlBpeGVsQnVmZmVyR2V0SGVp Z2h0T2ZQbGFuZShwaXhlbF9idWZmZXIsIDEpOworCisgICAgaWYgKHNyY193aWR0aF95ICE9IGRz dF93aWR0aF95CisgICAgICAgIHx8IHNyY19oZWlnaHRfeSAhPSBkc3RfaGVpZ2h0X3kKKyAgICAg ICAgfHwgc3JjX3dpZHRoX3V2ICE9IGRzdF93aWR0aF91dgorICAgICAgICB8fCBzcmNfaGVpZ2h0 X3V2ICE9IGRzdF9oZWlnaHRfdXYpCisgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGludCBy ZXN1bHQgPSBsaWJ5dXY6Okk0MjBUb05WMTIoCiAgICAgICAgIGZyYW1lLT5EYXRhWSgpLCBmcmFt ZS0+U3RyaWRlWSgpLAo=