<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>222959</bug_id>
          
          <creation_ts>2021-03-08 21:07:16 -0800</creation_ts>
          <short_desc>[CMake] Build fails on RISC-V with GCC 11</short_desc>
          <delta_ts>2021-03-16 07:23:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Khem Raj">raj.khem</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>benjamin</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cdumez</cc>
    
    <cc>clopez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>nina</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>saam</cc>
    
    <cc>sergio</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1737458</commentid>
    <comment_count>0</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-08 21:07:16 -0800</bug_when>
    <thetext>with GCC 11 there is additional use of C11 atomics in WTF code, which is causing the builds to fails like below

/usr/src/debug/webkitgtk/2.30.5-r0/webkitgtk-2.30.5/Source/WTF/wtf/Assertions.cpp:226: undefined reference to `__atomic_compare_exchange_1&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1737460</commentid>
    <comment_count>1</comment_count>
      <attachid>422662</attachid>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-08 21:10:31 -0800</bug_when>
    <thetext>Created attachment 422662
potential fix

this fixes the problem. But perhaps better would be to let CMake&apos;ry detect if linking with -latomic is needed or not. Since it may not be necessary on all platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1737527</commentid>
    <comment_count>2</comment_count>
    <who name="Nina Kolesová">nina</who>
    <bug_when>2021-03-09 03:52:05 -0800</bug_when>
    <thetext>there is already build system stuff in place to check for libatomic (since a bunch of 32-bit targets, notably armv6, powerpc and mips, do not have hardware 64-bit operations)

risc-v has them, but __atomic_compare_exchange_1 is a 1-byte CAS, and operations on values less than 4 bytes are apparently not always lock-free on risc-v, so basically you just need to extend the existing checks that are in place</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1737593</commentid>
    <comment_count>3</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-09 08:52:08 -0800</bug_when>
    <thetext>(In reply to Daniel Kolesa from comment #2)
&gt; there is already build system stuff in place to check for libatomic (since a
&gt; bunch of 32-bit targets, notably armv6, powerpc and mips, do not have
&gt; hardware 64-bit operations)
&gt; 
&gt; risc-v has them, but __atomic_compare_exchange_1 is a 1-byte CAS, and
&gt; operations on values less than 4 bytes are apparently not always lock-free
&gt; on risc-v, so basically you just need to extend the existing checks that are
&gt; in place

right, could you help pointing to the test I can enhance and try out ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1737626</commentid>
    <comment_count>4</comment_count>
    <who name="Nina Kolesová">nina</who>
    <bug_when>2021-03-09 09:38:45 -0800</bug_when>
    <thetext>sure, here you go https://github.com/WebKit/WebKit/blob/main/Source/cmake/WebKitCompilerFlags.cmake#L275

the test should do a compare-and-swap on int8_t, using the standard C++ atomic API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1737628</commentid>
    <comment_count>5</comment_count>
    <who name="Nina Kolesová">nina</who>
    <bug_when>2021-03-09 09:42:13 -0800</bug_when>
    <thetext>oh, and you can probably just put it in the existing compile-test (rather than making a separate one with a separate variable; the outcome in either case is &quot;we want libatomic&quot; which means if you just do both operations in the same test, it doesn&apos;t matter if just one fails or both fail; i&apos;d also rename ATOMIC_INT64_IS_BUILTIN to something more generic, like say, ATOMIC_NEED_LIBATOMIC</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1737768</commentid>
    <comment_count>6</comment_count>
      <attachid>422760</attachid>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-09 14:39:42 -0800</bug_when>
    <thetext>Created attachment 422760
potential fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1737987</commentid>
    <comment_count>7</comment_count>
      <attachid>422760</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2021-03-10 01:57:00 -0800</bug_when>
    <thetext>Comment on attachment 422760
potential fix

Thanks! The patch looks good to me, but it&apos;s lacking a ChangeLog entry.

Could you add one and re-submit the patch? You can use the script
at “Tools/Scripts/prepare-ChangeLog” to generate a new entry and
fill the details there.

There is more information about how to add ChangeLog entries here:

  https://webkit.org/contributing-code/#changelog-files

I hope this helps :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738363</commentid>
    <comment_count>8</comment_count>
      <attachid>422903</attachid>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-10 23:09:28 -0800</bug_when>
    <thetext>Created attachment 422903
potential fix 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738391</commentid>
    <comment_count>9</comment_count>
      <attachid>422903</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2021-03-11 01:36:21 -0800</bug_when>
    <thetext>Comment on attachment 422903
potential fix 2

Hi again!

The patch is not *almost* ready. There are a couple of small changes
needed—please take a look.

And no worries, it&apos;s normal to run into these issues when submitting
patches to WebKit in the beginning, thanks for your patience.  :) 

View in context: https://bugs.webkit.org/attachment.cgi?id=422903&amp;action=review

&gt; ChangeLog:4
&gt; +	architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free 

This line is using tabs for indentation. In the ChangeLog files we use
always 8 spaces. This is the reason why the “style” build bot is red.
You can click the status bubbles to read the logs, in this case the
log is at:

  https://ews-build.webkit.org/#/builders/6/builds/42288

You can use ”Tools/Scripts/check-webkit-style” if you want to verify
patches before submitting them :)

&gt; ChangeLog:8
&gt; +        Reviewed by Adrian Perez.

This should be “Reviewed by Adrian Perez de Castro“, because that is how
my name appears in “Tools/Scripts/webkitpy/common/config/contributors.json”

Even better: It is possible to leave the “Reviewed by OOPS” line without
typing the name of the reviewer, and then when a patch is marked as reviewed
(r+) in Bugzilla the “OOPS” will be replaced automatically when the patch gets
merged in the repository :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738392</commentid>
    <comment_count>10</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2021-03-11 01:38:58 -0800</bug_when>
    <thetext>Ah, and I forgot to mention that we have “Tools/Scripts/webkit-path”
that can upload patches to Bugzilla automatically from the command line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738393</commentid>
    <comment_count>11</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2021-03-11 01:39:45 -0800</bug_when>
    <thetext>(In reply to Adrian Perez from comment #10)
&gt; Ah, and I forgot to mention that we have “Tools/Scripts/webkit-path”
&gt; that can upload patches to Bugzilla automatically from the command line.

I meant ”webkit-patch” O:-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738418</commentid>
    <comment_count>12</comment_count>
    <who name="Nina Kolesová">nina</who>
    <bug_when>2021-03-11 04:37:34 -0800</bug_when>
    <thetext>the test is not correct, the undefined reference was `__atomic_compare_exchange_1` while the one you&apos;re testing is `__atomic_fetch_add_1`</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738535</commentid>
    <comment_count>13</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-11 10:58:36 -0800</bug_when>
    <thetext>(In reply to Daniel Kolesa from comment #12)
&gt; the test is not correct, the undefined reference was
&gt; `__atomic_compare_exchange_1` while the one you&apos;re testing is
&gt; `__atomic_fetch_add_1`

yes, although I saw that none of 1byte ops were not available as builtins since the test was simple for __atomic_fetch_add_1, I went with it. but perhaps using __atomic_compare_exchange_1 for test would be more accurate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738566</commentid>
    <comment_count>14</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-11 11:51:11 -0800</bug_when>
    <thetext>(In reply to Adrian Perez from comment #10)
&gt; Ah, and I forgot to mention that we have “Tools/Scripts/webkit-path”
&gt; that can upload patches to Bugzilla automatically from the command line.

it does not work on my host (archlinux ) see http://sprunge.us/XUqwhd</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738567</commentid>
    <comment_count>15</comment_count>
      <attachid>422956</attachid>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-11 11:53:03 -0800</bug_when>
    <thetext>Created attachment 422956
potential fix 3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738568</commentid>
    <comment_count>16</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-11 11:53:40 -0800</bug_when>
    <thetext>(In reply to Daniel Kolesa from comment #12)
&gt; the test is not correct, the undefined reference was
&gt; `__atomic_compare_exchange_1` while the one you&apos;re testing is
&gt; `__atomic_fetch_add_1`

I have addressed it in v3 of patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738602</commentid>
    <comment_count>17</comment_count>
      <attachid>422956</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-03-11 13:51:54 -0800</bug_when>
    <thetext>Comment on attachment 422956
potential fix 3

View in context: https://bugs.webkit.org/attachment.cgi?id=422956&amp;action=review

&gt; Source/WebKit/ChangeLog:4
&gt; +        Use renamed ATOMICS_REQUIRE_LIBATOMIC instead of
&gt; +       ATOMIC_INT64_REQUIRES_LIBATOMIC.

We don&apos;t usually wrap long lines on WebKit. The practice is to use just one line for all the subject even if this is many characters long.

&gt; Source/WebKit/ChangeLog:6
&gt; +
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=222959

Also we don&apos;t use an extra empty line between the subjet and the bug link

&gt; Source/WebKit/ChangeLog:8
&gt; +        Reviewed by OOPS.

This should be &quot;Reviewed by NOBODY (OOPS!).&quot;
That is important because the tooling we use to land patches looks for those exact words to later replace the &quot;NOBODY (OOPS!)&quot; with the name of the reviewer.

I know this sounds like a lot of bureaucracy at first, but once you get used to it is pretty straightforward.

To generate the changelogs we have a script. We don&apos;t create them by hand.
It is used like this:

Tools/Scripts/prepare-ChangeLog -b ${bugzillanumber} -g ${localgitcommitforchangelog}

For example, assuming you are checked out on the patch to upload and this patch is committed locally

Tools/Scripts/prepare-ChangeLog -b 222959 -g HEAD

It will generate the changelog files, then you just edit under the reviewed line it will appear the message of your local commit.. you edit that to tell a bit about what the patch does. Then you add the changelogs to git and commit them by amending the previos commit, then its ready to upload.

You can generate a patch and upload it here manually or you can use another script to upload the patch directly.

Tools/Scripts/webkit-patch upload -g ${localgitcommittobeuploaded} --suggest-reviewers

It will automatically detect the bug number where the patch should be uploaded from the changelog

&gt; Source/cmake/WebKitCompilerFlags.cmake:284
&gt;  if (COMPILER_IS_GCC_OR_CLANG)
&gt;      set(ATOMIC_TEST_SOURCE &quot;
&gt; -        #include &lt;atomic&gt;
&gt; -        int main() { std::atomic&lt;int64_t&gt; i(0); i++; return 0; }
&gt; +	#include &lt;atomic&gt;
&gt; +	int main() {
&gt; +          std::atomic&lt;bool&gt; y (false);
&gt; +          std::atomic&lt;uint64_t&gt; x (0);
&gt; +          bool expected = true;
&gt; +          bool j = y.compare_exchange_weak(expected,false);
&gt; +          x++;
&gt; +          return 0;
&gt; +        }

The Early Warning System (EWS) bot for checking the style is complaining here about mixed spaces/tabs

ERROR: Source/cmake/WebKitCompilerFlags.cmake:276:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/cmake/WebKitCompilerFlags.cmake:277:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 8 files
program finished with exit code 1

^^ https://ews-build.webkit.org/#/builders/6/builds/42334</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738660</commentid>
    <comment_count>18</comment_count>
      <attachid>422979</attachid>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-11 15:17:02 -0800</bug_when>
    <thetext>Created attachment 422979
potential fix 4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738665</commentid>
    <comment_count>19</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-11 15:23:27 -0800</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #17)
&gt; Comment on attachment 422956 [details]
&gt; potential fix 3
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=422956&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:4
&gt; &gt; +        Use renamed ATOMICS_REQUIRE_LIBATOMIC instead of
&gt; &gt; +       ATOMIC_INT64_REQUIRES_LIBATOMIC.
&gt; 
&gt; We don&apos;t usually wrap long lines on WebKit. The practice is to use just one
&gt; line for all the subject even if this is many characters long.

Done.

&gt; 
&gt; &gt; Source/WebKit/ChangeLog:6
&gt; &gt; +
&gt; &gt; +        https://bugs.webkit.org/show_bug.cgi?id=222959
&gt; 
&gt; Also we don&apos;t use an extra empty line between the subjet and the bug link

Thanks done, I generated them but then edited them heavily :)

&gt; 
&gt; &gt; Source/WebKit/ChangeLog:8
&gt; &gt; +        Reviewed by OOPS.
&gt; 
&gt; This should be &quot;Reviewed by NOBODY (OOPS!).&quot;
&gt; That is important because the tooling we use to land patches looks for those
&gt; exact words to later replace the &quot;NOBODY (OOPS!)&quot; with the name of the
&gt; reviewer.

Good to know. done.

&gt; 
&gt; I know this sounds like a lot of bureaucracy at first, but once you get used
&gt; to it is pretty straightforward.
&gt; 

yeah in the world after git, CHANGELOGs have become out of fashion but I know
few other projects who still use them.


&gt; To generate the changelogs we have a script. We don&apos;t create them by hand.
&gt; It is used like this:
&gt; 
&gt; Tools/Scripts/prepare-ChangeLog -b ${bugzillanumber} -g
&gt; ${localgitcommitforchangelog}
&gt; 
&gt; For example, assuming you are checked out on the patch to upload and this
&gt; patch is committed locally
&gt; 
&gt; Tools/Scripts/prepare-ChangeLog -b 222959 -g HEAD
&gt; 
&gt; It will generate the changelog files, then you just edit under the reviewed
&gt; line it will appear the message of your local commit.. you edit that to tell
&gt; a bit about what the patch does. Then you add the changelogs to git and
&gt; commit them by amending the previos commit, then its ready to upload.
&gt; 
&gt; You can generate a patch and upload it here manually or you can use another
&gt; script to upload the patch directly.
&gt; 
&gt; Tools/Scripts/webkit-patch upload -g ${localgitcommittobeuploaded}
&gt; --suggest-reviewers

I think these python tools expect python to point to python2 or something like that, on my machine python points to python3, perhaps that&apos;s the issue but it does not work as expected. I manually changed the interpreter in one of these tools to call for python2 and it did lot better. 

&gt; 
&gt; It will automatically detect the bug number where the patch should be
&gt; uploaded from the changelog
&gt; 
&gt; &gt; Source/cmake/WebKitCompilerFlags.cmake:284
&gt; &gt;  if (COMPILER_IS_GCC_OR_CLANG)
&gt; &gt;      set(ATOMIC_TEST_SOURCE &quot;
&gt; &gt; -        #include &lt;atomic&gt;
&gt; &gt; -        int main() { std::atomic&lt;int64_t&gt; i(0); i++; return 0; }
&gt; &gt; +	#include &lt;atomic&gt;
&gt; &gt; +	int main() {
&gt; &gt; +          std::atomic&lt;bool&gt; y (false);
&gt; &gt; +          std::atomic&lt;uint64_t&gt; x (0);
&gt; &gt; +          bool expected = true;
&gt; &gt; +          bool j = y.compare_exchange_weak(expected,false);
&gt; &gt; +          x++;
&gt; &gt; +          return 0;
&gt; &gt; +        }
&gt; 
&gt; The Early Warning System (EWS) bot for checking the style is complaining
&gt; here about mixed spaces/tabs
&gt; 
&gt; ERROR: Source/cmake/WebKitCompilerFlags.cmake:276:  Line contains tab
&gt; character.  [whitespace/tab] [5]
&gt; ERROR: Source/cmake/WebKitCompilerFlags.cmake:277:  Line contains tab
&gt; character.  [whitespace/tab] [5]
&gt; Total errors found: 2 in 8 files
&gt; program finished with exit code 1

Fixes, my editor is as adamant as me :) usually its smart about indenting
and detects the style from sources, but in a CMakeFile embedding C++ code it
falls back to my defaults which causes these issues. 

Is there a way to run all EWS tests locally before submitting ?

&gt; 
&gt; ^^ https://ews-build.webkit.org/#/builders/6/builds/42334</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738798</commentid>
    <comment_count>20</comment_count>
    <who name="Nina Kolesová">nina</who>
    <bug_when>2021-03-12 00:58:33 -0800</bug_when>
    <thetext>(In reply to Khem Raj from comment #13)
&gt; (In reply to Daniel Kolesa from comment #12)
&gt; &gt; the test is not correct, the undefined reference was
&gt; &gt; `__atomic_compare_exchange_1` while the one you&apos;re testing is
&gt; &gt; `__atomic_fetch_add_1`
&gt; 
&gt; yes, although I saw that none of 1byte ops were not available as builtins
&gt; since the test was simple for __atomic_fetch_add_1, I went with it. but
&gt; perhaps using __atomic_compare_exchange_1 for test would be more accurate.

well, the reason i&apos;m saying this is mainly that IMO we should be testing for the functions that are actually missing from the build

gcc claims that the hardware support for less-than-4-byte-atomics is partial in risc-v, idk what it means in practice though (haven&apos;t looked into the cross-compiler output more deeply)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1738915</commentid>
    <comment_count>21</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-12 08:58:43 -0800</bug_when>
    <thetext>(In reply to Daniel Kolesa from comment #20)
&gt; (In reply to Khem Raj from comment #13)
&gt; &gt; (In reply to Daniel Kolesa from comment #12)
&gt; &gt; &gt; the test is not correct, the undefined reference was
&gt; &gt; &gt; `__atomic_compare_exchange_1` while the one you&apos;re testing is
&gt; &gt; &gt; `__atomic_fetch_add_1`
&gt; &gt; 
&gt; &gt; yes, although I saw that none of 1byte ops were not available as builtins
&gt; &gt; since the test was simple for __atomic_fetch_add_1, I went with it. but
&gt; &gt; perhaps using __atomic_compare_exchange_1 for test would be more accurate.
&gt; 
&gt; well, the reason i&apos;m saying this is mainly that IMO we should be testing for
&gt; the functions that are actually missing from the build
&gt; 
&gt; gcc claims that the hardware support for less-than-4-byte-atomics is partial
&gt; in risc-v, idk what it means in practice though (haven&apos;t looked into the
&gt; cross-compiler output more deeply)

right, I have tweaked the test to check for __atomic_compare_exchange_1 in latest patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1739803</commentid>
    <comment_count>22</comment_count>
      <attachid>422979</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-03-15 19:47:55 -0700</bug_when>
    <thetext>Comment on attachment 422979
potential fix 4

View in context: https://bugs.webkit.org/attachment.cgi?id=422979&amp;action=review

Some nitpicks with the format used for the Changelogs, commenting in-line.
Other than that I think the patch is fine.
Thanks for your patience :)

&gt; ChangeLog:4
&gt; +        Check for 1 byte atomic operations along with 64bit ones, some
&gt; +        architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free

The title used on the Changelog files should be the same title used on the bug. So this title should be:
[CMake] Build fails on RISC-V with GCC 11

The explanation &quot;Check for 1 byte atomic operations along with 64bit ones, some architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free&quot; should go under the &quot;Reviewed by ... line

&gt; ChangeLog:7
&gt; +        Reviewed by Reviewed by NOBODY (OOPS!).

This reviewed line has errors. It should be &quot;Reviewed by NOBODY (OOPS!).&quot; and not &quot; Reviewed by Reviewed by NOBODY (OOPS!).&quot;

&gt; Source/JavaScriptCore/ChangeLog:3
&gt; +        Use renamed variable ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC

Here the title should be the same than above

&gt; Source/JavaScriptCore/ChangeLog:7
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=222959
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +

Below this line is where the explanation &quot;Use renamed variable ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC&quot; should be written, but the subject (what goes above the bugzilla bug link) should be the same than the bug title.

&gt; Source/WTF/ChangeLog:3
&gt; +        Link with libatomic if ATOMICS_REQUIRE_LIBATOMIC is set.

Here the same issues: the title should be the one of the bug, and this explanation should go below the &quot;Reviewed by&quot; line

&gt; Source/WebKit/ChangeLog:3
&gt; +        Use renamed ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC.

Same issue with the title (should be the same title than the bug)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1739847</commentid>
    <comment_count>23</comment_count>
      <attachid>423303</attachid>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-15 23:03:48 -0700</bug_when>
    <thetext>Created attachment 423303
potential fix 5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1739849</commentid>
    <comment_count>24</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-03-15 23:07:04 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #22)
&gt; Comment on attachment 422979 [details]
&gt; potential fix 4
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=422979&amp;action=review
&gt; 
&gt; Some nitpicks with the format used for the Changelogs, commenting in-line.
&gt; Other than that I think the patch is fine.
&gt; Thanks for your patience :)
&gt; 
&gt; &gt; ChangeLog:4
&gt; &gt; +        Check for 1 byte atomic operations along with 64bit ones, some
&gt; &gt; +        architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free
&gt; 
&gt; The title used on the Changelog files should be the same title used on the
&gt; bug. So this title should be:
&gt; [CMake] Build fails on RISC-V with GCC 11
&gt; 
&gt; The explanation &quot;Check for 1 byte atomic operations along with 64bit ones,
&gt; some architevtures (e.g. RISCV) operations on less than 4 bytes are not
&gt; lock-free&quot; should go under the &quot;Reviewed by ... line
&gt; 
&gt; &gt; ChangeLog:7
&gt; &gt; +        Reviewed by Reviewed by NOBODY (OOPS!).
&gt; 
&gt; This reviewed line has errors. It should be &quot;Reviewed by NOBODY (OOPS!).&quot;
&gt; and not &quot; Reviewed by Reviewed by NOBODY (OOPS!).&quot;
&gt; 
&gt; &gt; Source/JavaScriptCore/ChangeLog:3
&gt; &gt; +        Use renamed variable ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC
&gt; 
&gt; Here the title should be the same than above
&gt; 
&gt; &gt; Source/JavaScriptCore/ChangeLog:7
&gt; &gt; +        https://bugs.webkit.org/show_bug.cgi?id=222959
&gt; &gt; +
&gt; &gt; +        Reviewed by NOBODY (OOPS!).
&gt; &gt; +
&gt; 
&gt; Below this line is where the explanation &quot;Use renamed variable
&gt; ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC&quot; should
&gt; be written, but the subject (what goes above the bugzilla bug link) should
&gt; be the same than the bug title.
&gt; 
&gt; &gt; Source/WTF/ChangeLog:3
&gt; &gt; +        Link with libatomic if ATOMICS_REQUIRE_LIBATOMIC is set.
&gt; 
&gt; Here the same issues: the title should be the one of the bug, and this
&gt; explanation should go below the &quot;Reviewed by&quot; line
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:3
&gt; &gt; +        Use renamed ATOMICS_REQUIRE_LIBATOMIC instead of ATOMIC_INT64_REQUIRES_LIBATOMIC.
&gt; 
&gt; Same issue with the title (should be the same title than the bug)

OK thanks for help. I have used ./Tools/./Scripts/prepare-ChangeLog
this time, but then again I had to edit it manually so hopefully its ok this time</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1739923</commentid>
    <comment_count>25</comment_count>
      <attachid>423303</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-03-16 07:19:46 -0700</bug_when>
    <thetext>Comment on attachment 423303
potential fix 5

Looks good. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1739926</commentid>
    <comment_count>26</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-03-16 07:22:57 -0700</bug_when>
    <thetext>Committed r274476: &lt;https://commits.webkit.org/r274476&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423303.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422662</attachid>
            <date>2021-03-08 21:10:31 -0800</date>
            <delta_ts>2021-03-09 14:39:42 -0800</delta_ts>
            <desc>potential fix</desc>
            <filename>webdriver-libatomic.patch</filename>
            <type>text/plain</type>
            <size>712</size>
            <attacher name="Khem Raj">raj.khem</attacher>
            
              <data encoding="base64">bGluayB3aXRoIGxpYmF0b21pYwoKVGhpcyBmaXhlcyBidWlsZCB3aXRoIEMxMQoKbGliLy4uL1Nv
dXJjZS9XVEYvd3RmL0NNYWtlRmlsZXMvV1RGLmRpci9Bc3NlcnRpb25zLmNwcC5vOi91c3IvaW5j
bHVkZS9jKysvMTEuMC4xL2JpdHMvYXRvbWljX2Jhc2UuaDo1MjA6IG1vcmUgdW5kZWZpbmVkIHJl
ZmVyZW5jZXMgdG8gYF9fYXRvbWljX2NvbXBhcmVfZXhjaGFuZ2VfMScgZm9sbG93CnwgY29sbGVj
dDI6IGVycm9yOiBsZCByZXR1cm5lZCAxIGV4aXQgc3RhdHVzCgpVcHN0cmVhbS1TdGF0dXM6IFBl
bmRpbmcKU2lnbmVkLW9mZi1ieTogS2hlbSBSYWogPHJhai5raGVtQGdtYWlsLmNvbT4KCi0tLSBh
L1NvdXJjZS9XVEYvd3RmL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XVEYvd3RmL0NNYWtl
TGlzdHMudHh0CkBAIC01MjksNiArNTI5LDEwIEBAIGxpc3QoQVBQRU5EIFdURl9MSUJSQVJJRVMK
ICAgICBJQ1U6OnVjCiApCiAKK2xpc3QoQVBQRU5EIFdURl9MSUJSQVJJRVMKKyAgICAgLVdsLC0t
YXMtbmVlZGVkIC1XbCwtbGF0b21pYyAtV2wsLS1uby1hcy1uZWVkZWQKKykKKwogc2V0KFdURl9J
TlRFUkZBQ0VfTElCUkFSSUVTIFdURikKIHNldChXVEZfSU5URVJGQUNFX0lOQ0xVREVfRElSRUNU
T1JJRVMgJHtXVEZfRlJBTUVXT1JLX0hFQURFUlNfRElSfSkKIHNldChXVEZfSU5URVJGQUNFX0RF
UEVOREVOQ0lFUyBXVEZfQ29weUhlYWRlcnMpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422760</attachid>
            <date>2021-03-09 14:39:42 -0800</date>
            <delta_ts>2021-03-10 23:09:28 -0800</delta_ts>
            <desc>potential fix</desc>
            <filename>0001-Extend-atomics-check-to-include-1-byte-CAS-test.patch</filename>
            <type>text/plain</type>
            <size>2582</size>
            <attacher name="Khem Raj">raj.khem</attacher>
            
              <data encoding="base64">RnJvbSA0MDUyMGIwZGU2OWQ4Y2E4ZTY1OTI0OGY1ZmZlNjQxZjMzY2M2ZGVlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLaGVtIFJhaiA8cmFqLmtoZW1AZ21haWwuY29tPgpEYXRlOiBU
dWUsIDkgTWFyIDIwMjEgMTQ6MTY6NTggLTA4MDAKU3ViamVjdDogW1BBVENIXSBFeHRlbmQgYXRv
bWljcyBjaGVjayB0byBpbmNsdWRlIDEtYnl0ZSBDQVMgdGVzdAoKUmVuYW1lIEFUT01JQ19JTlQ2
NF9SRVFVSVJFU19MSUJBVE9NSUMgdG8gQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQyBzbwppdCBj
YW4gcmVmbGVjdCBicm9hZGVyIHJhbmdlIHdoaWNoIGlzIG5vdyBjaGVja2VkCgpSZW5hbWUgQVRP
TUlDX0lOVDY0X0lTX0JVSUxUSU4gdG8gQVRPTUlDU19BUkVfQlVJTFRJTgoKU2lnbmVkLW9mZi1i
eTogS2hlbSBSYWogPHJhai5raGVtQGdtYWlsLmNvbT4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ01ha2VMaXN0cy50eHQgICB8ICAyICstCiBTb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0
ICAgICAgICAgICB8ICAyICstCiBTb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFr
ZSB8IDE1ICsrKysrKysrKystLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCsp
LCA3IGRlbGV0aW9ucygtKQoKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu
dHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTI5LDcg
KzEyOSw3IEBAIGlmIChVU0VfQ0FQU1RPTkUpCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENv
cmVfTElCUkFSSUVTIGNhcHN0b25lKQogZW5kaWYgKCkKIAotaWYgKEFUT01JQ19JTlQ2NF9SRVFV
SVJFU19MSUJBVE9NSUMpCitpZiAoQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQykKICAgICBsaXN0
KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVMgYXRvbWljKQogZW5kaWYgKCkKIAotLS0g
YS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXQvQ01ha2VM
aXN0cy50eHQKQEAgLTMzNyw3ICszMzcsNyBAQCBpZiAoVVNFX0xJQldFQlJUQykKICAgICBsaXN0
KEFQUEVORCBXZWJLaXRfTElCUkFSSUVTIHdlYnJ0YykKIGVuZGlmICgpCiAKLWlmIChBVE9NSUNf
SU5UNjRfUkVRVUlSRVNfTElCQVRPTUlDKQoraWYgKEFUT01JQ1NfUkVRVUlSRV9MSUJBVE9NSUMp
CiAgICAgbGlzdChBUFBFTkQgV2ViS2l0X1BSSVZBVEVfTElCUkFSSUVTIGF0b21pYykKIGVuZGlm
ICgpCiAKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdENvbXBpbGVyRmxhZ3MuY21ha2UKKysrIGIv
U291cmNlL2NtYWtlL1dlYktpdENvbXBpbGVyRmxhZ3MuY21ha2UKQEAgLTI4MCwxMiArMjgwLDE3
IEBAIGVuZGlmICgpCiBpZiAoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQogICAgIHNldChBVE9N
SUNfVEVTVF9TT1VSQ0UgIgogICAgICAgICAjaW5jbHVkZSA8YXRvbWljPgotICAgICAgICBpbnQg
bWFpbigpIHsgc3RkOjphdG9taWM8aW50NjRfdD4gaSgwKTsgaSsrOyByZXR1cm4gMDsgfQorICAg
ICAgICBpbnQgbWFpbigpIHsKKyAgICAgICAgICBzdGQ6OmF0b21pYzxpbnQ2NF90PiBpKDApOwor
ICAgICAgICAgIHN0ZDo6YXRvbWljPGludDhfdD4gaigwKTsKKyAgICAgICAgICBpKys7IGorKzsK
KyAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgfQogICAgICIpCi0gICAgY2hlY2tfY3h4X3Nv
dXJjZV9jb21waWxlcygiJHtBVE9NSUNfVEVTVF9TT1VSQ0V9IiBBVE9NSUNfSU5UNjRfSVNfQlVJ
TFRJTikKLSAgICBpZiAoTk9UIEFUT01JQ19JTlQ2NF9JU19CVUlMVElOKQorICAgIGNoZWNrX2N4
eF9zb3VyY2VfY29tcGlsZXMoIiR7QVRPTUlDX1RFU1RfU09VUkNFfSIgQVRPTUlDU19BUkVfQlVJ
TFRJTikKKyAgICBpZiAoTk9UIEFUT01JQ1NfQVJFX0JVSUxUSU4pCiAgICAgICAgIHNldChDTUFL
RV9SRVFVSVJFRF9MSUJSQVJJRVMgYXRvbWljKQotICAgICAgICBjaGVja19jeHhfc291cmNlX2Nv
bXBpbGVzKCIke0FUT01JQ19URVNUX1NPVVJDRX0iIEFUT01JQ19JTlQ2NF9SRVFVSVJFU19MSUJB
VE9NSUMpCisgICAgICAgIGNoZWNrX2N4eF9zb3VyY2VfY29tcGlsZXMoIiR7QVRPTUlDX1RFU1Rf
U09VUkNFfSIgQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQykKICAgICAgICAgdW5zZXQoQ01BS0Vf
UkVRVUlSRURfTElCUkFSSUVTKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQotLS0gYS9Tb3VyY2Uv
V1RGL3d0Zi9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3RzLnR4
dApAQCAtNTI5LDYgKzUyOSwxMCBAQCBsaXN0KEFQUEVORCBXVEZfTElCUkFSSUVTCiAgICAgSUNV
Ojp1YwogKQogCitpZiAoQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQykKKyAgICBsaXN0KEFQUEVO
RCBXVEZfTElCUkFSSUVTIGF0b21pYykKK2VuZGlmICgpCisKIHNldChXVEZfSU5URVJGQUNFX0xJ
QlJBUklFUyBXVEYpCiBzZXQoV1RGX0lOVEVSRkFDRV9JTkNMVURFX0RJUkVDVE9SSUVTICR7V1RG
X0ZSQU1FV09SS19IRUFERVJTX0RJUn0pCiBzZXQoV1RGX0lOVEVSRkFDRV9ERVBFTkRFTkNJRVMg
V1RGX0NvcHlIZWFkZXJzKQo=
</data>
<flag name="review"
          id="441989"
          type_id="1"
          status="-"
          setter="aperez"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422903</attachid>
            <date>2021-03-10 23:09:28 -0800</date>
            <delta_ts>2021-03-11 11:53:03 -0800</delta_ts>
            <desc>potential fix 2</desc>
            <filename>0001-Extend-atomics-check-to-include-1-byte-CAS-test.patch</filename>
            <type>text/plain</type>
            <size>5594</size>
            <attacher name="Khem Raj">raj.khem</attacher>
            
              <data encoding="base64">RnJvbSBiNzFiOGI4ZjhkNTdjOWM3YWU2YTRlZDVlNDJmYWRiNTUwNDY0ZTQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLaGVtIFJhaiA8cmFqLmtoZW1AZ21haWwuY29tPgpEYXRlOiBX
ZWQsIDEwIE1hciAyMDIxIDIzOjA1OjE0IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRXh0ZW5kIGF0
b21pY3MgY2hlY2sgdG8gaW5jbHVkZSAxLWJ5dGUgQ0FTIHRlc3QKClJlbmFtZSBBVE9NSUNfSU5U
NjRfUkVRVUlSRVNfTElCQVRPTUlDIHRvIEFUT01JQ1NfUkVRVUlSRV9MSUJBVE9NSUMgc28KaXQg
Y2FuIHJlZmxlY3QgYnJvYWRlciByYW5nZSB3aGljaCBpcyBub3cgY2hlY2tlZAoKUmVuYW1lIEFU
T01JQ19JTlQ2NF9JU19CVUlMVElOIHRvIEFUT01JQ1NfQVJFX0JVSUxUSU4KLS0tCiBDaGFuZ2VM
b2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDExICsrKysrKysrKysrCiBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgICB8ICAyICstCiBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nICAgICAgICB8IDEwICsrKysrKysrKysKIFNvdXJjZS9XVEYvQ2hhbmdl
TG9nICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKysrKysrKwogU291cmNlL1dURi93dGYvQ01h
a2VMaXN0cy50eHQgICAgICAgICAgfCAgNCArKysrCiBTb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMu
dHh0ICAgICAgICAgICB8ICAyICstCiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyAgICAgICAgICAg
ICAgICB8IDExICsrKysrKysrKysrCiBTb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5j
bWFrZSB8IDEzICsrKysrKysrKy0tLS0KIDggZmlsZXMgY2hhbmdlZCwgNTcgaW5zZXJ0aW9ucygr
KSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5k
ZXggYmU4ZDFjZjhlMDdhLi4yNTc1ODU1ZGYxNjIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg
Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wMy0xMCAgS2hlbSBSYWogIDxyYWou
a2hlbUBnbWFpbC5jb20+CisKKyAgICAgICAgQ2hlY2sgZm9yIDEgYnl0ZSBhdG9taWMgb3BlcmF0
aW9ucyBhbG9uZyB3aXRoIDY0Yml0IG9uZXMsIHNvbWUKKwlhcmNoaXRldnR1cmVzIChlLmcuIFJJ
U0NWKSBvcGVyYXRpb25zIG9uIGxlc3MgdGhhbiA0IGJ5dGVzIGFyZSBub3QgbG9jay1mcmVlIAor
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI5NTkK
KworICAgICAgICBSZXZpZXdlZCBieSBBZHJpYW4gUGVyZXouCisKKyAgICAgICAgKiBTb3VyY2Uv
Y21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFrZToKKwogMjAyMS0wMy0xMCAgTWljaGFlbCBD
YXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KIAogICAgICAgICBbR1RLXSBSZWVuYWJs
ZSAtZnZpc2liaWxpdHk9aGlkZGVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
Q01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5k
ZXggNWRlOTllYzY2MWM3Li5iNTVlNWRmNWFmODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VM
aXN0cy50eHQKQEAgLTEzOSw3ICsxMzksNyBAQCBpZiAoVVNFX0NBUFNUT05FKQogICAgIGxpc3Qo
QVBQRU5EIEphdmFTY3JpcHRDb3JlX0xJQlJBUklFUyBjYXBzdG9uZSkKIGVuZGlmICgpCiAKLWlm
IChBVE9NSUNfSU5UNjRfUkVRVUlSRVNfTElCQVRPTUlDKQoraWYgKEFUT01JQ1NfUkVRVUlSRV9M
SUJBVE9NSUMpCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfTElCUkFSSUVTIGF0b21p
YykKIGVuZGlmICgpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVlOWZkYWI1OGM1OS4u
MTI5NzFhY2I1NjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor
MjAyMS0wMy0xMCAgS2hlbSBSYWogIDxyYWoua2hlbUBnbWFpbC5jb20+CisKKyAgICAgICAgVXNl
IHJlbmFtZWQgdmFyaWFibGUgQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQyBpbnN0ZWFkIG9mIEFU
T01JQ19JTlQ2NF9SRVFVSVJFU19MSUJBVE9NSUMKKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyOTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRy
aWFuIFBlcmV6LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjEtMDMtMTAgIFRh
ZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQUkgdmFsaWRhdG9y
IHBhdGNocG9pbnQgc2hvdWxkIHJlYWQgaGVhcCB0b3AKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv
Q2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggOGU0YWUzOWRlYmM4Li5hYWIy
ZjRiMmIyZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X
VEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDMtMTAgIEtoZW0gUmFqICA8cmFq
LmtoZW1AZ21haWwuY29tPgorCisgICAgICAgIExpbmsgd2l0aCBsaWJhdG9taWMgaWYgQVRPTUlD
U19SRVFVSVJFX0xJQkFUT01JQyBpcyBzZXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjk1OQorCisgICAgICAgIFJldmlld2VkIGJ5IEFkcmlh
biBQZXJlei4KKworICAgICAgICAqIHd0Zi9DTWFrZUxpc3RzLnR4dDoKKwogMjAyMS0wMy0xMCAg
Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBSZXRhaW5QdHI8
PiAvIE9TT2JqZWN0UHRyPD4gbW9yZSBpbiBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv
d3RmL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQKaW5kZXgg
NDNjZGEzZWM5MWM0Li5iMzVjNzUyZDJjMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NN
YWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XVEYvd3RmL0NNYWtlTGlzdHMudHh0CkBAIC01MzEs
NiArNTMxLDEwIEBAIGlmIChOT1QgVVNFX1NZU1RFTV9NQUxMT0MpCiAgICAgc2V0KFdURl9GUkFN
RVdPUktTIGJtYWxsb2MpCiBlbmRpZiAoKQogCitpZiAoQVRPTUlDU19SRVFVSVJFX0xJQkFUT01J
QykKKyAgICBsaXN0KEFQUEVORCBXVEZfTElCUkFSSUVTIGF0b21pYykKK2VuZGlmICgpCisKIHNl
dChXVEZfSU5URVJGQUNFX0xJQlJBUklFUyBXVEYpCiBzZXQoV1RGX0lOVEVSRkFDRV9JTkNMVURF
X0RJUkVDVE9SSUVTICR7V1RGX0ZSQU1FV09SS19IRUFERVJTX0RJUn0pCiBzZXQoV1RGX0lOVEVS
RkFDRV9ERVBFTkRFTkNJRVMgV1RGX0NvcHlIZWFkZXJzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdC9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJLaXQvQ01ha2VMaXN0cy50eHQKaW5kZXgg
M2VhNzk0NjA4NDEwLi44ZWZhZjhiOGM2NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ01h
a2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dApAQCAtMzQ2LDcg
KzM0Niw3IEBAIGlmIChVU0VfTElCV0VCUlRDKQogICAgIGxpc3QoQVBQRU5EIFdlYktpdF9MSUJS
QVJJRVMgd2VicnRjKQogZW5kaWYgKCkKIAotaWYgKEFUT01JQ19JTlQ2NF9SRVFVSVJFU19MSUJB
VE9NSUMpCitpZiAoQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQykKICAgICBsaXN0KEFQUEVORCBX
ZWJLaXRfUFJJVkFURV9MSUJSQVJJRVMgYXRvbWljKQogZW5kaWYgKCkKIApkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAy
YjY3Mzk4MGYyMTguLjk1OWJjMTk3NDM0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAy
MS0wMy0xMCAgS2hlbSBSYWogIDxyYWoua2hlbUBnbWFpbC5jb20+CisKKyAgICAgICAgVXNlIHJl
bmFtZWQgQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQyBpbnN0ZWFkIG9mCisJQVRPTUlDX0lOVDY0
X1JFUVVJUkVTX0xJQkFUT01JQy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjIyOTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRyaWFuIFBlcmV6
LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjEtMDMtMTAgIFBlbmcgTGl1ICA8
cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVIFByb2Nlc3NdIEFzc2VydGlvbiB1
bmRlciBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmNvbXB1dGVDb21wb3NpdGluZ1JlcXVpcmVtZW50
cygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFrZSBi
L1NvdXJjZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNtYWtlCmluZGV4IDMxY2E1M2VkZDYz
OS4uMDM0ZmIzNDVmMmQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJG
bGFncy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFrZQpA
QCAtMjc0LDEyICsyNzQsMTcgQEAgZW5kaWYgKCkKIGlmIChDT01QSUxFUl9JU19HQ0NfT1JfQ0xB
TkcpCiAgICAgc2V0KEFUT01JQ19URVNUX1NPVVJDRSAiCiAgICAgICAgICNpbmNsdWRlIDxhdG9t
aWM+Ci0gICAgICAgIGludCBtYWluKCkgeyBzdGQ6OmF0b21pYzxpbnQ2NF90PiBpKDApOyBpKys7
IHJldHVybiAwOyB9CisgICAgICAgIGludCBtYWluKCkgeworICAgICAgICAgIHN0ZDo6YXRvbWlj
PGludDY0X3Q+IGkoMCk7CisgICAgICAgICAgc3RkOjphdG9taWM8aW50OF90PiBqKDApOworICAg
ICAgICAgIGkrKzsgaisrOworICAgICAgICAgIHJldHVybiAwOworICAgICAgICB9CiAgICAgIikK
LSAgICBjaGVja19jeHhfc291cmNlX2NvbXBpbGVzKCIke0FUT01JQ19URVNUX1NPVVJDRX0iIEFU
T01JQ19JTlQ2NF9JU19CVUlMVElOKQotICAgIGlmIChOT1QgQVRPTUlDX0lOVDY0X0lTX0JVSUxU
SU4pCisgICAgY2hlY2tfY3h4X3NvdXJjZV9jb21waWxlcygiJHtBVE9NSUNfVEVTVF9TT1VSQ0V9
IiBBVE9NSUNTX0FSRV9CVUlMVElOKQorICAgIGlmIChOT1QgQVRPTUlDU19BUkVfQlVJTFRJTikK
ICAgICAgICAgc2V0KENNQUtFX1JFUVVJUkVEX0xJQlJBUklFUyBhdG9taWMpCi0gICAgICAgIGNo
ZWNrX2N4eF9zb3VyY2VfY29tcGlsZXMoIiR7QVRPTUlDX1RFU1RfU09VUkNFfSIgQVRPTUlDX0lO
VDY0X1JFUVVJUkVTX0xJQkFUT01JQykKKyAgICAgICAgY2hlY2tfY3h4X3NvdXJjZV9jb21waWxl
cygiJHtBVE9NSUNfVEVTVF9TT1VSQ0V9IiBBVE9NSUNTX1JFUVVJUkVfTElCQVRPTUlDKQogICAg
ICAgICB1bnNldChDTUFLRV9SRVFVSVJFRF9MSUJSQVJJRVMpCiAgICAgZW5kaWYgKCkKIAotLSAK
Mi4zMC4yCgo=
</data>
<flag name="review"
          id="442135"
          type_id="1"
          status="-"
          setter="aperez"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422956</attachid>
            <date>2021-03-11 11:53:03 -0800</date>
            <delta_ts>2021-03-11 15:17:02 -0800</delta_ts>
            <desc>potential fix 3</desc>
            <filename>fix.patch</filename>
            <type>text/plain</type>
            <size>4747</size>
            <attacher name="Khem Raj">raj.khem</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZGIxODJmNjQ1OWMuLmM3
ZGVlYzZmMGM3MSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE0IEBACisyMDIxLTAzLTExICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNvbT4KKwor
ICAgICAgICBDaGVjayBmb3IgMSBieXRlIGF0b21pYyBvcGVyYXRpb25zIGFsb25nIHdpdGggNjRi
aXQgb25lcywgc29tZQorICAgICAgICBhcmNoaXRldnR1cmVzIChlLmcuIFJJU0NWKSBvcGVyYXRp
b25zIG9uIGxlc3MgdGhhbiA0IGJ5dGVzIGFyZSBub3QgbG9jay1mcmVlCisKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjk1OQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE9PUFMuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJG
bGFncy5jbWFrZToKKwogMjAyMS0wMy0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh
QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gW0dUS11bV1BFXSBCdW1wIGxpYnNv
dXAzIHZlcnNpb24gdG8gMi45OS4zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
Q01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5k
ZXggNWRlOTllYzY2MWM3Li5iNTVlNWRmNWFmODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VM
aXN0cy50eHQKQEAgLTEzOSw3ICsxMzksNyBAQCBpZiAoVVNFX0NBUFNUT05FKQogICAgIGxpc3Qo
QVBQRU5EIEphdmFTY3JpcHRDb3JlX0xJQlJBUklFUyBjYXBzdG9uZSkKIGVuZGlmICgpCiAKLWlm
IChBVE9NSUNfSU5UNjRfUkVRVUlSRVNfTElCQVRPTUlDKQoraWYgKEFUT01JQ1NfUkVRVUlSRV9M
SUJBVE9NSUMpCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfTElCUkFSSUVTIGF0b21p
YykKIGVuZGlmICgpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDcxOWY4ZDliYzg5ZC4u
ZTdlMmEyY2EyY2Q2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor
MjAyMS0wMy0xMSAgS2hlbSBSYWogIDxyYWoua2hlbUBnbWFpbC5jb20+CisKKyAgICAgICAgVXNl
IHJlbmFtZWQgdmFyaWFibGUgQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQyBpbnN0ZWFkIG9mIEFU
T01JQ19JTlQ2NF9SRVFVSVJFU19MSUJBVE9NSUMKKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyOTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgT09Q
Uy4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDIxLTAzLTExICBDb21taXQgUXVl
dWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZl
cnRpbmcgcjI3NDI2My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNl
L1dURi9DaGFuZ2VMb2cKaW5kZXggNGM4MGE3ZGUxMTFlLi43NGViMDdlYjhiYzAgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTMgQEAKKzIwMjEtMDMtMTEgIEtoZW0gUmFqICA8cmFqLmtoZW1AZ21haWwuY29tPgor
CisgICAgICAgIExpbmsgd2l0aCBsaWJhdG9taWMgaWYgQVRPTUlDU19SRVFVSVJFX0xJQkFUT01J
QyBpcyBzZXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIyMjk1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE9PUFMuCisKKyAgICAgICAgKiB3dGYv
Q01ha2VMaXN0cy50eHQ6CisKIDIwMjEtMDMtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl
LmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2UgV29ya1F1ZXVlOjpkaXNwYXRjaFN5bmMoKQpkaWZm
IC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV1RGL3d0Zi9D
TWFrZUxpc3RzLnR4dAppbmRleCA0M2NkYTNlYzkxYzQuLmIzNWM3NTJkMmMwMCAxMDA2NDQKLS0t
IGEvU291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dURi93dGYvQ01h
a2VMaXN0cy50eHQKQEAgLTUzMSw2ICs1MzEsMTAgQEAgaWYgKE5PVCBVU0VfU1lTVEVNX01BTExP
QykKICAgICBzZXQoV1RGX0ZSQU1FV09SS1MgYm1hbGxvYykKIGVuZGlmICgpCiAKK2lmIChBVE9N
SUNTX1JFUVVJUkVfTElCQVRPTUlDKQorICAgIGxpc3QoQVBQRU5EIFdURl9MSUJSQVJJRVMgYXRv
bWljKQorZW5kaWYgKCkKKwogc2V0KFdURl9JTlRFUkZBQ0VfTElCUkFSSUVTIFdURikKIHNldChX
VEZfSU5URVJGQUNFX0lOQ0xVREVfRElSRUNUT1JJRVMgJHtXVEZfRlJBTUVXT1JLX0hFQURFUlNf
RElSfSkKIHNldChXVEZfSU5URVJGQUNFX0RFUEVOREVOQ0lFUyBXVEZfQ29weUhlYWRlcnMpCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdC9D
TWFrZUxpc3RzLnR4dAppbmRleCAzZWE3OTQ2MDg0MTAuLjhlZmFmOGI4YzY0OSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0L0NNYWtl
TGlzdHMudHh0CkBAIC0zNDYsNyArMzQ2LDcgQEAgaWYgKFVTRV9MSUJXRUJSVEMpCiAgICAgbGlz
dChBUFBFTkQgV2ViS2l0X0xJQlJBUklFUyB3ZWJydGMpCiBlbmRpZiAoKQogCi1pZiAoQVRPTUlD
X0lOVDY0X1JFUVVJUkVTX0xJQkFUT01JQykKK2lmIChBVE9NSUNTX1JFUVVJUkVfTElCQVRPTUlD
KQogICAgIGxpc3QoQVBQRU5EIFdlYktpdF9QUklWQVRFX0xJQlJBUklFUyBhdG9taWMpCiBlbmRp
ZiAoKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCmluZGV4IDc4Y2U5MGFhY2MzZi4uYTEwNjNhNmZiMWQxIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE0IEBACisyMDIxLTAzLTExICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNv
bT4KKworICAgICAgICBVc2UgcmVuYW1lZCBBVE9NSUNTX1JFUVVJUkVfTElCQVRPTUlDIGluc3Rl
YWQgb2YKKyAgICAgICBBVE9NSUNfSU5UNjRfUkVRVUlSRVNfTElCQVRPTUlDLgorCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI5NTkKKworICAgICAg
ICBSZXZpZXdlZCBieSBPT1BTLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjEt
MDMtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1
Y2UgV29ya1F1ZXVlOjpkaXNwYXRjaFN5bmMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dl
YktpdENvbXBpbGVyRmxhZ3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFn
cy5jbWFrZQppbmRleCAzMWNhNTNlZGQ2MzkuLjVjM2VjODVlYWM1ZCAxMDA2NDQKLS0tIGEvU291
cmNlL2NtYWtlL1dlYktpdENvbXBpbGVyRmxhZ3MuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dl
YktpdENvbXBpbGVyRmxhZ3MuY21ha2UKQEAgLTI3MywxMyArMjczLDIwIEBAIGVuZGlmICgpCiAK
IGlmIChDT01QSUxFUl9JU19HQ0NfT1JfQ0xBTkcpCiAgICAgc2V0KEFUT01JQ19URVNUX1NPVVJD
RSAiCi0gICAgICAgICNpbmNsdWRlIDxhdG9taWM+Ci0gICAgICAgIGludCBtYWluKCkgeyBzdGQ6
OmF0b21pYzxpbnQ2NF90PiBpKDApOyBpKys7IHJldHVybiAwOyB9CisJI2luY2x1ZGUgPGF0b21p
Yz4KKwlpbnQgbWFpbigpIHsKKyAgICAgICAgICBzdGQ6OmF0b21pYzxib29sPiB5IChmYWxzZSk7
CisgICAgICAgICAgc3RkOjphdG9taWM8dWludDY0X3Q+IHggKDApOworICAgICAgICAgIGJvb2wg
ZXhwZWN0ZWQgPSB0cnVlOworICAgICAgICAgIGJvb2wgaiA9IHkuY29tcGFyZV9leGNoYW5nZV93
ZWFrKGV4cGVjdGVkLGZhbHNlKTsKKyAgICAgICAgICB4Kys7CisgICAgICAgICAgcmV0dXJuIDA7
CisgICAgICAgIH0KICAgICAiKQotICAgIGNoZWNrX2N4eF9zb3VyY2VfY29tcGlsZXMoIiR7QVRP
TUlDX1RFU1RfU09VUkNFfSIgQVRPTUlDX0lOVDY0X0lTX0JVSUxUSU4pCi0gICAgaWYgKE5PVCBB
VE9NSUNfSU5UNjRfSVNfQlVJTFRJTikKKyAgICBjaGVja19jeHhfc291cmNlX2NvbXBpbGVzKCIk
e0FUT01JQ19URVNUX1NPVVJDRX0iIEFUT01JQ1NfQVJFX0JVSUxUSU4pCisgICAgaWYgKE5PVCBB
VE9NSUNTX0FSRV9CVUlMVElOKQogICAgICAgICBzZXQoQ01BS0VfUkVRVUlSRURfTElCUkFSSUVT
IGF0b21pYykKLSAgICAgICAgY2hlY2tfY3h4X3NvdXJjZV9jb21waWxlcygiJHtBVE9NSUNfVEVT
VF9TT1VSQ0V9IiBBVE9NSUNfSU5UNjRfUkVRVUlSRVNfTElCQVRPTUlDKQorICAgICAgICBjaGVj
a19jeHhfc291cmNlX2NvbXBpbGVzKCIke0FUT01JQ19URVNUX1NPVVJDRX0iIEFUT01JQ1NfUkVR
VUlSRV9MSUJBVE9NSUMpCiAgICAgICAgIHVuc2V0KENNQUtFX1JFUVVJUkVEX0xJQlJBUklFUykK
ICAgICBlbmRpZiAoKQogCg==
</data>
<flag name="commit-queue"
          id="442205"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422979</attachid>
            <date>2021-03-11 15:17:02 -0800</date>
            <delta_ts>2021-03-15 23:03:48 -0700</delta_ts>
            <desc>potential fix 4</desc>
            <filename>0001-Enhance-atomic-check-to-include-1-byte-CAS.patch</filename>
            <type>text/plain</type>
            <size>5482</size>
            <attacher name="Khem Raj">raj.khem</attacher>
            
              <data encoding="base64">RnJvbSBkZGRhYWM4NmY5NjM2ZmZjZDE3YWNiZDY2ZjhmMzM2YWZkMzgwNzQ2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLaGVtIFJhaiA8cmFqLmtoZW1AZ21haWwuY29tPgpEYXRlOiBU
aHUsIDExIE1hciAyMDIxIDE1OjE0OjA3IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRW5oYW5jZSBh
dG9taWMgY2hlY2sgdG8gaW5jbHVkZSAxLWJ5dGUgQ0FTCgotLS0KIENoYW5nZUxvZyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRD
b3JlL0NNYWtlTGlzdHMudHh0ICAgfCAgMiArLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n
ZUxvZyAgICAgICAgfCAgOSArKysrKysrKysKIFNvdXJjZS9XVEYvQ2hhbmdlTG9nICAgICAgICAg
ICAgICAgICAgIHwgIDkgKysrKysrKysrCiBTb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3RzLnR4dCAg
ICAgICAgICB8ICA0ICsrKysKIFNvdXJjZS9XZWJLaXQvQ01ha2VMaXN0cy50eHQgICAgICAgICAg
IHwgIDIgKy0KIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgIDkgKysr
KysrKysrCiBTb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFrZSB8IDE1ICsrKysr
KysrKysrLS0tLQogOCBmaWxlcyBjaGFuZ2VkLCA1NCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u
cygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZGIxODJmNjQ1
OWMuLjVkMDRjZTY4ZGU1MyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDEzIEBACisyMDIxLTAzLTExICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNv
bT4KKworICAgICAgICBDaGVjayBmb3IgMSBieXRlIGF0b21pYyBvcGVyYXRpb25zIGFsb25nIHdp
dGggNjRiaXQgb25lcywgc29tZQorICAgICAgICBhcmNoaXRldnR1cmVzIChlLmcuIFJJU0NWKSBv
cGVyYXRpb25zIG9uIGxlc3MgdGhhbiA0IGJ5dGVzIGFyZSBub3QgbG9jay1mcmVlCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI5NTkKKworICAgICAg
ICBSZXZpZXdlZCBieSBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNv
dXJjZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNtYWtlOgorCiAyMDIxLTAzLTExICBDYXJs
b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmll
d2VkLiBbR1RLXVtXUEVdIEJ1bXAgbGlic291cDMgdmVyc2lvbiB0byAyLjk5LjMKZGlmZiAtLWdp
dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCA1ZGU5OWVjNjYxYzcuLmI1NWU1ZGY1YWY4OCAx
MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTM5LDcgKzEzOSw3IEBAIGlm
IChVU0VfQ0FQU1RPTkUpCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfTElCUkFSSUVT
IGNhcHN0b25lKQogZW5kaWYgKCkKIAotaWYgKEFUT01JQ19JTlQ2NF9SRVFVSVJFU19MSUJBVE9N
SUMpCitpZiAoQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQykKICAgICBsaXN0KEFQUEVORCBKYXZh
U2NyaXB0Q29yZV9MSUJSQVJJRVMgYXRvbWljKQogZW5kaWYgKCkKIApkaWZmIC0tZ2l0IGEvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu
Z2VMb2cKaW5kZXggNzE5ZjhkOWJjODlkLi40NGMyNzQ3YTM4MjUgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAzLTExICBLaGVtIFJhaiAgPHJhai5raGVt
QGdtYWlsLmNvbT4KKworICAgICAgICBVc2UgcmVuYW1lZCB2YXJpYWJsZSBBVE9NSUNTX1JFUVVJ
UkVfTElCQVRPTUlDIGluc3RlYWQgb2YgQVRPTUlDX0lOVDY0X1JFUVVJUkVTX0xJQkFUT01JQwor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyOTU5CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxp
c3RzLnR4dDoKKwogMjAyMS0wMy0xMSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp
dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzQyNjMuCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRj
ODBhN2RlMTExZS4uZDc2YTk0ZDljOWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxv
ZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAzLTEx
ICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNvbT4KKworICAgICAgICBMaW5rIHdpdGggbGli
YXRvbWljIGlmIEFUT01JQ1NfUkVRVUlSRV9MSUJBVE9NSUMgaXMgc2V0LgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyOTU5CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvQ01ha2VMaXN0cy50eHQ6
CisKIDIwMjEtMDMtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg
ICBJbnRyb2R1Y2UgV29ya1F1ZXVlOjpkaXNwYXRjaFN5bmMoKQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dURi93dGYvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3RzLnR4dApp
bmRleCA0M2NkYTNlYzkxYzQuLmIzNWM3NTJkMmMwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93
dGYvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQKQEAg
LTUzMSw2ICs1MzEsMTAgQEAgaWYgKE5PVCBVU0VfU1lTVEVNX01BTExPQykKICAgICBzZXQoV1RG
X0ZSQU1FV09SS1MgYm1hbGxvYykKIGVuZGlmICgpCiAKK2lmIChBVE9NSUNTX1JFUVVJUkVfTElC
QVRPTUlDKQorICAgIGxpc3QoQVBQRU5EIFdURl9MSUJSQVJJRVMgYXRvbWljKQorZW5kaWYgKCkK
Kwogc2V0KFdURl9JTlRFUkZBQ0VfTElCUkFSSUVTIFdURikKIHNldChXVEZfSU5URVJGQUNFX0lO
Q0xVREVfRElSRUNUT1JJRVMgJHtXVEZfRlJBTUVXT1JLX0hFQURFUlNfRElSfSkKIHNldChXVEZf
SU5URVJGQUNFX0RFUEVOREVOQ0lFUyBXVEZfQ29weUhlYWRlcnMpCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dApp
bmRleCAzZWE3OTQ2MDg0MTAuLjhlZmFmOGI4YzY0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp
dC9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0CkBAIC0z
NDYsNyArMzQ2LDcgQEAgaWYgKFVTRV9MSUJXRUJSVEMpCiAgICAgbGlzdChBUFBFTkQgV2ViS2l0
X0xJQlJBUklFUyB3ZWJydGMpCiBlbmRpZiAoKQogCi1pZiAoQVRPTUlDX0lOVDY0X1JFUVVJUkVT
X0xJQkFUT01JQykKK2lmIChBVE9NSUNTX1JFUVVJUkVfTElCQVRPTUlDKQogICAgIGxpc3QoQVBQ
RU5EIFdlYktpdF9QUklWQVRFX0xJQlJBUklFUyBhdG9taWMpCiBlbmRpZiAoKQogCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmlu
ZGV4IDc4Y2U5MGFhY2MzZi4uZjhlNWY2MDM4YWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBA
CisyMDIxLTAzLTExICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNvbT4KKworICAgICAgICBV
c2UgcmVuYW1lZCBBVE9NSUNTX1JFUVVJUkVfTElCQVRPTUlDIGluc3RlYWQgb2YgQVRPTUlDX0lO
VDY0X1JFUVVJUkVTX0xJQkFUT01JQy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIyMjk1OQorCisgICAgICAgIFJldmlld2VkIGJ5IFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjEtMDMt
MTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2Ug
V29ya1F1ZXVlOjpkaXNwYXRjaFN5bmMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktp
dENvbXBpbGVyRmxhZ3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5j
bWFrZQppbmRleCAzMWNhNTNlZGQ2MzkuLjQ3NWY0YjE1ZjczZiAxMDA2NDQKLS0tIGEvU291cmNl
L2NtYWtlL1dlYktpdENvbXBpbGVyRmxhZ3MuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktp
dENvbXBpbGVyRmxhZ3MuY21ha2UKQEAgLTI3NCwxMiArMjc0LDE5IEBAIGVuZGlmICgpCiBpZiAo
Q09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQogICAgIHNldChBVE9NSUNfVEVTVF9TT1VSQ0UgIgog
ICAgICAgICAjaW5jbHVkZSA8YXRvbWljPgotICAgICAgICBpbnQgbWFpbigpIHsgc3RkOjphdG9t
aWM8aW50NjRfdD4gaSgwKTsgaSsrOyByZXR1cm4gMDsgfQorICAgICAgICBpbnQgbWFpbigpIHsK
KyAgICAgICAgICBzdGQ6OmF0b21pYzxib29sPiB5IChmYWxzZSk7CisgICAgICAgICAgc3RkOjph
dG9taWM8dWludDY0X3Q+IHggKDApOworICAgICAgICAgIGJvb2wgZXhwZWN0ZWQgPSB0cnVlOwor
ICAgICAgICAgIGJvb2wgaiA9IHkuY29tcGFyZV9leGNoYW5nZV93ZWFrKGV4cGVjdGVkLGZhbHNl
KTsKKyAgICAgICAgICB4Kys7CisgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIH0KICAgICAi
KQotICAgIGNoZWNrX2N4eF9zb3VyY2VfY29tcGlsZXMoIiR7QVRPTUlDX1RFU1RfU09VUkNFfSIg
QVRPTUlDX0lOVDY0X0lTX0JVSUxUSU4pCi0gICAgaWYgKE5PVCBBVE9NSUNfSU5UNjRfSVNfQlVJ
TFRJTikKKyAgICBjaGVja19jeHhfc291cmNlX2NvbXBpbGVzKCIke0FUT01JQ19URVNUX1NPVVJD
RX0iIEFUT01JQ1NfQVJFX0JVSUxUSU4pCisgICAgaWYgKE5PVCBBVE9NSUNTX0FSRV9CVUlMVElO
KQogICAgICAgICBzZXQoQ01BS0VfUkVRVUlSRURfTElCUkFSSUVTIGF0b21pYykKLSAgICAgICAg
Y2hlY2tfY3h4X3NvdXJjZV9jb21waWxlcygiJHtBVE9NSUNfVEVTVF9TT1VSQ0V9IiBBVE9NSUNf
SU5UNjRfUkVRVUlSRVNfTElCQVRPTUlDKQorICAgICAgICBjaGVja19jeHhfc291cmNlX2NvbXBp
bGVzKCIke0FUT01JQ19URVNUX1NPVVJDRX0iIEFUT01JQ1NfUkVRVUlSRV9MSUJBVE9NSUMpCiAg
ICAgICAgIHVuc2V0KENNQUtFX1JFUVVJUkVEX0xJQlJBUklFUykKICAgICBlbmRpZiAoKQogCi0t
IAoyLjMwLjIKCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>423303</attachid>
            <date>2021-03-15 23:03:48 -0700</date>
            <delta_ts>2021-03-16 07:23:00 -0700</delta_ts>
            <desc>potential fix 5</desc>
            <filename>b.patch</filename>
            <type>text/plain</type>
            <size>5100</size>
            <attacher name="Khem Raj">raj.khem</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxMzk5NGRlMzdkZDkuLjcz
Mjk4ZDg0MTY2NyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE1IEBACisyMDIxLTAzLTE1ICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNvbT4KKwor
ICAgICAgICBbQ01ha2VdIEJ1aWxkIGZhaWxzIG9uIFJJU0MtViB3aXRoIEdDQyAxMQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyOTU5CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgZm9yIDEgYnl0
ZSBhdG9taWMgb3BlcmF0aW9ucyBhbG9uZyB3aXRoIDY0Yml0IG9uZXMsIHNvbWUKKyAgICAgICAg
YXJjaGl0ZXZ0dXJlcyAoZS5nLiBSSVNDVikgb3BlcmF0aW9ucyBvbiBsZXNzIHRoYW4gNCBieXRl
cyBhcmUgbm90IGxvY2stZnJlZQorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdENvbXBp
bGVyRmxhZ3MuY21ha2U6CisKIDIwMjEtMDMtMTQgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxp
YS5jb20+CiAKICAgICAgICAgW0dMSUJdIEtlZXAgR1BVUHJvY2VzcyBkaXNhYmxlZCB3aGVuIHVz
aW5nIGV4cGVyaW1lbnRhbCBmZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0
CmluZGV4IDVkZTk5ZWM2NjFjNy4uYjU1ZTVkZjVhZjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NN
YWtlTGlzdHMudHh0CkBAIC0xMzksNyArMTM5LDcgQEAgaWYgKFVTRV9DQVBTVE9ORSkKICAgICBs
aXN0KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVMgY2Fwc3RvbmUpCiBlbmRpZiAoKQog
Ci1pZiAoQVRPTUlDX0lOVDY0X1JFUVVJUkVTX0xJQkFUT01JQykKK2lmIChBVE9NSUNTX1JFUVVJ
UkVfTElCQVRPTUlDKQogICAgIGxpc3QoQVBQRU5EIEphdmFTY3JpcHRDb3JlX0xJQlJBUklFUyBh
dG9taWMpCiBlbmRpZiAoKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh
bmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBmODU2NTZiYzZm
ZGEuLmUxOGE3MTdmNzJhNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n
ZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg
QEAKKzIwMjEtMDMtMTUgIEtoZW0gUmFqICA8cmFqLmtoZW1AZ21haWwuY29tPgorCisgICAgICAg
IFtDTWFrZV0gQnVpbGQgZmFpbHMgb24gUklTQy1WIHdpdGggR0NDIDExCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI5NTkKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgcmVuYW1lZCB2YXJpYWJsZSBB
VE9NSUNTX1JFUVVJUkVfTElCQVRPTUlDIGluc3RlYWQgb2YgQVRPTUlDX0lOVDY0X1JFUVVJUkVT
X0xJQkFUT01JQworCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjEtMDMtMTUgIEFu
Z2Vsb3MgT2lrb25vbW9wb3Vsb3MgIDxhbmdlbG9zQGlnYWxpYS5jb20+CiAKICAgICAgICAgcG9z
dHByb2Nlc3MtYXNtL3Jlc29sdmUtYXNtLWZpbGUtY29uZmxpY3RzLnJiIGJ1aWxkIGZhaWx1cmUg
YWZ0ZXIgdXBncmFkaW5nIHRvIEYzNApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cg
Yi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCA1NjljNzE3NDE3YTMuLjg4MjUxYWIzNmQzNyAx
MDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wMy0xNSAgS2hlbSBSYWogIDxyYWoua2hlbUBnbWFp
bC5jb20+CisKKyAgICAgICAgW0NNYWtlXSBCdWlsZCBmYWlscyBvbiBSSVNDLVYgd2l0aCBHQ0Mg
MTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjk1
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExpbmsg
d2l0aCBsaWJhdG9taWMgaWYgQVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQyBpcyBzZXQuCisKKyAg
ICAgICAgKiB3dGYvQ01ha2VMaXN0cy50eHQ6CisKIDIwMjEtMDMtMTUgIEFsZXggQ2hyaXN0ZW5z
ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OOiAocjI1
NTYxMSkgWyBNYWMgXSAzIGxsZGIgdGVzdHMgZmFpbGluZyByZWxhdGVkIHRvIEhhc2hNYXAKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dURi93dGYv
Q01ha2VMaXN0cy50eHQKaW5kZXggNDNjZGEzZWM5MWM0Li5iMzVjNzUyZDJjMDAgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XVEYvd3RmL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XVEYvd3RmL0NN
YWtlTGlzdHMudHh0CkBAIC01MzEsNiArNTMxLDEwIEBAIGlmIChOT1QgVVNFX1NZU1RFTV9NQUxM
T0MpCiAgICAgc2V0KFdURl9GUkFNRVdPUktTIGJtYWxsb2MpCiBlbmRpZiAoKQogCitpZiAoQVRP
TUlDU19SRVFVSVJFX0xJQkFUT01JQykKKyAgICBsaXN0KEFQUEVORCBXVEZfTElCUkFSSUVTIGF0
b21pYykKK2VuZGlmICgpCisKIHNldChXVEZfSU5URVJGQUNFX0xJQlJBUklFUyBXVEYpCiBzZXQo
V1RGX0lOVEVSRkFDRV9JTkNMVURFX0RJUkVDVE9SSUVTICR7V1RGX0ZSQU1FV09SS19IRUFERVJT
X0RJUn0pCiBzZXQoV1RGX0lOVEVSRkFDRV9ERVBFTkRFTkNJRVMgV1RGX0NvcHlIZWFkZXJzKQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJLaXQv
Q01ha2VMaXN0cy50eHQKaW5kZXggM2VhNzk0NjA4NDEwLi44ZWZhZjhiOGM2NDkgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdC9DTWFr
ZUxpc3RzLnR4dApAQCAtMzQ2LDcgKzM0Niw3IEBAIGlmIChVU0VfTElCV0VCUlRDKQogICAgIGxp
c3QoQVBQRU5EIFdlYktpdF9MSUJSQVJJRVMgd2VicnRjKQogZW5kaWYgKCkKIAotaWYgKEFUT01J
Q19JTlQ2NF9SRVFVSVJFU19MSUJBVE9NSUMpCitpZiAoQVRPTUlDU19SRVFVSVJFX0xJQkFUT01J
QykKICAgICBsaXN0KEFQUEVORCBXZWJLaXRfUFJJVkFURV9MSUJSQVJJRVMgYXRvbWljKQogZW5k
aWYgKCkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
S2l0L0NoYW5nZUxvZwppbmRleCAzZDZjYWVmYjNmZjAuLjNhNmNhNzM2N2I3YSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNCBAQAorMjAyMS0wMy0xNSAgS2hlbSBSYWogIDxyYWoua2hlbUBnbWFpbC5j
b20+CisKKyAgICAgICAgW0NNYWtlXSBCdWlsZCBmYWlscyBvbiBSSVNDLVYgd2l0aCBHQ0MgMTEK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjk1OQor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSByZW5h
bWVkIEFUT01JQ1NfUkVRVUlSRV9MSUJBVE9NSUMgaW5zdGVhZCBvZiBBVE9NSUNfSU5UNjRfUkVR
VUlSRVNfTElCQVRPTUlDLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjEtMDMt
MTUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk
LCByZXZlcnQgcjI3MjYyOSBhcyBpdCBjYXVzZWQgcmVncmVzc2lvbnMgaW4gc29tZSBhcHBzCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFrZSBiL1NvdXJj
ZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNtYWtlCmluZGV4IDMxY2E1M2VkZDYzOS4uNDc1
ZjRiMTVmNzNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5j
bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFrZQpAQCAtMjc0
LDEyICsyNzQsMTkgQEAgZW5kaWYgKCkKIGlmIChDT01QSUxFUl9JU19HQ0NfT1JfQ0xBTkcpCiAg
ICAgc2V0KEFUT01JQ19URVNUX1NPVVJDRSAiCiAgICAgICAgICNpbmNsdWRlIDxhdG9taWM+Ci0g
ICAgICAgIGludCBtYWluKCkgeyBzdGQ6OmF0b21pYzxpbnQ2NF90PiBpKDApOyBpKys7IHJldHVy
biAwOyB9CisgICAgICAgIGludCBtYWluKCkgeworICAgICAgICAgIHN0ZDo6YXRvbWljPGJvb2w+
IHkgKGZhbHNlKTsKKyAgICAgICAgICBzdGQ6OmF0b21pYzx1aW50NjRfdD4geCAoMCk7CisgICAg
ICAgICAgYm9vbCBleHBlY3RlZCA9IHRydWU7CisgICAgICAgICAgYm9vbCBqID0geS5jb21wYXJl
X2V4Y2hhbmdlX3dlYWsoZXhwZWN0ZWQsZmFsc2UpOworICAgICAgICAgIHgrKzsKKyAgICAgICAg
ICByZXR1cm4gMDsKKyAgICAgICAgfQogICAgICIpCi0gICAgY2hlY2tfY3h4X3NvdXJjZV9jb21w
aWxlcygiJHtBVE9NSUNfVEVTVF9TT1VSQ0V9IiBBVE9NSUNfSU5UNjRfSVNfQlVJTFRJTikKLSAg
ICBpZiAoTk9UIEFUT01JQ19JTlQ2NF9JU19CVUlMVElOKQorICAgIGNoZWNrX2N4eF9zb3VyY2Vf
Y29tcGlsZXMoIiR7QVRPTUlDX1RFU1RfU09VUkNFfSIgQVRPTUlDU19BUkVfQlVJTFRJTikKKyAg
ICBpZiAoTk9UIEFUT01JQ1NfQVJFX0JVSUxUSU4pCiAgICAgICAgIHNldChDTUFLRV9SRVFVSVJF
RF9MSUJSQVJJRVMgYXRvbWljKQotICAgICAgICBjaGVja19jeHhfc291cmNlX2NvbXBpbGVzKCIk
e0FUT01JQ19URVNUX1NPVVJDRX0iIEFUT01JQ19JTlQ2NF9SRVFVSVJFU19MSUJBVE9NSUMpCisg
ICAgICAgIGNoZWNrX2N4eF9zb3VyY2VfY29tcGlsZXMoIiR7QVRPTUlDX1RFU1RfU09VUkNFfSIg
QVRPTUlDU19SRVFVSVJFX0xJQkFUT01JQykKICAgICAgICAgdW5zZXQoQ01BS0VfUkVRVUlSRURf
TElCUkFSSUVTKQogICAgIGVuZGlmICgpCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>