222946 2021-03-08 15:43:41 -0800 [webkitscmpy] Isolate dateutil imports 2021-03-09 16:33:04 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223006 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dewei_zhu ryanhaddad webkit-bug-importer oldest_to_newest 1737331 0 jbedard 2021-03-08 15:43:41 -0800 dateutil has issues installing on some platforms because it relies on pip. It's only used for unit testing anyways, so let's isolate those imports to the functions that require them. 1737332 1 webkit-bug-importer 2021-03-08 15:44:01 -0800 <rdar://problem/75191226> 1737334 2 422627 jbedard 2021-03-08 15:45:46 -0800 Created attachment 422627 Patch 1737389 3 422643 jbedard 2021-03-08 17:23:30 -0800 Created attachment 422643 Patch for landing 1737408 4 ews-feeder 2021-03-08 18:10:14 -0800 Committed r274127: <https://commits.webkit.org/r274127> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422643. 422627 2021-03-08 15:45:46 -0800 2021-03-08 17:23:23 -0800 Patch bug-222946-20210308154545.patch text/plain 2790 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDExNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAzLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NtcHldIElzb2xhdGUgZGF0ZXV0aWwgaW1wb3J0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyOTQ2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83NTE5MTIyNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3Nl dHVwLnB5OiBCdW1wIHZlcnNpb24uCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHk6IERpdHRvLgorICAgICAgICAqIFNjcmlwdHMv bGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L21vY2tzL3JlbW90ZS9zdm4ucHk6Cisg ICAgICAgIChTdm4ucmVxdWVzdCk6IElzb2xhdGUgZGF0ZXV0aWwgaW1wb3J0cy4KKwogMjAyMS0w My0wOCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIHN0cmVz cyB0ZXN0cycgJHRlc3RTcGVjaWZpY1JlcXVpcmVkT3B0aW9ucyBzaG91bGQgYmUgYXBwZW5kZWQg bGFzdC4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVw LnB5CShyZXZpc2lvbiAyNzQxMTQpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRz Y21weS9zZXR1cC5weQkod29ya2luZyBjb3B5KQpAQCAtMjksNyArMjksNyBAQCBkZWYgcmVhZG1l KCk6CiAKIHNldHVwKAogICAgIG5hbWU9J3dlYmtpdHNjbXB5JywKLSAgICB2ZXJzaW9uPScwLjEy LjQnLAorICAgIHZlcnNpb249JzAuMTIuNScsCiAgICAgZGVzY3JpcHRpb249J0xpYnJhcnkgZGVz aWduZWQgdG8gaW50ZXJhY3Qgd2l0aCBnaXQgYW5kIHN2biByZXBvc2l0b3JpZXMuJywKICAgICBs b25nX2Rlc2NyaXB0aW9uPXJlYWRtZSgpLAogICAgIGNsYXNzaWZpZXJzPVsKSW5kZXg6IFRvb2xz L1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNj bXB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAyNzQxMTQpCisrKyBUb29scy9TY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weQkod29ya2luZyBjb3B5KQpA QCAtNDYsNyArNDYsNyBAQCBleGNlcHQgSW1wb3J0RXJyb3I6CiAgICAgICAgICJQbGVhc2UgaW5z dGFsbCB3ZWJraXRjb3JlcHkgd2l0aCBgcGlwIGluc3RhbGwgd2Via2l0Y29yZXB5IC0tZXh0cmEt aW5kZXgtdXJsIDxwYWNrYWdlIGluZGV4IFVSTD5gIgogICAgICkKIAotdmVyc2lvbiA9IFZlcnNp b24oMCwgMTIsIDQpCit2ZXJzaW9uID0gVmVyc2lvbigwLCAxMiwgNSkKIAogQXV0b0luc3RhbGwu cmVnaXN0ZXIoUGFja2FnZSgnZmFzdGVuZXJzJywgVmVyc2lvbigwLCAxNSwgMCkpKQogQXV0b0lu c3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnbW9ub3RvbmljJywgVmVyc2lvbigxLCA1KSkpCkluZGV4 OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9tb2Nrcy9y ZW1vdGUvc3ZuLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtp dHNjbXB5L3dlYmtpdHNjbXB5L21vY2tzL3JlbW90ZS9zdm4ucHkJKHJldmlzaW9uIDI3NDExNCkK KysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L21vY2tz L3JlbW90ZS9zdm4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTI2LDcgKzI2LDYgQEAgaW1wb3J0IHJl CiBpbXBvcnQgeG1sdG9kaWN0CiAKIGZyb20gY29sbGVjdGlvbnMgaW1wb3J0IE9yZGVyZWREaWN0 Ci1mcm9tIGRhdGV1dGlsLnR6IGltcG9ydCB0em9mZnNldAogZnJvbSB3ZWJraXRjb3JlcHkgaW1w b3J0IG1vY2tzCiBmcm9tIHdlYmtpdHNjbXB5IGltcG9ydCBDb21taXQsIENvbnRyaWJ1dG9yLCBy ZW1vdGUgYXMgc2NtcmVtb3RlCiAKQEAgLTEzNCw2ICsxMzMsNyBAQCBjbGFzcyBTdm4obW9ja3Mu UmVxdWVzdHMpOgogCiAgICAgZGVmIHJlcXVlc3Qoc2VsZiwgbWV0aG9kLCB1cmwsIGRhdGE9Tm9u ZSwgKiprd2FyZ3MpOgogICAgICAgICBmcm9tIGRhdGV0aW1lIGltcG9ydCBkYXRldGltZQorICAg ICAgICBmcm9tIGRhdGV1dGlsLnR6IGltcG9ydCB0em9mZnNldAogCiAgICAgICAgIGlmIG5vdCB1 cmwuc3RhcnRzd2l0aCgnaHR0cDovLycpIGFuZCBub3QgdXJsLnN0YXJ0c3dpdGgoJ2h0dHBzOi8v Jyk6CiAgICAgICAgICAgICByZXR1cm4gbW9ja3MuUmVzcG9uc2UuY3JlYXRlNDA0KHVybCkK 422643 2021-03-08 17:23:30 -0800 2021-03-08 18:10:16 -0800 Patch for landing bug-222946-20210308172327.patch text/plain 3401 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NDEyNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAzLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NtcHldIElzb2xhdGUgZGF0ZXV0aWwgaW1wb3J0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyOTQ2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83NTE5MTIyNj4KKworICAgICAgICBSZXZpZXdlZCBieSBEZXdl aSBaaHUuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS9zZXR1cC5w eTogQnVtcCB2ZXJzaW9uLgorICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5OiBEaXR0by4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9tb2Nrcy9yZW1vdGUvc3ZuLnB5OgorICAgICAg ICAoU3ZuLnJlcXVlc3QpOiBJc29sYXRlIGRhdGV1dGlsIGltcG9ydHMuCisKIDIwMjEtMDMtMDgg IEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJs ZSBhY2Nlc3NpYmlsaXR5L2FyaWEtaW52YWxpZC5odG1sIHRlc3Qgb24gaU9TLgpJbmRleDogVG9v bHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHkJKHJldmlzaW9uIDI3 NDEyNSkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBAIGRlZiByZWFkbWUoKToKIAogc2V0dXAoCiAg ICAgbmFtZT0nd2Via2l0c2NtcHknLAotICAgIHZlcnNpb249JzAuMTIuNCcsCisgICAgdmVyc2lv bj0nMC4xMi41JywKICAgICBkZXNjcmlwdGlvbj0nTGlicmFyeSBkZXNpZ25lZCB0byBpbnRlcmFj dCB3aXRoIGdpdCBhbmQgc3ZuIHJlcG9zaXRvcmllcy4nLAogICAgIGxvbmdfZGVzY3JpcHRpb249 cmVhZG1lKCksCiAgICAgY2xhc3NpZmllcnM9WwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJ KHJldmlzaW9uIDI3NDEyNSkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBA IGV4Y2VwdCBJbXBvcnRFcnJvcjoKICAgICAgICAgIlBsZWFzZSBpbnN0YWxsIHdlYmtpdGNvcmVw eSB3aXRoIGBwaXAgaW5zdGFsbCB3ZWJraXRjb3JlcHkgLS1leHRyYS1pbmRleC11cmwgPHBhY2th Z2UgaW5kZXggVVJMPmAiCiAgICAgKQogCi12ZXJzaW9uID0gVmVyc2lvbigwLCAxMiwgNCkKK3Zl cnNpb24gPSBWZXJzaW9uKDAsIDEyLCA1KQogCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdl KCdmYXN0ZW5lcnMnLCBWZXJzaW9uKDAsIDE1LCAwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQ YWNrYWdlKCdtb25vdG9uaWMnLCBWZXJzaW9uKDEsIDUpKSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMv bGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L21vY2tzL3JlbW90ZS9zdm4ucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2Nt cHkvbW9ja3MvcmVtb3RlL3N2bi5weQkocmV2aXNpb24gMjc0MTI1KQorKysgVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbW9ja3MvcmVtb3RlL3N2bi5weQko d29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYsNiBAQCBpbXBvcnQgcmUKIGltcG9ydCB4bWx0b2Rp Y3QKIAogZnJvbSBjb2xsZWN0aW9ucyBpbXBvcnQgT3JkZXJlZERpY3QKLWZyb20gZGF0ZXV0aWwu dHogaW1wb3J0IHR6b2Zmc2V0CiBmcm9tIHdlYmtpdGNvcmVweSBpbXBvcnQgbW9ja3MKIGZyb20g d2Via2l0c2NtcHkgaW1wb3J0IENvbW1pdCwgQ29udHJpYnV0b3IsIHJlbW90ZSBhcyBzY21yZW1v dGUKIApAQCAtMTM0LDYgKzEzMyw3IEBAIGNsYXNzIFN2bihtb2Nrcy5SZXF1ZXN0cyk6CiAKICAg ICBkZWYgcmVxdWVzdChzZWxmLCBtZXRob2QsIHVybCwgZGF0YT1Ob25lLCAqKmt3YXJncyk6CiAg ICAgICAgIGZyb20gZGF0ZXRpbWUgaW1wb3J0IGRhdGV0aW1lCisgICAgICAgIGZyb20gZGF0ZXV0 aWwudHogaW1wb3J0IHR6b2Zmc2V0CiAKICAgICAgICAgaWYgbm90IHVybC5zdGFydHN3aXRoKCdo dHRwOi8vJykgYW5kIG5vdCB1cmwuc3RhcnRzd2l0aCgnaHR0cHM6Ly8nKToKICAgICAgICAgICAg IHJldHVybiBtb2Nrcy5SZXNwb25zZS5jcmVhdGU0MDQodXJsKQpJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9fX2luaXRfXy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtp dHB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAyNzQxMjUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03MSw2ICs3MSw2IEBAIEF1dG9JbnN0 YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3dlYmVuY29kaW4KIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ3ppcHAnLCBWZXJzaW9uKDEsIDIsIDApKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ3pvcGUuaW50ZXJmYWNlJywgVmVyc2lvbig1LCAxLCAwKSwgYWxpYXNlcz1bJ3pvcGUn XSwgcHlwaV9uYW1lPSd6b3BlLWludGVyZmFjZScpKQogCi1BdXRvSW5zdGFsbC5yZWdpc3RlcihQ YWNrYWdlKCd3ZWJraXRzY21weScsIFZlcnNpb24oMCwgMCwgMSkpLCBsb2NhbD1UcnVlKQorQXV0 b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnd2Via2l0c2NtcHknLCBWZXJzaW9uKDAsIDEyLCA1 KSksIGxvY2FsPVRydWUpCiAKIGltcG9ydCB3ZWJraXRzY21weQo=