222930 2021-03-08 12:09:25 -0800 Web Inspector: Regression (r270134) Timeline recordings 2 and beyond do not show a timescale. 2021-03-31 19:02:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1737210 0 pangle 2021-03-08 12:09:25 -0800 Steps to reproduce: 1. Inspect `webkit.org` 2. Go to the timelines tab and have Automatically stop... enabled. 3. Refresh the page to take a brief recording. 4. Refresh the page again to take a second recording. Results: The second timeline recording has an empty timescale bar (the area with time/tic marks above timeline graphs for each recording type). 1739620 1 webkit-bug-importer 2021-03-15 13:10:15 -0700 <rdar://problem/75443284> 1744933 2 424585 pangle 2021-03-29 14:52:42 -0700 Created attachment 424585 Patch v1.0 1744956 3 424585 hi 2021-03-29 15:15:41 -0700 Comment on attachment 424585 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=424585&action=review > Source/WebInspectorUI/ChangeLog:9 > + Starting with r270134, when a new `TimelineOverview` with a `TimelineRuler` is created, the order of operations > + no longer causes `WI.TimelineRuler.__prototype__.sizeDidChange` to be invoked in the initial layout of the view, Really??!? This seems like a deeper bug than just `WI.TimelineOverview` then. `sizeDidChange` should always be called for the initial layout (see bug 196901). Maybe you can explain a bit more of the "order of operations"? NIT: this should just be `.prototype.` 1744987 4 424585 pangle 2021-03-29 17:07:52 -0700 Comment on attachment 424585 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=424585&action=review >> Source/WebInspectorUI/ChangeLog:9 >> + no longer causes `WI.TimelineRuler.__prototype__.sizeDidChange` to be invoked in the initial layout of the view, > > Really??!? This seems like a deeper bug than just `WI.TimelineOverview` then. `sizeDidChange` should always be called for the initial layout (see bug 196901). Maybe you can explain a bit more of the "order of operations"? > > NIT: this should just be `.prototype.` Looked further into this: sizeDidChange **is** called, but is called at a point where the underlying DOM element is not attached anywhere, so the clientWidth reads as zero. After further digging, this issue is caused by `TimelineOverview.prototype._viewModeDidChange` which updates the layout of it's children and itself before being attached, which consumes the opportunity for sizeDidChange to be called on the actual initial layout where the TimelineRuler's element is attached to the DOM, since sizeDidChange is only invoked on the initial layout, or as the result of a resize layout (attaching a subview counts instead as a `LayoutReason.Dirty` layout). 1745012 5 424610 pangle 2021-03-29 18:56:57 -0700 Created attachment 424610 Patch v1.1 - Revised approach 1745131 6 pangle 2021-03-30 08:51:23 -0700 mac-AS-debug-wk2 test failure is historical flakey crash being addressed in bug 222277. 1745347 7 424610 hi 2021-03-30 14:56:44 -0700 Comment on attachment 424610 Patch v1.1 - Revised approach View in context: https://bugs.webkit.org/attachment.cgi?id=424610&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:856 > + if (this.isAttached) I wonder if maybe we should also/instead check `this.didInitialLayout` 🤔 Just a thought. No need to change it if you'd rather not introduce more variables :) 1745370 8 424610 pangle 2021-03-30 15:33:55 -0700 Comment on attachment 424610 Patch v1.1 - Revised approach View in context: https://bugs.webkit.org/attachment.cgi?id=424610&action=review >> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:856 >> + if (this.isAttached) > > I wonder if maybe we should also/instead check `this.didInitialLayout` 🤔 > > Just a thought. No need to change it if you'd rather not introduce more variables :) It's not a bad idea, since otherwise it is possible to attach the TimelineOverview somewhere and then change the view mode, which would force layout immediately, instead of when it is already scheduled. 1745692 9 424788 pangle 2021-03-31 11:07:50 -0700 Created attachment 424788 Patch v1.2 - Use didInitialLayout instead of isAttached 1745916 10 ews-feeder 2021-03-31 19:02:52 -0700 Committed r275337: <https://commits.webkit.org/r275337> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424788. 424585 2021-03-29 14:52:42 -0700 2021-03-29 18:56:56 -0700 Patch v1.0 bug-222930-20210329145241.patch text/plain 1951 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YWJkYjJkOGVlOWExZjEwNTMyMWNlZGZiYzM2NTkzYWY2ZDk5NDllLi5hZTNjMDYwOTlmOGQ2ZjY0 MjQzNjBjOTBiNDRjZGZlMmExOTg3ODI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wMy0yOSAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVncmVzc2lvbiAocjI3MDEzNCkgVGltZWxpbmUg cmVjb3JkaW5ncyAyIGFuZCBiZXlvbmQgZG8gbm90IHNob3cgYSB0aW1lc2NhbGUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI5MzAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdGFydGluZyB3aXRoIHIy NzAxMzQsIHdoZW4gYSBuZXcgYFRpbWVsaW5lT3ZlcnZpZXdgIHdpdGggYSBgVGltZWxpbmVSdWxl cmAgaXMgY3JlYXRlZCwgdGhlIG9yZGVyIG9mIG9wZXJhdGlvbnMKKyAgICAgICAgbm8gbG9uZ2Vy IGNhdXNlcyBgV0kuVGltZWxpbmVSdWxlci5fX3Byb3RvdHlwZV9fLnNpemVEaWRDaGFuZ2VgIHRv IGJlIGludm9rZWQgaW4gdGhlIGluaXRpYWwgbGF5b3V0IG9mIHRoZSB2aWV3LAorICAgICAgICB3 aGljaCBtZWFudCB0aGF0IHRoZSBjYWNoZWQgd2lkdGggb2YgZWZmZWN0aXZlbHkgMCB3YXMgbm90 IHVwZGF0ZWQgd2hlbiB0aGUgcnVsZXIgd2FzIGF0dGFjaGVkIHRvIGFuIGFscmVhZHkKKyAgICAg ICAgc2l6ZWQgdmlldy4gVGhpcyBpcyByZXNvbHZlZCBieSBjYWNoaW5nIHRoZSB3aWR0aCBhdCBh dHRhY2htZW50IHRpbWUgaW4gYWRkaXRpb24gdG8gb24gYHNpemVEaWRDaGFuZ2VgCisgICAgICAg IGludm9jYXRpb25zLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1 bGVyLmpzOgorICAgICAgICAoV0kuVGltZWxpbmVSdWxlci5wcm90b3R5cGUuYXR0YWNoZWQpOgor CiAyMDIxLTAzLTI4ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZW1vdmUgRU5BQkxFX0lOREVYRURfREFUQUJBU0UgJiBFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRV9J Tl9XT1JLRVJTLCBpdCBzZWVtcyBsaWtlIGl0IGlzIG9uIGZvciBhbGwgcG9ydHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVs ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGlu ZVJ1bGVyLmpzCmluZGV4IGY2Y2MwOGI3N2Y2YzkyZmYwNTBkMzkyMzIxNGQxNzFhYTY3ODM3ZGEu LmIxZjdiYTJiNDg5ZWVmMDUxNDk4NjFkZWI2ZDRlYmU4MTQ5NWViOGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVS dWxlci5qcwpAQCAtNDQwLDYgKzQ0MCwxMyBAQCBXSS5UaW1lbGluZVJ1bGVyID0gY2xhc3MgVGlt ZWxpbmVSdWxlciBleHRlbmRzIFdJLlZpZXcKIAogICAgIC8vIFByb3RlY3RlZAogCisgICAgYXR0 YWNoZWQoKQorICAgIHsKKyAgICAgICAgc3VwZXIuYXR0YWNoZWQoKTsKKworICAgICAgICB0aGlz Ll9jYWNoZWRDbGllbnRXaWR0aCA9IHRoaXMuZWxlbWVudC5jbGllbnRXaWR0aDsKKyAgICB9CisK ICAgICBsYXlvdXQoKQogICAgIHsKICAgICAgICAgbGV0IHZpc2libGVXaWR0aCA9IHRoaXMuX3Jl Y2FsY3VsYXRlKCk7Cg== 424610 2021-03-29 18:56:57 -0700 2021-03-31 11:07:49 -0700 Patch v1.1 - Revised approach bug-222930-20210329185656.patch text/plain 2495 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YWJkYjJkOGVlOWExZjEwNTMyMWNlZGZiYzM2NTkzYWY2ZDk5NDllLi5lNGU1NWVmMjljZWNiY2Yx YjQ0MGRmNzU0ZjQ1YmEzODI5MjY5Y2E0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAyMS0wMy0yOSAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVncmVzc2lvbiAocjI3MDEzNCkgVGltZWxpbmUg cmVjb3JkaW5ncyAyIGFuZCBiZXlvbmQgZG8gbm90IHNob3cgYSB0aW1lc2NhbGUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI5MzAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgbmV3IGBUaW1l bGluZU92ZXJ2aWV3YCBpcyBjcmVhdGVkLCBpdCBjYWxscyBgVGltZWxpbmVPdmVydmlldy5wcm90 b3R5cGUuX3ZpZXdNb2RlRGlkQ2hhbmdlYCBpbnNpZGUgdGhlCisgICAgICAgIGNvbnN0cnVjdG9y LCB3aGljaCBpbiB0dXJuIGNhbGxlZCBgdXBkYXRlTGF5b3V0YC4gVGhpcyB3YXMgcHJvYmxlbWF0 aWMgaW4gdGhhdCBhIGBUaW1lbGluZVJ1bGVyYCB3b3VsZCBoYXZlCisgICAgICAgIGBzaXplRGlk Q2hhbmdlYCBpbnZva2VkIGJlZm9yZSBpdCB3YXMgYXR0YWNoZWQgdG8gdGhlIERPTSwgd2hpY2gg bWVhbnQgdGhhdCB0aGVyZSB3YXMgbm8gd2lkdGggdG8gY2FjaGUuIEJlY2F1c2UKKyAgICAgICAg YHNpemVEaWRDaGFuZ2VgIGlzIG9ubHkgaW52b2tlZCBkdXJpbmcgdGhlIGZpcnN0IGxheW91dCBh bmQgb24gcmVzaXplIGV2ZW50cywgdGhlIGNhY2hlZCB3aWR0aCBpcyBub3QgdXBkYXRlZAorICAg ICAgICB3aGVuIHRoZSBydWxlciBpcyBhdHRhY2hlZCB0byB0aGUgdmlldyBoaWVyYXJjaHksIGhh dmluZyBhbHJlYWR5IHBlcmZvcm1lZCBhbiBlYXJseSBpbml0aWFsIGxheW91dC4KKworICAgICAg ICBUaGlzIHBhdGNoIG5vdyBjaGVja3MgaWYgdGhlIGBUaW1lbGluZU92ZXJ2aWV3YCBpcyBhdHRh Y2hlZCBiZWZvcmUgdXBkYXRpbmcgdGhlIGxheW91dCwgd2hpY2ggbWVhbnMgdGhhdCB0aGUKKyAg ICAgICAgaW5pdGlhbCBsYXlvdXQgb24gdGhlIGNoaWxkIGBUaW1lbGluZVJ1bGVyYCB3aWxsIGJl IGRvbmUgd2hpbGUgYXR0YWNoZWQsIHRodXMgcHJvZHVjaW5nIGEgdmFsaWQgd2lkdGggdmFsdWUg dG8KKyAgICAgICAgY2FjaGUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lT3ZlcnZpZXcuanM6CisgICAgICAgIChXSS5UaW1lbGluZVJ1bGVyLnByb3RvdHlwZS5fdmll d01vZGVEaWRDaGFuZ2UpOgorCiAyMDIxLTAzLTI4ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFX0lOREVYRURfREFUQUJBU0UgJiBFTkFCTEVf SU5ERVhFRF9EQVRBQkFTRV9JTl9XT1JLRVJTLCBpdCBzZWVtcyBsaWtlIGl0IGlzIG9uIGZvciBh bGwgcG9ydHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCmluZGV4IDk1MDQ5Y2M5NGQwZjkzMzBi MTkwZjdlMGUyOTAyNTZmZWQyMzRlOWQuLjEyNDA1NjI2MzhkOGY5MzdhZWY1YTgxOTE4ZDkyODhk ODY5MzViMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcwpAQCAtODUzLDcgKzg1Myw4IEBA IFdJLlRpbWVsaW5lT3ZlcnZpZXcgPSBjbGFzcyBUaW1lbGluZU92ZXJ2aWV3IGV4dGVuZHMgV0ku VmlldwogCiAgICAgICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3QudG9nZ2xlKCJmcmFtZXMiLCBp c1JlbmRlcmluZ0ZyYW1lc01vZGUpOwogCi0gICAgICAgIHRoaXMudXBkYXRlTGF5b3V0KFdJLlZp ZXcuTGF5b3V0UmVhc29uLlJlc2l6ZSk7CisgICAgICAgIGlmICh0aGlzLmlzQXR0YWNoZWQpCisg ICAgICAgICAgICB0aGlzLnVwZGF0ZUxheW91dChXSS5WaWV3LkxheW91dFJlYXNvbi5SZXNpemUp OwogICAgIH0KIAogICAgIF9jcmVhdGVWaWV3TW9kZVNldHRpbmdzKHZpZXdNb2RlLCBtaW5pbXVt RHVyYXRpb25QZXJQaXhlbCwgbWF4aW11bUR1cmF0aW9uUGVyUGl4ZWwsIGR1cmF0aW9uUGVyUGl4 ZWwsIHNlbGVjdGlvblN0YXJ0VmFsdWUsIHNlbGVjdGlvbkR1cmF0aW9uKQo= 424788 2021-03-31 11:07:50 -0700 2021-03-31 19:02:53 -0700 Patch v1.2 - Use didInitialLayout instead of isAttached bug-222930-20210331110749.patch text/plain 2548 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YWJkYjJkOGVlOWExZjEwNTMyMWNlZGZiYzM2NTkzYWY2ZDk5NDllLi4yMWJmMTkyZTRjYTNiOTY5 MWNiOWI1OWI0NTM4ZGNlZDg1NzA2ODAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAyMS0wMy0yOSAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVncmVzc2lvbiAocjI3MDEzNCkgVGltZWxpbmUg cmVjb3JkaW5ncyAyIGFuZCBiZXlvbmQgZG8gbm90IHNob3cgYSB0aW1lc2NhbGUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI5MzAKKworICAgICAg ICBSZXZpZXdlZCBieSBEZXZpbiBSb3Vzc28uCisKKyAgICAgICAgV2hlbiBhIG5ldyBgVGltZWxp bmVPdmVydmlld2AgaXMgY3JlYXRlZCwgaXQgY2FsbHMgYFRpbWVsaW5lT3ZlcnZpZXcucHJvdG90 eXBlLl92aWV3TW9kZURpZENoYW5nZWAgaW5zaWRlIHRoZQorICAgICAgICBjb25zdHJ1Y3Rvciwg d2hpY2ggaW4gdHVybiBjYWxsZWQgYHVwZGF0ZUxheW91dGAuIFRoaXMgd2FzIHByb2JsZW1hdGlj IGluIHRoYXQgYSBgVGltZWxpbmVSdWxlcmAgd291bGQgaGF2ZQorICAgICAgICBgc2l6ZURpZENo YW5nZWAgaW52b2tlZCBiZWZvcmUgaXQgd2FzIGF0dGFjaGVkIHRvIHRoZSBET00sIHdoaWNoIG1l YW50IHRoYXQgdGhlcmUgd2FzIG5vIHdpZHRoIHRvIGNhY2hlLiBCZWNhdXNlCisgICAgICAgIGBz aXplRGlkQ2hhbmdlYCBpcyBvbmx5IGludm9rZWQgZHVyaW5nIHRoZSBmaXJzdCBsYXlvdXQgYW5k IG9uIHJlc2l6ZSBldmVudHMsIHRoZSBjYWNoZWQgd2lkdGggaXMgbm90IHVwZGF0ZWQKKyAgICAg ICAgd2hlbiB0aGUgcnVsZXIgaXMgYXR0YWNoZWQgdG8gdGhlIHZpZXcgaGllcmFyY2h5LCBoYXZp bmcgYWxyZWFkeSBwZXJmb3JtZWQgYW4gZWFybHkgaW5pdGlhbCBsYXlvdXQuCisKKyAgICAgICAg VGhpcyBwYXRjaCBub3cgY2hlY2tzIGlmIHRoZSBgVGltZWxpbmVPdmVydmlld2AgaGFzIHBlcmZv cm1lZCBpdHMgaW5pdGlhbCBsYXlvdXQgYmVmb3JlIHVwZGF0aW5nIHRoZSBsYXlvdXQKKyAgICAg ICAgaW5zaWRlIGBfdmlld01vZGVEaWRDaGFuZ2VgLCB3aGljaCBtZWFucyB0aGF0IHRoZSBpbml0 aWFsIGxheW91dCBvbiB0aGUgY2hpbGQgYFRpbWVsaW5lUnVsZXJgIHdpbGwgYmUgZG9uZSB3aGls ZQorICAgICAgICBhdHRhY2hlZCwgdGh1cyBwcm9kdWNpbmcgYSB2YWxpZCB3aWR0aCB2YWx1ZSB0 byBjYWNoZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmll dy5qczoKKyAgICAgICAgKFdJLlRpbWVsaW5lUnVsZXIucHJvdG90eXBlLl92aWV3TW9kZURpZENo YW5nZSk6CisKIDIwMjEtMDMtMjggIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRSAmIEVOQUJMRV9JTkRFWEVEX0RB VEFCQVNFX0lOX1dPUktFUlMsIGl0IHNlZW1zIGxpa2UgaXQgaXMgb24gZm9yIGFsbCBwb3J0cwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVPdmVydmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKaW5kZXggOTUwNDljYzk0ZDBmOTMzMGIxOTBmN2UwZTI5 MDI1NmZlZDIzNGU5ZC4uODk5NmIzMjgwNjEwY2VhNzEzOWNlOTY3YWVkN2FiZmMzMzk1Y2RkNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVPdmVydmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCkBAIC04NTMsNyArODUzLDggQEAgV0kuVGltZWxp bmVPdmVydmlldyA9IGNsYXNzIFRpbWVsaW5lT3ZlcnZpZXcgZXh0ZW5kcyBXSS5WaWV3CiAKICAg ICAgICAgdGhpcy5lbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoImZyYW1lcyIsIGlzUmVuZGVyaW5n RnJhbWVzTW9kZSk7CiAKLSAgICAgICAgdGhpcy51cGRhdGVMYXlvdXQoV0kuVmlldy5MYXlvdXRS ZWFzb24uUmVzaXplKTsKKyAgICAgICAgaWYgKHRoaXMuZGlkSW5pdGlhbExheW91dCkKKyAgICAg ICAgICAgIHRoaXMudXBkYXRlTGF5b3V0KFdJLlZpZXcuTGF5b3V0UmVhc29uLlJlc2l6ZSk7CiAg ICAgfQogCiAgICAgX2NyZWF0ZVZpZXdNb2RlU2V0dGluZ3Modmlld01vZGUsIG1pbmltdW1EdXJh dGlvblBlclBpeGVsLCBtYXhpbXVtRHVyYXRpb25QZXJQaXhlbCwgZHVyYXRpb25QZXJQaXhlbCwg c2VsZWN0aW9uU3RhcnRWYWx1ZSwgc2VsZWN0aW9uRHVyYXRpb24pCg==