222925 2021-03-08 11:43:58 -0800 [Cocoa] Changes in WebInspectorUI's appearance don't propagate to .effectiveAppearance while docked 2021-03-08 14:10:12 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1737189 0 bburg 2021-03-08 11:43:58 -0800 . 1737191 1 bburg 2021-03-08 11:44:15 -0800 <rdar://71201454> 1737196 2 422594 bburg 2021-03-08 11:48:55 -0800 Created attachment 422594 Patch v1.0 1737260 3 422594 hi 2021-03-08 13:17:51 -0800 Comment on attachment 422594 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=422594&action=review r=me with one question/concern > Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm:862 > + [m_inspectorViewController webView].appearance = platformAppearance; Does this have any effect on the inspected page when Web Inspector is docked and the developer changes the Appearance setting in the General pane of the Settings Tab? 1737277 4 422594 bburg 2021-03-08 13:50:36 -0800 Comment on attachment 422594 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=422594&action=review >> Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm:862 >> + [m_inspectorViewController webView].appearance = platformAppearance; > > Does this have any effect on the inspected page when Web Inspector is docked and the developer changes the Appearance setting in the General pane of the Settings Tab? It's just for the inspector WebView (m_inspectorPage). The inspected webView will follow the appearance of the client (i.e. Safari) until set otherwise. 1737288 5 ews-feeder 2021-03-08 14:10:10 -0800 Committed r274106: <https://commits.webkit.org/r274106> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422594. 422594 2021-03-08 11:48:55 -0800 2021-03-08 14:10:11 -0800 Patch v1.0 bug-222925-20210308114855.patch text/plain 4241 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkzNjYxNzM5ZmI3MTIzYzFk NjZkZGVlYjE5ZjY0NjJjNTc4YmExZjguLjg5MzFlMTMyZWQ0NTY1YzQzMWI2Y2VmN2Q0ZjZkZTQy ZWNhZjE3YzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDMtMDggIEJKIEJ1cmcg IDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBDaGFuZ2VzIGluIFdlYkluc3Bl Y3RvclVJJ3MgYXBwZWFyYW5jZSBkb24ndCBwcm9wYWdhdGUgdG8gLmVmZmVjdGl2ZUFwcGVhcmFu Y2Ugd2hpbGUgZG9ja2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjI5MjUKKyAgICAgICAgPHJkYXI6Ly83MTIwMTQ1ND4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIGFwcGVhcmFuY2Ug cHJvcGVydHkgZm9yIHRoZSB1bmRlcmx5aW5nIHdlYlZpZXcgaW4gYWRkaXRpb24gdG8KKyAgICAg ICAgc2V0dGluZyBpdCBmb3IgdGhlIGluc3BlY3RvciBOU1dpbmRvdyAodW5kb2NrZWQgb25seSku CisKKyAgICAgICAgVGhpcyBmaXggaXMgbmVlZGVkIGZvciBib3RoIGxvY2FsIGFuZCByZW1vdGUg aW5zcGVjdG9yIGNvZGUgcGF0aHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvSW5zcGVjdG9yL21h Yy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6UmVtb3Rl V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtU2V0Rm9yY2VkQXBwZWFyYW5jZSk6CisgICAgICAg ICogVUlQcm9jZXNzL0luc3BlY3Rvci9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW06CisgICAg ICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjphcHBseUZvcmNlZEFwcGVhcmFuY2UpOgor CiAyMDIxLTAzLTA4ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSA8c2VsZWN0IG11bHRpcGxlPiBncm91cCBoZWFkZXJzIGFyZSBpbGxlZ2libGUg aW4gZGFyayBtb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0 b3IvbWFjL1JlbW90ZVdlYkluc3BlY3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvSW5zcGVjdG9yL21hYy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eU1hYy5tbQppbmRleCBl NDNiMDI4NTRjMmIyYjFjMDI2NTRkYzY0MTc3ZmYzMDIxMzk0N2M1Li4yMjM0MThkMGQ4YTk3Nzhk N2ZkN2NkODRkZGI5MDdiOWM3OWJhZGM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9JbnNwZWN0b3IvbWFjL1JlbW90ZVdlYkluc3BlY3RvclByb3h5TWFjLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9tYWMvUmVtb3RlV2ViSW5zcGVjdG9yUHJv eHlNYWMubW0KQEAgLTI0MCwyMiArMjQwLDI2IEBAIHZvaWQgUmVtb3RlV2ViSW5zcGVjdG9yUHJv eHk6OnBsYXRmb3JtU2V0U2hlZXRSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKIAogdm9pZCBS ZW1vdGVXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1TZXRGb3JjZWRBcHBlYXJhbmNlKEluc3Bl Y3RvckZyb250ZW5kQ2xpZW50OjpBcHBlYXJhbmNlIGFwcGVhcmFuY2UpCiB7Ci0gICAgTlNXaW5k b3cgKndpbmRvdyA9IG1fd2luZG93LmdldCgpOwotICAgIEFTU0VSVCh3aW5kb3cpOwotCisgICAg TlNBcHBlYXJhbmNlICpwbGF0Zm9ybUFwcGVhcmFuY2U7CiAgICAgc3dpdGNoIChhcHBlYXJhbmNl KSB7CiAgICAgY2FzZSBJbnNwZWN0b3JGcm9udGVuZENsaWVudDo6QXBwZWFyYW5jZTo6U3lzdGVt OgotICAgICAgICB3aW5kb3cuYXBwZWFyYW5jZSA9IG5pbDsKKyAgICAgICAgcGxhdGZvcm1BcHBl YXJhbmNlID0gbmlsOwogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgSW5zcGVjdG9yRnJvbnRl bmRDbGllbnQ6OkFwcGVhcmFuY2U6OkxpZ2h0OgotICAgICAgICB3aW5kb3cuYXBwZWFyYW5jZSA9 IFtOU0FwcGVhcmFuY2UgYXBwZWFyYW5jZU5hbWVkOk5TQXBwZWFyYW5jZU5hbWVBcXVhXTsKKyAg ICAgICAgcGxhdGZvcm1BcHBlYXJhbmNlID0gW05TQXBwZWFyYW5jZSBhcHBlYXJhbmNlTmFtZWQ6 TlNBcHBlYXJhbmNlTmFtZUFxdWFdOwogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgSW5zcGVj dG9yRnJvbnRlbmRDbGllbnQ6OkFwcGVhcmFuY2U6OkRhcms6Ci0gICAgICAgIHdpbmRvdy5hcHBl YXJhbmNlID0gW05TQXBwZWFyYW5jZSBhcHBlYXJhbmNlTmFtZWQ6TlNBcHBlYXJhbmNlTmFtZURh cmtBcXVhXTsKKyAgICAgICAgcGxhdGZvcm1BcHBlYXJhbmNlID0gW05TQXBwZWFyYW5jZSBhcHBl YXJhbmNlTmFtZWQ6TlNBcHBlYXJhbmNlTmFtZURhcmtBcXVhXTsKICAgICAgICAgYnJlYWs7CiAg ICAgfQorCisgICAgd2ViVmlldygpLmFwcGVhcmFuY2UgPSBwbGF0Zm9ybUFwcGVhcmFuY2U7CisK KyAgICBOU1dpbmRvdyAqd2luZG93ID0gbV93aW5kb3cuZ2V0KCk7CisgICAgQVNTRVJUKHdpbmRv dyk7CisgICAgd2luZG93LmFwcGVhcmFuY2UgPSBwbGF0Zm9ybUFwcGVhcmFuY2U7CiB9CiAKIHZv aWQgUmVtb3RlV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtU3RhcnRXaW5kb3dEcmFnKCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9tYWMvV2ViSW5zcGVj dG9yUHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dl Ykluc3BlY3RvclByb3h5TWFjLm1tCmluZGV4IDA3MmFlM2QwMzY5ZjA3M2Y1NzQyZDQ0YzAyMjk3 ODZlMmE0MzE0OWIuLjg2MmEzOWFiZDFhNWYxZjJlY2U2MjkzM2MxZTBkNzMzMjFhZmM4YzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9tYWMvV2ViSW5zcGVj dG9yUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL21h Yy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQpAQCAtODQxLDIzICs4NDEsMjUgQEAgRGVidWdnYWJs ZUluZm9EYXRhIFdlYkluc3BlY3RvclByb3h5OjppbmZvRm9yTG9jYWxEZWJ1Z2dhYmxlKCkKIAog dm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6YXBwbHlGb3JjZWRBcHBlYXJhbmNlKCkKIHsKLSAgICBO U1dpbmRvdyAqd2luZG93ID0gbV9pbnNwZWN0b3JXaW5kb3cuZ2V0KCk7Ci0gICAgaWYgKCF3aW5k b3cpCi0gICAgICAgIHJldHVybjsKLQorICAgIE5TQXBwZWFyYW5jZSAqcGxhdGZvcm1BcHBlYXJh bmNlOwogICAgIHN3aXRjaCAobV9mcm9udGVuZEFwcGVhcmFuY2UpIHsKICAgICBjYXNlIEluc3Bl Y3RvckZyb250ZW5kQ2xpZW50OjpBcHBlYXJhbmNlOjpTeXN0ZW06Ci0gICAgICAgIHdpbmRvdy5h cHBlYXJhbmNlID0gbmlsOworICAgICAgICBwbGF0Zm9ybUFwcGVhcmFuY2UgPSBuaWw7CiAgICAg ICAgIGJyZWFrOwogCiAgICAgY2FzZSBJbnNwZWN0b3JGcm9udGVuZENsaWVudDo6QXBwZWFyYW5j ZTo6TGlnaHQ6Ci0gICAgICAgIHdpbmRvdy5hcHBlYXJhbmNlID0gW05TQXBwZWFyYW5jZSBhcHBl YXJhbmNlTmFtZWQ6TlNBcHBlYXJhbmNlTmFtZUFxdWFdOworICAgICAgICBwbGF0Zm9ybUFwcGVh cmFuY2UgPSBbTlNBcHBlYXJhbmNlIGFwcGVhcmFuY2VOYW1lZDpOU0FwcGVhcmFuY2VOYW1lQXF1 YV07CiAgICAgICAgIGJyZWFrOwogCiAgICAgY2FzZSBJbnNwZWN0b3JGcm9udGVuZENsaWVudDo6 QXBwZWFyYW5jZTo6RGFyazoKLSAgICAgICAgd2luZG93LmFwcGVhcmFuY2UgPSBbTlNBcHBlYXJh bmNlIGFwcGVhcmFuY2VOYW1lZDpOU0FwcGVhcmFuY2VOYW1lRGFya0FxdWFdOworICAgICAgICBw bGF0Zm9ybUFwcGVhcmFuY2UgPSBbTlNBcHBlYXJhbmNlIGFwcGVhcmFuY2VOYW1lZDpOU0FwcGVh cmFuY2VOYW1lRGFya0FxdWFdOwogICAgICAgICBicmVhazsKICAgICB9CisKKyAgICBpZiAoTlNX aW5kb3cgKndpbmRvdyA9IG1faW5zcGVjdG9yV2luZG93LmdldCgpKQorICAgICAgICB3aW5kb3cu YXBwZWFyYW5jZSA9IHBsYXRmb3JtQXBwZWFyYW5jZTsKKworICAgIFttX2luc3BlY3RvclZpZXdD b250cm9sbGVyIHdlYlZpZXddLmFwcGVhcmFuY2UgPSBwbGF0Zm9ybUFwcGVhcmFuY2U7CiB9CiAK IH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=