222921 2021-03-08 11:01:19 -0800 Web Inspector: REGRESSION (r267038): Inspector fails to show any details about animations/transitions in the timeline 2021-03-08 15:06:35 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes pangle webkit-bug-importer oldest_to_newest 1737170 0 pangle 2021-03-08 11:01:19 -0800 <rdar://75104395> 1737268 1 422612 pangle 2021-03-08 13:31:54 -0800 Created attachment 422612 Patch v1.0 1737272 2 422612 hi 2021-03-08 13:42:03 -0800 Comment on attachment 422612 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=422612&action=review r=me > Source/WebInspectorUI/ChangeLog:13 > + The check for not being in the inactive state was particularlly problematic as it is quite common that a "particularlly" > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:-875 > - // Only update end time while not stopping, otherwise the interface contues scrolling. So just to make sure, the "otherwise the interface contues scrolling" part is no longer the case, right? When stopping we don't continue scrolling, yes? > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:-879 > - // Only update current time while active/starting or else the interface continues scrolling. ditto (:-875) > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:874 > + timelineView.endTime = endTime; > + timelineView.currentTime = this._currentTime; NIT: we normally set `startTime`, then `currentTime`, then `endTime` :P 1737278 3 422612 pangle 2021-03-08 13:53:31 -0800 Comment on attachment 422612 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=422612&action=review >> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:-875 >> - // Only update end time while not stopping, otherwise the interface contues scrolling. > > So just to make sure, the "otherwise the interface contues scrolling" part is no longer the case, right? When stopping we don't continue scrolling, yes? Correct. This patch doesn't change that behavior. We do still stop scrolling when you hit stop, and then make one final jump after all the data has come in if we needed to scroll a bit further to account for it (something that began before stopping, but finished after stopping). That logic happens above on (:481-490). >> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:874 >> + timelineView.currentTime = this._currentTime; > > NIT: we normally set `startTime`, then `currentTime`, then `endTime` :P Whoops. 1737284 4 422616 pangle 2021-03-08 14:04:24 -0800 Created attachment 422616 Patch v1.1 - Review notes 1737315 5 ews-feeder 2021-03-08 15:06:33 -0800 Committed r274112: <https://commits.webkit.org/r274112> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422616. 422612 2021-03-08 13:31:54 -0800 2021-03-08 14:04:23 -0800 Patch v1.0 bug-222921-20210308133153.patch text/plain 3991 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ZDk1MTM4OGJjMWQyYTBhYjVhZDc2M2YxYzM5MTdhYWM5NTk1MDRkLi4yNzYyNjA3ZDQ2YWQ3NzE4 MzZjODg0ZWQ5M2FhOTBlZDI0YmZjMGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAyMS0wMy0wOCAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjI2NzAzOCk6IEluc3BlY3Rv ciBmYWlscyB0byBzaG93IGFueSBkZXRhaWxzIGFib3V0IGFuaW1hdGlvbnMvdHJhbnNpdGlvbnMg aW4gdGhlIHRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjI5MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaW1lbGluZSB2aWV3cyBzaG91bGQgYWx3YXlzIGJlIHVwZGF0ZWQgd2l0aCB0aGUg dGltZSBmcm9tIHRoZSBvdmVydmlldywgYnV0IHIyNjcwMzggZXJyb25lb3VzbHkgcHJldmVudGVk IHRoZQorICAgICAgICBlbmQgdGltZSBmcm9tIGJlaW5nIHVwZGF0ZWQgd2hpbGUgcmVjb3JkaW5n IHdhcyBzdG9wcGluZyBhbmQgcHJldmVudGVkIHRoZSBjdXJyZW50IHRpbWUgZnJvbSBiZWluZyB1 cGRhdGVkIHdoaWxlCisgICAgICAgIHJlY29yZGluZyB3YXMgc3RvcHBpbmcgb3IgaW5hY3RpdmUs IHdoaWNoIG1lYW50IGFmdGVyIGEgcmVjb3JkaW5nIGZpbmlzaGVkIChTdG9wcGluZyAtPiBJbmFj dGl2ZSkgdGhlIHRpbWVsaW5lCisgICAgICAgIHZpZXdzIHdvdWxkIG5vdCBiZSB1cGRhdGVkIHdp dGggdGhlIGN1cnJlbnQgdGltZS4gQmVjYXVzZSBgX3VwZGF0ZVRpbWVsaW5lVmlld1RpbWVzYCBj YW4gYmUgY2FsbGVkIHdoZW4gYQorICAgICAgICBkaWZmZXJlbnQgY29udGVudCB2aWV3IGlzIHNl bGVjdGVkLCBpdCB3YXMgaW5jb3JyZWN0IHRvIGdhdGUgc2V0dGluZyB0aGVzZSB2YWx1ZXMgYmFz ZWQgb24gdGhlIHJlY29yZGluZyBzdGF0ZS4KKyAgICAgICAgVGhlIGNoZWNrIGZvciBub3QgYmVp bmcgaW4gdGhlIGluYWN0aXZlIHN0YXRlIHdhcyBwYXJ0aWN1bGFybGx5IHByb2JsZW1hdGljIGFz IGl0IGlzIHF1aXRlIGNvbW1vbiB0aGF0IGEKKyAgICAgICAgZGV2ZWxvcGVyIHdvdWxkIG9wZW4g YSBzcGVjaWZpYyB0aW1lbGltZSB2aWV3IGZvciB0aGUgZmlyc3QgdGltZSBhZnRlciByZWNvcmRp bmcgZmluaXNoZXMsIGF0IHdoaWNoIHBvaW50IGFsbAorICAgICAgICB2YWx1ZXMgc2hvdWxkIGJl IHBvcHVsYXRlZCByZWdhcmRsZXNzIG9mIHJlY29yZGluZyBzdGF0ZS4gVGhlIHNvdXJjZSBvZiB0 aGUgdGltZSB2YWx1ZXMgY29udGludWVzIHRvIGJlIGhhbmRsZWQKKyAgICAgICAgaW4gc3VjaCBh IHdheSBhcyB0byBwcmV2ZW50IHZhbHVlcyBmcm9tIGNvbnRpbnVvdXNseSBqdW1waW5nIGFyb3Vu ZCBhcyBhIHJlY29yZGluZyBpcyBzdG9wcGVkIGJ1dCBkYXRhIGNvbnRpbnVlcworICAgICAgICB0 byBhcnJpdmUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3Jk aW5nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRW aWV3LnByb3RvdHlwZS5fdXBkYXRlVGltZXMpOgorICAgICAgICAtIERyaXZlLWJ5IHNwZWxsaW5n IGNvcnJlY3Rpb24uCisgICAgICAgIChXSS5UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LnBy b3RvdHlwZS5fdXBkYXRlVGltZWxpbmVWaWV3VGltZXMpOgorICAgICAgICAtIFJlbW92ZSBjaGVj a3MgZm9yIHRoZSBjdXJyZW50IHJlY29yZGluZyBzdGF0ZS4KKwogMjAyMS0wMy0wNiAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICA8bW9kZWw+IHNob3Vs ZCBjcmVhdGUgYSBtb2RlbC1vd25pbmcgY29tcG9zaXRpbmcgbGF5ZXIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5n Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmluZGV4IGRlMjc4ZWMzY2MzYmM2YjE4 MjE3Y2JlMDQ4NzE2OTk4MWM5NjI3YzEuLmQwZWU5NDU5YTI4N2E3Y2RkYjczYTFjOGE0MjRiMzcz YmFlZTdlYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmll dy5qcwpAQCAtNDc5LDcgKzQ3OSw3IEBAIFdJLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcg PSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuCiAgICAgICAg IH0KIAogICAgICAgICBpZiAoV0kudGltZWxpbmVNYW5hZ2VyLmNhcHR1cmluZ1N0YXRlICE9PSBX SS5UaW1lbGluZU1hbmFnZXIuQ2FwdHVyaW5nU3RhdGUuU3RvcHBpbmcpIHsKLSAgICAgICAgICAg IC8vIE9ubHkgdXBkYXRlIGVuZCB0aW1lIHdoaWxlIG5vdCBzdG9wcGluZywgb3RoZXJ3aXNlIHRo ZSBpbnRlcmZhY2UgY29udHVlcyBzY3JvbGxpbmcuCisgICAgICAgICAgICAvLyBPbmx5IHVwZGF0 ZSBlbmQgdGltZSB3aGlsZSBub3Qgc3RvcHBpbmcsIG90aGVyd2lzZSB0aGUgaW50ZXJmYWNlIGNv bnRpbnVlcyBzY3JvbGxpbmcuCiAgICAgICAgICAgICB0aGlzLl90aW1lbGluZU92ZXJ2aWV3LmVu ZFRpbWUgPSBNYXRoLm1heChlbmRUaW1lLCBjdXJyZW50VGltZSk7CiAKICAgICAgICAgICAgIGlm IChXSS50aW1lbGluZU1hbmFnZXIuY2FwdHVyaW5nU3RhdGUgIT09IFdJLlRpbWVsaW5lTWFuYWdl ci5DYXB0dXJpbmdTdGF0ZS5JbmFjdGl2ZSkgewpAQCAtODcwLDE2ICs4NzAsOCBAQCBXSS5UaW1l bGluZVJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdDb250ZW50 VmlldyBleHRlbmRzIFdJLgogICAgICAgICB9CiAKICAgICAgICAgdGltZWxpbmVWaWV3LnN0YXJ0 VGltZSA9IHRoaXMuX3RpbWVsaW5lT3ZlcnZpZXcuc2VsZWN0aW9uU3RhcnRUaW1lOwotCi0gICAg ICAgIGlmIChXSS50aW1lbGluZU1hbmFnZXIuY2FwdHVyaW5nU3RhdGUgIT09IFdJLlRpbWVsaW5l TWFuYWdlci5DYXB0dXJpbmdTdGF0ZS5TdG9wcGluZykgewotICAgICAgICAgICAgLy8gT25seSB1 cGRhdGUgZW5kIHRpbWUgd2hpbGUgbm90IHN0b3BwaW5nLCBvdGhlcndpc2UgdGhlIGludGVyZmFj ZSBjb250dWVzIHNjcm9sbGluZy4KLSAgICAgICAgICAgIHRpbWVsaW5lVmlldy5lbmRUaW1lID0g ZW5kVGltZTsKLQotICAgICAgICAgICAgaWYgKFdJLnRpbWVsaW5lTWFuYWdlci5jYXB0dXJpbmdT dGF0ZSAhPT0gV0kuVGltZWxpbmVNYW5hZ2VyLkNhcHR1cmluZ1N0YXRlLkluYWN0aXZlKSB7Ci0g ICAgICAgICAgICAgICAgLy8gT25seSB1cGRhdGUgY3VycmVudCB0aW1lIHdoaWxlIGFjdGl2ZS9z dGFydGluZyBvciBlbHNlIHRoZSBpbnRlcmZhY2UgY29udGludWVzIHNjcm9sbGluZy4KLSAgICAg ICAgICAgICAgICB0aW1lbGluZVZpZXcuY3VycmVudFRpbWUgPSB0aGlzLl9jdXJyZW50VGltZTsK LSAgICAgICAgICAgIH0KLSAgICAgICAgfQorICAgICAgICB0aW1lbGluZVZpZXcuZW5kVGltZSA9 IGVuZFRpbWU7CisgICAgICAgIHRpbWVsaW5lVmlldy5jdXJyZW50VGltZSA9IHRoaXMuX2N1cnJl bnRUaW1lOwogICAgIH0KIAogICAgIF9lZGl0aW5nSW5zdHJ1bWVudHNEaWRDaGFuZ2UoZXZlbnQp Cg== 422616 2021-03-08 14:04:24 -0800 2021-03-08 15:06:34 -0800 Patch v1.1 - Review notes bug-222921-20210308140424.patch text/plain 3988 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ZDk1MTM4OGJjMWQyYTBhYjVhZDc2M2YxYzM5MTdhYWM5NTk1MDRkLi5kY2NjMDI3YTFkMGRlZjRi YWVjYThlOTAxODI4YTkzNzA1NGQ2YjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAyMS0wMy0wOCAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjI2NzAzOCk6IEluc3BlY3Rv ciBmYWlscyB0byBzaG93IGFueSBkZXRhaWxzIGFib3V0IGFuaW1hdGlvbnMvdHJhbnNpdGlvbnMg aW4gdGhlIHRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjI5MjEKKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBSb3Vzc28uCisKKyAg ICAgICAgVGltZWxpbmUgdmlld3Mgc2hvdWxkIGFsd2F5cyBiZSB1cGRhdGVkIHdpdGggdGhlIHRp bWUgZnJvbSB0aGUgb3ZlcnZpZXcsIGJ1dCByMjY3MDM4IGVycm9uZW91c2x5IHByZXZlbnRlZCB0 aGUKKyAgICAgICAgZW5kIHRpbWUgZnJvbSBiZWluZyB1cGRhdGVkIHdoaWxlIHJlY29yZGluZyB3 YXMgc3RvcHBpbmcgYW5kIHByZXZlbnRlZCB0aGUgY3VycmVudCB0aW1lIGZyb20gYmVpbmcgdXBk YXRlZCB3aGlsZQorICAgICAgICByZWNvcmRpbmcgd2FzIHN0b3BwaW5nIG9yIGluYWN0aXZlLCB3 aGljaCBtZWFudCBhZnRlciBhIHJlY29yZGluZyBmaW5pc2hlZCAoU3RvcHBpbmcgLT4gSW5hY3Rp dmUpIHRoZSB0aW1lbGluZQorICAgICAgICB2aWV3cyB3b3VsZCBub3QgYmUgdXBkYXRlZCB3aXRo IHRoZSBjdXJyZW50IHRpbWUuIEJlY2F1c2UgYF91cGRhdGVUaW1lbGluZVZpZXdUaW1lc2AgY2Fu IGJlIGNhbGxlZCB3aGVuIGEKKyAgICAgICAgZGlmZmVyZW50IGNvbnRlbnQgdmlldyBpcyBzZWxl Y3RlZCwgaXQgd2FzIGluY29ycmVjdCB0byBnYXRlIHNldHRpbmcgdGhlc2UgdmFsdWVzIGJhc2Vk IG9uIHRoZSByZWNvcmRpbmcgc3RhdGUuCisgICAgICAgIFRoZSBjaGVjayBmb3Igbm90IGJlaW5n IGluIHRoZSBpbmFjdGl2ZSBzdGF0ZSB3YXMgcGFydGljdWxhcmx5IHByb2JsZW1hdGljIGFzIGl0 IGlzIHF1aXRlIGNvbW1vbiB0aGF0IGEKKyAgICAgICAgZGV2ZWxvcGVyIHdvdWxkIG9wZW4gYSBz cGVjaWZpYyB0aW1lbGltZSB2aWV3IGZvciB0aGUgZmlyc3QgdGltZSBhZnRlciByZWNvcmRpbmcg ZmluaXNoZXMsIGF0IHdoaWNoIHBvaW50IGFsbAorICAgICAgICB2YWx1ZXMgc2hvdWxkIGJlIHBv cHVsYXRlZCByZWdhcmRsZXNzIG9mIHJlY29yZGluZyBzdGF0ZS4gVGhlIHNvdXJjZSBvZiB0aGUg dGltZSB2YWx1ZXMgY29udGludWVzIHRvIGJlIGhhbmRsZWQKKyAgICAgICAgaW4gc3VjaCBhIHdh eSBhcyB0byBwcmV2ZW50IHZhbHVlcyBmcm9tIGNvbnRpbnVvdXNseSBqdW1waW5nIGFyb3VuZCBh cyBhIHJlY29yZGluZyBpcyBzdG9wcGVkIGJ1dCBkYXRhIGNvbnRpbnVlcworICAgICAgICB0byBh cnJpdmUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5n Q29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3 LnByb3RvdHlwZS5fdXBkYXRlVGltZXMpOgorICAgICAgICAtIERyaXZlLWJ5IHNwZWxsaW5nIGNv cnJlY3Rpb24uCisgICAgICAgIChXSS5UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LnByb3Rv dHlwZS5fdXBkYXRlVGltZWxpbmVWaWV3VGltZXMpOgorICAgICAgICAtIFJlbW92ZSBjaGVja3Mg Zm9yIHRoZSBjdXJyZW50IHJlY29yZGluZyBzdGF0ZS4KKwogMjAyMS0wMy0wNiAgVGltIEhvcnRv biAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICA8bW9kZWw+IHNob3VsZCBj cmVhdGUgYSBtb2RlbC1vd25pbmcgY29tcG9zaXRpbmcgbGF5ZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29u dGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9U aW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmluZGV4IGRlMjc4ZWMzY2MzYmM2YjE4MjE3 Y2JlMDQ4NzE2OTk4MWM5NjI3YzEuLjRiN2YwNTQzZGI1NjIzZTBmMmNjNGFhMGEzYWNmYzAzNGY0 Yzc0MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5q cwpAQCAtNDc5LDcgKzQ3OSw3IEBAIFdJLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgPSBj bGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuCiAgICAgICAgIH0K IAogICAgICAgICBpZiAoV0kudGltZWxpbmVNYW5hZ2VyLmNhcHR1cmluZ1N0YXRlICE9PSBXSS5U aW1lbGluZU1hbmFnZXIuQ2FwdHVyaW5nU3RhdGUuU3RvcHBpbmcpIHsKLSAgICAgICAgICAgIC8v IE9ubHkgdXBkYXRlIGVuZCB0aW1lIHdoaWxlIG5vdCBzdG9wcGluZywgb3RoZXJ3aXNlIHRoZSBp bnRlcmZhY2UgY29udHVlcyBzY3JvbGxpbmcuCisgICAgICAgICAgICAvLyBPbmx5IHVwZGF0ZSBl bmQgdGltZSB3aGlsZSBub3Qgc3RvcHBpbmcsIG90aGVyd2lzZSB0aGUgaW50ZXJmYWNlIGNvbnRp bnVlcyBzY3JvbGxpbmcuCiAgICAgICAgICAgICB0aGlzLl90aW1lbGluZU92ZXJ2aWV3LmVuZFRp bWUgPSBNYXRoLm1heChlbmRUaW1lLCBjdXJyZW50VGltZSk7CiAKICAgICAgICAgICAgIGlmIChX SS50aW1lbGluZU1hbmFnZXIuY2FwdHVyaW5nU3RhdGUgIT09IFdJLlRpbWVsaW5lTWFuYWdlci5D YXB0dXJpbmdTdGF0ZS5JbmFjdGl2ZSkgewpAQCAtODcwLDE2ICs4NzAsOCBAQCBXSS5UaW1lbGlu ZVJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmll dyBleHRlbmRzIFdJLgogICAgICAgICB9CiAKICAgICAgICAgdGltZWxpbmVWaWV3LnN0YXJ0VGlt ZSA9IHRoaXMuX3RpbWVsaW5lT3ZlcnZpZXcuc2VsZWN0aW9uU3RhcnRUaW1lOwotCi0gICAgICAg IGlmIChXSS50aW1lbGluZU1hbmFnZXIuY2FwdHVyaW5nU3RhdGUgIT09IFdJLlRpbWVsaW5lTWFu YWdlci5DYXB0dXJpbmdTdGF0ZS5TdG9wcGluZykgewotICAgICAgICAgICAgLy8gT25seSB1cGRh dGUgZW5kIHRpbWUgd2hpbGUgbm90IHN0b3BwaW5nLCBvdGhlcndpc2UgdGhlIGludGVyZmFjZSBj b250dWVzIHNjcm9sbGluZy4KLSAgICAgICAgICAgIHRpbWVsaW5lVmlldy5lbmRUaW1lID0gZW5k VGltZTsKLQotICAgICAgICAgICAgaWYgKFdJLnRpbWVsaW5lTWFuYWdlci5jYXB0dXJpbmdTdGF0 ZSAhPT0gV0kuVGltZWxpbmVNYW5hZ2VyLkNhcHR1cmluZ1N0YXRlLkluYWN0aXZlKSB7Ci0gICAg ICAgICAgICAgICAgLy8gT25seSB1cGRhdGUgY3VycmVudCB0aW1lIHdoaWxlIGFjdGl2ZS9zdGFy dGluZyBvciBlbHNlIHRoZSBpbnRlcmZhY2UgY29udGludWVzIHNjcm9sbGluZy4KLSAgICAgICAg ICAgICAgICB0aW1lbGluZVZpZXcuY3VycmVudFRpbWUgPSB0aGlzLl9jdXJyZW50VGltZTsKLSAg ICAgICAgICAgIH0KLSAgICAgICAgfQorICAgICAgICB0aW1lbGluZVZpZXcuY3VycmVudFRpbWUg PSB0aGlzLl9jdXJyZW50VGltZTsKKyAgICAgICAgdGltZWxpbmVWaWV3LmVuZFRpbWUgPSBlbmRU aW1lOwogICAgIH0KIAogICAgIF9lZGl0aW5nSW5zdHJ1bWVudHNEaWRDaGFuZ2UoZXZlbnQpCg==