222913 2021-03-08 08:33:47 -0800 Web Inspector: CSS Grid Inspector clean-up 2021-03-10 12:36:37 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 rcaliman rcaliman bburg ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1737096 0 rcaliman 2021-03-08 08:33:47 -0800 Remove helpers added early on that are not necessary anymore. 1737097 1 webkit-bug-importer 2021-03-08 08:34:15 -0800 <rdar://problem/75171301> 1737100 2 422572 rcaliman 2021-03-08 08:42:56 -0800 Created attachment 422572 Patch 1738159 3 422572 bburg 2021-03-10 12:04:50 -0800 Comment on attachment 422572 Patch r=me 1738176 4 ews-feeder 2021-03-10 12:36:35 -0800 Committed r274229: <https://commits.webkit.org/r274229> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422572. 422572 2021-03-08 08:42:56 -0800 2021-03-10 12:36:36 -0800 Patch bug-222913-20210308174254.patch text/plain 4248 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRkOTUxMzg4YmMxZDJhMGFiNWFkNzYzZjFjMzkx N2FhYzk1OTUwNGQuLjdkZTgzNWQ1MGZkYTFhZDEzZWVkYmYxM2Q2MWYzOWJkZDUwMGU1ZjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTA4ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBDU1MgR3JpZCBJbnNwZWN0b3IgY2xlYW4tdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjkxMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzUx NzEzMDE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIG9ic29sZXRlIG1ldGhvZHMgdG8gc2hvdy9oaWRlIHRoZSBncmlkIG92ZXJsYXkgZGly ZWN0bHkgZnJvbSBhIERPTU5vZGUuCisgICAgICAgIFJlbW92ZSBlbmdpbmVlcmluZy1vbmx5IGNv bnRleHQgbWVudSBoZWxwZXJzIHVzZWQgd2hpbGUgaW1wbGVtZW50aW5nIGdyaWQgb3ZlcmxheXMu CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzOgorICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvQ29udGV4dE1lbnVVdGlsaXRpZXMuanM6CisKIDIwMjEtMDMt MDYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgPG1v ZGVsPiBzaG91bGQgY3JlYXRlIGEgbW9kZWwtb3duaW5nIGNvbXBvc2l0aW5nIGxheWVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9k ZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2Rl LmpzCmluZGV4IDk0MTZkZGZhNjQzMjJjNWFmNzliNDcxMGU1Yjg1MThmYTIzNDg2NmEuLjAyNTQ1 Y2RiODhkOThiZjc2NTc5MWZjM2ZlNGRiOTE1ZDg1NTgwYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzCkBAIC01NzQs MzQgKzU3NCw2IEBAIFdJLkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVuZHMgV0kuT2JqZWN0 CiAgICAgICAgIHRhcmdldC5ET01BZ2VudC5oaWdobGlnaHROb2RlKFdJLkRPTU1hbmFnZXIuYnVp bGRIaWdobGlnaHRDb25maWcobW9kZSksIHRoaXMuaWQpOwogICAgIH0KIAotICAgIHNob3dHcmlk T3ZlcmxheShjb2xvciwge3Nob3dMaW5lTmFtZXMsIHNob3dMaW5lTnVtYmVycywgc2hvd0V4dGVu ZGVkR3JpZExpbmVzLCBzaG93VHJhY2tTaXplcywgc2hvd0FyZWFOYW1lc30gPSB7fSkKLSAgICB7 Ci0gICAgICAgIGNvbnNvbGUuYXNzZXJ0KGNvbG9yIGluc3RhbmNlb2YgV0kuQ29sb3IsIGNvbG9y KTsKLQotICAgICAgICBpZiAodGhpcy5fZGVzdHJveWVkKQotICAgICAgICAgICAgcmV0dXJuIFBy b21pc2UucmVqZWN0KCJDYW5ub3Qgc2hvdyBvdmVybGF5LCBub2RlIGlzIGRlc3Ryb3llZCIpOwot Ci0gICAgICAgIGxldCB0YXJnZXQgPSBXSS5hc3N1bWluZ01haW5UYXJnZXQoKTsKLSAgICAgICAg cmV0dXJuIHRhcmdldC5ET01BZ2VudC5zaG93R3JpZE92ZXJsYXkuaW52b2tlKHsKLSAgICAgICAg ICAgIG5vZGVJZDogdGhpcy5pZCwKLSAgICAgICAgICAgIGdyaWRDb2xvcjogY29sb3IudG9Qcm90 b2NvbCgpLAotICAgICAgICAgICAgc2hvd0xpbmVOYW1lczogISFzaG93TGluZU5hbWVzLAotICAg ICAgICAgICAgc2hvd0xpbmVOdW1iZXJzOiAhIXNob3dMaW5lTnVtYmVycywKLSAgICAgICAgICAg IHNob3dFeHRlbmRlZEdyaWRMaW5lczogISFzaG93RXh0ZW5kZWRHcmlkTGluZXMsCi0gICAgICAg ICAgICBzaG93VHJhY2tTaXplczogISFzaG93VHJhY2tTaXplcywKLSAgICAgICAgICAgIHNob3dB cmVhTmFtZXM6ICEhc2hvd0FyZWFOYW1lcywKLSAgICAgICAgfSk7Ci0gICAgfQotCi0gICAgaGlk ZUdyaWRPdmVybGF5KCkKLSAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9kZXN0cm95ZWQpCi0gICAg ICAgICAgICByZXR1cm4gUHJvbWlzZS5yZWplY3QoIkNhbm5vdCBoaWRlIG92ZXJsYXksIG5vZGUg aXMgZGVzdHJveWVkIik7Ci0KLSAgICAgICAgbGV0IHRhcmdldCA9IFdJLmFzc3VtaW5nTWFpblRh cmdldCgpOwotICAgICAgICByZXR1cm4gdGFyZ2V0LkRPTUFnZW50LmhpZGVHcmlkT3ZlcmxheSh0 aGlzLmlkKTsKLSAgICB9Ci0KICAgICBzY3JvbGxJbnRvVmlldygpCiAgICAgewogICAgICAgICBX SS5SZW1vdGVPYmplY3QucmVzb2x2ZU5vZGUodGhpcykudGhlbigob2JqZWN0KSA9PiB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0 TWVudVV0aWxpdGllcy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NvbnRleHRNZW51VXRpbGl0aWVzLmpzCmluZGV4IDViYTY5YWJlZTJiZjgxMDBhYWJmZDA5 ZGFjMTMxZmEyNDU3N2FlNjYuLjMwNjJjMTJmMDA2MDM3MmViMDA5NTNhYjM1ZWQzYzIwZjRkYzhm MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NvbnRleHRNZW51VXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbnRleHRNZW51VXRpbGl0aWVzLmpzCkBAIC0zODYsMjggKzM4Niw2 IEBAIFdJLmFwcGVuZENvbnRleHRNZW51SXRlbXNGb3JET01Ob2RlID0gZnVuY3Rpb24oY29udGV4 dE1lbnUsIGRvbU5vZGUsIG9wdGlvbnMgPSB7CiAgICAgICAgIH0KIAogICAgICAgICBjb250ZXh0 TWVudS5hcHBlbmRTZXBhcmF0b3IoKTsKLQotICAgICAgICAvLyBGSVhNRTogPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzIyMTI0Nj4gcmVtb3ZlIHRoZXNlIGVuZ2luZWVyaW5nLW9ubHkgbWVudSBpdGVt cyB3aGVuIHJlbW92aW5nIHRoZSBmZWF0dXJlIGZsYWcuCi0gICAgICAgIGlmIChXSS5pc0VuZ2lu ZWVyaW5nQnVpbGQgJiYgV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlTGF5b3V0UGFuZWwu dmFsdWUpIHsKLSAgICAgICAgICAgIGlmIChJbnNwZWN0b3JCYWNrZW5kLmhhc0NvbW1hbmQoIkRP TS5zaG93R3JpZE92ZXJsYXkiKSAmJiBhdHRhY2hlZCkgewotICAgICAgICAgICAgICAgIGNvbnRl eHRNZW51LmFwcGVuZEl0ZW0oV0kudW5sb2NhbGl6ZWRTdHJpbmcoIkFkZCBHcmlkIE92ZXJsYXkg d2l0aCBSYW5kb20gQ29sb3IiKSwgKCkgPT4gewotICAgICAgICAgICAgICAgICAgICBsZXQgcmFu ZG9tQ29tcG9uZW50ID0gKCkgPT4gTWF0aC5mbG9vcihNYXRoLnJhbmRvbSgpICogMjU1KTsKLSAg ICAgICAgICAgICAgICAgICAgbGV0IGNvbG9yID0gbmV3IFdJLkNvbG9yKFdJLkNvbG9yLkZvcm1h dC5SR0IsIFtyYW5kb21Db21wb25lbnQoKSwgcmFuZG9tQ29tcG9uZW50KCksIHJhbmRvbUNvbXBv bmVudCgpXSk7Ci0gICAgICAgICAgICAgICAgICAgIGRvbU5vZGUuc2hvd0dyaWRPdmVybGF5KGNv bG9yKS5jYXRjaChjb25zb2xlLmVycm9yKTsKLSAgICAgICAgICAgICAgICB9KTsKLQotICAgICAg ICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV0kudW5sb2NhbGl6ZWRTdHJpbmcoIlJl bW92ZSBHcmlkIE92ZXJsYXkgZm9yIHRoaXMgTm9kZSIpLCAoKSA9PiB7Ci0gICAgICAgICAgICAg ICAgICAgIGRvbU5vZGUuaGlkZUdyaWRPdmVybGF5KCk7Ci0gICAgICAgICAgICAgICAgfSk7Ci0K LSAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdJLnVubG9jYWxpemVkU3Ry aW5nKCJSZW1vdmUgQWxsIEdyaWQgT3ZlcmxheXMiKSwgKCkgPT4gewotICAgICAgICAgICAgICAg ICAgICBsZXQgdGFyZ2V0ID0gV0kuYXNzdW1pbmdNYWluVGFyZ2V0KCk7Ci0gICAgICAgICAgICAg ICAgICAgIHRhcmdldC5ET01BZ2VudC5oaWRlR3JpZE92ZXJsYXkoKTsKLSAgICAgICAgICAgICAg ICB9KTsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQotCi0gICAgICAgIGNvbnRleHRNZW51LmFw cGVuZFNlcGFyYXRvcigpOwogICAgIH0KIH07CiAK