222905 2021-03-08 06:35:42 -0800 REGRESSION(r273084): User agent quirks still needed after all 2021-03-08 08:09:05 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 222910 222039 1 commit-queue commit-queue cgarcia mcatanzaro webkit-bug-importer oldest_to_newest 1737051 0 commit-queue 2021-03-08 06:35:42 -0800 https://trac.webkit.org/changeset/273084 broke the build: User agent quirks still needed after all This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1737053 1 422561 commit-queue 2021-03-08 06:35:49 -0800 Created attachment 422561 REVERT of r273084 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1737057 2 ews-feeder 2021-03-08 06:38:18 -0800 Committed r274070: <https://commits.webkit.org/r274070> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422561. 1737058 3 webkit-bug-importer 2021-03-08 06:39:15 -0800 <rdar://problem/75168306> 1737075 4 commit-queue 2021-03-08 08:01:39 -0800 Re-opened since this is blocked by bug 222910 422561 2021-03-08 06:35:49 -0800 2021-03-08 06:38:18 -0800 REVERT of r273084 bug-222905-20210308143549.patch text/plain 6181 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE0Mzk5ZDAxMmMzMmMw ZjgzOWI3M2RjMzlkMmU5NzA4YzIzNzMyOC4uMTc1N2ZkMDY3ODMxMGMzNmQ2ZDFlODg1ZmJmMjhm YWMzMmU3ZDM2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTA4ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI3MzA4NC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyMjkwNQorCisgICAgICAgIFVzZXIgYWdlbnQgcXVpcmtzIHN0aWxsIG5l ZWRlZCBhZnRlciBhbGwKKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAg IltHVEtdIFJlbW92ZSBhbGwgR29vZ2xlIHVzZXIgYWdlbnQgcXVpcmtzIGV4Y2VwdCBmb3IgR29v Z2xlCisgICAgICAgIERvY3MiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjIwMzkKKyAgICAgICAgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzI3MzA4NAorCiAyMDIxLTAzLTA4ICBDaHJpcyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4K IAogICAgICAgICBBbGxvdyBjcmVhdGlvbiBvZiBhIENTU0ZvbnRTZWxlY3RvciB3aXRoIGEgbm9u LURvY3VtZW50IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9Vc2VyQWdlbnRRdWlya3MuY3BwCmluZGV4IGUzNDhkZjIxNmJhMWM5NTE4MDJhYTI1NGY3OTBm MDU1M2VjZTZiMWMuLmU1YWI4Y2ZkYWEwZDJjODE0YjZkZWFlYjA3Mzk4ZWQxYzVlY2RkNTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcApAQCAtMTIzLDYg KzEyMywxMSBAQCBzdGF0aWMgYm9vbCB1cmxSZXF1aXJlc01hY2ludG9zaFBsYXRmb3JtKGNvbnN0 IFVSTCYgdXJsKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAorc3RhdGljIGJvb2wgdXJsUmVxdWly ZXNMaW51eERlc2t0b3BQbGF0Zm9ybShjb25zdCBVUkwmIHVybCkKK3sKKyAgICByZXR1cm4gaXNH b29nbGUodXJsKSAmJiBjaGFzc2lzVHlwZSgpICE9IFdURjo6Q2hhc3Npc1R5cGU6Ok1vYmlsZTsK K30KKwogVXNlckFnZW50UXVpcmtzIFVzZXJBZ2VudFF1aXJrczo6cXVpcmtzRm9yVVJMKGNvbnN0 IFVSTCYgdXJsKQogewogICAgIEFTU0VSVCghdXJsLmlzTnVsbCgpKTsKQEAgLTEzNiw2ICsxNDEs OCBAQCBVc2VyQWdlbnRRdWlya3MgVXNlckFnZW50UXVpcmtzOjpxdWlya3NGb3JVUkwoY29uc3Qg VVJMJiB1cmwpCiAKICAgICBpZiAodXJsUmVxdWlyZXNNYWNpbnRvc2hQbGF0Zm9ybSh1cmwpKQog ICAgICAgICBxdWlya3MuYWRkKFVzZXJBZ2VudFF1aXJrczo6TmVlZHNNYWNpbnRvc2hQbGF0Zm9y bSk7CisgICAgZWxzZSBpZiAodXJsUmVxdWlyZXNMaW51eERlc2t0b3BQbGF0Zm9ybSh1cmwpKQor ICAgICAgICBxdWlya3MuYWRkKFVzZXJBZ2VudFF1aXJrczo6TmVlZHNMaW51eERlc2t0b3BQbGF0 Zm9ybSk7CiAKICAgICByZXR1cm4gcXVpcmtzOwogfQpAQCAtMTUwLDYgKzE1Nyw4IEBAIFN0cmlu ZyBVc2VyQWdlbnRRdWlya3M6OnN0cmluZ0ZvclF1aXJrKFVzZXJBZ2VudFF1aXJrIHF1aXJrKQog ICAgICAgICByZXR1cm4gIjsgcnY6ODcuMCkgR2Vja28vMjAxMDAxMDEgRmlyZWZveC84Ny4wIl9z OwogICAgIGNhc2UgTmVlZHNNYWNpbnRvc2hQbGF0Zm9ybToKICAgICAgICAgcmV0dXJuICJNYWNp bnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1Il9zOworICAgIGNhc2UgTmVlZHNMaW51eERlc2t0 b3BQbGF0Zm9ybToKKyAgICAgICAgcmV0dXJuICJYMTE7IExpbnV4IHg4Nl82NCJfczsKICAgICBj YXNlIE51bVVzZXJBZ2VudFF1aXJrczoKICAgICBkZWZhdWx0OgogICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNl ckFnZW50R0xpYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdM aWIuY3BwCmluZGV4IDUzYzE4MDNjYTEzMTU0MjMzZTJhM2M4ZjhhZTFmMDMzZWRhYjQ3NTEuLjQ0 NDM5NjM4ZjQ5MDdmNjVhZDMxMzk1N2Y1Y2Q2ZTA0ODZjZTY4MjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xpYi5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcApAQCAtODksNiArODksOCBAQCBz dGF0aWMgU3RyaW5nIGJ1aWxkVXNlckFnZW50U3RyaW5nKGNvbnN0IFVzZXJBZ2VudFF1aXJrcyYg cXVpcmtzKQogCiAgICAgaWYgKHF1aXJrcy5jb250YWlucyhVc2VyQWdlbnRRdWlya3M6Ok5lZWRz TWFjaW50b3NoUGxhdGZvcm0pKQogICAgICAgICB1YVN0cmluZy5hcHBlbmQoVXNlckFnZW50UXVp cmtzOjpzdHJpbmdGb3JRdWlyayhVc2VyQWdlbnRRdWlya3M6Ok5lZWRzTWFjaW50b3NoUGxhdGZv cm0pKTsKKyAgICBlbHNlIGlmIChxdWlya3MuY29udGFpbnMoVXNlckFnZW50UXVpcmtzOjpOZWVk c0xpbnV4RGVza3RvcFBsYXRmb3JtKSkKKyAgICAgICAgdWFTdHJpbmcuYXBwZW5kKFVzZXJBZ2Vu dFF1aXJrczo6c3RyaW5nRm9yUXVpcmsoVXNlckFnZW50UXVpcmtzOjpOZWVkc0xpbnV4RGVza3Rv cFBsYXRmb3JtKSk7CiAgICAgZWxzZSB7CiAgICAgICAgIHVhU3RyaW5nLmFwcGVuZChwbGF0Zm9y bUZvclVBU3RyaW5nKCkpOwogICAgICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFsKCI7ICIpOwpk aWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGJjMTcw NGRhMjBiYWU5YTZhZTliZWU3YjFlMmM3ZmNmOTc2YWEwNjMuLmVjMmZmNDE1NGRmZjljYjM0ZWEw ZjViZjg1OGVjZWNkMzM5NDZhMTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMS0wMy0wOCAgQ29tbWl0IFF1ZXVl ICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0 aW5nIHIyNzMwODQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjI5MDUKKworICAgICAgICBVc2VyIGFnZW50IHF1aXJrcyBzdGlsbCBuZWVkZWQgYWZ0 ZXIgYWxsCisKKyAgICAgICAgUmV2ZXJ0ZWQgY2hhbmdlc2V0OgorCisgICAgICAgICJbR1RLXSBS ZW1vdmUgYWxsIEdvb2dsZSB1c2VyIGFnZW50IHF1aXJrcyBleGNlcHQgZm9yIEdvb2dsZQorICAg ICAgICBEb2NzIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIyMDM5CisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNzMw ODQKKwogMjAyMS0wMy0wNyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBtYWlsZCBoaXRzIGEgc2ltdWxhdGVkIGNyYXNoIHdoZW4gRU5BQkxF KEFQUF9ISUdITElHSFRTKSBpcyBkZWZpbmVkCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwCmluZGV4IDZiZWIxNzRhNmFjZjY3 Mjc1ZmQwYzIzM2MxYjJhYzk2ZjVjMDg3MDUuLjM3NmJiNWI2MDI1ZDg3YWQwNzc1NDhjNGEyNzEz NTFjNmI5MjczZmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29y ZS9Vc2VyQWdlbnRRdWlya3MuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi Q29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwCkBAIC01NCw2ICs1NCwxNyBAQCBzdGF0aWMgdm9pZCBh c3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNGaXJlZm94QnJvd3NlclF1aXJrKGNvbnN0IGNoYXIqIHVy bCkKICAgICBFWFBFQ1RfRkFMU0UodWFTdHJpbmcuY29udGFpbnMoIlZlcnNpb24iKSk7CiB9CiAK K3N0YXRpYyB2b2lkIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0xpbnV4UGxhdGZvcm1RdWlyayhj b25zdCBjaGFyKiB1cmwpCit7CisgICAgU3RyaW5nIHVhU3RyaW5nID0gc3RhbmRhcmRVc2VyQWdl bnRGb3JVUkwoVVJMKHsgfSwgdXJsKSk7CisKKyAgICBFWFBFQ1RfVFJVRSh1YVN0cmluZy5jb250 YWlucygiTGludXgiKSk7CisgICAgRVhQRUNUX0ZBTFNFKHVhU3RyaW5nLmNvbnRhaW5zKCJNYWNp bnRvc2giKSk7CisgICAgRVhQRUNUX0ZBTFNFKHVhU3RyaW5nLmNvbnRhaW5zKCJNYWMgT1MgWCIp KTsKKyAgICBFWFBFQ1RfRkFMU0UodWFTdHJpbmcuY29udGFpbnMoIkNocm9tZSIpKTsKKyAgICBF WFBFQ1RfRkFMU0UodWFTdHJpbmcuY29udGFpbnMoIkZyZWVCU0QiKSk7Cit9CisKIHN0YXRpYyB2 b2lkIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc01hY1BsYXRmb3JtUXVpcmsoY29uc3QgY2hhciog dXJsKQogewogICAgIFN0cmluZyB1YVN0cmluZyA9IHN0YW5kYXJkVXNlckFnZW50Rm9yVVJMKFVS TCh7IH0sIHVybCkpOwpAQCAtNzEsNiArODIsMTIgQEAgVEVTVChVc2VyQWdlbnRUZXN0LCBRdWly a3MpCiAgICAgU3RyaW5nIHVhU3RyaW5nID0gc3RhbmRhcmRVc2VyQWdlbnRGb3JVUkwoVVJMKHsg fSwgImh0dHA6Ly93d3cud2Via2l0Lm9yZy8iKSk7CiAgICAgRVhQRUNUX1RSVUUodWFTdHJpbmcu aXNOdWxsKCkpOwogCisjaWYgIU9TKExJTlVYKSB8fCAhQ1BVKFg4Nl82NCkKKyAgICAvLyBHb29n bGUgcXVpcmsgc2hvdWxkIG5vdCBhZmZlY3Qgc2l0ZXMgd2l0aCBzaW1pbGFyIGRvbWFpbnMuCisg ICAgdWFTdHJpbmcgPSBzdGFuZGFyZFVzZXJBZ2VudEZvclVSTChVUkwoeyB9LCAiaHR0cDovL3d3 dy5nb29nbGVibG9nLmNvbS8iKSk7CisgICAgRVhQRUNUX0ZBTFNFKHVhU3RyaW5nLmNvbnRhaW5z KCJMaW51eCB4ODZfNjQiKSk7CisjZW5kaWYKKwogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhh c0Nocm9tZUJyb3dzZXJRdWlyaygiaHR0cDovL3R5cGVraXQuY29tLyIpOwogICAgIGFzc2VydFVz ZXJBZ2VudEZvclVSTEhhc0Nocm9tZUJyb3dzZXJRdWlyaygiaHR0cDovL3R5cGVraXQubmV0LyIp OwogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0Nocm9tZUJyb3dzZXJRdWlyaygiaHR0cDov L2F1dGgubWF5b2hyLmNvbS8iKTsKQEAgLTgzLDYgKzEwMCwxMiBAQCBURVNUKFVzZXJBZ2VudFRl c3QsIFF1aXJrcykKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNGaXJlZm94QnJvd3NlclF1 aXJrKCJodHRwOi8vd3d3Lm5ldGZsaXguY29tLyIpOwogI2VuZGlmCiAKKyAgICBhc3NlcnRVc2Vy QWdlbnRGb3JVUkxIYXNMaW51eFBsYXRmb3JtUXVpcmsoImh0dHA6Ly93d3cuZ29vZ2xlLmNvbS8i KTsKKyAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNMaW51eFBsYXRmb3JtUXVpcmsoImh0dHA6 Ly93d3cuZ29vZ2xlLmVzLyIpOworICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0xpbnV4UGxh dGZvcm1RdWlyaygiaHR0cDovL2NhbGVuZGFyLmdvb2dsZS5jb20vIik7CisgICAgYXNzZXJ0VXNl ckFnZW50Rm9yVVJMSGFzTGludXhQbGF0Zm9ybVF1aXJrKCJodHRwOi8vcGx1cy5nb29nbGUuY29t LyIpOworICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0xpbnV4UGxhdGZvcm1RdWlyaygiaHR0 cDovL2ZvbnRzLmdvb2dsZWFwaXMuY29tLyIpOworCiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJM SGFzTWFjUGxhdGZvcm1RdWlyaygiaHR0cDovL3d3dy55YWhvby5jb20vIik7CiAgICAgYXNzZXJ0 VXNlckFnZW50Rm9yVVJMSGFzTWFjUGxhdGZvcm1RdWlyaygiaHR0cDovL2ZpbmFuY2UueWFob28u Y29tLyIpOwogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc01hY1BsYXRmb3JtUXVpcmsoImh0 dHA6Ly9pbnRsLnRhb2Jhby5jb20vIik7Cg==