222874 2021-03-06 17:29:47 -0800 [perf dashboard] Some browser tests are flaky or failing 2021-03-06 18:26:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222463 InRadar P2 Normal --- 1 rniwa rniwa dewei_zhu saam webkit-bug-importer ysuzuki zhifei_fang oldest_to_newest 1736867 0 rniwa 2021-03-06 17:29:47 -0800 Some subtests under TimeSeriesChart intermittently fails due to race conditions. 1736872 1 422514 rniwa 2021-03-06 18:11:21 -0800 Created attachment 422514 Fixed tests 1736875 2 rniwa 2021-03-06 18:22:09 -0800 Thanks for the reviews! 1736876 3 rniwa 2021-03-06 18:25:28 -0800 Committed r274046 (234982@main): <https://commits.webkit.org/234982@main> 1736877 4 webkit-bug-importer 2021-03-06 18:26:14 -0800 <rdar://problem/75138819> 422514 2021-03-06 18:11:21 -0800 2021-03-06 18:16:55 -0800 Fixed tests bug-222874-20210306181120.patch text/plain 6274 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjc0MDQ1KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDIxLTAzLTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFtwZXJmIGRhc2hib2FyZF0gU29tZSBicm93c2VyIHRlc3RzIGFyZSBmbGFreSBv ciBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjI4NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGVyZSB3ZXJlIHR3byB0ZXN0cyBpbiBUaW1lU2VyaWVzQ2hhcnQgdGVzdHMgdGhhdCB3ZXJl IGludGVybWl0dGVudGx5IGZhaWxpbmcgZHVlIHRvIHRoZSB0ZXN0CisgICAgICAgIG5vdCByZWxp YWJseSB3YWl0aW5nIGZvciB0aGUgaWZyYW1lJ3MgcmVzaXplIHRvIHRha2UgZWZmZWN0IGFuZCBu b3Qgd2FpdGluZyBmb3IgdGhlIHRpbWUgc2VyaWVzJworICAgICAgICBmZXRjaGluZyBsb2dpYyB0 byBydW4gJ3RpbCBjb21wbGV0aW9uIGJlZm9yZSB3YWl0aW5nIGZvciBjYW52YXMgY2hhcnRzIHRv IGJlIHJlLWRyYXduLiBGaXhpbmcKKyAgICAgICAgdGhlc2UgYnkgYWRkaW5nIGNvZGUgdG8gd2Fp dCBmb3IgdGhlc2UgY29uZGl0b25zLgorCisgICAgICAgIEFsbCBicm93c2VyIHRlc3RzIGZvciBt YXJrdXAtY29tcG9uZW50LmpzIHdhcyBicm9rZW4gaW4gcjI3NDAzNiBhcyBgcmVxdWlyZWAgZnVu Y3Rpb24gaXMgbm90CisgICAgICAgIGF2YWlsYWJsZSBpbiBicm93c2Vycy4gQWRkZWQgYSB3b3Jr YXJvdW5kIGluIEJyb3dzaW5nQ29udGV4dCB0byBhZGQgYSBtYWtlIGFzc2VydC5vayBmdW5jdGlv bgorICAgICAgICB1c2luZyBleHBlY3QofikudG8uYmUudHJ1ZSgpLgorCisgICAgICAgICogYnJv d3Nlci10ZXN0cy9pbmRleC5odG1sOgorICAgICAgICAoQnJvd3NpbmdDb250ZXh0LnByb3RvdHlw ZS5jb25zdHJ1Y3Rvcik6IAorICAgICAgICAod2FpdEZvckVsZW1lbnRSZXNpemUpOiBBZGRlZC4K KyAgICAgICAgKiBicm93c2VyLXRlc3RzL3RpbWUtc2VyaWVzLWNoYXJ0LXRlc3RzLmpzOiBGaXhl ZCBidWdzIGluIHRoZSB0ZXN0cy4KKwogMjAyMS0wMy0wNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBbcGVyZiBkYXNoYm9hcmRdIE1vZGVybml6ZSBEYXRhTW9k ZWxPYmplY3QgYW5kIExhYmVsZWRPYmplY3QKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9y Zy9icm93c2VyLXRlc3RzL2luZGV4Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53 ZWJraXQub3JnL2Jyb3dzZXItdGVzdHMvaW5kZXguaHRtbAkocmV2aXNpb24gMjc0MDQzKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL2Jyb3dzZXItdGVzdHMvaW5kZXguaHRtbAkod29ya2lu ZyBjb3B5KQpAQCAtNTEsNiArNTEsMTQgQEAgY2xhc3MgQnJvd3NpbmdDb250ZXh0IHsKICAgICAg ICAgLy8gRXhwZWRpdGUgY2FsbHMgdG8gY2FsbGJhY2tzIHRvIG1ha2UgdGVzdHMgZ28gZmFzdGVy LgogICAgICAgICBpZnJhbWUuY29udGVudFdpbmRvdy5yZXF1ZXN0QW5pbWF0aW9uRnJhbWUgPSAo Y2FsbGJhY2spID0+IHNldFRpbWVvdXQoY2FsbGJhY2ssIDApOwogCisgICAgICAgIC8vIEFsbG93 IG1hcmt1cC1jb21wb25lbnQuanMgdG8gZnVuY3Rpb24uCisgICAgICAgIGlmcmFtZS5jb250ZW50 V2luZG93LnJlcXVpcmUgPSAobW9kdWxlKSA9PiB7CisgICAgICAgICAgICBleHBlY3QobW9kdWxl KS50by5iZSgnYXNzZXJ0Jyk7CisgICAgICAgICAgICByZXR1cm4geworICAgICAgICAgICAgICAg IG9rOiAoY29uZGl0aW9uKSA9PiBleHBlY3QoISFjb25kaXRpb24pLnRvLmJlKHRydWUpCisgICAg ICAgICAgICB9OyAgICAgICAgICAgIAorICAgICAgICB9CisKICAgICAgICAgdGhpcy5pZnJhbWUg PSBpZnJhbWU7CiAgICAgICAgIHRoaXMuc3ltYm9scyA9IHt9OwogICAgICAgICB0aGlzLmdsb2Jh bCA9IHRoaXMuaWZyYW1lLmNvbnRlbnRXaW5kb3c7CkBAIC0xMjgsNiArMTM2LDE3IEBAIGZ1bmN0 aW9uIHdhaXRGb3JDb21wb25lbnRzVG9SZW5kZXIoY29udGUKICAgICB9KTsKIH0KIAorZnVuY3Rp b24gd2FpdEZvckVsZW1lbnRSZXNpemUoZWxlbWVudCkKK3sKKyAgICByZXR1cm4gbmV3IFByb21p c2UoKHJlc29sdmUpID0+IHsKKyAgICAgICAgY29uc3Qgb2JzZXJ2ZXIgPSBuZXcgUmVzaXplT2Jz ZXJ2ZXIoKCkgPT4geworICAgICAgICAgICAgb2JzZXJ2ZXIuZGlzY29ubmVjdCgpOworICAgICAg ICAgICAgcmVzb2x2ZSgpOworICAgICAgICB9KTsKKyAgICAgICAgb2JzZXJ2ZXIub2JzZXJ2ZShl bGVtZW50KTsKKyAgICB9KQorfQorCiBmdW5jdGlvbiB3YWl0KG1pbGxpc2Vjb25kcykKIHsKICAg ICByZXR1cm4gbmV3IFByb21pc2UoKHJlc29sdmUpID0+IHsKQEAgLTM3NSw3ICszOTQsNyBAQCBj b25zdCBDaGFydFRlc3QgPSB7CiB9OwogCiBtb2NoYS5jaGVja0xlYWtzKCk7Ci1tb2NoYS5nbG9i YWxzKFsnZXhwZWN0JywgJ0Jyb3dzaW5nQ29udGV4dCcsICdDYW52YXNUZXN0JywgJ0NoYXJ0VGVz dCcsICd3YWl0JywgJ3dhaXRGb3JDb21wb25lbnRzVG9SZW5kZXInXSk7Cittb2NoYS5nbG9iYWxz KFsnZXhwZWN0JywgJ0Jyb3dzaW5nQ29udGV4dCcsICdDYW52YXNUZXN0JywgJ0NoYXJ0VGVzdCcs ICd3YWl0JywgJ3dhaXRGb3JDb21wb25lbnRzVG9SZW5kZXInLCAnd2FpdEZvckVsZW1lbnRSZXNp emUnXSk7CiBtb2NoYS5ydW4oKTsKIAogPC9zY3JpcHQ+CkluZGV4OiBXZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvYnJvd3Nlci10ZXN0cy90aW1lLXNlcmllcy1jaGFydC10ZXN0cy5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvYnJvd3Nlci10ZXN0cy90aW1lLXNlcmll cy1jaGFydC10ZXN0cy5qcwkocmV2aXNpb24gMjc0MDQzKQorKysgV2Vic2l0ZXMvcGVyZi53ZWJr aXQub3JnL2Jyb3dzZXItdGVzdHMvdGltZS1zZXJpZXMtY2hhcnQtdGVzdHMuanMJKHdvcmtpbmcg Y29weSkKQEAgLTYyNSw3ICs2MjUsNyBAQCBkZXNjcmliZSgnVGltZVNlcmllc0NoYXJ0JywgKCkg PT4gewogICAgICAgICAgICAgICAgIGxldCBjYW52YXM7CiAgICAgICAgICAgICAgICAgbGV0IG9y aWdpbmFsV2lkdGg7CiAgICAgICAgICAgICAgICAgbGV0IG9yaWdpbmFsSGVpZ2h0OwotICAgICAg ICAgICAgICAgIHJldHVybiB3YWl0Rm9yQ29tcG9uZW50c1RvUmVuZGVyKGNvbnRleHQpLnRoZW4o KCkgPT4geworICAgICAgICAgICAgICAgIHJldHVybiB3YWl0Rm9yQ29tcG9uZW50c1RvUmVuZGVy KGNvbnRleHQpLnRoZW4oYXN5bmMgKCkgPT4gewogICAgICAgICAgICAgICAgICAgICBleHBlY3Qo ZGF0YUNoYW5nZUNvdW50KS50by5iZSgxKTsKICAgICAgICAgICAgICAgICAgICAgZXhwZWN0KGNo YXJ0LnNhbXBsZWRUaW1lU2VyaWVzRGF0YSgnY3VycmVudCcpKS50by5ub3QuYmUobnVsbCk7CiAg ICAgICAgICAgICAgICAgICAgIGNhbnZhcyA9IGNoYXJ0LmNvbnRlbnQoKS5xdWVyeVNlbGVjdG9y KCdjYW52YXMnKTsKQEAgLTY0Myw3ICs2NDMsOCBAQCBkZXNjcmliZSgnVGltZVNlcmllc0NoYXJ0 JywgKCkgPT4gewogICAgICAgICAgICAgICAgICAgICBleHBlY3QoY2FudmFzLm9mZnNldFdpZHRo KS50by5iZShvcmlnaW5hbFdpZHRoKTsKICAgICAgICAgICAgICAgICAgICAgZXhwZWN0KGNhbnZh cy5vZmZzZXRIZWlnaHQpLnRvLmJlKG9yaWdpbmFsSGVpZ2h0KTsKIAotICAgICAgICAgICAgICAg ICAgICByZXR1cm4gd2FpdEZvckNvbXBvbmVudHNUb1JlbmRlcihjb250ZXh0KTsKKyAgICAgICAg ICAgICAgICAgICAgYXdhaXQgd2FpdEZvckVsZW1lbnRSZXNpemUoY2hhcnQuZWxlbWVudCgpKTsK KyAgICAgICAgICAgICAgICAgICAgYXdhaXQgd2FpdEZvckNvbXBvbmVudHNUb1JlbmRlcihjb250 ZXh0KTsKICAgICAgICAgICAgICAgICB9KS50aGVuKCgpID0+IHsKICAgICAgICAgICAgICAgICAg ICAgZXhwZWN0KGRhdGFDaGFuZ2VDb3VudCkudG8uYmUoMik7CiAgICAgICAgICAgICAgICAgICAg IGV4cGVjdChjYW52YXMub2Zmc2V0V2lkdGgpLnRvLmJlLmdyZWF0ZXJUaGFuKG9yaWdpbmFsV2lk dGgpOwpAQCAtNzcwLDcgKzc3MSw3IEBAIGRlc2NyaWJlKCdUaW1lU2VyaWVzQ2hhcnQnLCAoKSA9 PiB7CiAKICAgICAgICAgICAgICAgICBsZXQgY2FudmFzV2l0aFNhbXBsaW5nOwogICAgICAgICAg ICAgICAgIGxldCBjYW52YXNXaXRob3V0U2FtcGxpbmc7Ci0gICAgICAgICAgICAgICAgcmV0dXJu IHdhaXRGb3JDb21wb25lbnRzVG9SZW5kZXIoY29udGV4dCkudGhlbigoKSA9PiB7CisgICAgICAg ICAgICAgICAgcmV0dXJuIHdhaXRGb3JDb21wb25lbnRzVG9SZW5kZXIoY29udGV4dCkudGhlbihh c3luYyAoKSA9PiB7CiAgICAgICAgICAgICAgICAgICAgIGNhbnZhc1dpdGhvdXRTYW1wbGluZyA9 IGNoYXJ0V2l0aG91dFNhbXBsaW5nLmNvbnRlbnQoKS5xdWVyeVNlbGVjdG9yKCdjYW52YXMnKTsK ICAgICAgICAgICAgICAgICAgICAgY2FudmFzV2l0aFNhbXBsaW5nID0gY2hhcnRXaXRoU2FtcGxp bmcuY29udGVudCgpLnF1ZXJ5U2VsZWN0b3IoJ2NhbnZhcycpOwogCkBAIC03NzksMTEgKzc4MCwx NiBAQCBkZXNjcmliZSgnVGltZVNlcmllc0NoYXJ0JywgKCkgPT4gewogICAgICAgICAgICAgICAg ICAgICBleHBlY3QoQ2FudmFzVGVzdC5jYW52YXNDb250YWluc0NvbG9yKGNhbnZhc1dpdGhTYW1w bGluZywgbGluZUNvbG9yKSkudG8uYmUodHJ1ZSk7CiAKICAgICAgICAgICAgICAgICAgICAgY29u c3QgZGlmZiA9IENoYXJ0VGVzdC5zYW1wbGVDbHVzdGVyLmVuZFRpbWUgLSBDaGFydFRlc3Quc2Ft cGxlQ2x1c3Rlci5zdGFydFRpbWU7Ci0gICAgICAgICAgICAgICAgICAgIGNoYXJ0V2l0aG91dFNh bXBsaW5nLnNldERvbWFpbihDaGFydFRlc3Quc2FtcGxlQ2x1c3Rlci5zdGFydFRpbWUgLSAyICog ZGlmZiwgQ2hhcnRUZXN0LnNhbXBsZUNsdXN0ZXIuZW5kVGltZSk7Ci0gICAgICAgICAgICAgICAg ICAgIGNoYXJ0V2l0aFNhbXBsaW5nLnNldERvbWFpbihDaGFydFRlc3Quc2FtcGxlQ2x1c3Rlci5z dGFydFRpbWUgLSAyICogZGlmZiwgQ2hhcnRUZXN0LnNhbXBsZUNsdXN0ZXIuZW5kVGltZSk7Cisg ICAgICAgICAgICAgICAgICAgIGNvbnN0IGV4cGFuZGVkU3RhcnRUaW1lID0gQ2hhcnRUZXN0LnNh bXBsZUNsdXN0ZXIuc3RhcnRUaW1lIC0gMiAqIGRpZmY7CisgICAgICAgICAgICAgICAgICAgIGNo YXJ0V2l0aG91dFNhbXBsaW5nLnNldERvbWFpbihleHBhbmRlZFN0YXJ0VGltZSwgQ2hhcnRUZXN0 LnNhbXBsZUNsdXN0ZXIuZW5kVGltZSk7CisgICAgICAgICAgICAgICAgICAgIGNoYXJ0V2l0aFNh bXBsaW5nLnNldERvbWFpbihleHBhbmRlZFN0YXJ0VGltZSwgQ2hhcnRUZXN0LnNhbXBsZUNsdXN0 ZXIuZW5kVGltZSk7CiAKICAgICAgICAgICAgICAgICAgICAgQ2FudmFzVGVzdC5maWxsQ2FudmFz QmVmb3JlUmVkcmF3Q2hlY2soY2FudmFzV2l0aG91dFNhbXBsaW5nKTsKICAgICAgICAgICAgICAg ICAgICAgQ2FudmFzVGVzdC5maWxsQ2FudmFzQmVmb3JlUmVkcmF3Q2hlY2soY2FudmFzV2l0aFNh bXBsaW5nKTsKKworICAgICAgICAgICAgICAgICAgICBmb3IgKGNvbnN0IHNvdXJjZSBvZiBjaGFy dFdpdGhvdXRTYW1wbGluZy5zb3VyY2VMaXN0KCkpCisgICAgICAgICAgICAgICAgICAgICAgICBh d2FpdCBzb3VyY2UubWVhc3VyZW1lbnRTZXQuZmV0Y2hCZXR3ZWVuKGV4cGFuZGVkU3RhcnRUaW1l LCBDaGFydFRlc3Quc2FtcGxlQ2x1c3Rlci5lbmRUaW1lKTsKKwogICAgICAgICAgICAgICAgICAg ICByZXR1cm4gd2FpdEZvckNvbXBvbmVudHNUb1JlbmRlcihjb250ZXh0KTsKICAgICAgICAgICAg ICAgICB9KS50aGVuKCgpID0+IHsKICAgICAgICAgICAgICAgICAgICAgZXhwZWN0KENhbnZhc1Rl c3QuaGFzQ2FudmFzQmVlblJlZHJhd24oY2FudmFzV2l0aG91dFNhbXBsaW5nKSkudG8uYmUodHJ1 ZSk7Cg==