222873 2021-03-06 17:00:21 -0800 REGRESSION(r274041): Broke the build instead of fixing it 2021-03-07 08:49:46 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 commit-queue commit-queue mmaxfield sam webkit-bug-importer oldest_to_newest 1736862 0 commit-queue 2021-03-06 17:00:21 -0800 https://trac.webkit.org/changeset/274041 broke the build: Broke the build instead of fixing it This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1736863 1 422512 commit-queue 2021-03-06 17:00:24 -0800 Created attachment 422512 REVERT of r274041 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1736864 2 ews-feeder 2021-03-06 17:02:09 -0800 Committed r274045: <https://commits.webkit.org/r274045> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422512. 1736865 3 webkit-bug-importer 2021-03-06 17:03:15 -0800 <rdar://problem/75138138> 1736923 4 sam 2021-03-07 08:49:46 -0800 If we do add this back at any point, probably makes more sense to do it in the definition of DECLARE_CALL_FRAME, where the __builtin_frame_address(1) actually is. But it would also be good to understand the original error which was (as I understand it): ./dfg/DFGOSRExit.cpp:225:28: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address] CallFrame* callFrame = DECLARE_CALL_FRAME(vm); Since we explicitly call: bitwise_cast<JSC::CallFrame*>(__builtin_frame_address(1)); \ It seems like we are doing something clang does not like. Looks like there was some discussion of this in rdar://70421807 / https://bugs.webkit.org/show_bug.cgi?id=217588. 422512 2021-03-06 17:00:24 -0800 2021-03-06 17:02:10 -0800 REVERT of r274041 bug-222873-20210307010023.patch text/plain 1493 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZWYxM2VhMzJmZjJlMTI1ZjkzMTUxMTliZGU0MTZmOTQ0OTU0ZDc2Li42ZTUyN2U1YmQ5YTQyN2Uy Nzk2MjIxZTQwOGI3YTUyZDY1YWE5NTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMS0wMy0wNiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzQwNDEuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI4NzMKKworICAgICAg ICBCcm9rZSB0aGUgYnVpbGQgaW5zdGVhZCBvZiBmaXhpbmcgaXQKKworICAgICAgICBSZXZlcnRl ZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIkZpeCB0aGUgYnVpbGQiCisgICAgICAgIGh0dHBzOi8v dHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNzQwNDEKKwogMjAyMS0wMy0wNiAgTXlsZXMgQy4g TWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCmluZGV4IDYwMDE1Y2UzOTk5 ZjcyMWJlNDFhODRlZjRiYmJlOWU1ZTBmN2JlZWQuLmZkNjM4YTM4Y2Q2Mzk1YTUwOGM4Zjk1ZThh OTE3NTNhNjRkOTUyMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T1NSRXhpdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0LmNw cApAQCAtMjI0LDEwICsyMjQsNyBAQCBKU0NfREVGSU5FX0pJVF9PUEVSQVRJT04ob3BlcmF0aW9u TWF0ZXJpYWxpemVPU1JFeGl0U2lkZVN0YXRlLCB2b2lkLCAoVk0qIHZtUG9pbgogewogICAgIGNv bnN0IE9TUkV4aXRCYXNlJiBleGl0ID0gKmV4aXRQb2ludGVyOwogICAgIFZNJiB2bSA9ICp2bVBv aW50ZXI7Ci0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAotI3ByYWdtYSBjbGFuZyBkaWFn bm9zdGljIGlnbm9yZWQgIi1XZnJhbWUtYWRkcmVzcyIKICAgICBDYWxsRnJhbWUqIGNhbGxGcmFt ZSA9IERFQ0xBUkVfQ0FMTF9GUkFNRSh2bSk7Ci0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9w CiAKICAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPENoZWNrcG9pbnRPU1JFeGl0U2lkZVN0YXRl PiwgVk06OmV4cGVjdGVkTWF4QWN0aXZlU2lkZVN0YXRlQ291bnQ+IHNpZGVTdGF0ZXM7CiAgICAg c2lkZVN0YXRlcy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGV4aXQubV9jb2RlT3JpZ2luLmlubGlu ZURlcHRoKCkpOwo=