222859 2021-03-06 05:54:55 -0800 Metal-ANGLE can ASSERT because MTL signal event code is compiled out 2021-03-18 12:07:54 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino dino ews-watchlist graouts kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1736781 0 dino 2021-03-06 05:54:55 -0800 Metal-ANGLE can ASSERT because MTL signal event code is compiled out 1736782 1 webkit-bug-importer 2021-03-06 05:56:33 -0800 <rdar://problem/75132180> 1736784 2 422487 dino 2021-03-06 06:02:31 -0800 Created attachment 422487 Patch 1737028 3 ews-watchlist 2021-03-08 04:26:08 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1737374 4 422487 kbr 2021-03-08 16:50:08 -0800 Comment on attachment 422487 Patch Looks good. I vaguely remember this fix being done elsewhere (in the previous attempt to upstream the new Metal backend to ANGLE?) but sounds fine to get this fix in now. r+ 1740874 5 dino 2021-03-17 13:34:26 -0700 Landed as part of r274547 1741316 6 dino 2021-03-18 12:07:54 -0700 Committed r274660 (235485@main): <https://commits.webkit.org/235485@main> 422487 2021-03-06 06:02:31 -0800 2021-03-08 16:50:08 -0800 Patch bug-222859-20210307010229.patch text/plain 3184 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMzgwYWYyMjgwNDczNTI1NzJkMTNkZjNmMGU0OTQ1OTAwYjBkZmU1Yi4uNWY3MzlhODY3MDJi NjRiZjcwYTg4YTA2NjY3ODdhZWFiNzRiYmYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTAzLTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KKworICAgICAgICBNZXRhbC1BTkdMRSBjYW4gQVNTRVJUIGJlY2F1c2UgTVRMIHNpZ25h bCBldmVudCBjb2RlIGlzIGNvbXBpbGVkIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyODU5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTEz MjE4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aXRoIHRoZSBNZXRhbCBiYWNrZW5kIGVuYWJsZWQsIHRoZSB0ZXN0CisgICAgICAgIHdlYmdsLzIu MC4wL2NvbmZvcm1hbmNlMi9zdGF0ZS9nbC1vYmplY3QtZ2V0LWNhbGxzLmh0bWwgd2lsbAorICAg ICAgICBvY2Nhc2lvbmFsbHkgY3Jhc2ggaW4gbXRsX2NvbW1hbmRfYnVmZmVyIHdoZW4gaXQgaGl0 cyB1bnJlYWNoYWJsZQorICAgICAgICBjb2RlIGJlY2F1c2UgQU5HTEVfTVRMX0VWRU5UX0FWQUlM QUJMRSBoYXNuJ3QgYmVlbiBkZWZpbmVkLiBUaGlzIGlzCisgICAgICAgIGF2YWlsYWJsZSBvbiBt YWNPUyAxMC4xNCBhbmQgYWJvdmUsIHNvIHNob3VsZCBiZSBlbmFibGVkLgorCisgICAgICAgIEF0 IHRoZSBzYW1lIHRpbWUsIGl0IGRvZXNuJ3QgbWFrZSBzZW5zZSB0byBjYWxsIHRoZSBtZXRob2Qg dGhhdCBoYXMKKyAgICAgICAgdW5yZWFjaGFibGUgY29kZSwgc28gZ3VhcmQgYWdhaW5zdCB0aGF0 IGluIG10bF9jb21tYW5kX2J1ZmZlci4KKworICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJl ci9tZXRhbC9tdGxfY29tbWFuZF9idWZmZXIubW06CisgICAgICAgIChyeDo6bXRsOjpDb21tYW5k QnVmZmVyOjpzZXRQZW5kaW5nRXZlbnRzKToKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVy ZXIvbWV0YWwvbXRsX2NvbW1vbi5oOiBEZWZpbmUgQU5HTEVfTVRMX0VWRU5UX0FWQUlMQUJMRS4K KwogMjAyMS0wMy0wMyAgS3lsZSBQaWRkaW5ndG9uICA8a3BpZGRpbmd0b25AYXBwbGUuY29tPgog CiAgICAgICAgIFN1cHBvcnQgRGVwdGgyNF9TdGVuY2lsOCBzaW11bGF0aW9uIGluIHRoZSBNVExT aW11bGF0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdM RS9yZW5kZXJlci9tZXRhbC9tdGxfY29tbWFuZF9idWZmZXIubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2NvbW1hbmRfYnVmZmVyLm1t CmluZGV4IGI0YTMzNDc0MmU2MjdjYTA0OTEyMTAzZTJmYWRmY2M3MzEyNDdmMzMuLjdlZDBlMjEy MDhjYzA4ODIyODExNDkxMTU3ZmRlNjg0NWM0ZGNhN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfY29tbWFuZF9idWZm ZXIubW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVy L21ldGFsL210bF9jb21tYW5kX2J1ZmZlci5tbQpAQCAtNzkxLDExICs3OTEsMTMgQEAgdm9pZCBD b21tYW5kQnVmZmVyOjpmb3JjZUVuZGluZ0N1cnJlbnRFbmNvZGVyKCkKIAogdm9pZCBDb21tYW5k QnVmZmVyOjpzZXRQZW5kaW5nRXZlbnRzKCkKIHsKKyNpZiBBTkdMRV9NVExfRVZFTlRfQVZBSUxB QkxFCiAgICAgZm9yIChjb25zdCBzdGQ6OnBhaXI8bXRsOjpTaGFyZWRFdmVudFJlZiwgdWludDY0 X3Q+ICZldmVudEVudHJ5IDogbVBlbmRpbmdTaWduYWxFdmVudHMpCiAgICAgewogICAgICAgICBz ZXRFdmVudEltcGwoZXZlbnRFbnRyeS5maXJzdCwgZXZlbnRFbnRyeS5zZWNvbmQpOwogICAgIH0K ICAgICBtUGVuZGluZ1NpZ25hbEV2ZW50cy5jbGVhcigpOworI2VuZGlmCiB9CiAKIHZvaWQgQ29t bWFuZEJ1ZmZlcjo6c2V0RXZlbnRJbXBsKGNvbnN0IG10bDo6U2hhcmVkRXZlbnRSZWYgJmV2ZW50 LCB1aW50NjRfdCB2YWx1ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3Ny Yy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfY29tbW9uLmggYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2NvbW1vbi5oCmluZGV4IDA2 NTE0NjUxMWJkNTFmNDlhYzU4MWMyNTNkN2U3NDI2Y2JkZWFkZjAuLmVmNzFiM2M4ZjZlNzI0MWZl NmE0MWYxNGRjYjU4MGMyYmIxNjJhMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfY29tbW9uLmgKKysrIGIvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9jb21tb24u aApAQCAtMjk1LDkgKzI5NSwxMSBAQCB1c2luZyBBdXRvT2JqQ09iaiA9IEF1dG9PYmpDUHRyPFQg Kj47CiAKIC8vIE5PVEU6IFNoYXJlZEV2ZW50IGlzIG9ubHkgZGVjbGFyZWQgb24gaU9TIDEyLjAr IG9yIG1hYyAxMC4xNCsKICNpZiBkZWZpbmVkKF9fSVBIT05FXzEyXzApIHx8IGRlZmluZWQoX19N QUNfMTBfMTQpCisjZGVmaW5lIEFOR0xFX01UTF9FVkVOVF9BVkFJTEFCTEUgMQogdXNpbmcgU2hh cmVkRXZlbnRSZWYgPSBBdXRvT2JqQ1B0cjxpZDxNVExTaGFyZWRFdmVudD4+OwogI2Vsc2UKLXVz aW5nIFNoYXJlZEV2ZW50UmVmICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg PSBBdXRvT2JqQ09iajxOU09iamVjdD47CisjZGVmaW5lIEFOR0xFX01UTF9FVkVOVF9BVkFJTEFC TEUgMAordXNpbmcgU2hhcmVkRXZlbnRSZWYgPSBBdXRvT2JqQ09iajxOU09iamVjdD47CiAjZW5k aWYKIAogLy8gVGhlIG5hdGl2ZSBpbWFnZSBpbmRleCB1c2VkIGJ5IE1ldGFsIGJhY2stZW5kLCAg dGhlIGltYWdlIGluZGV4IHVzZXMgbmF0aXZlIG1pcG1hcCBsZXZlbCBpbnN0ZWFkCg==